Backtestshugorun-20261007-020926#15245
hugo mod npm pack emits a publishable, checkout-named package.json
Our patch was judged better than the merged fix.
In this judgment, Patch A = our agent, Patch B = the merged fix.
Patch A fixes the issue more completely. It always writes `"private": true` and a fixed, scoped name, `@gohugoio/hugoautogen`. That covers both requests in the issue: the package can't be published, and its name no longer depends on the checkout directory. It also follows the issue's preference for a scoped name, which only the scope owner can claim on the registry. Patch B's default name is the bare `hugoautogen`, which the issue specifically warns anyone can register. Patch B also reads the existing `package.json` and keeps its `name`, `version` and `private` values. Most existing committed manifests were generated by older Hugo and carry the checkout-derived name (e.g. `site-a`). Patch B would keep that bad name indefinitely instead of fixing it. It would likewise keep a stale `private: false`, and it adds a read-parse-merge step with silent fallback on parse errors. Preserving hand-edits is beyond the issue's ask, and here it adds risk by weakening the fix for exactly the repos that reported the problem. Tests: both update the testscript goldens. Patch A's new test seeds a stale checkout-named file and checks that regeneration replaces it with the stable private name. Patch B's test checks the defaults and then that edits are preserved, including `private: false`, which conflicts with the goal of a non-publishable workspace. Patch A also documents the behaviour. A is the better fix.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
1h
Wall-clock time in the container
Full test suite
No new failures
3,729 passed · 99 skipped · 3,830 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
66vs 78 merged
Changed lines, ours vs merged
The issue
View on GitHubTL;DR: the generated package.json has no "private": true and a checkout-derived name, so committed copies are publishable under names sites don't control. Suggested fix: emit "private": true and a stable (ideally scoped) default name.
What version of Hugo are you using (hugo version)?
hugo v0.165.0-76a5e1880ab46688155b02e99bab9be2a6134492+extended darwin/arm64 BuildDate=2026-08-12T14:26:28Z VendorInfo=gohugoio
Does this issue reproduce with the latest release?
Yes (transcript below is v0.165.0). The behavior is in master's package_builder.go.
What happened
hugo mod npm pack writes packages/hugoautogen/package.json with:
- a name derived from the checkout directory, so it varies per clone and can be a registry name the site doesn't control, and
- no
"private": true, npm's do-not-publish guard for internal packages.
The file is regenerated wholesale on each run, so hand-set fields don't survive. From a fresh clone of a repo whose committed copy was hand-normalized:
$ git clone https://github.com/google/docsy-example.git site-a && cd site-a
$ grep -E '"(name|version|private)"' packages/hugoautogen/package.json
"name": "@docsy/hugoautogen",
"version": "0.1.0",
"private": true
$ hugo mod npm pack
$ grep -E '"(name|version|private)"' packages/hugoautogen/package.json
"name": "site-a",
"version": "0.1.0"
A sibling clone of the same repo into site-b yields "name": "site-b".
Why it matters
Sites that commit the generated workspace (e.g. so npm ci works without running Hugo first) end up carrying a manifest that npm workspace publishing and common release tools treat as publishable by default: npm publish --dry-run --workspaces packs it as site-a@0.1.0, while with "private": true npm skips the workspace. The name variance also churns the committed manifest, and the lockfile's workspace entry, across differently named checkouts.
What did you expect
The generated internal workspace is non-publishable ("private": true) and has a stable, project-controlled default name rather than the checkout directory's basename. Ideally the default is scoped: a bare name can be claimed on the registry by anyone, a scoped one only by the scope owner.
Workaround
docsy-example#487 follows each pack invocation with a single npm pkg set line restoring a scoped name and private.
Happy to send a PR for the private field (and for the name default, if you have a preference for what it should be).
The two patches
docs/content/en/hugo-modules/nodejs-dependencies.mdindex 98384e36c..3a0e6985e 100644@@ -44,6 +44,8 @@ after v0.174.0, 15 minor releases after the improvement. > [!NOTE] In Hugo < v0.159.0 Hugo wrote the dependencies into your project's package.json, so if you have used `hugo mod npm pack` on your project using older Hugo versions, now is the time to do a spring cleaning of your project `package.json` file: Only direct Node dependencies needs to live in this file, all incoming dependencies from imported modules gets written to `packages/hugoautogen/package.json`. +The generated package is always named `@gohugoio/hugoautogen` and marked `"private": true`, so its content does not depend on the name of the directory your project is checked out in, and npm will refuse to publish it.+ When merging, the **topmost version, starting from the project, take precedence**. If a module declares `tailwindcss@4.1` but your project already has `tailwindcss@4.0`, the project version wins and the module dependency is excluded from the generated workspace package. ## Staleness detectionmodules/npm/package_builder.goindex cea1dc8cd..e3500092b 100644@@ -43,6 +43,9 @@ const ( packageJSONName = "package.json" packageMetaJSONName = "hugo_packagemeta.json"++ // autoGenPackageName is the name of the autogenerated workspace package.+ autoGenPackageName = "@gohugoio/hugoautogen" ) var (@@ -195,15 +198,13 @@ func Pack(sourceFs, assetsWithDuplicatesPreservedFs afero.Fs, mods modules.Modul } } - name := "project"- rfi, err := sourceFs.Stat("")- if err == nil {- name = rfi.Name()- }-+ // The workspace is internal to the project and must never be published,+ // so mark it private and give it a stable, scoped name that does not+ // depend on the name of the directory the project is checked out in. autoGenPkg := map[string]any{- "name": name,+ "name": autoGenPackageName, "version": "0.1.0",+ "private": true, dependenciesKey: moduleDeps, devDependenciesKey: moduleDevDeps, }modules/npm/package_builder_integration_test.goindex 65649d7ce..c535e36f7 100644@@ -14,6 +14,7 @@ package npm_test import (+ "encoding/json" "strings" "testing" @@ -92,6 +93,33 @@ func TestPackageBuilder(t *testing.T) { b.Assert(string(meta2), qt.Equals, string(meta1)) } +// The generated workspace package must not be publishable and its name must+// not depend on the directory the project is checked out in.+func TestPackageBuilderPrivateStableName(t *testing.T) {+ files := getPackageBuilderTestFiles()+ b := hugolib.Test(t, files)+ sourceFs := b.H.BaseFs.ProjectSourceFs+ assetsFs := b.H.BaseFs.AssetsWithDuplicatesPreserved.Fs+ mods := b.H.Configs.Modules++ // Simulate a hand-normalized, committed copy that Pack regenerates.+ b.Assert(afero.WriteFile(sourceFs, "packages/hugoautogen/package.json", []byte(`{"name": "site-a", "version": "0.1.0"}`), 0o666), qt.IsNil)++ b.Assert(npm.Pack(sourceFs, assetsFs, mods), qt.IsNil)++ data, err := afero.ReadFile(sourceFs, "packages/hugoautogen/package.json")+ b.Assert(err, qt.IsNil)+ var pkg map[string]any+ b.Assert(json.Unmarshal(data, &pkg), qt.IsNil)+ b.Assert(pkg["name"], qt.Equals, "@gohugoio/hugoautogen")+ b.Assert(pkg["private"], qt.Equals, true)+ b.Assert(pkg["version"], qt.Equals, "0.1.0")++ rfi, err := sourceFs.Stat("")+ b.Assert(err, qt.IsNil)+ b.Assert(pkg["name"], qt.Not(qt.Equals), rfi.Name())+}+ func BenchmarkPackageFilesSum(b *testing.B) { files := getPackageBuilderTestFiles() bb := hugolib.Test(b, files)testscripts/commands/mod_npm.txtindex 169f26c17..82d409d22 100644@@ -119,7 +119,8 @@ usePackageJSON="auto" "strip-ansi": "7.2.0", "to-pascal-case": "1.0.0" },- "name": "script-mod_npm",+ "name": "@gohugoio/hugoautogen",+ "private": true, "version": "0.1.0" } -- golden1/package.json --@@ -149,7 +150,8 @@ usePackageJSON="auto" "strip-ansi": "7.2.0", "to-pascal-case": "1.0.0" },- "name": "script-mod_npm",+ "name": "@gohugoio/hugoautogen",+ "private": true, "version": "0.1.0" } -- golden3/packages/hugoautogen/package.json --@@ -168,7 +170,8 @@ usePackageJSON="auto" "strip-ansi": "7.2.0", "to-pascal-case": "1.0.0" },- "name": "script-mod_npm",+ "name": "@gohugoio/hugoautogen",+ "private": true, "version": "0.1.0" } -- golden4/packages/hugoautogen/package.json --@@ -188,7 +191,8 @@ usePackageJSON="auto" "strip-ansi": "7.2.0", "to-pascal-case": "1.0.0" },- "name": "script-mod_npm",+ "name": "@gohugoio/hugoautogen",+ "private": true, "version": "0.1.0" } -- golden5/packages/hugoautogen/package.json --@@ -206,7 +210,8 @@ usePackageJSON="auto" "strip-ansi": "7.2.0", "to-pascal-case": "1.0.0" },- "name": "script-mod_npm",+ "name": "@gohugoio/hugoautogen",+ "private": true, "version": "0.1.0" } -- go.mod --testscripts/commands/mod_npm__moduleorder.txtindex 4dc202046..a765c285a 100644@@ -42,7 +42,8 @@ go 1.20 "strip-ansi": "7.0.0", "to-pascal-case": "1.0.0" },- "name": "script-mod_npm__moduleorder",+ "name": "@gohugoio/hugoautogen",+ "private": true, "version": "0.1.0" } -- golden1/packages/hugoautogen/hugo_packagemeta.json --testscripts/commands/mod_npm_withexisting.txtindex b11a4a3b6..ffd8a1234 100644@@ -37,7 +37,8 @@ path="github.com/gohugoio/hugoTestModule2" "@babel/preset-env": "7.9.5", "postcss-cli": "7.1.0" },- "name": "script-mod_npm_withexisting",+ "name": "@gohugoio/hugoautogen",+ "private": true, "version": "0.1.0" } -- golden/package.json --
modules/npm/package_builder.goindex cea1dc8cd..631036878 100644@@ -195,15 +195,28 @@ func Pack(sourceFs, assetsWithDuplicatesPreservedFs afero.Fs, mods modules.Modul } } - name := "project"- rfi, err := sourceFs.Stat("")- if err == nil {- name = rfi.Name()+ // Stable defaults; mark the workspace private so npm never publishes it.+ // Preserve any hand-set values from an existing file.+ name, version, private := "hugoautogen", "0.1.0", true+ if data, err := afero.ReadFile(sourceFs, workspacePackageJSON); err == nil {+ var existing map[string]any+ if err := json.Unmarshal(data, &existing); err == nil {+ if s, ok := existing["name"].(string); ok && s != "" {+ name = s+ }+ if s, ok := existing["version"].(string); ok && s != "" {+ version = s+ }+ if b, ok := existing["private"].(bool); ok {+ private = b+ }+ } } autoGenPkg := map[string]any{ "name": name,- "version": "0.1.0",+ "version": version,+ "private": private, dependenciesKey: moduleDeps, devDependenciesKey: moduleDevDeps, }modules/npm/package_builder_integration_test.goindex 65649d7ce..bf3c91bcd 100644@@ -92,6 +92,40 @@ func TestPackageBuilder(t *testing.T) { b.Assert(string(meta2), qt.Equals, string(meta1)) } +// The generated workspace package.json should get a stable name and+// "private": true, and preserve hand-set name/version/private on regeneration.+// See issue 15245.+func TestPackStableNameAndPrivate(t *testing.T) {+ files := getPackageBuilderTestFiles()+ b := hugolib.Test(t, files)+ sourceFs := b.H.BaseFs.ProjectSourceFs+ assetsFs := b.H.BaseFs.AssetsWithDuplicatesPreserved.Fs+ mods := b.H.Configs.Modules++ b.Assert(npm.Pack(sourceFs, assetsFs, mods), qt.IsNil)++ pkg, err := afero.ReadFile(sourceFs, "packages/hugoautogen/package.json")+ b.Assert(err, qt.IsNil)+ b.Assert(string(pkg), qt.Contains, `"name": "hugoautogen"`)+ b.Assert(string(pkg), qt.Contains, `"private": true`)+ b.Assert(string(pkg), qt.Contains, `"version": "0.1.0"`)++ // Hand-set fields survive a re-pack.+ edited := strings.NewReplacer(+ `"name": "hugoautogen"`, `"name": "@foo/hugoautogen"`,+ `"version": "0.1.0"`, `"version": "1.2.3"`,+ `"private": true`, `"private": false`,+ ).Replace(string(pkg))+ b.Assert(afero.WriteFile(sourceFs, "packages/hugoautogen/package.json", []byte(edited), 0o666), qt.IsNil)++ b.Assert(npm.Pack(sourceFs, assetsFs, mods), qt.IsNil)+ pkg, err = afero.ReadFile(sourceFs, "packages/hugoautogen/package.json")+ b.Assert(err, qt.IsNil)+ b.Assert(string(pkg), qt.Contains, `"name": "@foo/hugoautogen"`)+ b.Assert(string(pkg), qt.Contains, `"version": "1.2.3"`)+ b.Assert(string(pkg), qt.Contains, `"private": false`)+}+ func BenchmarkPackageFilesSum(b *testing.B) { files := getPackageBuilderTestFiles() bb := hugolib.Test(b, files)testscripts/commands/mod_npm.txtindex 169f26c17..136277fc5 100644@@ -119,7 +119,8 @@ usePackageJSON="auto" "strip-ansi": "7.2.0", "to-pascal-case": "1.0.0" },- "name": "script-mod_npm",+ "name": "hugoautogen",+ "private": true, "version": "0.1.0" } -- golden1/package.json --@@ -149,7 +150,8 @@ usePackageJSON="auto" "strip-ansi": "7.2.0", "to-pascal-case": "1.0.0" },- "name": "script-mod_npm",+ "name": "hugoautogen",+ "private": true, "version": "0.1.0" } -- golden3/packages/hugoautogen/package.json --@@ -168,7 +170,8 @@ usePackageJSON="auto" "strip-ansi": "7.2.0", "to-pascal-case": "1.0.0" },- "name": "script-mod_npm",+ "name": "hugoautogen",+ "private": true, "version": "0.1.0" } -- golden4/packages/hugoautogen/package.json --@@ -188,7 +191,8 @@ usePackageJSON="auto" "strip-ansi": "7.2.0", "to-pascal-case": "1.0.0" },- "name": "script-mod_npm",+ "name": "hugoautogen",+ "private": true, "version": "0.1.0" } -- golden5/packages/hugoautogen/package.json --@@ -206,7 +210,8 @@ usePackageJSON="auto" "strip-ansi": "7.2.0", "to-pascal-case": "1.0.0" },- "name": "script-mod_npm",+ "name": "hugoautogen",+ "private": true, "version": "0.1.0" } -- go.mod --testscripts/commands/mod_npm__moduleorder.txtindex 4dc202046..20228e548 100644@@ -42,7 +42,8 @@ go 1.20 "strip-ansi": "7.0.0", "to-pascal-case": "1.0.0" },- "name": "script-mod_npm__moduleorder",+ "name": "hugoautogen",+ "private": true, "version": "0.1.0" } -- golden1/packages/hugoautogen/hugo_packagemeta.json --testscripts/commands/mod_npm_withexisting.txtindex b11a4a3b6..aa5a77bca 100644@@ -37,7 +37,8 @@ path="github.com/gohugoio/hugoTestModule2" "@babel/preset-env": "7.9.5", "postcss-cli": "7.1.0" },- "name": "script-mod_npm_withexisting",+ "name": "hugoautogen",+ "private": true, "version": "0.1.0" } -- golden/package.json --