Backtestshugorun-20261009-153657#15116
common/hugo: Include aom, dav1d, and libavif in commands/env output
Our patch was judged better than the merged fix.
In this judgment, Patch A = our agent, Patch B = the merged fix.
Patch A wins on correctness, risk and scope. Correctness and risk: Patch A adds the three requested dependencies (libavif, aom, dav1d) directly in `GetDependencyListNonGo`. It adds a comment saying to keep them in sync with the genwebp/genavif Makefiles. The change is minimal and low-risk, and it corrects the issue's typo, using libavif "v1.4.1" rather than "v.14.1". Patch B makes `common/hugo` import `internal/warpc`. That is a new dependency from a low-level common package into an internal subsystem. It risks an import cycle and pulls the whole WASM runtime package into `common/hugo`. B also adds a KaTeX entry the issue didn't ask for, with a hardcoded "0.16.21" that must be kept in sync with `package.json`. B does not actually derive versions from the plugin setup either: it just moves the hardcoded constants elsewhere, so the TODO is not really resolved. Tests: Patch A adds a unit test asserting the exact formatted strings and extends the env testscript with exact versions. Both fail before the change and pass after. Patch B only checks that the module paths appear in the testscript, not the versions, which is weaker. Scope and craft: Patch B includes unrelated formatting churn in `warpc.go` (moved closing parens and argument wrapping) and in the dart-sass append. This obscures the fix. Patch A is focused and consistent with the surrounding code.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
15m 6s
Wall-clock time in the container
Full test suite
No new failures
1,083 passed · 58 skipped · 1,148 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
23vs 51 merged
Changed lines, ours vs merged
The issue
View on GitHubCurrently, the hugo env command prints:
hugo v0.164.0-ce2470e7012b5ab5fc4e10ebe4027e9f8d9e00dc+withdeploy linux/amd64 BuildDate=2026-07-06T16:39:30Z VendorInfo=gohugoio
GOOS="linux"
GOARCH="amd64"
GOVERSION="go1.26.3"
github.com/webmproject/libwebp="v1.6.0"
github.com/sass/dart-sass/protocol="3.2.0"
github.com/sass/dart-sass/compiler="1.101.0"
github.com/sass/dart-sass/implementation="1.101.0"
I think it would make sense to also list...
aomedia.googlesource.com/aom="v3.14.1"
code.videolan.org/videolan/dav1d="1.5.3"
github.com/AOMediaCodec/libavif="v.14.1"
...assuming I have the correct source strings.
See:
<https://github.com/gohugoio/hugo/blob/a198116669fdfba2eeda4f1d63c055001a10142f/common/hugo/hugo.go#L213-L214>.
The two patches
common/hugo/hugo.goindex 28f8b9393..15b8e3cf7 100644@@ -211,7 +211,14 @@ func GetDependencyList() []string { // GetDependencyListNonGo returns a list of non-Go dependencies. func GetDependencyListNonGo() []string {- deps := []string{formatDep("github.com/webmproject/libwebp", "v1.6.0")} // via WASM. TODO(bep) get versions from the plugin setup.+ // Via WASM. TODO(bep) get versions from the plugin setup.+ // Keep these in sync with internal/warpc/genwebp/Makefile and internal/warpc/genavif/Makefile.+ deps := []string{+ formatDep("github.com/webmproject/libwebp", "v1.6.0"),+ formatDep("github.com/AOMediaCodec/libavif", "v1.4.1"),+ formatDep("aomedia.googlesource.com/aom", "v3.14.1"),+ formatDep("code.videolan.org/videolan/dav1d", "1.5.3"),+ } if IsExtended { deps = append(common/hugo/hugo_test.goindex a572f74d4..11cfeed4e 100644@@ -50,6 +50,16 @@ func TestMarkupScope(t *testing.T) { c.Assert(GetMarkupScope(ctx), qt.Equals, "foo") } +func TestGetDependencyListNonGo(t *testing.T) {+ c := qt.New(t)++ deps := GetDependencyListNonGo()+ c.Assert(deps, qt.Contains, `github.com/webmproject/libwebp="v1.6.0"`)+ c.Assert(deps, qt.Contains, `github.com/AOMediaCodec/libavif="v1.4.1"`)+ c.Assert(deps, qt.Contains, `aomedia.googlesource.com/aom="v3.14.1"`)+ c.Assert(deps, qt.Contains, `code.videolan.org/videolan/dav1d="1.5.3"`)+}+ func TestGetBuildInfo(t *testing.T) { c := qt.New(t) testscripts/commands/env.txtindex 742e05ffc..ff9202d59 100644@@ -2,4 +2,8 @@ hugo env stdout 'GOARCH'+stdout 'github.com/webmproject/libwebp="v1.6.0"'+stdout 'github.com/AOMediaCodec/libavif="v1.4.1"'+stdout 'aomedia.googlesource.com/aom="v3.14.1"'+stdout 'code.videolan.org/videolan/dav1d="1.5.3"' ! stderr .\ No newline at end of file
common/hugo/hugo.goindex 28f8b9393..ac490a84b 100644@@ -33,6 +33,7 @@ import ( "github.com/gohugoio/hugo/common/loggers" "github.com/gohugoio/hugo/common/version" "github.com/gohugoio/hugo/hugofs/files"+ "github.com/gohugoio/hugo/internal/warpc" "github.com/spf13/afero" @@ -211,7 +212,10 @@ func GetDependencyList() []string { // GetDependencyListNonGo returns a list of non-Go dependencies. func GetDependencyListNonGo() []string {- deps := []string{formatDep("github.com/webmproject/libwebp", "v1.6.0")} // via WASM. TODO(bep) get versions from the plugin setup.+ var deps []string+ for _, dep := range warpc.GetWASMDeps() {+ deps = append(deps, formatDep(dep[0], dep[1]))+ } if IsExtended { deps = append(@@ -225,7 +229,8 @@ func GetDependencyListNonGo() []string { if IsDartSassGeV2() { dartSassPath = "github.com/sass/dart-sass" }- deps = append(deps,+ deps = append(+ deps, formatDep(dartSassPath+"/protocol", dartSass.ProtocolVersion), formatDep(dartSassPath+"/compiler", dartSass.CompilerVersion), formatDep(dartSassPath+"/implementation", dartSass.ImplementationVersion),internal/warpc/avif.goindex baadaadd7..f080b87b1 100644@@ -25,6 +25,13 @@ import ( "github.com/gohugoio/hugo/common/hugio" ) +// Keep in sync with genavif/Makefile.+const (+ libavifVersion = "v1.4.1"+ aomVersion = "v3.14.1"+ dav1dVersion = "1.5.3"+)+ var ( _ SourceProvider = AvifInput{} _ DestinationProvider = AvifInput{}internal/warpc/katex.goindex 75c20117f..627f18e3a 100644@@ -17,6 +17,9 @@ import ( _ "embed" ) +// Keep in sync with js/package.json.+const katexVersion = "0.16.21"+ //go:embed wasm/renderkatex.wasm var katexWasm []byte internal/warpc/warpc.goindex b7763e782..be8e48bb5 100644@@ -48,6 +48,17 @@ const ( const currentVersion = 1 +// GetWASMDeps returns version information for the C libraries bundled as WASM.+func GetWASMDeps() [][2]string {+ return [][2]string{+ {"aomedia.googlesource.com/aom", aomVersion},+ {"code.videolan.org/videolan/dav1d", dav1dVersion},+ {"github.com/AOMediaCodec/libavif", libavifVersion},+ {"github.com/KaTeX/KaTeX", katexVersion},+ {"github.com/webmproject/libwebp", libwebpVersion},+ }+}+ //go:embed wasm/quickjs.wasm var quickjsWasm []byte @@ -348,7 +359,8 @@ func (d *dispatcher[Q, R]) inputBlobs() error { call.done() } return nil- }); err != nil {+ },+ ); err != nil { inputErr = err break }@@ -384,7 +396,8 @@ func (d *dispatcher[Q, R]) inputJSON() error { call.done() } return nil- }); err != nil {+ },+ ); err != nil { inputErr = err break }@@ -679,7 +692,8 @@ func newDispatcher[Q, R any](opts Options) (*dispatcherPool[Q, R], error) { if err != nil { return toErr("quickjs", errBuff, err) }- ctx = experimental.WithImportResolver(ctx,+ ctx = experimental.WithImportResolver(+ ctx, func(name string) api.Module { if name == opts.Runtime.Name { return runtimeInstanceinternal/warpc/webp.goindex 35ee98899..2c2be0bd4 100644@@ -28,6 +28,9 @@ import ( "github.com/gohugoio/hugo/common/hugio" ) +// Keep in sync with genwebp/Makefile.+const libwebpVersion = "v1.6.0"+ var ( _ SourceProvider = WebpInput{} _ DestinationProvider = WebpInput{}testscripts/commands/env.txtindex 742e05ffc..1ae628c6c 100644@@ -1,5 +1,12 @@ # Test the hugo env command. hugo env+stdout 'GOOS' stdout 'GOARCH'-! stderr .\ No newline at end of file+stdout 'GOVERSION'+stdout 'aomedia\.googlesource\.com/aom'+stdout 'code\.videolan\.org/videolan/dav1d'+stdout 'github\.com/AOMediaCodec/libavif'+stdout 'github\.com/KaTeX/KaTeX'+stdout 'github\.com/webmproject/libwebp'+! stderr .