Backtestspydanticrun-20260923-170312#13467

Issue #13467 Merged fix PR # Run 23 Sep 2026 · run-20260923-170312 pydantic/pydantic

Support Ellipsis

Worse

The merged fix was judged better than our patch.

In this judgment, Patch A = our agent, Patch B = the merged fix.

Both patches map EllipsisType via _generate_schema's dict, so both resolve the issue's basic ask (validate/serialize `...`). But they differ sharply in root-cause fit, robustness, and convention.

Patch B introduces a dedicated 'ellipsis' core schema type (validator, serializer, error type, JSON-schema handler) that mirrors the codebase's own recently-added MissingSentinel singleton pattern almost line-for-line. That is the idiomatic root-cause design for a singleton placeholder type: it yields a proper dedicated error ('ellipsis_error', "Input should be the 'Ellipsis' literal") instead of a confusing generic literal_error, and it defines explicit, tested serialization semantics (to_python returns `...`, JSON serialization deliberately raises a clear PydanticSerializationError). Its tests are comprehensive and behavior-anchored across core error tests, schema-function tests, TypeAdapter validate/dump/dump_json, and JSON schema, and it documents the new error. The large size is justified because it is a genuine new type following an established convention, not incidental churn.

Patch A is clever and minimal but reuses literal_schema([...]) and then hacks the shared GenerateJsonSchema.literal_schema to filter out `...` and raise PydanticOmit when empty. This overloads a general-purpose code path for a niche case, altering literal handling globally. Silently omitting a required, no-default EllipsisType field from JSON schema 'properties' risks an inconsistent schema (field potentially still in 'required'), and A never tests JSON serialization of `...`, leaving the literal serializer's behavior there unverified. Its single combined test is weaker coverage. A's one real edge — graceful union JSON schema for `int | EllipsisType` (the issue's example) — is a legitimate point, but B's choice to raise PydanticInvalidForJsonSchema for an inherently non-representable type is defensible and more honest than A's silent drop.

On correctness robustness, dedicated error UX, serialization semantics, test depth, and consistency with the existing sentinel convention, B is the stronger fix; A's smaller footprint doesn't outweigh its overloading of shared literal logic and untested serialization edges.

The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.

Solve

8m 59s13 turns

Wall-clock time in the container

Full test suite

No new failures

6,457 passed · 366 skipped · 6,823 total

Contamination audit

Unknown

See the audit notes for this run

Patch size

35vs 225 merged

Changed lines, ours vs merged

Initial Checks

  • I have searched Google & GitHub for similar requests and couldn't find anything
  • I have read and followed the docs and still think this feature is missing

Description

Ellipsis is a builtin type that pydantic does not support. Its usage is infrequent, but it can be useful to express placeholders:

This is a bit of a contrived example, but:

class Model(pydantic.BaseModel):
    m: list[list[float]]
    subset: tuple[int | Ellipsis, int | Ellipsis]

    def subset_arr(self) -> np.NDArray:
        return np.asarray(self.m)[*self.subset]

Here's how I implement this right now with an adapter: https://github.com/psalvaggio/scientific_pydantic/blob/main/src/scientific_pydantic/ellipsis.py

However, since this is a standard library type, I think this would be a good thing to live in pydantic itself.

Affected Components

The two patches

Our patch+33 −2
pydantic/_internal/_generate_schema.pyindex 3fba8dc3..f5b2549c 100644@@ -23,7 +23,7 @@ from inspect import Parameter, _ParameterKind from ipaddress import IPv4Address, IPv4Interface, IPv4Network, IPv6Address, IPv6Interface, IPv6Network from itertools import chain from operator import attrgetter-from types import FunctionType, GenericAlias, LambdaType, MethodType, NoneType+from types import EllipsisType, FunctionType, GenericAlias, LambdaType, MethodType, NoneType from typing import (     TYPE_CHECKING,     Any,@@ -364,6 +364,7 @@ class GenerateSchema:         None: lambda self, obj: core_schema.none_schema(),         NoneType: lambda self, obj: core_schema.none_schema(),         MISSING: lambda self, obj: core_schema.missing_sentinel_schema(),+        EllipsisType: lambda self, obj: core_schema.literal_schema([...]),         type: lambda self, obj: self._type_schema(),         dict: lambda self, obj: self._dict_schema(Any, Any),         tuple: lambda self, obj: self._tuple_schema(obj),pydantic/json_schema.pyindex 27756c09..7c8e8951 100644@@ -873,7 +873,11 @@ class GenerateJsonSchema:         Returns:             The generated JSON schema.         """-        expected = [to_jsonable_python(v.value if isinstance(v, Enum) else v) for v in schema['expected']]+        # `Ellipsis` (from `EllipsisType` annotations) has no JSON Schema representation, so it is omitted:+        values = [v for v in schema['expected'] if v is not ...]+        if not values:+            raise PydanticOmit+        expected = [to_jsonable_python(v.value if isinstance(v, Enum) else v) for v in values]          result: dict[str, Any] = {}         if len(expected) == 1:tests/test_types.pyindex df4d5f06..7577c1d4 100644@@ -20,6 +20,7 @@ from enum import Enum, IntEnum from numbers import Number from pathlib import Path from re import Pattern+from types import EllipsisType from typing import (     Annotated,     Any,@@ -5326,6 +5327,31 @@ def test_none(value_type):     ]  +def test_ellipsis_type():+    class Model(BaseModel):+        e: EllipsisType++    m = Model(e=...)+    assert m.e is ...++    with pytest.raises(ValidationError) as exc_info:+        Model(e=1)+    assert exc_info.value.errors(include_url=False)[0]['type'] == 'literal_error'++    assert Model(e=...).model_dump() == {'e': ...}+    assert Model(e=...).model_dump()['e'] is ...++    assert 'e' not in Model.model_json_schema().get('properties', {})++    class UnionModel(BaseModel):+        u: int | EllipsisType++    assert UnionModel(u=5).u == 5+    assert UnionModel(u=...).u is ...++    assert UnionModel.model_json_schema()['properties']['u'] == {'title': 'U', 'type': 'integer'}++ def test_none_literal():     class Model(BaseModel):         my_none: Literal[None] 
Merged fix · PR #+224 −1
docs/errors/validation_errors.mdindex b0d509b97..fc0539fef 100644@@ -724,6 +724,27 @@ except ValidationError as exc:     #> 'dict_type' ``` +## `ellipsis_error`++This error is raised when the input isn't the [`Ellipsis`][] literal:++```python+from types import EllipsisType++from pydantic import BaseModel, ValidationError+++class Model(BaseModel):+    e: EllipsisType+++try:+    Model(e=1)+except ValidationError as exc:+    print(repr(exc.errors()[0]['type']))+    #> 'ellipsis_error'+```+ ## `enum`  This error is raised when the input value does not exist in an `enum` field members:pydantic-core/python/pydantic_core/core_schema.pyindex c6118a082..965cf28e1 100644@@ -1453,6 +1453,25 @@ def missing_sentinel_schema(     )  +class EllipsisSchema(TypedDict, total=False):+    type: Required[Literal['ellipsis']]+    metadata: dict[str, Any]+    serialization: SerSchema+++def ellipsis_schema(+    metadata: dict[str, Any] | None = None,+    serialization: SerSchema | None = None,+) -> EllipsisSchema:+    """Returns a schema for the [`Ellipsis`][] literal."""++    return _dict_not_none(+        type='ellipsis',+        metadata=metadata,+        serialization=serialization,+    )++ # must match input/parse_json.rs::JsonType::try_from JsonType = Literal['null', 'bool', 'int', 'float', 'str', 'list', 'dict'] @@ -4201,6 +4220,7 @@ if not MYPY:         | TimedeltaSchema         | LiteralSchema         | MissingSentinelSchema+        | EllipsisSchema         | EnumSchema         | IsInstanceSchema         | IsSubclassSchema@@ -4261,6 +4281,7 @@ CoreSchemaType: TypeAlias = Literal[     'timedelta',     'literal',     'missing-sentinel',+    'ellipsis',     'enum',     'is-instance',     'is-subclass',@@ -4363,6 +4384,7 @@ ErrorType: TypeAlias = Literal[     'assertion_error',     'literal_error',     'missing_sentinel_error',+    'ellipsis_error',     'date_type',     'date_parsing',     'date_from_datetime_parsing',pydantic-core/src/errors/types.rsindex da9cdae0c..8f8e936ce 100644@@ -324,6 +324,9 @@ error_types! {     // ---------------------     // missing sentinel     MissingSentinelError {},+    // ---------------------+    // ellipsis+    EllipsisError {},     // date errors     DateType {},     DateParsing {@@ -552,6 +555,7 @@ impl ErrorType {             Self::CustomError { .. } => "", // custom errors are handled separately             Self::LiteralError { .. } => "Input should be {expected}",             Self::MissingSentinelError { .. } => "Input should be the 'MISSING' sentinel",+            Self::EllipsisError { .. } => "Input should be the 'Ellipsis' literal",             Self::DateType { .. } => "Input should be a valid date",             Self::DateParsing { .. } => "Input should be a valid date in the format YYYY-MM-DD, {error}",             Self::DateFromDatetimeParsing { .. } => "Input should be a valid date or datetime, {error}",pydantic-core/src/serializers/shared.rsindex 5f7efee37..f6342c1ec 100644@@ -153,6 +153,7 @@ combined_serializer! {         TaggedUnion: super::type_serializers::union::TaggedUnionSerializer;         Literal: super::type_serializers::literal::LiteralSerializer;         MissingSentinel: super::type_serializers::missing_sentinel::MissingSentinelSerializer;+        Ellipsis: super::type_serializers::ellipsis::EllipsisSerializer;         Enum: super::type_serializers::enum_::EnumSerializer;         Recursive: super::type_serializers::definitions::DefinitionRefSerializer;         Tuple: super::type_serializers::tuple::TupleSerializer;@@ -385,6 +386,7 @@ impl PyGcTraverse for CombinedSerializer {             CombinedSerializer::TaggedUnion(inner) => inner.py_gc_traverse(visit),             CombinedSerializer::Literal(inner) => inner.py_gc_traverse(visit),             CombinedSerializer::MissingSentinel(inner) => inner.py_gc_traverse(visit),+            CombinedSerializer::Ellipsis(inner) => inner.py_gc_traverse(visit),             CombinedSerializer::Enum(inner) => inner.py_gc_traverse(visit),             CombinedSerializer::Recursive(inner) => inner.py_gc_traverse(visit),             CombinedSerializer::Tuple(inner) => inner.py_gc_traverse(visit),pydantic-core/src/serializers/type_serializers/ellipsis.rsnew file mode 100644index 000000000..634916c5d@@ -0,0 +1,74 @@+// This serializer is defined so that building a schema serializer containing an+// 'ellipsis' core schema doesn't crash. In practice, the serializer can be used+// if the 'ellipsis' core schema is used standalone (e.g. with a Pydantic type+// adapter), but this isn't something we explicitly support.++use std::borrow::Cow;+use std::sync::{Arc, LazyLock};++use pyo3::prelude::*;+use pyo3::types::{PyDict, PyEllipsis};++use serde::ser::Error;++use crate::PydanticSerializationUnexpectedValue;+use crate::definitions::DefinitionsBuilder;+use crate::serializers::SerializationState;++use super::{BuildSerializer, CombinedSerializer, TypeSerializer};++#[derive(Debug)]+pub struct EllipsisSerializer {}++static ELLIPSIS_SERIALIZER: LazyLock<Arc<CombinedSerializer>> =+    LazyLock::new(|| Arc::new(EllipsisSerializer {}.into()));++impl BuildSerializer for EllipsisSerializer {+    const EXPECTED_TYPE: &'static str = "ellipsis";++    fn build(+        _schema: &Bound<'_, PyDict>,+        _config: Option<&Bound<'_, PyDict>>,+        _definitions: &mut DefinitionsBuilder<Arc<CombinedSerializer>>,+    ) -> PyResult<Arc<CombinedSerializer>> {+        Ok(ELLIPSIS_SERIALIZER.clone())+    }+}++impl_py_gc_traverse!(EllipsisSerializer {});++impl TypeSerializer for EllipsisSerializer {+    fn to_python(&self, value: &Bound<'_, PyAny>, _state: &mut SerializationState<'_>) -> PyResult<Py<PyAny>> {+        let ellipsis = PyEllipsis::get(value.py());++        if value.is(ellipsis) {+            Ok(ellipsis.to_owned().into_any().unbind())+        } else {+            Err(+                PydanticSerializationUnexpectedValue::new_from_msg(Some("Expected 'Ellipsis' object".to_string()))+                    .to_py_err(),+            )+        }+    }++    fn json_key<'a, 'py>(+        &self,+        key: &'a Bound<'py, PyAny>,+        state: &mut SerializationState<'py>,+    ) -> PyResult<Cow<'a, str>> {+        self.invalid_as_json_key(key, state, Self::EXPECTED_TYPE)+    }++    fn serde_serialize<S: serde::ser::Serializer>(+        &self,+        _value: &Bound<'_, PyAny>,+        _serializer: S,+        _state: &mut SerializationState<'_>,+    ) -> Result<S::Ok, S::Error> {+        Err(Error::custom("'Ellipsis' can't be serialized to JSON".to_string()))+    }++    fn get_name(&self) -> &str {+        Self::EXPECTED_TYPE+    }+}pydantic-core/src/serializers/type_serializers/mod.rsindex da95113ea..ad664e8f8 100644@@ -6,6 +6,7 @@ pub mod datetime_etc; pub mod decimal; pub mod definitions; pub mod dict;+pub mod ellipsis; pub mod enum_; pub mod float; pub mod format;pydantic-core/src/validators/ellipsis.rsnew file mode 100644index 000000000..d3dfa9faf@@ -0,0 +1,48 @@+use core::fmt::Debug;+use std::sync::{Arc, LazyLock};++use pyo3::prelude::*;+use pyo3::types::{PyDict, PyEllipsis};++use crate::errors::{ErrorType, ValError, ValResult};+use crate::input::Input;++use super::{BuildValidator, CombinedValidator, DefinitionsBuilder, ValidationState, Validator};++#[derive(Debug, Clone)]+pub struct EllipsisValidator {}++static ELLIPSIS_VALIDATOR: LazyLock<Arc<CombinedValidator>> =+    LazyLock::new(|| CombinedValidator::Ellipsis(EllipsisValidator {}).into());++impl BuildValidator for EllipsisValidator {+    const EXPECTED_TYPE: &'static str = "ellipsis";++    fn build(+        _schema: &Bound<'_, PyDict>,+        _config: Option<&Bound<'_, PyDict>>,+        _definitions: &mut DefinitionsBuilder<Arc<CombinedValidator>>,+    ) -> PyResult<Arc<CombinedValidator>> {+        Ok(ELLIPSIS_VALIDATOR.clone())+    }+}++impl_py_gc_traverse!(EllipsisValidator {});++impl Validator for EllipsisValidator {+    fn validate<'py>(+        &self,+        py: Python<'py>,+        input: &(impl Input<'py> + ?Sized),+        _state: &mut ValidationState<'_, 'py>,+    ) -> ValResult<Py<PyAny>> {+        match input.as_python() {+            Some(v) if v.is(PyEllipsis::get(py)) => Ok(v.to_owned().into()),+            _ => Err(ValError::new(ErrorType::EllipsisError { context: None }, input)),+        }+    }++    fn get_name(&self) -> &str {+        Self::EXPECTED_TYPE+    }+}pydantic-core/src/validators/mod.rsindex 2ab41e6b0..7a6875e3d 100644@@ -37,6 +37,7 @@ mod datetime; pub(crate) mod decimal; mod definitions; mod dict;+mod ellipsis; mod enum_; mod float; pub(crate) mod fraction;@@ -610,6 +611,8 @@ fn build_validator_inner(         literal::LiteralValidator,         // missing sentinel         missing_sentinel::MissingSentinelValidator,+        // ellipsis+        ellipsis::EllipsisValidator,         // enums         enum_::BuildEnumValidator,         // any@@ -775,6 +778,8 @@ pub enum CombinedValidator {     Literal(literal::LiteralValidator),     // Missing sentinel     MissingSentinel(missing_sentinel::MissingSentinelValidator),+    // Ellipsis+    Ellipsis(ellipsis::EllipsisValidator),     // enums     IntEnum(enum_::EnumValidator<enum_::IntEnumValidator>),     StrEnum(enum_::EnumValidator<enum_::StrEnumValidator>),pydantic-core/tests/test_errors.pyindex 274ecb3f6..334e281bd 100644@@ -347,6 +347,7 @@ all_errors = [     ('literal_error', 'Input should be foo', {'expected': 'foo'}),     ('literal_error', 'Input should be foo or bar', {'expected': 'foo or bar'}),     ('missing_sentinel_error', "Input should be the 'MISSING' sentinel", None),+    ('ellipsis_error', "Input should be the 'Ellipsis' literal", None),     ('date_type', 'Input should be a valid date', None),     ('date_parsing', 'Input should be a valid date in the format YYYY-MM-DD, foobar', {'error': 'foobar'}),     ('date_from_datetime_parsing', 'Input should be a valid date or datetime, foobar', {'error': 'foobar'}),pydantic-core/tests/test_schema_functions.pyindex 299b08e3f..65a015a6f 100644@@ -83,6 +83,7 @@ all_schema_functions = [     ),     (core_schema.literal_schema, args(['a', 'b']), {'type': 'literal', 'expected': ['a', 'b']}),     (core_schema.missing_sentinel_schema, args(), {'type': 'missing-sentinel'}),+    (core_schema.ellipsis_schema, args(), {'type': 'ellipsis'}),     (         core_schema.enum_schema,         args(MyEnum, list(MyEnum.__members__.values())),pydantic/_internal/_generate_schema.pyindex 3fba8dc3e..3436338cc 100644@@ -23,7 +23,7 @@ from inspect import Parameter, _ParameterKind from ipaddress import IPv4Address, IPv4Interface, IPv4Network, IPv6Address, IPv6Interface, IPv6Network from itertools import chain from operator import attrgetter-from types import FunctionType, GenericAlias, LambdaType, MethodType, NoneType+from types import EllipsisType, FunctionType, GenericAlias, LambdaType, MethodType, NoneType from typing import (     TYPE_CHECKING,     Any,@@ -364,6 +364,7 @@ class GenerateSchema:         None: lambda self, obj: core_schema.none_schema(),         NoneType: lambda self, obj: core_schema.none_schema(),         MISSING: lambda self, obj: core_schema.missing_sentinel_schema(),+        EllipsisType: lambda self, obj: core_schema.ellipsis_schema(),         type: lambda self, obj: self._type_schema(),         dict: lambda self, obj: self._dict_schema(Any, Any),         tuple: lambda self, obj: self._tuple_schema(obj),pydantic/json_schema.pyindex 27756c099..c6adb6947 100644@@ -907,6 +907,19 @@ class GenerateJsonSchema:         """         raise PydanticOmit +    def ellipsis_schema(self, schema: core_schema.EllipsisSchema) -> JsonSchemaValue:+        """Handles JSON schema generation for a core schema that checks if a value is the [`Ellipsis`][] literal.++        Unless overridden in a subclass, this raises an error.++        Args:+            schema: The core schema.++        Returns:+            The generated JSON schema.+        """+        return self.handle_invalid_for_json_schema(schema, 'core_schema.EllipsisSchema')+     def enum_schema(self, schema: core_schema.EnumSchema) -> JsonSchemaValue:         """Generates a JSON schema that matches an Enum value. tests/test_json_schema.pyindex 2486dfdd8..633abea77 100644@@ -12,6 +12,7 @@ from enum import Enum, IntEnum from ipaddress import IPv4Address, IPv4Interface, IPv4Network, IPv6Address, IPv6Interface, IPv6Network from pathlib import Path from re import Pattern+from types import EllipsisType from typing import (     Annotated,     Any,@@ -1319,6 +1320,14 @@ def test_callable_type(type_, default_value, base_json_schema, properties):     assert model_schema['properties'] == properties  +def test_ellipsis_schema() -> None:+    class Model(BaseModel):+        e: EllipsisType++    with pytest.raises(PydanticInvalidForJsonSchema):+        Model.model_json_schema()++ @pytest.mark.parametrize(     'default_value,properties',     (tests/types/test_ellipsis.pynew file mode 100644index 000000000..11b7fdea7@@ -0,0 +1,21 @@+from types import EllipsisType++import pytest+from pydantic_core import PydanticSerializationError, PydanticSerializationUnexpectedValue++from pydantic import TypeAdapter+++def test_ellipsis_literal() -> None:+    ta = TypeAdapter(EllipsisType)++    assert ta.validate_python(...) is ...+    assert ta.dump_python(...) is ...++    with pytest.raises(PydanticSerializationUnexpectedValue):+        ta.dump_python(1)++    with pytest.raises(+        PydanticSerializationError, match="Error serializing to JSON: 'Ellipsis' can't be serialized to JSON"+    ):+        ta.dump_json(...) 

What the agent reported

The change is complete and reviewed. Here's the final report.

What was wrong

Pydantic did not support the standard-library types.EllipsisType (the type of ...). Annotating a field with it raised PydanticSchemaGenerationError: Unable to generate pydantic-core schema for <class 'ellipsis'>, because there was no handler registered for it in the core-schema dispatch table.

What I changed

  1. pydantic/_internal/_generate_schema.py
  2. Imported EllipsisType from types (line 26).
  3. Added a handler to the _handlers dispatch dict, next to the existing None/NoneType/MISSING singleton handlers: EllipsisType: lambda self, obj: core_schema.literal_schema([...]). This validates only the ... singleton and serializes ... in Python mode.
  1. pydantic/json_schema.py — literal_schema handler: ... has no JSON representation, so to_jsonable_python(...) would raise invalid-json-value. Since a literal schema can only contain ... via an EllipsisType annotation (Literal[...] is unspellable), the handler now filters out Ellipsis values and raises PydanticOmit if nothing remains — mirroring how missing_sentinel_schema is omitted from JSON schema. Ordinary literals are computed identically (no behavior change when no Ellipsis is present).
  1. tests/test_types.py — added test_ellipsis_type (after test_none), asserting validation of ..., literal_error on bad input, Python-mode serialization round-trip preserving the singleton, JSON-schema omission, and union usage (int | EllipsisType, where the Ellipsis branch is dropped from the JSON schema).

Test evidence

  • ./bt-test tests/test_types.py -k test_ellipsis_type → passed. Without the production change the test errors at class-definition time (unhandled type), so it captures the regression.
  • Blast-radius gate ./bt-test tests/test_types.py tests/test_json_schema.py tests/test_missing_sentinel.py -k "literal or none or ellipsis or missing_sentinel" → 40 passed, 1 xfailed (the xfail is the pre-existing pickle test), confirming the shared literal_schema JSON handler change breaks no existing literal/none/sentinel behavior.
  • Reviewer confirmed the diff is minimal, correct, touches no unrelated code or existing tests, and leaves no scratch files.

Requirements disposition

  • Support Ellipsis / types.EllipsisType as a validatable field type — Implemented, with test evidence above (validation + invalid-input error).
  • Serialization (model_dump) — Implemented; Python-mode round-trips ... by identity (tested). JSON-mode serialization of ... isn't meaningful (no JSON representation) and isn't required by the report.
  • JSON schema behavior — Implemented; Ellipsis fields are omitted (consistent with the MISSING sentinel precedent), tested for both bare and union cases.
  • The report's "Affected Components" checklist boxes were all left unchecked by the reporter; the concrete ask (a contrived tuple[int | Ellipsis, ...] placeholder use-case) is served by supporting EllipsisType in unions, which is tested.

All changes are left uncommitted in the working tree.