Backtestspydanticrun-20260929-204949#13664
JSON Schema ignores ser_json_temporal, so serialization schemas contradict model_dump_json() output
Our patch was judged better than the merged fix.
In this judgment, Patch A = our agent, Patch B = the merged fix.
Both patches correctly implement the ser_json_temporal precedence for timedelta (both gate on `'ser_json_temporal' in self._config.config_dict` and set the format explicitly, so that path is equivalent and correct). The decisive difference is in date/time/datetime. Patch A checks `self._config.ser_json_temporal in ('seconds', 'milliseconds')` and returns a number only for those explicit values, so it is safe regardless of what the config default for ser_json_temporal is. Patch B routes date/time/datetime through `_common_temporal_schema('date', self._config.ser_json_temporal)` where the branch is `if temporal_format != 'iso8601': return {'type': 'number'}`. This is correct ONLY if the config default value of ser_json_temporal is exactly 'iso8601'. If the default is None/absent (which is plausible given the whole precedence design keys off presence in config_dict, and this method is shared by validation-mode schemas), Patch B would silently emit `{'type': 'number'}` for every temporal field even with no config set — a serious regression that neither patch's added tests exercise (both only test explicit configs). Patch A cannot exhibit this failure mode under any default. On tests, both add meaningful before/after coverage of both mismatch directions; Patch B's dump-vs-schema type comparison test is a nice touch and slightly more direct, and its `_common_temporal_schema` factoring is clean (a craft plus), but that same factoring is what introduces the default-value dependency. Given correctness is weighted first and Patch A is provably safe across all default scenarios while Patch B hinges on an unverified assumption about the default, Patch A is the safer, more clearly-correct fix. Scope is comparable and minimal for both.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
6m 37s17 turns
Wall-clock time in the container
Full test suite
No new failures
12,351 passed · 500 skipped · 12,851 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
76vs 88 merged
Changed lines, ours vs merged
The issue
View on GitHubInitial Checks
- I confirm that I'm using Pydantic V2
Description
ser_json_temporal landed in v2.12 and controls how datetime, date, time and timedelta are serialized to JSON. GenerateJsonSchema was never told about it, so a mode='serialization' schema still says these fields are strings even when model_dump_json() writes numbers.
With ser_json_temporal='seconds' (same with 'milliseconds'), every temporal field is affected:
schema: {'dt': {'type': 'string', 'format': 'date-time'}, 'td': {'type': 'string', 'format': 'duration'}}
dump: {'dt': 1577836800.0, 'td': 86400.0}
Running that payload through a JSON Schema validator fails with 1577836800.0 is not of type 'string', so the schema pydantic publishes rejects the output pydantic itself just produced. date_schema, time_schema and datetime_schema read no config at all right now.
There is a second mismatch that goes the other way, on timedelta. timedelta_schema only looks at the older ser_json_timedelta setting. The docs for ser_json_temporal say it takes precedence over ser_json_timedelta, and pydantic-core implements exactly that: SerializationConfig::from_config and TimeDeltaSerializer::build both check whether ser_json_temporal is present in the config before falling back to ser_json_timedelta. The JSON schema layer does not, so setting ser_json_temporal='iso8601' together with ser_json_timedelta='float' gives you the reverse problem:
schema: {'td': {'type': 'number'}}
dump: {'td': 'P1D'}
For anyone generating an OpenAPI document from a model this is a silent wrong answer rather than a crash, which is probably why it has gone unnoticed since the setting was added.
I have a patch that mirrors the pydantic-core resolution in the four temporal schema methods, plus tests. Happy to open a PR if you want to assign this to me.
Example Code
import json
from datetime import date, datetime, time, timedelta
from pydantic import BaseModel, ConfigDict
class Numeric(BaseModel):
model_config = ConfigDict(ser_json_temporal='seconds')
dt: datetime
d: date
t: time
td: timedelta
model = Numeric(dt=datetime(2020, 1, 1), d=date(2020, 1, 1), t=time(12, 0), td=timedelta(days=1))
print(Numeric.model_json_schema(mode='serialization')['properties'])
#> {'dt': {'format': 'date-time', 'title': 'Dt', 'type': 'string'},
#> 'd': {'format': 'date', 'title': 'D', 'type': 'string'},
#> 't': {'format': 'time', 'title': 'T', 'type': 'string'},
#> 'td': {'format': 'duration', 'title': 'Td', 'type': 'string'}}
print(json.loads(model.model_dump_json()))
#> {'dt': 1577836800.0, 'd': 1577836800.0, 't': 43200.0, 'td': 86400.0}
# The timedelta precedence case, wrong in the opposite direction:
class Precedence(BaseModel):
model_config = ConfigDict(ser_json_temporal='iso8601', ser_json_timedelta='float')
td: timedelta
print(Precedence.model_json_schema(mode='serialization')['properties'])
#> {'td': {'title': 'Td', 'type': 'number'}}
print(json.loads(Precedence(td=timedelta(days=1)).model_dump_json()))
#> {'td': 'P1D'}
Python, Pydantic & OS Version
pydantic version: 2.13.4
pydantic-core version: 2.46.4
pydantic-core build: profile=release pgo=false
python version: 3.12.13 (main, May 10 2026, 19:20:41) [Clang 22.1.3 ]
platform: macOS-15.7.4-arm64-arm-64bit
related packages: typing_extensions-4.16.0
commit: unknown
Also reproduces on main (2.14.0b1 / pydantic-core 2.48.0).
The two patches
pydantic/json_schema.pyindex c2183e19..444756ef 100644@@ -818,6 +818,9 @@ class GenerateJsonSchema: self.update_with_validations(json_schema, schema, self.ValidationsMapping.bytes) return json_schema + def _ser_json_temporal_is_numeric(self) -> bool:+ return self._config.ser_json_temporal in ('seconds', 'milliseconds')+ def date_schema(self, schema: core_schema.DateSchema) -> JsonSchemaValue: """Generates a JSON schema that matches a date value. @@ -827,6 +830,8 @@ class GenerateJsonSchema: Returns: The generated JSON schema. """+ if self._ser_json_temporal_is_numeric():+ return {'type': 'number'} return {'type': 'string', 'format': 'date'} def time_schema(self, schema: core_schema.TimeSchema) -> JsonSchemaValue:@@ -838,6 +843,8 @@ class GenerateJsonSchema: Returns: The generated JSON schema. """+ if self._ser_json_temporal_is_numeric():+ return {'type': 'number'} return {'type': 'string', 'format': 'time'} def datetime_schema(self, schema: core_schema.DatetimeSchema) -> JsonSchemaValue:@@ -849,6 +856,8 @@ class GenerateJsonSchema: Returns: The generated JSON schema. """+ if self._ser_json_temporal_is_numeric():+ return {'type': 'number'} return {'type': 'string', 'format': 'date-time'} def timedelta_schema(self, schema: core_schema.TimedeltaSchema) -> JsonSchemaValue:@@ -860,7 +869,10 @@ class GenerateJsonSchema: Returns: The generated JSON schema. """- if self._config.ser_json_timedelta == 'float':+ if 'ser_json_temporal' in self._config.config_dict:+ if self._ser_json_temporal_is_numeric():+ return {'type': 'number'}+ elif self._config.ser_json_timedelta == 'float': return {'type': 'number'} return {'type': 'string', 'format': 'duration'} tests/test_json_schema.pyindex 9cca3292..bf756114 100644@@ -1960,6 +1960,68 @@ def test_typeddict_default_timedelta(ser_json_timedelta: Literal['float', 'iso86 } +@pytest.mark.parametrize(+ 'config,properties',+ [+ (+ ConfigDict(ser_json_temporal='seconds'),+ {+ 'dt': {'title': 'Dt', 'type': 'number'},+ 'd': {'title': 'D', 'type': 'number'},+ 't': {'title': 'T', 'type': 'number'},+ 'td': {'title': 'Td', 'type': 'number'},+ },+ ),+ (+ ConfigDict(ser_json_temporal='milliseconds'),+ {+ 'dt': {'title': 'Dt', 'type': 'number'},+ 'd': {'title': 'D', 'type': 'number'},+ 't': {'title': 'T', 'type': 'number'},+ 'td': {'title': 'Td', 'type': 'number'},+ },+ ),+ (+ ConfigDict(ser_json_temporal='iso8601'),+ {+ 'dt': {'title': 'Dt', 'type': 'string', 'format': 'date-time'},+ 'd': {'title': 'D', 'type': 'string', 'format': 'date'},+ 't': {'title': 'T', 'type': 'string', 'format': 'time'},+ 'td': {'title': 'Td', 'type': 'string', 'format': 'duration'},+ },+ ),+ (+ ConfigDict(ser_json_temporal='iso8601', ser_json_timedelta='float'),+ {+ 'dt': {'title': 'Dt', 'type': 'string', 'format': 'date-time'},+ 'd': {'title': 'D', 'type': 'string', 'format': 'date'},+ 't': {'title': 'T', 'type': 'string', 'format': 'time'},+ 'td': {'title': 'Td', 'type': 'string', 'format': 'duration'},+ },+ ),+ (+ ConfigDict(ser_json_timedelta='float'),+ {+ 'dt': {'title': 'Dt', 'type': 'string', 'format': 'date-time'},+ 'd': {'title': 'D', 'type': 'string', 'format': 'date'},+ 't': {'title': 'T', 'type': 'string', 'format': 'time'},+ 'td': {'title': 'Td', 'type': 'number'},+ },+ ),+ ],+)+def test_model_ser_json_temporal_json_schema(config: ConfigDict, properties: dict[str, Any]):+ class Model(BaseModel):+ model_config = config++ dt: datetime+ d: date+ t: time+ td: timedelta++ assert Model.model_json_schema(mode='serialization')['properties'] == properties++ @pytest.mark.parametrize( 'ser_json_bytes,properties', [
pydantic/json_schema.pyindex c2183e193..aa330bc66 100644@@ -827,7 +827,7 @@ class GenerateJsonSchema: Returns: The generated JSON schema. """- return {'type': 'string', 'format': 'date'}+ return self._common_temporal_schema('date', self._config.ser_json_temporal) def time_schema(self, schema: core_schema.TimeSchema) -> JsonSchemaValue: """Generates a JSON schema that matches a time value.@@ -838,7 +838,7 @@ class GenerateJsonSchema: Returns: The generated JSON schema. """- return {'type': 'string', 'format': 'time'}+ return self._common_temporal_schema('time', self._config.ser_json_temporal) def datetime_schema(self, schema: core_schema.DatetimeSchema) -> JsonSchemaValue: """Generates a JSON schema that matches a datetime value.@@ -849,7 +849,7 @@ class GenerateJsonSchema: Returns: The generated JSON schema. """- return {'type': 'string', 'format': 'date-time'}+ return self._common_temporal_schema('date-time', self._config.ser_json_temporal) def timedelta_schema(self, schema: core_schema.TimedeltaSchema) -> JsonSchemaValue: """Generates a JSON schema that matches a timedelta value.@@ -860,9 +860,21 @@ class GenerateJsonSchema: Returns: The generated JSON schema. """- if self._config.ser_json_timedelta == 'float':+ if 'ser_json_temporal' in self._config.config_dict:+ temporal_format = self._config.ser_json_temporal+ else:+ # `ser_json_temporal` supersedes `ser_json_timedelta`, which only applies when the former isn't+ # explicitly set.+ temporal_format = 'seconds' if self._config.ser_json_timedelta == 'float' else 'iso8601'+ return self._common_temporal_schema('duration', temporal_format)++ def _common_temporal_schema(+ self, format: str, temporal_format: Literal['iso8601', 'seconds', 'milliseconds']+ ) -> JsonSchemaValue:+ if temporal_format != 'iso8601':+ # Both `'seconds'` and `'milliseconds'` serialize to a number: return {'type': 'number'}- return {'type': 'string', 'format': 'duration'}+ return {'type': 'string', 'format': format} def literal_schema(self, schema: core_schema.LiteralSchema) -> JsonSchemaValue: """Generates a JSON schema that matches a literal value.tests/test_json_schema.pyindex 9cca32928..5157bdb80 100644@@ -830,6 +830,72 @@ def test_date_types(field_type, expected_schema): assert Model.model_json_schema() == base_schema +@pytest.mark.parametrize('ser_json_temporal', ['iso8601', 'seconds', 'milliseconds'])+@pytest.mark.parametrize(+ 'field_type,iso8601_format',+ [+ (datetime, 'date-time'),+ (date, 'date'),+ (time, 'time'),+ (timedelta, 'duration'),+ ],+)+def test_date_types_ser_json_temporal(field_type, iso8601_format, ser_json_temporal):+ """https://github.com/pydantic/pydantic/issues/13664"""++ class Model(BaseModel):+ model_config = ConfigDict(ser_json_temporal=ser_json_temporal)++ a: field_type++ if ser_json_temporal == 'iso8601':+ expected_schema = {'title': 'A', 'type': 'string', 'format': iso8601_format}+ else:+ expected_schema = {'title': 'A', 'type': 'number'}++ assert Model.model_json_schema(mode='serialization')['properties']['a'] == expected_schema+++@pytest.mark.parametrize('ser_json_temporal', ['iso8601', 'seconds', 'milliseconds'])+def test_date_types_ser_json_temporal_matches_serialized_output(ser_json_temporal):+ class Model(BaseModel):+ model_config = ConfigDict(ser_json_temporal=ser_json_temporal)++ dt: datetime+ d: date+ t: time+ td: timedelta++ model = Model(dt=datetime(2020, 1, 1), d=date(2020, 1, 1), t=time(12, 0), td=timedelta(days=1))+ properties = Model.model_json_schema(mode='serialization')['properties']+ expected_type = 'string' if ser_json_temporal == 'iso8601' else 'number'++ for field_name, value in json.loads(model.model_dump_json()).items():+ assert properties[field_name]['type'] == expected_type+ if ser_json_temporal == 'iso8601':+ assert isinstance(value, str)+ else:+ assert isinstance(value, float)+++@pytest.mark.parametrize(+ 'config,expected_schema',+ [+ ({'ser_json_timedelta': 'float'}, {'type': 'number'}),+ ({'ser_json_timedelta': 'iso8601'}, {'type': 'string', 'format': 'duration'}),+ ({'ser_json_temporal': 'seconds', 'ser_json_timedelta': 'iso8601'}, {'type': 'number'}),+ ({'ser_json_temporal': 'iso8601', 'ser_json_timedelta': 'float'}, {'type': 'string', 'format': 'duration'}),+ ],+)+def test_timedelta_ser_json_temporal_takes_precedence(config, expected_schema):+ class Model(BaseModel):+ model_config = config++ a: timedelta++ assert Model.model_json_schema(mode='serialization')['properties']['a'] == {'title': 'A', **expected_schema}++ @pytest.mark.parametrize( 'interval', [
What the agent reported
The review confirms the fix is complete and correct. Here is my final report.
What was wrong
GenerateJsonSchema never learned about the ser_json_temporal config (added in v2.12). As a result:
- datetime/date/time schemas were hardcoded to
{'type': 'string', 'format': ...}and read no config at all. Withser_json_temporal='seconds'(or'milliseconds'),model_dump_json()emits numbers, so the published serialization schema rejected pydantic's own output. timedelta_schemaonly checked the legacyser_json_timedeltaand ignoredser_json_temporal's documented precedence, soser_json_temporal='iso8601'+ser_json_timedelta='float'gave{'type': 'number'}while the dump was the ISO string'P1D'.
I verified actual serialization behavior empirically (the installed pydantic-core differs from what a naive read of the Rust source suggested): datetime/date/time depend only on ser_json_temporal; timedelta uses ser_json_temporal when explicitly set, else falls back to ser_json_timedelta.
What I changed
pydantic/json_schema.py (lines 821-877):
- Added helper
_ser_json_temporal_is_numeric()→ true for'seconds'/'milliseconds'. date_schema,time_schema,datetime_schema: return{'type': 'number'}when numeric, else the existing string+format.timedelta_schema: if'ser_json_temporal'is explicitly present inconfig_dict, follow it; otherwise fall back to the legacyser_json_timedelta == 'float'rule (backward compatible).
tests/test_json_schema.py: added test_model_ser_json_temporal_json_schema, parametrized over all reported scenarios.
Test evidence
- Before fix: the new test had
3 failed, 2 passed(the seconds, milliseconds, and precedence cases failed exactly as reported). - After fix:
./bt-test tests/test_json_schema.py→ 539 passed, 3 skipped, 1 xfailed — the new tests pass and no previously passing test regressed (the existing*_default_timedeltatests still pass unchanged, confirming backward compatibility).
Requirements disposition
- JSON schema honors
ser_json_temporalfor datetime/date/time ('seconds'/'milliseconds'→ number) — ✅ Implemented; covered by the seconds/milliseconds parametrizations. - timedelta precedence:
ser_json_temporaloverridesser_json_timedeltawhen set (iso8601+float→ string/duration) — ✅ Implemented; covered by the precedence parametrization. iso8601/default still yields string schemas with correct formats — ✅ Implemented; covered.- Backward compat:
ser_json_timedelta='float'alone → number — ✅ Preserved; covered by dedicated parametrization and the untouched existing*_default_timedeltatests.
All changes are left uncommitted in the working tree.