Backtestspydanticrun-20260930-183947#12435

Issue #12435 Merged fix PR #13553 Run 30 Sep 2026 · run-20260930-183947 pydantic/pydantic

Add FastMCP and MCP's python-sdk to third-party tests

Worse

The merged fix was judged better than our patch.

In this judgment, Patch B = our agent, Patch A = the merged fix.

Both patches add `test-mcp-python-sdk` and `test-fastmcp` jobs and wire them into `create-issue-on-failure`, so both address the issue's ask. The deciding factor is whether the new jobs would actually pass.

Patch A's jobs handle concrete failure modes that Patch B's do not:
- It unsets the workflow-level `FORCE_COLOR`, noting that Rich's ANSI output breaks FastMCP's CLI tests, which assert on plain text or JSON.
- Its marker filter matches FastMCP's own unit-test CI action: it also excludes `subprocess_heavy` and `conformance`, and sets `--timeout=5`.
- It sets `MCP_EXAMPLES_SMOKE=0` to skip the MCP SDK smoke tests, which spawn real stdio and uvicorn subprocesses.
- It points at the current `PrefectHQ/fastmcp` location.

Patch B's FastMCP job keeps `FORCE_COLOR` set and uses a narrower marker exclusion, so the CLI and subprocess-heavy tests are likely to fail. `uv sync --locked` also fails whenever FastMCP's lockfile drifts from its pyproject. B's extra editable install of `./pydantic-latest/pydantic-core` adds a Rust build dependency on an assumed repo layout, and none of the existing jobs visible in the diff context do this.

Patch A's main weakness is unrelated churn in other jobs: appended `tests/` paths, a manual `git clone` for ODMantic, a redis service for Polar, and a changed Dify setup and command. These look like fixes for jobs that are currently broken, but they are outside the issue's scope and carry some risk. The ODMantic `-k` line, for example, now passes `tests` twice.

Neither patch adds tests, as expected for a CI-only change. Weighing correctness first, A's MCP and FastMCP jobs are clearly more likely to run green and be useful. That outweighs its extra scope.

The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.

Solve

6m 26s

Wall-clock time in the container

Full test suite

No new failures

12,298 passed · 501 skipped · 12,799 total

Contamination audit

Clean

No sign the agent saw the real fix

Patch size

89vs 141 merged

Changed lines, ours vs merged

The two patches

Our patch+88 −1
.github/workflows/third-party.ymlindex 6a057644..893ad944 100644@@ -877,6 +877,89 @@ jobs:       - name: Run FastDepends tests         run: uv run --no-sync pytest +  test-fastmcp:+    name: Test FastMCP (main branch) on Python ${{ matrix.python-version }}+    if: |+      github.event_name == 'workflow_dispatch' ||+      (github.event_name == 'schedule' && github.repository == 'pydantic/pydantic') ||+      (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'third-party-tests'))++    runs-on: ubuntu-latest+    strategy:+      fail-fast: false+      matrix:+        python-version: ['3.10', '3.11', '3.12', '3.13']+    steps:+      - name: Checkout FastMCP+        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0+        with:+          repository: jlowin/fastmcp+          persist-credentials: false++      - name: Checkout Pydantic+        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0+        with:+          path: pydantic-latest+          persist-credentials: false++      - uses: astral-sh/setup-uv@fac544c07dec837d0ccb6301d7b5580bf5edae39 # v8.2.0+        with:+          python-version: ${{ matrix.python-version }}++      - name: Install FastMCP dependencies+        run: |+          uv sync --locked --no-progress+          uv pip uninstall pydantic pydantic-core+          uv pip install -e ./pydantic-latest -e ./pydantic-latest/pydantic-core++      - name: List installed dependencies+        run: uv pip list++      - name: Run FastMCP tests+        # Integration tests require network access and external services, and are also excluded in FastMCP's own unit tests CI job:+        run: uv run --no-sync pytest --inline-snapshot=disable tests -m 'not integration and not client_process'++  test-mcp-python-sdk:+    name: Test MCP Python SDK (main branch) on Python ${{ matrix.python-version }}+    if: |+      github.event_name == 'workflow_dispatch' ||+      (github.event_name == 'schedule' && github.repository == 'pydantic/pydantic') ||+      (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'third-party-tests'))++    runs-on: ubuntu-latest+    strategy:+      fail-fast: false+      matrix:+        python-version: ['3.10', '3.11', '3.12', '3.13']+    steps:+      - name: Checkout MCP Python SDK+        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0+        with:+          repository: modelcontextprotocol/python-sdk+          persist-credentials: false++      - name: Checkout Pydantic+        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0+        with:+          path: pydantic-latest+          persist-credentials: false++      - uses: astral-sh/setup-uv@fac544c07dec837d0ccb6301d7b5580bf5edae39 # v8.2.0+        with:+          python-version: ${{ matrix.python-version }}++      - name: Install MCP Python SDK dependencies+        run: |+          uv sync --frozen --no-progress --all-extras+          uv pip uninstall pydantic pydantic-core+          uv pip install -e ./pydantic-latest -e ./pydantic-latest/pydantic-core++      - name: List installed dependencies+        run: uv pip list++      - name: Run MCP Python SDK tests+        run: uv run --frozen --no-sync pytest tests+   create-issue-on-failure:     name: Create an issue if tests failed     runs-on: ubuntu-latest@@ -897,6 +980,8 @@ jobs:       - test-redis-om       - test-django-ninja       - test-fastdepends+      - test-fastmcp+      - test-mcp-python-sdk     # Issue report disabled for now due to flakiness:     if: |       always() &&@@ -919,7 +1004,9 @@ jobs:         needs.test-pydantic-xml.result == 'failure' ||         needs.test-redis-om.result == 'failure' ||         needs.test-django-ninja.result == 'failure' ||-        needs.test-fastdepends.result == 'failure'+        needs.test-fastdepends.result == 'failure' ||+        needs.test-fastmcp.result == 'failure' ||+        needs.test-mcp-python-sdk.result == 'failure'       )     permissions:       issues: write 
Merged fix · PR #13553+127 −14
.github/workflows/third-party.ymlindex 6a057644a..bdc248775 100644@@ -167,7 +167,7 @@ jobs:         run: pip list        - name: Run Beanie tests-        run: pytest -v+        run: pytest -v tests/    test-openapi-python-client:     name: Test openapi-python-client (main branch) on Python ${{ matrix.python-version }}@@ -277,10 +277,10 @@ jobs:      steps:       - name: Checkout ODMantic-        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0-        with:-          repository: art049/odmantic-          persist-credentials: false+        # Not using actions/checkout, as the ODMantic repository has a stale gitlink entry+        # ('.mongodb-cluster-action', with no matching '.gitmodules' entry) that makes the+        # action's 'git submodule foreach' auth cleanup fail with exit code 128.+        run: git clone --depth=1 https://github.com/art049/odmantic.git .        - name: Checkout Pydantic         uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0@@ -313,7 +313,7 @@ jobs:        - name: Run ODMantic tests         # Disabled tests, as per https://github.com/art049/odmantic/issues/512:-        run: uv run --no-sync pytest tests -k 'not test_custom_bson_serializable and not test_sync_custom_bson_serializable and not test_with_bson_serializer_override_builtin_bson'+        run: uv run --no-sync pytest tests -k 'not test_custom_bson_serializable and not test_sync_custom_bson_serializable and not test_with_bson_serializer_override_builtin_bson' tests/         env:           TEST_MONGO_URI: mongodb://localhost:27017/           TEST_MONGO_MODE: standalone@@ -350,6 +350,16 @@ jobs:         ports:           - 5432:5432 +      redis:+        image: redis:7.4-alpine+        options: >-+          --health-cmd "redis-cli ping"+          --health-interval 10s+          --health-timeout 5s+          --health-retries 5+        ports:+          - 6379:6379+       minio:         image: bitnamilegacy/minio:2024.5.28         ports:@@ -435,7 +445,7 @@ jobs:        - name: 🐍 Run polar tests (pytest)         working-directory: ./server-        run: uv run --no-sync pytest -n auto --no-cov+        run: uv run --no-sync pytest -n auto --no-cov tests/    test-bentoml:     name: Test BentoML (main branch) on Python ${{ matrix.python-version }}@@ -627,9 +637,8 @@ jobs:         with:           python-version: ${{ matrix.python-version }} -      - name: Install uv-        shell: bash-        run: pip install uv~=0.7.0+      - name: Set up uv+        uses: astral-sh/setup-uv@fac544c07dec837d0ccb6301d7b5580bf5edae39 # v8.2.0        - name: Install Dify dependencies         run: |@@ -641,7 +650,7 @@ jobs:         run: uv pip --directory api list        - name: Run Dify unit tests-        run: uv run --no-sync --project api bash dev/pytest/pytest_unit_tests.sh+        run: uv run --no-sync --directory api pytest tests/unit_tests/    test-cadwyn:     name: Test Cadwyn (main branch) on Python ${{ matrix.python-version }}@@ -833,7 +842,7 @@ jobs:         run: pip list        - name: Run Django Ninja tests-        run: pytest+        run: pytest tests/    test-fastdepends:     name: Test FastDepends (main branch) on Python ${{ matrix.python-version }}@@ -875,7 +884,107 @@ jobs:         run: uv pip list        - name: Run FastDepends tests-        run: uv run --no-sync pytest+        run: uv run --no-sync pytest tests/++  test-mcp-python-sdk:+    name: Test MCP Python SDK (main branch) on Python ${{ matrix.python-version }}+    if: |+      github.event_name == 'workflow_dispatch' ||+      (github.event_name == 'schedule' && github.repository == 'pydantic/pydantic') ||+      (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'third-party-tests'))++    runs-on: ubuntu-latest+    strategy:+      fail-fast: false+      matrix:+        python-version: ['3.10', '3.11', '3.12', '3.13', '3.14']+    steps:+      - name: Checkout MCP Python SDK+        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0+        with:+          repository: modelcontextprotocol/python-sdk+          persist-credentials: false++      - name: Checkout Pydantic+        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0+        with:+          path: pydantic-latest+          persist-credentials: false++      - uses: astral-sh/setup-uv@fac544c07dec837d0ccb6301d7b5580bf5edae39 # v8.2.0+        with:+          enable-cache: true+          python-version: ${{ matrix.python-version }}++      - name: Install MCP Python SDK dependencies+        run: |+          uv venv --python ${{ matrix.python-version }}+          uv sync --all-extras --python ${{ matrix.python-version }}+          uv pip uninstall pydantic+          uv pip install -e ./pydantic-latest++      - name: List installed dependencies+        run: uv pip list++      - name: Run MCP Python SDK tests+        shell: bash+        env:+          # tests/examples/test_stories_smoke.py is gated on this var; it spawns real+          # stdio + uvicorn subprocesses, so we don't run it for third-party tests:+          MCP_EXAMPLES_SMOKE: '0'+        run: uv run --frozen --no-sync pytest -n auto tests/++  test-fastmcp:+    name: Test FastMCP (main branch) on Python ${{ matrix.python-version }}+    if: |+      github.event_name == 'workflow_dispatch' ||+      (github.event_name == 'schedule' && github.repository == 'pydantic/pydantic') ||+      (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'third-party-tests'))++    runs-on: ubuntu-latest+    strategy:+      fail-fast: false+      matrix:+        python-version: ['3.10', '3.13']+    steps:+      - name: Checkout FastMCP+        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0+        with:+          repository: PrefectHQ/fastmcp+          persist-credentials: false++      - name: Checkout Pydantic+        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0+        with:+          path: pydantic-latest+          persist-credentials: false++      - uses: astral-sh/setup-uv@fac544c07dec837d0ccb6301d7b5580bf5edae39 # v8.2.0+        with:+          enable-cache: true+          python-version: ${{ matrix.python-version }}++      - name: Install FastMCP dependencies+        run: |+          uv sync --no-progress+          uv pip uninstall pydantic+          uv pip install -e ./pydantic-latest++      - name: List installed dependencies+        run: uv pip list++      # unit tests only (see https://github.com/PrefectHQ/fastmcp/blob/main/.github/actions/run-pytest/action.yml):+      - name: Run FastMCP tests+        # The workflow-level FORCE_COLOR makes Rich emit ANSI codes in captured output,+        # breaking FastMCP's CLI tests (which assert on plain text/JSON output):+        run: |+          unset FORCE_COLOR+          uv run --frozen --no-sync pytest \+            --inline-snapshot=disable \+            --timeout=5 \+            --durations=50 \+            -m "not integration and not client_process and not subprocess_heavy and not conformance" \+            tests/    create-issue-on-failure:     name: Create an issue if tests failed@@ -897,6 +1006,8 @@ jobs:       - test-redis-om       - test-django-ninja       - test-fastdepends+      - test-mcp-python-sdk+      - test-fastmcp     # Issue report disabled for now due to flakiness:     if: |       always() &&@@ -919,7 +1030,9 @@ jobs:         needs.test-pydantic-xml.result == 'failure' ||         needs.test-redis-om.result == 'failure' ||         needs.test-django-ninja.result == 'failure' ||-        needs.test-fastdepends.result == 'failure'+        needs.test-fastdepends.result == 'failure' ||+        needs.test-mcp-python-sdk.result == 'failure' ||+        needs.test-fastmcp.result == 'failure'       )     permissions:       issues: write