Backtestspydanticrun-20260930-183947#12978

Issue #12978 Merged fix PR #13441 Run 30 Sep 2026 · run-20260930-183947 pydantic/pydantic

mypy [arg-type]-error when passing in type that can be converted to RootModel

Better

Our patch was judged better than the merged fix.

In this judgment, Patch B = our agent, Patch A = the merged fix.

The two patches make the same core fix in `pydantic/mypy.py`. Both register `_RootModelMetaclass` in `get_metaclass_hook`, so the plugin (not `dataclass_transform`) handles `RootModel` classes. Both also skip the 'existing `__init__`' early return when the class is `RootModel` itself, so the plugin-generated `__init__` (untyped unless `init_typed`) replaces the hand-written typed one. This covers direct parametrizations like `RootModel[float]('1.0')` and subclasses. The only code difference is `self._cls.fullname` (A) versus `self._cls.info.fullname` (B), which are equivalent in mypy. Correctness is therefore essentially tied. The difference is in the tests. A covers only the positional form for an alias and a subclass. B also covers the keyword form `root='1.0'`, an inline `RootModel[float]('1.0')`, a nested coercion case (`RootModel[list[int]](['1'])`), and `assert_type` checks that the `.root` type is still inferred as `float`. B also adds a `mypy-plugin-strict.ini` run of `root_models.py`, which checks that `init_typed=True` still reports the arg-type errors, so the fix does not over-loosen strict mode. B's tests are more thorough and guard the setting-dependent behavior better, so B is the better patch.

The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.

Solve

20m 28s

Wall-clock time in the container

Full test suite

No new failures

12,253 passed · 502 skipped · 12,755 total

Contamination audit

Clean

No sign the agent saw the real fix

Patch size

197vs 63 merged

Changed lines, ours vs merged

Initial Checks

  • I confirm that I'm using Pydantic V2

Description

The below example code (named foo.py) passes when running python foo.py as the input "1.0"-string gets converted to float. However, running mypy foo.py (with or without --strict) gives the following error:

foo.py:11: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float"  [arg-type]
Found 1 error in 1 file (checked 1 source file)

I would expect the BaseModel-fields and the RootModel-field to behave the same in this case. That is, if the value can be converted – either via a custom made validator or through the conversion table – then mypy should not raise an error.

Example Code

import pydantic


class Foo(pydantic.BaseModel):
    f: float


RFoo = pydantic.RootModel[float]

f = Foo(f="1.0")
rf = RFoo("1.0")

assert isinstance(f.f, float)
assert isinstance(rf.root, float)
assert f.f == rf.root

Python, Pydantic & OS Version

pydantic version: 2.12.5
        pydantic-core version: 2.41.5
          pydantic-core build: profile=release pgo=false
               python version: 3.11.14 (main, Feb  3 2026, 22:51:56) [Clang 21.1.4 ]
                     platform: Linux-5.15.0-173-generic-x86_64-with-glibc2.35
             related packages: typing_extensions-4.15.0 mypy-1.19.1
                       commit: unknown

The two patches

Our patch+194 −3
pydantic/mypy.pyindex cd28e700..576a9466 100644@@ -88,6 +88,7 @@ CREATE_MODEL_FULLNAME = 'pydantic.main.create_model' BASESETTINGS_FULLNAME = 'pydantic_settings.main.BaseSettings' ROOT_MODEL_FULLNAME = 'pydantic.root_model.RootModel' MODEL_METACLASS_FULLNAME = 'pydantic._internal._model_construction.ModelMetaclass'+ROOT_MODEL_METACLASS_FULLNAME = 'pydantic.root_model._RootModelMetaclass' FIELD_FULLNAME = 'pydantic.fields.Field' DATACLASS_FULLNAME = 'pydantic.dataclasses.dataclass' MODEL_VALIDATOR_FULLNAME = 'pydantic.functional_validators.model_validator'@@ -143,7 +144,7 @@ class PydanticPlugin(Plugin):      def get_metaclass_hook(self, fullname: str) -> Callable[[ClassDefContext], None] | None:         """Update Pydantic `ModelMetaclass` definition."""-        if fullname == MODEL_METACLASS_FULLNAME:+        if fullname in (MODEL_METACLASS_FULLNAME, ROOT_MODEL_METACLASS_FULLNAME):             return self._pydantic_model_metaclass_marker_callback         return None @@ -171,7 +172,7 @@ class PydanticPlugin(Plugin):         transformer.transform()      def _pydantic_model_metaclass_marker_callback(self, ctx: ClassDefContext) -> None:-        """Reset dataclass_transform_spec attribute of ModelMetaclass.+        """Reset dataclass_transform_spec attribute of ModelMetaclass (and of the `RootModel` metaclass).          Let the plugin handle it. This behavior can be disabled         if 'debug_dataclass_transform' is set to True', for testing purposes.@@ -916,7 +917,13 @@ class PydanticModelTransformer:          The added `__init__` will be annotated with types vs. all `Any` depending on the plugin settings.         """-        if '__init__' in self._cls.info.names and not self._cls.info.names['__init__'].plugin_generated:+        if (+            '__init__' in self._cls.info.names+            and not self._cls.info.names['__init__'].plugin_generated+            # The `__init__` defined on `RootModel` itself is overridden, so that direct parametrizations+            # (e.g. `RootModel[float]('1.0')`) respect the plugin settings (e.g. `init_typed`):+            and self._cls.info.fullname != ROOT_MODEL_FULLNAME+        ):             return  # Don't generate an __init__ if one already exists          typed = self.plugin_config.init_typedtests/mypy/modules/root_models.pyindex 804d1d43..5c0cf072 100644@@ -46,3 +46,24 @@ m = Model[str](m1=Maybe(None), m2=Maybe('dog'), m3=Maybe([])) Model(m1=None, m2={}, m3=[])  assert_type(m.m1, Maybe[int])+++# Pydantic may convert the input to the root type during validation, so (unless `init_typed` is set)+# the `root` argument is not type checked, consistently with `BaseModel` fields:+class FloatRoot(RootModel[float]):+    pass+++FloatRoot('1.0')+FloatRoot(root='1.0')++FloatRootAlias = RootModel[float]++FloatRootAlias('1.0')+FloatRootAlias(root='1.0')+RootModel[float]('1.0')+RootModel[list[int]](['1'])++assert_type(FloatRoot('1.0').root, float)+assert_type(FloatRootAlias('1.0').root, float)+assert_type(RootModel[float]('1.0').root, float)tests/mypy/outputs/mypy-default_ini/root_models.pyindex 01cf5bbb..b706e3bb 100644@@ -54,3 +54,33 @@ Model(m1=None, m2={}, m3=[]) # MYPY: error: Argument "m3" to "Model" has incompatible type "list[Never]"; expected "Maybe[Any]"  [arg-type]  assert_type(m.m1, Maybe[int])+++# Pydantic may convert the input to the root type during validation, so (unless `init_typed` is set)+# the `root` argument is not type checked, consistently with `BaseModel` fields:+class FloatRoot(RootModel[float]):+    pass+++FloatRoot('1.0')+# MYPY: error: Argument 1 to "FloatRoot" has incompatible type "str"; expected "float"  [arg-type]+FloatRoot(root='1.0')+# MYPY: error: Argument "root" to "FloatRoot" has incompatible type "str"; expected "float"  [arg-type]++FloatRootAlias = RootModel[float]++FloatRootAlias('1.0')+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float"  [arg-type]+FloatRootAlias(root='1.0')+# MYPY: error: Argument "root" to "RootModel" has incompatible type "str"; expected "float"  [arg-type]+RootModel[float]('1.0')+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float"  [arg-type]+RootModel[list[int]](['1'])+# MYPY: error: List item 0 has incompatible type "str"; expected "int"  [list-item]++assert_type(FloatRoot('1.0').root, float)+# MYPY: error: Argument 1 to "FloatRoot" has incompatible type "str"; expected "float"  [arg-type]+assert_type(FloatRootAlias('1.0').root, float)+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float"  [arg-type]+assert_type(RootModel[float]('1.0').root, float)+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float"  [arg-type]tests/mypy/outputs/mypy-plugin-strict_ini/root_models.pynew file mode 100644index 00000000..07ae82ca@@ -0,0 +1,81 @@+from typing import Generic, TypeVar++from typing_extensions import assert_type++from pydantic import BaseModel, RootModel+++class Pets1(RootModel[list[str]]):+    pass+++pets_construct = Pets1.model_construct(['dog'])++Pets2 = RootModel[list[str]]+++class Pets3(RootModel):+# MYPY: error: Missing type parameters for generic type "RootModel"  [type-arg]+    root: list[str]+++pets1 = Pets1(['dog', 'cat'])+pets2 = Pets2(['dog', 'cat'])+pets3 = Pets3(['dog', 'cat'])+++class Pets4(RootModel[list[str]]):+    pets: list[str]+# MYPY: error: Only `root` is allowed as a field of a `RootModel`  [pydantic-field]+++T = TypeVar('T')+V = TypeVar('V')+++class Maybe(RootModel[T | None]):+    pass+++class Model(BaseModel, Generic[V]):+    m1: Maybe[int]+    m2: Maybe[V]+    m3: Maybe+# MYPY: error: Missing type parameters for generic type "Maybe"  [type-arg]+++Model[str](m1=1, m2='dog', m3=[])+m = Model[str](m1=Maybe(None), m2=Maybe('dog'), m3=Maybe([]))+Model(m1=None, m2={}, m3=[])++assert_type(m.m1, Maybe[int])+++# Pydantic may convert the input to the root type during validation, so (unless `init_typed` is set)+# the `root` argument is not type checked, consistently with `BaseModel` fields:+class FloatRoot(RootModel[float]):+    pass+++FloatRoot('1.0')+# MYPY: error: Argument 1 to "FloatRoot" has incompatible type "str"; expected "float"  [arg-type]+FloatRoot(root='1.0')+# MYPY: error: Argument "root" to "FloatRoot" has incompatible type "str"; expected "float"  [arg-type]++FloatRootAlias = RootModel[float]++FloatRootAlias('1.0')+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float"  [arg-type]+FloatRootAlias(root='1.0')+# MYPY: error: Argument "root" to "RootModel" has incompatible type "str"; expected "float"  [arg-type]+RootModel[float]('1.0')+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float"  [arg-type]+RootModel[list[int]](['1'])+# MYPY: error: List item 0 has incompatible type "str"; expected "int"  [list-item]++assert_type(FloatRoot('1.0').root, float)+# MYPY: error: Argument 1 to "FloatRoot" has incompatible type "str"; expected "float"  [arg-type]+assert_type(FloatRootAlias('1.0').root, float)+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float"  [arg-type]+assert_type(RootModel[float]('1.0').root, float)+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float"  [arg-type]tests/mypy/outputs/mypy-plugin_ini/root_models.pyindex 5bb30a04..64d7835e 100644@@ -49,3 +49,24 @@ m = Model[str](m1=Maybe(None), m2=Maybe('dog'), m3=Maybe([])) Model(m1=None, m2={}, m3=[])  assert_type(m.m1, Maybe[int])+++# Pydantic may convert the input to the root type during validation, so (unless `init_typed` is set)+# the `root` argument is not type checked, consistently with `BaseModel` fields:+class FloatRoot(RootModel[float]):+    pass+++FloatRoot('1.0')+FloatRoot(root='1.0')++FloatRootAlias = RootModel[float]++FloatRootAlias('1.0')+FloatRootAlias(root='1.0')+RootModel[float]('1.0')+RootModel[list[int]](['1'])++assert_type(FloatRoot('1.0').root, float)+assert_type(FloatRootAlias('1.0').root, float)+assert_type(RootModel[float]('1.0').root, float)tests/mypy/outputs/pyproject-default_toml/root_models.pyindex 01cf5bbb..b706e3bb 100644@@ -54,3 +54,33 @@ Model(m1=None, m2={}, m3=[]) # MYPY: error: Argument "m3" to "Model" has incompatible type "list[Never]"; expected "Maybe[Any]"  [arg-type]  assert_type(m.m1, Maybe[int])+++# Pydantic may convert the input to the root type during validation, so (unless `init_typed` is set)+# the `root` argument is not type checked, consistently with `BaseModel` fields:+class FloatRoot(RootModel[float]):+    pass+++FloatRoot('1.0')+# MYPY: error: Argument 1 to "FloatRoot" has incompatible type "str"; expected "float"  [arg-type]+FloatRoot(root='1.0')+# MYPY: error: Argument "root" to "FloatRoot" has incompatible type "str"; expected "float"  [arg-type]++FloatRootAlias = RootModel[float]++FloatRootAlias('1.0')+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float"  [arg-type]+FloatRootAlias(root='1.0')+# MYPY: error: Argument "root" to "RootModel" has incompatible type "str"; expected "float"  [arg-type]+RootModel[float]('1.0')+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float"  [arg-type]+RootModel[list[int]](['1'])+# MYPY: error: List item 0 has incompatible type "str"; expected "int"  [list-item]++assert_type(FloatRoot('1.0').root, float)+# MYPY: error: Argument 1 to "FloatRoot" has incompatible type "str"; expected "float"  [arg-type]+assert_type(FloatRootAlias('1.0').root, float)+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float"  [arg-type]+assert_type(RootModel[float]('1.0').root, float)+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float"  [arg-type]tests/mypy/test_mypy.pyindex c66f1964..743013ad 100644@@ -107,6 +107,7 @@ cases: list[ParameterSet | tuple[str, str]] = [         ('mypy-plugin.ini', 'plugin_optional_inheritance.py'),         ('mypy-plugin.ini', 'generics.py'),         ('mypy-plugin.ini', 'root_models.py'),+        ('mypy-plugin-strict.ini', 'root_models.py'),         ('mypy-plugin.ini', 'plugin_strict_fields.py'),         ('mypy-plugin.ini', 'final_with_default.py'),         ('mypy-plugin.ini', 'create_model_var.py'), 
Merged fix · PR #13441+61 −2
pydantic/mypy.pyindex cd28e7004..40aee0627 100644@@ -88,6 +88,7 @@ CREATE_MODEL_FULLNAME = 'pydantic.main.create_model' BASESETTINGS_FULLNAME = 'pydantic_settings.main.BaseSettings' ROOT_MODEL_FULLNAME = 'pydantic.root_model.RootModel' MODEL_METACLASS_FULLNAME = 'pydantic._internal._model_construction.ModelMetaclass'+ROOT_MODEL_METACLASS_FULLNAME = 'pydantic.root_model._RootModelMetaclass' FIELD_FULLNAME = 'pydantic.fields.Field' DATACLASS_FULLNAME = 'pydantic.dataclasses.dataclass' MODEL_VALIDATOR_FULLNAME = 'pydantic.functional_validators.model_validator'@@ -143,7 +144,7 @@ class PydanticPlugin(Plugin):      def get_metaclass_hook(self, fullname: str) -> Callable[[ClassDefContext], None] | None:         """Update Pydantic `ModelMetaclass` definition."""-        if fullname == MODEL_METACLASS_FULLNAME:+        if fullname in (MODEL_METACLASS_FULLNAME, ROOT_MODEL_METACLASS_FULLNAME):             return self._pydantic_model_metaclass_marker_callback         return None @@ -916,7 +917,13 @@ class PydanticModelTransformer:          The added `__init__` will be annotated with types vs. all `Any` depending on the plugin settings.         """-        if '__init__' in self._cls.info.names and not self._cls.info.names['__init__'].plugin_generated:+        if (+            '__init__' in self._cls.info.names+            and not self._cls.info.names['__init__'].plugin_generated+            # `RootModel` declares a typed `__init__` for the benefit of type checkers when the plugin+            # isn't used, but the plugin-generated one should take priority over it:+            and self._cls.fullname != ROOT_MODEL_FULLNAME+        ):             return  # Don't generate an __init__ if one already exists          typed = self.plugin_config.init_typedtests/mypy/modules/root_models.pyindex 804d1d43e..f95bd7fe1 100644@@ -22,6 +22,18 @@ pets1 = Pets1(['dog', 'cat']) pets2 = Pets2(['dog', 'cat']) pets3 = Pets3(['dog', 'cat']) +RFloat = RootModel[float]+++class RFloatSub(RootModel[float]):+    pass+++# When the plugin is used with `init_typed` unset, arbitrary input+# should be accepted as it may be coerced to the `root` type:+rfloat = RFloat('1.0')+rfloat_sub = RFloatSub('1.0')+  class Pets4(RootModel[list[str]]):     pets: list[str]tests/mypy/outputs/mypy-default_ini/root_models.pyindex 01cf5bbb3..df3354187 100644@@ -23,6 +23,20 @@ pets1 = Pets1(['dog', 'cat']) pets2 = Pets2(['dog', 'cat']) pets3 = Pets3(['dog', 'cat']) +RFloat = RootModel[float]+++class RFloatSub(RootModel[float]):+    pass+++# When the plugin is used with `init_typed` unset, arbitrary input+# should be accepted as it may be coerced to the `root` type:+rfloat = RFloat('1.0')+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float"  [arg-type]+rfloat_sub = RFloatSub('1.0')+# MYPY: error: Argument 1 to "RFloatSub" has incompatible type "str"; expected "float"  [arg-type]+  class Pets4(RootModel[list[str]]):     pets: list[str]tests/mypy/outputs/mypy-plugin_ini/root_models.pyindex 5bb30a044..12b4c84bd 100644@@ -23,6 +23,18 @@ pets1 = Pets1(['dog', 'cat']) pets2 = Pets2(['dog', 'cat']) pets3 = Pets3(['dog', 'cat']) +RFloat = RootModel[float]+++class RFloatSub(RootModel[float]):+    pass+++# When the plugin is used with `init_typed` unset, arbitrary input+# should be accepted as it may be coerced to the `root` type:+rfloat = RFloat('1.0')+rfloat_sub = RFloatSub('1.0')+  class Pets4(RootModel[list[str]]):     pets: list[str]tests/mypy/outputs/pyproject-default_toml/root_models.pyindex 01cf5bbb3..df3354187 100644@@ -23,6 +23,20 @@ pets1 = Pets1(['dog', 'cat']) pets2 = Pets2(['dog', 'cat']) pets3 = Pets3(['dog', 'cat']) +RFloat = RootModel[float]+++class RFloatSub(RootModel[float]):+    pass+++# When the plugin is used with `init_typed` unset, arbitrary input+# should be accepted as it may be coerced to the `root` type:+rfloat = RFloat('1.0')+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float"  [arg-type]+rfloat_sub = RFloatSub('1.0')+# MYPY: error: Argument 1 to "RFloatSub" has incompatible type "str"; expected "float"  [arg-type]+  class Pets4(RootModel[list[str]]):     pets: list[str]