Backtestspydanticrun-20260930-183947#13376
PrivateAttr(default_factory=...): takes_validated_data_argument re-runs inspect.signature on every instantiation (uncached) → CPU + cyclic-GC memory churn
Our patch was judged better than the merged fix.
In this judgment, Patch A = our agent, Patch B = the merged fix.
Both patches stop the per-instantiation `inspect.signature` call for `PrivateAttr(default_factory=...)`. They do this by caching the result on `ModelPrivateAttr` and passing the precomputed flag into `resolve_default_value`, so both address the root cause the issue names. Patch A is the more careful fix. **Correctness** - Patch A keys its cache on the identity of the factory, so reassigning `default_factory` invalidates the cache. Patch B caches forever once computed, so a reassigned factory would use a stale flag. - Patch A applies the same caching to `FieldInfo` and uses it in `wrap_default`. It also only computes the flag when `call_default_factory` is true, which keeps the old lazy behaviour. - Patch B's `FieldInfo.get_default` now always evaluates the uncached `FieldInfo.default_factory_takes_validated_data`, even when `call_default_factory=False`. That adds signature inspection on paths that previously skipped it, which is a small performance regression. - Patch B also makes `resolve_default_value` require keyword-only arguments, forcing churn in existing tests. - Patch A reads the cache with `getattr(..., None)`, so it stays safe if an instance was created without `__init__` running. **Tests** - Patch A adds regression tests that count calls to `takes_validated_data_argument` and assert 0 calls after warm-up. It does this for both the `PrivateAttr` path and `model_construct`. These tests would fail before the change and pass after. - Patch A also tests reassigning the factory and the repr. - Patch B adds no test verifying the fix. It only adds repr tests and rewrites existing `resolve_default_value` tests to the new signature. **Scope and craft** - Both add `__repr_args__` to hide the new slot from the repr. - Patch B includes an unrelated docstring edit. - Overall, Patch A is more robust, better tested, and consistent between `FieldInfo` and `ModelPrivateAttr`.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
8m 14s
Wall-clock time in the container
Full test suite
No new failures
12,253 passed · 500 skipped · 12,753 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
116vs 83 merged
Changed lines, ours vs merged
The issue
View on GitHubInitial Checks
- I confirm that I'm using Pydantic V2
Description
For a private attribute with a default_factory, every model instantiation re-derives whether the factory takes the validated data by calling takes_validated_data_argument(default_factory=...), which runs inspect.signature() on the factory (pydantic/_internal/_fields.py:694) — not cached, even though it's a pure function of the factory object. It runs twice per instantiation, from two separate sites in init_private_attributes() (pydantic/_internal/_model_construction.py:377): once via the ModelPrivateAttr.default_factory_takes_validated_data property, and once via get_default() → resolve_default_value() (_fields.py:718). Both are uncached.
Regular Field(default_factory=...) is not affected — it computes this once at schema-build time via FieldInfo.default_factory_takes_validated_data and bakes it into the core validator. Only the PrivateAttr path recomputes per instance.
For a factory whose inspect.signature() succeeds via CPython's inspect._signature_fromstr (list, tuple, set, threading.Lock, …), that call does sys.modules.copy() and builds closures that capture the copy — reference cycles the plain refcounter can't free, only the cyclic GC can. Instantiating such a model at a high rate in a long-running process accumulates this garbage faster than the collector reclaims it (and pymalloc keeps the freed arenas), so RSS climbs steadily.
Concretely: Sculptor has a BaseModel with _wait_lock: Lock = PrivateAttr(default_factory=Lock) that is instantiated constantly. It was harmless on Python ≤3.12 — there inspect.signature(Lock) raises ValueError: no signature found, so pydantic falls back cheaply — but began leaking multi-GB of RSS on 3.13+, because CPython 3.13 gave threading.Lock an inferrable signature and flipped every instantiation onto the _signature_fromstr path. We mitigated it by memoizing this check: imbue-ai/sculptor#205.
With default_factory=list it reproduces on every CPython tested (3.12.11, 3.13.5, 3.14.6) and on pydantic 2.13.4 through main (2.14.0a1) — ~52k objects of cycle-only garbage per 1000 instantiations. list/tuple have always had signatures, so the bug isn't tied to a Python version; the set of other builtins that trigger it just grows over time (set, threading.Lock at 3.13).
Example Code
import gc
from pydantic import BaseModel, PrivateAttr
from pydantic._internal import _fields
# (1) It's recomputed on every instantiation, uncached:
calls = 0
_orig = _fields.takes_validated_data_argument
def _counting(*args, **kwargs):
global calls
calls += 1
return _orig(*args, **kwargs)
_fields.takes_validated_data_argument = _counting
class M(BaseModel):
_items: list = PrivateAttr(default_factory=list)
M() # warm
calls = 0
for _ in range(1000):
M()
print("takes_validated_data_argument calls:", calls) # -> 2000
# (2) Each call leaves cycle-only garbage (default_factory=list):
gc.collect(); gc.disable()
before = len(gc.get_objects())
for _ in range(1000):
M()
after = len(gc.get_objects())
freed = gc.collect(); gc.enable()
print("objects grew:", after - before, "| freed only by cyclic gc:", freed)
# -> objects grew: ~54000 | freed only by cyclic gc: ~52000
Suggested fix
The simplest fix is to memoize takes_validated_data_argument (a pure function of the factory, e.g. functools.cache) — after the first call per factory, both per-instance calls become cache hits.
Alternatively, do what regular fields do and compute the flag once at class-construction time, storing it so both sites can read it. Note this is more than "reuse the property": ModelPrivateAttr.default_factory_takes_validated_data (pydantic/fields.py:1451) is itself an uncached @property that re-runs inspect.signature on every access — it's one of the two per-instance calls, so it has to be precomputed too, not just read from resolve_default_value.
Happy to open a PR if you'd like.
Python, Pydantic & OS Version
pydantic version: 2.13.4
pydantic-core version: 2.46.4
pydantic-core build: profile=release pgo=false
python version: 3.14.6 (main, Jun 11 2026, 03:55:33) [Clang 22.1.3 ]
platform: macOS-26.5.1-arm64-arm-64bit-Mach-O
related packages: typing_extensions-4.15.0 fastapi-0.137.2 pydantic-settings-2.14.2
commit: unknown
Also reproduced on main (pydantic 2.14.0a1 / pydantic-core 2.47.0) and on CPython 3.12.11 / 3.13.5.
Repro verified by hand by the maintainer of the affected service.
(prepared & edited with heavy use of Claude)
The two patches
pydantic/_internal/_fields.pyindex 9c2483fc..20a191b8 100644@@ -716,16 +716,23 @@ def resolve_default_value( default: Any, default_factory: Callable[[], Any] | Callable[[dict[str, Any]], Any] | None, *,+ default_factory_takes_data: bool | None = None, validated_data: dict[str, Any] | None = None, call_default_factory: bool = False, ) -> Any:- """Resolve the default value using either a static default or a default_factory."""+ """Resolve the default value using either a static default or a default_factory.++ If already known, `default_factory_takes_data` can be provided to avoid inspecting the signature+ of `default_factory` (see `takes_validated_data_argument()`).+ """ from ._utils import smart_deepcopy if default_factory is None: return smart_deepcopy(default) if call_default_factory:- if takes_validated_data_argument(default_factory=default_factory):+ if default_factory_takes_data is None:+ default_factory_takes_data = takes_validated_data_argument(default_factory=default_factory)+ if default_factory_takes_data: fac = cast('Callable[[dict[str, Any]], Any]', default_factory) if validated_data is None: raise ValueError(pydantic/_internal/_generate_schema.pyindex 003920f8..2d231c65 100644@@ -105,7 +105,6 @@ from ._fields import ( collect_dataclass_fields, rebuild_dataclass_fields, rebuild_model_fields,- takes_validated_data_argument, update_field_from_config, ) from ._forward_ref import PydanticRecursiveRef@@ -2651,7 +2650,7 @@ def wrap_default(field_info: FieldInfo, schema: core_schema.CoreSchema) -> core_ return core_schema.with_default_schema( schema, default_factory=field_info.default_factory,- default_factory_takes_data=takes_validated_data_argument(field_info.default_factory),+ default_factory_takes_data=field_info.default_factory_takes_validated_data, validate_default=field_info.validate_default, ) elif field_info.default is not PydanticUndefined:pydantic/fields.pyindex cd74d792..e2a7a3b0 100644@@ -204,6 +204,7 @@ class FieldInfo(_repr.Representation): '_original_assignment', '_original_annotation', '_final',+ '_default_factory_takes_data_cache', ) # used to convert kwargs to metadata/constraints,@@ -248,6 +249,7 @@ class FieldInfo(_repr.Representation): self.default = default self.default_factory = kwargs.pop('default_factory', None)+ self._default_factory_takes_data_cache: tuple[Callable[..., Any], bool] | None = None if self.default is not PydanticUndefined and self.default_factory is not None: raise TypeError('cannot specify both default and default_factory')@@ -712,8 +714,15 @@ class FieldInfo(_repr.Representation): Returns `None` if no default factory is set. """- if self.default_factory is not None:- return _fields.takes_validated_data_argument(self.default_factory)+ default_factory = self.default_factory+ if default_factory is None:+ return None+ # Inspecting the signature is costly, so cache the result (invalidated if `default_factory` is reassigned):+ cache = getattr(self, '_default_factory_takes_data_cache', None)+ if cache is None or cache[0] is not default_factory:+ cache = (default_factory, _fields.takes_validated_data_argument(default_factory))+ self._default_factory_takes_data_cache = cache+ return cache[1] @overload def get_default(@@ -740,6 +749,7 @@ class FieldInfo(_repr.Representation): return _fields.resolve_default_value( default=self.default, default_factory=self.default_factory,+ default_factory_takes_data=self.default_factory_takes_validated_data if call_default_factory else None, validated_data=validated_data, call_default_factory=call_default_factory, )@@ -848,6 +858,7 @@ class FieldInfo(_repr.Representation): '_original_assignment', '_original_annotation', '_final',+ '_default_factory_takes_data_cache', ): continue elif s == 'metadata' and not self.metadata:@@ -1413,7 +1424,7 @@ class ModelPrivateAttr(_repr.Representation): [`__dict__`][object.__dict__]) and the already initialized private attributes. """ - __slots__ = ('default', 'default_factory')+ __slots__ = ('default', 'default_factory', '_default_factory_takes_data_cache') def __init__( self,@@ -1426,6 +1437,7 @@ class ModelPrivateAttr(_repr.Representation): else: self.default = default self.default_factory = default_factory+ self._default_factory_takes_data_cache: tuple[Callable[..., Any], bool] | None = None if not TYPE_CHECKING: # We put `__getattr__` in a non-TYPE_CHECKING block because otherwise, mypy allows arbitrary attribute access@@ -1454,8 +1466,15 @@ class ModelPrivateAttr(_repr.Representation): Returns `None` if no default factory is set. """- if self.default_factory is not None:- return _fields.takes_validated_data_argument(self.default_factory)+ default_factory = self.default_factory+ if default_factory is None:+ return None+ # Inspecting the signature is costly, so cache the result (invalidated if `default_factory` is reassigned):+ cache = getattr(self, '_default_factory_takes_data_cache', None)+ if cache is None or cache[0] is not default_factory:+ cache = (default_factory, _fields.takes_validated_data_argument(default_factory))+ self._default_factory_takes_data_cache = cache+ return cache[1] @overload def get_default(@@ -1482,10 +1501,17 @@ class ModelPrivateAttr(_repr.Representation): return _fields.resolve_default_value( default=self.default, default_factory=self.default_factory,+ default_factory_takes_data=self.default_factory_takes_validated_data if call_default_factory else None, validated_data=validated_data, call_default_factory=call_default_factory, ) + def __repr_args__(self) -> ReprArgs:+ for attr_name in ('default', 'default_factory'):+ value = getattr(self, attr_name)+ if value is not None:+ yield attr_name, value+ def __eq__(self, other: Any) -> bool: return isinstance(other, self.__class__) and (self.default, self.default_factory) == ( other.default,tests/test_construction.pyindex 1f42457e..1182c8c7 100644@@ -5,6 +5,7 @@ import pytest from pydantic_core import PydanticUndefined, ValidationError from pydantic import AliasChoices, AliasPath, BaseModel, ConfigDict, Field, PrivateAttr, PydanticDeprecatedSince20+from pydantic._internal import _fields class Model(BaseModel):@@ -560,6 +561,31 @@ def test_construct_default_factory(): assert m.bar == 'Baz' +@pytest.mark.thread_unsafe(reason='Monkeypatching module attributes is thread unsafe')+def test_construct_default_factory_signature_not_inspected_on_each_call(monkeypatch):+ calls = 0+ orig = _fields.takes_validated_data_argument++ def counting(*args, **kwargs):+ nonlocal calls+ calls += 1+ return orig(*args, **kwargs)++ monkeypatch.setattr(_fields, 'takes_validated_data_argument', counting)++ class Model(BaseModel):+ foo: list[int] = Field(default_factory=list)+ bar: int = Field(default_factory=lambda data: len(data['foo']) + 1)++ Model.model_construct()+ calls = 0+ for _ in range(10):+ m = Model.model_construct()+ assert calls == 0+ assert m.foo == []+ assert m.bar == 1++ @pytest.mark.thread_unsafe(reason='`pytest.warns()` is thread unsafe') def test_copy_with_excluded_fields(): class User(BaseModel):tests/test_private_attributes.pyindex cefe4c6d..020cfdd9 100644@@ -6,6 +6,7 @@ import pytest from pydantic_core import PydanticUndefined from pydantic import BaseModel, ConfigDict, PrivateAttr, computed_field+from pydantic._internal import _fields from pydantic.fields import ModelPrivateAttr @@ -632,3 +633,42 @@ def test_private_attribute_not_skipped_during_ns_inspection() -> None: _priv: object = Fullname assert isinstance(Full._priv, ModelPrivateAttr)+++@pytest.mark.thread_unsafe(reason='Monkeypatching module attributes is thread unsafe')+def test_private_attr_default_factory_signature_not_inspected_on_each_instantiation(monkeypatch) -> None:+ calls = 0+ orig = _fields.takes_validated_data_argument++ def counting(*args, **kwargs):+ nonlocal calls+ calls += 1+ return orig(*args, **kwargs)++ monkeypatch.setattr(_fields, 'takes_validated_data_argument', counting)++ class Model(BaseModel):+ _items: list = PrivateAttr(default_factory=list)+ _from_data: int = PrivateAttr(default_factory=lambda data: len(data['_items']) + 1)++ Model()+ calls = 0+ for _ in range(10):+ m = Model()+ assert calls == 0+ assert m._items == []+ assert m._from_data == 1+ assert m._items is not Model()._items+++def test_private_attr_default_factory_reassigned() -> None:+ class Model(BaseModel):+ _attr: int = PrivateAttr(default_factory=lambda: 1)++ assert Model()._attr == 1++ private_attr = Model.__private_attributes__['_attr']+ private_attr.default_factory = lambda data: 2+ assert private_attr.default_factory_takes_validated_data is True+ assert Model()._attr == 2+ assert repr(private_attr).startswith('ModelPrivateAttr(default=PydanticUndefined, default_factory=<function')
pydantic/_internal/_fields.pyindex 9c2483fce..59c7f8d79 100644@@ -713,9 +713,10 @@ def takes_validated_data_argument( def resolve_default_value(+ *, default: Any, default_factory: Callable[[], Any] | Callable[[dict[str, Any]], Any] | None,- *,+ default_factory_takes_validated_data_argument: bool | None, validated_data: dict[str, Any] | None = None, call_default_factory: bool = False, ) -> Any:@@ -725,7 +726,7 @@ def resolve_default_value( if default_factory is None: return smart_deepcopy(default) if call_default_factory:- if takes_validated_data_argument(default_factory=default_factory):+ if default_factory_takes_validated_data_argument: fac = cast('Callable[[dict[str, Any]], Any]', default_factory) if validated_data is None: raise ValueError(pydantic/fields.pyindex cd74d7926..b54e5d052 100644@@ -740,6 +740,7 @@ class FieldInfo(_repr.Representation): return _fields.resolve_default_value( default=self.default, default_factory=self.default_factory,+ default_factory_takes_validated_data_argument=self.default_factory_takes_validated_data, validated_data=validated_data, call_default_factory=call_default_factory, )@@ -1404,7 +1405,7 @@ class ModelPrivateAttr(_repr.Representation): !!! warning You generally shouldn't be creating `ModelPrivateAttr` instances directly, instead use- `pydantic.fields.PrivateAttr`. (This is similar to `FieldInfo` vs. `Field`.)+ the [`PrivateAttr()`][pydantic.fields.PrivateAttr] function. Attributes: default: The default value of the attribute if not provided.@@ -1413,7 +1414,7 @@ class ModelPrivateAttr(_repr.Representation): [`__dict__`][object.__dict__]) and the already initialized private attributes. """ - __slots__ = ('default', 'default_factory')+ __slots__ = ('default', 'default_factory', '_default_factory_takes_validated_data') def __init__( self,@@ -1426,6 +1427,7 @@ class ModelPrivateAttr(_repr.Representation): else: self.default = default self.default_factory = default_factory+ self._default_factory_takes_validated_data: bool | None = _Unset if not TYPE_CHECKING: # We put `__getattr__` in a non-TYPE_CHECKING block because otherwise, mypy allows arbitrary attribute access@@ -1454,8 +1456,15 @@ class ModelPrivateAttr(_repr.Representation): Returns `None` if no default factory is set. """+ if self._default_factory_takes_validated_data is not _Unset:+ return self._default_factory_takes_validated_data++ value: bool | None = None if self.default_factory is not None:- return _fields.takes_validated_data_argument(self.default_factory)+ value = _fields.takes_validated_data_argument(self.default_factory)++ self._default_factory_takes_validated_data = value+ return value @overload def get_default(@@ -1482,6 +1491,7 @@ class ModelPrivateAttr(_repr.Representation): return _fields.resolve_default_value( default=self.default, default_factory=self.default_factory,+ default_factory_takes_validated_data_argument=self.default_factory_takes_validated_data, validated_data=validated_data, call_default_factory=call_default_factory, )@@ -1492,6 +1502,12 @@ class ModelPrivateAttr(_repr.Representation): other.default_factory, ) + def __repr_args__(self) -> ReprArgs:+ if self.default is not PydanticUndefined:+ yield 'default', self.default+ if self.default_factory is not None:+ yield 'default_factory', self.default_factory+ # NOTE: Actual return type is 'ModelPrivateAttr', but we want to help type checkers # to understand the magic that happens at runtime.tests/test_fields.pyindex 104a0f700..372584d7a 100644@@ -12,6 +12,7 @@ from pydantic import ( BaseModel, ConfigDict, Field,+ PrivateAttr, PydanticUserError, RootModel, TypeAdapter,@@ -20,7 +21,7 @@ from pydantic import ( create_model, validate_call, )-from pydantic.fields import FieldInfo+from pydantic.fields import FieldInfo, ModelPrivateAttr from pydantic.warnings import UnsupportedFieldAttributeWarning @@ -459,3 +460,15 @@ def test_default_factory_without_validated_data_unsupported() -> None: with pytest.raises(ValueError): FooBar.model_fields['a'].get_default(call_default_factory=True)+++@pytest.mark.parametrize(+ ['private_attr', 'result'],+ [+ (PrivateAttr(), 'ModelPrivateAttr()'),+ (PrivateAttr(default=1), 'ModelPrivateAttr(default=1)'),+ (PrivateAttr(default_factory=int), "ModelPrivateAttr(default_factory=<class 'int'>)"),+ ],+)+def test_privateattr_repr(private_attr: ModelPrivateAttr, result: str) -> None:+ assert repr(private_attr) == resulttests/test_internal.pyindex b94c05b42..acd0b46e7 100644@@ -244,19 +244,34 @@ def test_pydantic_js_functions(): @pytest.mark.parametrize(- 'default, default_factory, validated_data, call_default_factory, expected', [- ('foo', None, None, True, 'foo'),- ('foo', None, None, False, 'foo'),- ('foo-unused', lambda: 'foo', None, False, PydanticUndefined),- ('foo-unused', lambda: 'foo', None, True, 'foo'),- ('foo-unused', lambda data: data['foo'], {'foo': 'bar'}, True, 'bar'),+ 'default',+ 'default_factory',+ 'default_factory_takes_validated_data_argument',+ 'validated_data',+ 'call_default_factory',+ 'expected',+ ],+ [+ ('foo', None, False, None, True, 'foo'),+ ('foo', None, False, None, False, 'foo'),+ ('foo-unused', lambda: 'foo', False, None, False, PydanticUndefined),+ ('foo-unused', lambda: 'foo', False, None, True, 'foo'),+ ('foo-unused', lambda data: data['foo'], True, {'foo': 'bar'}, True, 'bar'), ], )-def test_resolve_default_value(default, default_factory, validated_data, call_default_factory, expected):+def test_resolve_default_value(+ default,+ default_factory,+ default_factory_takes_validated_data_argument,+ validated_data,+ call_default_factory,+ expected,+): result = resolve_default_value(- default,- default_factory,+ default=default,+ default_factory=default_factory,+ default_factory_takes_validated_data_argument=default_factory_takes_validated_data_argument, validated_data=validated_data, call_default_factory=call_default_factory, )@@ -266,4 +281,10 @@ def test_resolve_default_value(default, default_factory, validated_data, call_de def test_resolve_default_value_missing_validated_data(): # When factory requires validated_data but none is provided, a ValueError should be raised. with pytest.raises(ValueError):- resolve_default_value('foo', lambda data: data['foo'], validated_data=None, call_default_factory=True)+ resolve_default_value(+ default='foo',+ default_factory=lambda data: data['foo'],+ default_factory_takes_validated_data_argument=True,+ validated_data=None,+ call_default_factory=True,+ )