Backtestspydanticrun-20261002-175417#13422

Issue #13422 Merged fix PR #13437 Run 2 Oct 2026 · run-20261002-175417 pydantic/pydantic

to_json: timedelta_mode and temporal_mode break documented behavior

Better

Our patch was judged better than the merged fix.

In this judgment, Patch B = our agent, Patch A = the merged fix.

Patch B fixes the root cause. It adds a separate `timedelta_mode` field to `SerializationConfig`. Inferred `timedelta` serialization (python, JSON and JSON-key paths) uses that field, so `timedelta_mode` no longer affects `datetime`/`date`/`time`. With this change, `to_json(..., timedelta_mode='float', temporal_mode='iso8601')` produces ISO datetimes and a float timedelta, which is exactly what the issue expects. The precedence rule is kept: a non-default `temporal_mode`, or an explicitly set `ser_json_temporal`, overrides the legacy timedelta setting for timedeltas only. B also moves the duplicated resolution logic out of `TimeDeltaSerializer` into a shared `timedelta_mode_from_config` helper. Its tests cover `to_json`, `to_jsonable_python`, dict-key serialization and `SchemaSerializer` config. They include the issue's exact scenario, which would fail on the old code. Patch A changes only docstrings and makes no code change, so the reported misbehavior remains. Its new docs also do not describe the actual buggy behavior: they say `temporal_mode` takes precedence, yet with the default `'iso8601'` a `timedelta_mode='float'` still turns datetimes into floats. A neither fixes the bug nor accurately documents it, and it adds no tests.

The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.

Solve

15m 51s

Wall-clock time in the container

Full test suite

No new failures

12,266 passed · 501 skipped · 12,767 total

Contamination audit

Clean

No sign the agent saw the real fix

Patch size

135vs 55 merged

Changed lines, ours vs merged

Initial Checks

  • I confirm that I'm using Pydantic V2

Description

pydantic_core.to_json (and to_jsonable_python) documents timedelta_mode and temporal_mode as independent parameters governing disjoint type sets:

  • timedelta_mode: How to serialize timedelta objects, either 'iso8601' or 'float'.
  • temporal_mode: How to serialize datetime-like objects (datetime, date, time), either 'iso8601', 'seconds', or 'milliseconds'.

(This is what both the API docs and the shipped _pydantic_core.pyi type stub say.)

Given that contract, to_json(..., timedelta_mode="float", temporal_mode="iso8601") should serialize datetime/date/time as ISO 8601 strings and timedelta as a float. Instead, datetime/date/time are also coerced to unix-timestamp floats, timedelta_mode="float" silently overrides temporal_mode="iso8601" for all temporal types.

There is no combination of the two parameters that yields ISO datetimes with float-second timedeltas, even though the documented parameters imply there should be.

Root cause / regression. This regressed in #1743. Before that PR, SerializationConfig had a dedicated timedelta_mode: TimedeltaMode field and to_json had no temporal_mode parameter, so timedelta_mode was genuinely independent. #1743 replaced the dedicated field with a single unified temporal_mode and retrofitted timedelta_mode as a legacy alias that maps into it.

Either the docs/.pyi should be corrected to state that timedelta_mode is a deprecated alias that affects all temporal types, or (preferably) timedelta should retain an independent setting so the documented behavior holds. Personally I have a requirement to be able to set the timedelta format independent of the other datetime types.

Example Code

import datetime
import pydantic_core

payload = {
    "dt": datetime.datetime(2026, 7, 9, 12, 0, 0),
    "d": datetime.date(2026, 7, 9),
    "t": datetime.time(12, 0, 0),
    "td": datetime.timedelta(hours=1, minutes=30),
}

# Per the docs: temporal_mode governs dt/d/t; timedelta_mode governs td.
actual = pydantic_core.to_json(
    payload, timedelta_mode="float", temporal_mode="iso8601"
).decode()

expected = '{"dt":"2026-07-09T12:00:00","d":"2026-07-09","t":"12:00:00","td":5400.0}'

print("actual  :", actual)
print("expected:", expected)
assert actual == expected, "timedelta_mode='float' wrongly coerced datetime/date/time to floats"
# AssertionError: actual == {"dt":1783598400.0,"d":1783555200.0,"t":43200.0,"td":5400.0}

Python, Pydantic & OS Version

pydantic version: 2.13.4
        pydantic-core version: 2.46.4
          pydantic-core build: profile=release pgo=false
               python version: 3.11.14 (main, Oct 10 2025, 12:48:11) [Clang 20.1.4 ]
                     platform: Linux-6.17.0-35-generic-x86_64-with-glibc2.39
             related packages: typing_extensions-4.16.0 mypy-2.2.0 email-validator-2.3.0 pydantic-settings-2.14.2 pydantic-extra-types-2.11.1
                       commit: unknown

The two patches

Our patch+104 −31
pydantic-core/python/pydantic_core/_pydantic_core.pyiindex c13dd4d2..5788f20b 100644@@ -450,6 +450,7 @@ def to_json(         exclude_none: Whether to exclude fields that have a value of `None`.         round_trip: Whether to enable serialization and validation round-trip support.         timedelta_mode: How to serialize `timedelta` objects, either `'iso8601'` or `'float'`.+            Ignored if `temporal_mode` is set to `'seconds'` or `'milliseconds'`.         temporal_mode: How to serialize datetime-like objects (`datetime`, `date`, `time`), either `'iso8601'`, `'seconds'`, or `'milliseconds'`.             `iso8601` returns an ISO 8601 string; `seconds` returns the Unix timestamp in seconds as a float; `milliseconds` returns the Unix timestamp in milliseconds as a float. @@ -535,6 +536,7 @@ def to_jsonable_python(         exclude_none: Whether to exclude fields that have a value of `None`.         round_trip: Whether to enable serialization and validation round-trip support.         timedelta_mode: How to serialize `timedelta` objects, either `'iso8601'` or `'float'`.+            Ignored if `temporal_mode` is set to `'seconds'` or `'milliseconds'`.         temporal_mode: How to serialize datetime-like objects (`datetime`, `date`, `time`), either `'iso8601'`, `'seconds'`, or `'milliseconds'`.             `iso8601` returns an ISO 8601 string; `seconds` returns the Unix timestamp in seconds as a float; `milliseconds` returns the Unix timestamp in milliseconds as a float. pydantic-core/src/serializers/config.rsindex 9a1377c6..b45b766a 100644@@ -21,7 +21,10 @@ use super::errors::py_err_se_err; #[derive(Debug, Clone, Copy)] #[allow(clippy::struct_field_names)] pub(crate) struct SerializationConfig {+    /// How to serialize `datetime`, `date` and `time` objects.     pub temporal_mode: TemporalMode,+    /// How to serialize `timedelta` objects, resolved from both the temporal and the legacy timedelta settings.+    pub timedelta_mode: TemporalMode,     pub bytes_mode: BytesMode,     pub inf_nan_mode: InfNanMode, }@@ -30,6 +33,7 @@ impl Default for SerializationConfig {     fn default() -> Self {         Self {             temporal_mode: TemporalMode::default(),+            timedelta_mode: TemporalMode::default(),             bytes_mode: BytesMode::default(),             inf_nan_mode: InfNanMode::Constants,         }@@ -38,20 +42,11 @@ impl Default for SerializationConfig {  impl SerializationConfig {     pub fn from_config(config: Option<&Bound<'_, PyDict>>) -> PyResult<Self> {-        let temporal_set = config-            .and_then(|cfg| cfg.contains(intern!(cfg.py(), "ser_json_temporal")).ok())-            .unwrap_or(false);-        let temporal_mode = if temporal_set {-            TemporalMode::from_config(config)?-        } else {-            TimedeltaMode::from_config(config)?.into()-        };-        let bytes_mode = BytesMode::from_config(config)?;-        let inf_nan_mode = InfNanMode::from_config(config)?;         Ok(Self {-            temporal_mode,-            bytes_mode,-            inf_nan_mode,+            temporal_mode: TemporalMode::from_config(config)?,+            timedelta_mode: TemporalMode::timedelta_mode_from_config(config)?,+            bytes_mode: BytesMode::from_config(config)?,+            inf_nan_mode: InfNanMode::from_config(config)?,         })     } @@ -61,13 +56,18 @@ impl SerializationConfig {         bytes_mode: &str,         inf_nan_mode: &str,     ) -> PyResult<Self> {-        let resolved_temporal_mode = if temporal_mode != "iso8601" {-            TemporalMode::from_str(temporal_mode)?+        let temporal_mode = TemporalMode::from_str(temporal_mode)?;+        let timedelta_mode = TimedeltaMode::from_str(timedelta_mode)?;+        // A non-default `temporal_mode` takes precedence over the legacy `timedelta_mode` for timedeltas,+        // but `timedelta_mode` never affects how `datetime`, `date` and `time` are serialized.+        let resolved_timedelta_mode = if temporal_mode == TemporalMode::Iso8601 {+            timedelta_mode.into()         } else {-            TimedeltaMode::from_str(timedelta_mode)?.into()+            temporal_mode         };         Ok(Self {-            temporal_mode: resolved_temporal_mode,+            temporal_mode,+            timedelta_mode: resolved_timedelta_mode,             bytes_mode: BytesMode::from_str(bytes_mode)?,             inf_nan_mode: InfNanMode::from_str(inf_nan_mode)?,         })@@ -158,6 +158,19 @@ impl From<TimedeltaMode> for TemporalMode { }  impl TemporalMode {+    /// Resolve the mode used for `timedelta` objects: `ser_json_temporal` takes precedence when set,+    /// otherwise the legacy `ser_json_timedelta` setting is used.+    pub fn timedelta_mode_from_config(config: Option<&Bound<'_, PyDict>>) -> PyResult<Self> {+        let temporal_set = config+            .and_then(|cfg| cfg.contains(intern!(cfg.py(), "ser_json_temporal")).ok())+            .unwrap_or(false);+        if temporal_set {+            Self::from_config(config)+        } else {+            TimedeltaMode::from_config(config).map(Into::into)+        }+    }+     pub fn datetime_to_json(self, py: Python, datetime: &Bound<'_, PyDateTime>) -> PyResult<Py<PyAny>> {         let dt = pydatetime_as_datetime(datetime)?;         match self {pydantic-core/src/serializers/infer.rsindex 141a4d5f..f8aaccf9 100644@@ -164,7 +164,7 @@ pub(crate) fn infer_to_python_known<'py>(             }             ObType::Timedelta => {                 let either_delta = EitherTimedelta::try_from(value)?;-                state.config.temporal_mode.timedelta_to_json(value.py(), either_delta)?+                state.config.timedelta_mode.timedelta_to_json(value.py(), either_delta)?             }             ObType::Url             | ObType::MultiHostUrl@@ -412,7 +412,7 @@ pub(crate) fn infer_serialize_known<'py, S: Serializer>(         }         ObType::Timedelta => {             let either_delta = EitherTimedelta::try_from(value).map_err(py_err_se_err)?;-            state.config.temporal_mode.timedelta_serialize(either_delta, serializer)+            state.config.timedelta_mode.timedelta_serialize(either_delta, serializer)         }         ObType::Url         | ObType::MultiHostUrl@@ -538,7 +538,7 @@ pub(crate) fn infer_json_key_known<'a, 'py>(         }         ObType::Timedelta => {             let either_delta = EitherTimedelta::try_from(key)?;-            state.config.temporal_mode.timedelta_json_key(&either_delta)+            state.config.timedelta_mode.timedelta_json_key(&either_delta)         }         ObType::Url         | ObType::MultiHostUrlpydantic-core/src/serializers/type_serializers/timedelta.rsindex b866bf2e..a15466ed 100644@@ -1,4 +1,3 @@-use pyo3::intern; use pyo3::prelude::*; use pyo3::types::PyDict; use std::borrow::Cow;@@ -7,7 +6,7 @@ use std::sync::Arc; use crate::definitions::DefinitionsBuilder; use crate::input::EitherTimedelta; use crate::serializers::SerializationState;-use crate::serializers::config::{FromConfig, TemporalMode, TimedeltaMode};+use crate::serializers::config::TemporalMode;  use super::{     BuildSerializer, CombinedSerializer, SerMode, TypeSerializer, infer_json_key, infer_serialize, infer_to_python,@@ -26,15 +25,7 @@ impl BuildSerializer for TimeDeltaSerializer {         config: Option<&Bound<'_, PyDict>>,         _definitions: &mut DefinitionsBuilder<Arc<CombinedSerializer>>,     ) -> PyResult<Arc<CombinedSerializer>> {-        let temporal_set = config-            .and_then(|cfg| cfg.contains(intern!(cfg.py(), "ser_json_temporal")).ok())-            .unwrap_or(false);-        let temporal_mode = if temporal_set {-            TemporalMode::from_config(config)?-        } else {-            let td_mode = TimedeltaMode::from_config(config)?;-            td_mode.into()-        };+        let temporal_mode = TemporalMode::timedelta_mode_from_config(config)?;          Ok(Arc::new(Self { temporal_mode }.into()))     }pydantic-core/tests/serializers/test_any.pyindex 3d2ca39f..d0a3fcc0 100644@@ -456,6 +456,73 @@ def test_encoding(any_serializer, gen_input, kwargs, expected_json):         assert any_serializer.to_python(gen_input(), mode='json') == json.loads(expected_json)  +TEMPORAL_PAYLOAD = {+    'dt': datetime(2026, 7, 9, 12, 0, 0),+    'd': date(2026, 7, 9),+    't': time(12, 0, 0),+    'td': timedelta(hours=1, minutes=30),+}+++@pytest.mark.parametrize(+    'kwargs,expected,expected_keys',+    [+        (+            dict(timedelta_mode='float'),+            {'dt': '2026-07-09T12:00:00', 'd': '2026-07-09', 't': '12:00:00', 'td': 5400.0},+            ['2026-07-09T12:00:00', '2026-07-09', '12:00:00', '5400'],+        ),+        (+            dict(timedelta_mode='float', temporal_mode='iso8601'),+            {'dt': '2026-07-09T12:00:00', 'd': '2026-07-09', 't': '12:00:00', 'td': 5400.0},+            ['2026-07-09T12:00:00', '2026-07-09', '12:00:00', '5400'],+        ),+        (+            dict(timedelta_mode='iso8601', temporal_mode='seconds'),+            {'dt': 1783598400.0, 'd': 1783555200.0, 't': 43200.0, 'td': 5400.0},+            ['1783598400', '1783555200', '43200', '5400'],+        ),+        (+            dict(timedelta_mode='float', temporal_mode='milliseconds'),+            {'dt': 1783598400000.0, 'd': 1783555200000.0, 't': 43200000.0, 'td': 5400000.0},+            ['1783598400000', '1783555200000', '43200000', '5400000'],+        ),+    ],+)+def test_timedelta_mode_independent_of_temporal_mode(kwargs, expected, expected_keys):+    """`timedelta_mode` must only affect `timedelta`, never `datetime`, `date` or `time`."""+    assert json.loads(to_json(TEMPORAL_PAYLOAD, **kwargs)) == expected+    assert pydantic_core.to_jsonable_python(TEMPORAL_PAYLOAD, **kwargs) == expected++    # same for temporal values used as dict keys+    keys_payload = {v: k for k, v in TEMPORAL_PAYLOAD.items()}+    assert json.loads(to_json(keys_payload, **kwargs)) == dict(zip(expected_keys, TEMPORAL_PAYLOAD))+++@pytest.mark.parametrize(+    'config,expected',+    [+        (+            {'ser_json_timedelta': 'float'},+            {'dt': '2026-07-09T12:00:00', 'd': '2026-07-09', 't': '12:00:00', 'td': 5400.0},+        ),+        (+            {'ser_json_timedelta': 'float', 'ser_json_temporal': 'iso8601'},+            {'dt': '2026-07-09T12:00:00', 'd': '2026-07-09', 't': '12:00:00', 'td': 'PT1H30M'},+        ),+        (+            {'ser_json_timedelta': 'iso8601', 'ser_json_temporal': 'seconds'},+            {'dt': 1783598400.0, 'd': 1783555200.0, 't': 43200.0, 'td': 5400.0},+        ),+    ],+)+def test_any_serializer_timedelta_config_independent_of_temporal(config, expected):+    """`ser_json_timedelta` must not change how inferred `datetime`, `date` and `time` values are serialized."""+    s = SchemaSerializer(core_schema.any_schema(), config=config)+    assert s.to_python(TEMPORAL_PAYLOAD, mode='json') == expected+    assert json.loads(s.to_json(TEMPORAL_PAYLOAD)) == expected++ def test_any_dataclass():     @dataclasses.dataclass     class Foo: 
Merged fix · PR #13437+49 −6
pydantic-core/python/pydantic_core/_pydantic_core.pyiindex c13dd4d21..12b8e4d49 100644@@ -449,10 +449,31 @@ def to_json(         by_alias: Whether to use the alias names of fields.         exclude_none: Whether to exclude fields that have a value of `None`.         round_trip: Whether to enable serialization and validation round-trip support.-        timedelta_mode: How to serialize `timedelta` objects, either `'iso8601'` or `'float'`.-        temporal_mode: How to serialize datetime-like objects (`datetime`, `date`, `time`), either `'iso8601'`, `'seconds'`, or `'milliseconds'`.-            `iso8601` returns an ISO 8601 string; `seconds` returns the Unix timestamp in seconds as a float; `milliseconds` returns the Unix timestamp in milliseconds as a float.+        timedelta_mode: The format of serialized timedeltas. Accepts the string values of `'iso8601'` and `'float'`. +            - `'iso8601'` will serialize timedeltas to [ISO 8601 text format](https://en.wikipedia.org/wiki/ISO_8601#Durations).+            - `'float'` will serialize timedeltas to the total number of seconds.++            /// version-changed | v2.12+            It is now recommended to use the `temporal_mode` argument. `timedelta_mode` will be deprecated in v3.+            ///+        temporal_mode: The format of serialized temporal types from the [`datetime`][] module. This includes:++            - [`datetime.datetime`][]+            - [`datetime.date`][]+            - [`datetime.time`][]+            - [`datetime.timedelta`][]++            Can be one of:++            - `'iso8601'` will serialize date-like types to [ISO 8601 text format](https://en.wikipedia.org/wiki/ISO_8601#Durations).+            - `'milliseconds'` will serialize date-like types to a floating point number of milliseconds since the epoch.+            - `'seconds'` will serialize date-like types to a floating point number of seconds since the epoch.++            /// version-added | v2.12+            This argument replaces `timedelta_mode`, which will be deprecated in v3. `temporal_mode` adds more+            configurability for the other temporal types. It takes precedence over `timedelta_mode`.+            ///         bytes_mode: How to serialize `bytes` objects, either `'utf8'`, `'base64'`, or `'hex'`.         inf_nan_mode: How to serialize `Infinity`, `-Infinity` and `NaN` values, either `'null'`, `'constants'`, or `'strings'`.         serialize_unknown: Attempt to serialize unknown types, `str(value)` will be used, if that fails@@ -534,10 +555,31 @@ def to_jsonable_python(         by_alias: Whether to use the alias names of fields.         exclude_none: Whether to exclude fields that have a value of `None`.         round_trip: Whether to enable serialization and validation round-trip support.-        timedelta_mode: How to serialize `timedelta` objects, either `'iso8601'` or `'float'`.-        temporal_mode: How to serialize datetime-like objects (`datetime`, `date`, `time`), either `'iso8601'`, `'seconds'`, or `'milliseconds'`.-            `iso8601` returns an ISO 8601 string; `seconds` returns the Unix timestamp in seconds as a float; `milliseconds` returns the Unix timestamp in milliseconds as a float.+        timedelta_mode: The format of serialized timedeltas. Accepts the string values of `'iso8601'` and `'float'`.++            - `'iso8601'` will serialize timedeltas to [ISO 8601 text format](https://en.wikipedia.org/wiki/ISO_8601#Durations).+            - `'float'` will serialize timedeltas to the total number of seconds.++            /// version-changed | v2.12+            It is now recommended to use the `temporal_mode` argument. `timedelta_mode` will be deprecated in v3.+            ///+        temporal_mode: The format of serialized temporal types from the [`datetime`][] module. This includes:++            - [`datetime.datetime`][]+            - [`datetime.date`][]+            - [`datetime.time`][]+            - [`datetime.timedelta`][]++            Can be one of:++            - `'iso8601'` will serialize date-like types to [ISO 8601 text format](https://en.wikipedia.org/wiki/ISO_8601#Durations).+            - `'milliseconds'` will serialize date-like types to a floating point number of milliseconds since the epoch.+            - `'seconds'` will serialize date-like types to a floating point number of seconds since the epoch. +            /// version-added | v2.12+            This argument replaces `timedelta_mode`, which will be deprecated in v3. `temporal_mode` adds more+            configurability for the other temporal types. It takes precedence over `timedelta_mode`.+            ///         bytes_mode: How to serialize `bytes` objects, either `'utf8'`, `'base64'`, or `'hex'`.         inf_nan_mode: How to serialize `Infinity`, `-Infinity` and `NaN` values, either `'null'`, `'constants'`, or `'strings'`.         serialize_unknown: Attempt to serialize unknown types, `str(value)` will be used, if that failspydantic/config.pyindex 5211aae83..e61029bdf 100644@@ -595,6 +595,7 @@ class ConfigDict(TypedDict, total=False):     /// version-added | v2.12     This setting replaces [`ser_json_timedelta`][pydantic.config.ConfigDict.ser_json_timedelta],     which will be deprecated in v3. `ser_json_temporal` adds more configurability for the other temporal types.+    It takes precedence over `ser_json_timedelta`.     ///     """