Backtestspydanticrun-20261002-175417#13465

Issue #13465 Merged fix PR #13483 Run 2 Oct 2026 · run-20261002-175417 pydantic/pydantic

Generic pydantic_extra typevar substitution lost in non-generic subclasses of parametrized models

Error

The harness couldn't finish this ticket.

The solver hit its turn or time cap.. No judgment was produced for this ticket. It counts as an error in the run total.

Solve

1h 41m

Wall-clock time in the container

Full test suite

Not run

The harness did not reach the test stage

Contamination audit

Clean

No sign the agent saw the real fix

Patch size

0vs 56 merged

Changed lines, ours vs merged

Initial Checks

  • I confirm that I'm using Pydantic V2 (main @ 428b0dba8)
  • I have searched GitHub for a duplicate issue and I'm sure this is something new

Description

Follow-up to #13369 / #13391 (__pydantic_extra__ typevar substitution, currently main-only): the substitution works for direct parametrization (M[int]) but is lost in a plain (non-generic) subclass of a parametrized model (class Sub(M[int])). Extras on the subclass are silently unvalidated and the JSON schema loses the extras type.

M[int](x='nope')  -> ValidationError (correct, fixed by #13391)
Sub(x='nope')     -> accepted; m.x == 'nope'          # BUG
Sub(x='5').x      -> '5' (str)  vs  M[int](x='5').x == 5

M[int].model_json_schema()['additionalProperties']  -> {'type': 'integer'}
Sub.model_json_schema()['additionalProperties']     -> {}                  # BUG
Sub.__pydantic_extra_info__                          -> PydanticExtraInfo(annotation=dict[str, ~T], complete=True)

Root cause (from stepping through collect_model_fields in pydantic/_internal/_fields.py): for Sub, typevars_map is empty (its own __pydantic_generic_metadata__ is empty) and the inherited hint for __pydantic_extra__ is the parent's raw annotation dict[str, T] — so _generics.replace_types(ann, typevars_map) is a no-op and the raw ~T survives, producing extras_schema = {'type': 'any'}. Regular fields don't have this problem because they're copied from the parent's already-substituted model_fields; the extra-info path never consults the parent's __pydantic_extra_info__ (which on M[int] correctly holds dict[str, int]).

Note the 2-level generic chain (class Mid(M[T], Generic[T]); Mid[int]) works on main — only the plain-subclass case is broken.

I have a small fix working locally (reuse the parent's substituted PydanticExtraInfo annotation when __pydantic_extra__ is only inherited, mirroring how fields inherit; brings extra-info to exact parity with fields, including the same known deferred-annotation limitation as #12000), with a regression test in the style of test_extra_generic_class — it passes the test_main.py / test_generics.py / test_forward_ref.py / test_edge_cases.py suites with no new failures. Per the contributing guidelines I'd like to be assigned before opening the PR — happy to submit it right away.

Example Code

from typing import Generic, TypeVar
from pydantic import BaseModel, ConfigDict

T = TypeVar('T')

class M(BaseModel, Generic[T]):
    model_config = ConfigDict(extra='allow')
    __pydantic_extra__: dict[str, T]
    y: T

class Sub(M[int]):
    pass

print(Sub(y=1, x='not_an_int').x)  # 'not_an_int' — should raise ValidationError
print(Sub.model_json_schema().get('additionalProperties'))  # {} — should be {'type': 'integer'}

Python, Pydantic & OS Version

pydantic version: 2.14.0a1
pydantic-core version: 2.47.0
python version: 3.14.4
platform: macOS-26.5-arm64
commit: 428b0dba8 (main)

The two patches

Our patch+0 −0
No patch was produced.
Merged fix · PR #13483+48 −8
pydantic/_internal/_fields.pyindex 59c7f8d79..af78e98db 100644@@ -423,14 +423,35 @@ def collect_model_fields(  # noqa: C901      pydantic_extra_info: PydanticExtraInfo | None = None     if '__pydantic_extra__' in type_hints:-        ann, complete = type_hints['__pydantic_extra__']-        if complete:-            # If not complete, `rebuild_model_fields()` takes care of it:-            ann = _generics.replace_types(ann, typevars_map)-        pydantic_extra_info = PydanticExtraInfo(-            annotation=ann,-            complete=complete,-        )+        parent_extra_info: PydanticExtraInfo | None = None+        if '__pydantic_extra__' not in cls_annotations:+            # The annotation is only present on parent classes. As with fields, we make use of the parent's+            # extra info, where type variables are already substituted:+            for base in bases:+                parent_extra_info = getattr(base, '__pydantic_extra_info__', None)+                if parent_extra_info is not None:+                    break++        if parent_extra_info is not None:+            # As with fields, the only case where substituting the type variables is relevant (i.e. when+            # `typevars_map` is not empty) is when a generic class is parameterized:+            if typevars_map and parent_extra_info.complete:+                # If not complete, `rebuild_model_fields()` takes care of it:+                pydantic_extra_info = PydanticExtraInfo(+                    annotation=_generics.replace_types(parent_extra_info.annotation, typevars_map),+                    complete=True,+                )+            else:+                pydantic_extra_info = parent_extra_info+        else:+            ann, complete = type_hints['__pydantic_extra__']+            if complete:+                # If not complete, `rebuild_model_fields()` takes care of it:+                ann = _generics.replace_types(ann, typevars_map)+            pydantic_extra_info = PydanticExtraInfo(+                annotation=ann,+                complete=complete,+            )      return fields, pydantic_extra_info, class_vars tests/test_main.pyindex f924cec99..b6511f5c2 100644@@ -3507,6 +3507,25 @@ def test_extra_generic_class() -> None:     assert Mint(extra_value='1').model_extra == {'extra_value': 1}  +def test_extra_generic_class_subclass() -> None:+    """https://github.com/pydantic/pydantic/issues/13465"""++    T = TypeVar('T')++    class Model(BaseModel, Generic[T], extra='allow'):+        __pydantic_extra__: dict[str, T]++    class Sub(Model[int]):+        pass++    assert Sub.model_json_schema()['additionalProperties'] == {'type': 'integer'}++    with pytest.raises(ValidationError):+        Sub(extra_value='not_an_int')++    assert Sub(extra_value='1').model_extra == {'extra_value': 1}++ def test_super_getattr_extra():     class Model(BaseModel):         model_config = {'extra': 'allow'}