Backtestspydanticrun-20261002-175417#13661
Runtime by_name/by_alias arguments dropped by model_validator(mode="wrap")
Better
Our patch was judged better than the merged fix.
In this judgment, Patch A = our agent, Patch B = the merged fix.
The Rust changes are functionally identical. Both add `by_alias`/`by_name: Option<bool>` to `InternalValidator`, capture them from `extra` in `new`, and forward them in both `validate` and `validate_assignment` instead of hardcoding `None`. This is the root cause: the wrap handler's internal validator was resetting the runtime alias settings. The only difference is field placement in the struct, which doesn't matter. So both are equally correct, and the decision rests on tests and craft. Patch A's tests match the issue more closely. They exercise `TypeAdapter(...).validate_python` (the exact reproduction path) and `validate_json`, in both alias/name directions, plus `model_validate`. A also covers a wrap field validator around a nested model and the generator path (`Iterable[Item]`), which uses the same `InternalValidator`. All of these would fail before the fix. Patch B's first test covers `model_validate` with a wrap model validator and a nested wrap field validator, which also fails before the fix. However, it doesn't exercise `TypeAdapter`, JSON, or the generator path. B's second test checks strict, extra, from_attributes and context through wrap handlers. Those settings were already forwarded, so that test would likely pass before the change. It is regression hardening and earns no credit for this issue. B also leaves a placeholder `"""<link>"""` docstring, a minor craft blemish. Given identical fixes, A's tests verify the reported scenario and the other affected `InternalValidator` path more directly.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
7m 17s
Wall-clock time in the container
Full test suite
No new failures
12,369 passed · 500 skipped · 12,869 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
79vs 89 merged
Changed lines, ours vs merged
The issue
View on GitHubInitial Checks
- I confirm that I'm using Pydantic V2
Description
The handler passed to a wrap-mode model validator appears to silently drop the passed-in by_name/by_alias arguments from the top-level validate_python methods.
Example Code
from typing import Self
from pydantic import BaseModel, TypeAdapter, ValidatorFunctionWrapHandler, model_validator
CFG = {"alias_generator": lambda s: s.replace("_", "-"), "validate_by_name": True}
class Plain(BaseModel):
model_config = CFG
build_depends: list[str] = []
class Wrapped(BaseModel):
model_config = CFG
build_depends: list[str] = []
@model_validator(mode="wrap")
@classmethod
def _noop(cls, data, handler: ValidatorFunctionWrapHandler) -> Self:
return handler(data)
data = {"build_depends": ["x"]} # field name, not the alias
print(TypeAdapter(Plain).validate_python(data, by_alias=True, by_name=False)) # build_depends=[] correct
print(TypeAdapter(Wrapped).validate_python(data, by_alias=True, by_name=False)) # build_depends=['x'] wrong
Python, Pydantic & OS Version
pydantic version: 2.13.4
pydantic-core version: 2.46.4
pydantic-core build: profile=release pgo=false
python version: 3.14.6 (main, Jun 23 2026, 15:18:23) [Clang 22.1.3 ]
platform: Linux-6.18.33.2-microsoft-standard-WSL2-x86_64-with-glibc2.39
related packages: typing_extensions-4.16.0
commit: unknownThe two patches
Our patch+75 −4
pydantic-core/src/validators/generator.rsindex 7529248d..702825c4 100644@@ -234,6 +234,8 @@ pub struct InternalValidator { hide_input_in_errors: bool, validation_error_cause: bool, cache_str: jiter::StringCacheMode,+ by_alias: Option<bool>,+ by_name: Option<bool>, } impl fmt::Debug for InternalValidator {@@ -268,6 +270,8 @@ impl InternalValidator { hide_input_in_errors, validation_error_cause, cache_str: extra.cache_str,+ by_alias: extra.by_alias,+ by_name: extra.by_name, } } @@ -286,8 +290,8 @@ impl InternalValidator { from_attributes: self.from_attributes, context: self.context.as_ref().map(|data| data.bind(py)), cache_str: self.cache_str,- by_alias: None,- by_name: None,+ by_alias: self.by_alias,+ by_name: self.by_name, }; let mut state = ValidationState::new( extra,@@ -329,8 +333,8 @@ impl InternalValidator { from_attributes: self.from_attributes, context: self.context.as_ref().map(|data| data.bind(py)), cache_str: self.cache_str,- by_alias: None,- by_name: None,+ by_alias: self.by_alias,+ by_name: self.by_name, }; let mut state = ValidationState::new( extra,tests/test_aliases.pyindex c26efb28..09830789 100644@@ -1,3 +1,5 @@+import json+from collections.abc import Iterable from contextlib import AbstractContextManager from contextlib import nullcontext as does_not_raise from inspect import signature@@ -15,8 +17,12 @@ from pydantic import ( ConfigDict, Field, PydanticUserError,+ TypeAdapter, ValidationError,+ ValidatorFunctionWrapHandler, computed_field,+ field_validator,+ model_validator, ) @@ -876,6 +882,67 @@ def test_user_error_on_validation_methods() -> None: Model.model_validate_strings("{'my_alias': 1}", by_alias=False, by_name=False) +@pytest.mark.parametrize('method', ['python', 'json'])+def test_runtime_by_alias_by_name_with_wrap_model_validator(method: str) -> None:+ """Runtime `by_alias`/`by_name` must be propagated through the handler of a wrap validator."""++ class Model(BaseModel):+ model_config = ConfigDict(validate_by_name=True)++ my_field: list[str] = Field(default=[], alias='my-alias')++ @model_validator(mode='wrap')+ @classmethod+ def noop(cls, data: Any, handler: ValidatorFunctionWrapHandler) -> Any:+ return handler(data)++ def validate(data: dict[str, Any], **kwargs: Any) -> Model:+ if method == 'python':+ return TypeAdapter(Model).validate_python(data, **kwargs)+ return TypeAdapter(Model).validate_json(json.dumps(data), **kwargs)++ assert validate({'my_field': ['x']}, by_alias=True, by_name=False).my_field == []+ assert validate({'my_field': ['x']}, by_alias=True, by_name=True).my_field == ['x']+ assert validate({'my-alias': ['x']}, by_alias=False, by_name=True).my_field == []+ assert validate({'my-alias': ['x']}, by_alias=True, by_name=False).my_field == ['x']+ assert Model.model_validate({'my_field': ['x']}, by_alias=True, by_name=False).my_field == []+ assert Model.model_validate({'my-alias': ['x']}, by_alias=False, by_name=True).my_field == []+++def test_runtime_by_alias_by_name_with_wrap_field_validator() -> None:+ class Inner(BaseModel):+ model_config = ConfigDict(validate_by_name=True)++ my_field: int = Field(default=0, alias='my-alias')++ class Outer(BaseModel):+ inner: Inner++ @field_validator('inner', mode='wrap')+ @classmethod+ def noop(cls, value: Any, handler: ValidatorFunctionWrapHandler) -> Any:+ return handler(value)++ assert Outer.model_validate({'inner': {'my_field': 1}}, by_alias=True, by_name=False).inner.my_field == 0+ assert Outer.model_validate({'inner': {'my-alias': 1}}, by_alias=False, by_name=True).inner.my_field == 0+ assert Outer.model_validate({'inner': {'my_field': 1}}, by_alias=False, by_name=True).inner.my_field == 1+++def test_runtime_by_alias_by_name_with_generator() -> None:+ class Item(BaseModel):+ model_config = ConfigDict(validate_by_name=True)++ my_field: int = Field(default=0, alias='my-alias')++ ta = TypeAdapter(Iterable[Item])++ items = ta.validate_python([{'my_field': 1}, {'my-alias': 2}], by_alias=True, by_name=False)+ assert [item.my_field for item in items] == [0, 2]++ items = ta.validate_python([{'my_field': 1}, {'my-alias': 2}], by_alias=False, by_name=True)+ assert [item.my_field for item in items] == [1, 0]++ @pytest.mark.parametrize( 'config,runtime,expected', [
Merged fix · PR #13668+85 −4
pydantic-core/src/validators/generator.rsindex 7529248d3..a83527dfe 100644@@ -225,6 +225,8 @@ pub struct InternalValidator { extra_behavior: Option<ExtraBehavior>, from_attributes: Option<bool>, context: Option<Py<PyAny>>,+ by_alias: Option<bool>,+ by_name: Option<bool>, field_name: Option<Py<PyString>>, self_instance: Option<Py<PyAny>>, recursion_guard: RecursionState,@@ -259,6 +261,8 @@ impl InternalValidator { extra_behavior: extra.extra_behavior, from_attributes: extra.from_attributes, context: extra.context.map(|d| d.clone().unbind()),+ by_alias: extra.by_alias,+ by_name: extra.by_name, field_name: state.field_name().map(|d| d.clone().unbind()), self_instance: state.self_instance.map(|d| d.clone().unbind()), recursion_guard: state.recursion_guard.clone(),@@ -286,8 +290,8 @@ impl InternalValidator { from_attributes: self.from_attributes, context: self.context.as_ref().map(|data| data.bind(py)), cache_str: self.cache_str,- by_alias: None,- by_name: None,+ by_alias: self.by_alias,+ by_name: self.by_name, }; let mut state = ValidationState::new( extra,@@ -329,8 +333,8 @@ impl InternalValidator { from_attributes: self.from_attributes, context: self.context.as_ref().map(|data| data.bind(py)), cache_str: self.cache_str,- by_alias: None,- by_name: None,+ by_alias: self.by_alias,+ by_name: self.by_name, }; let mut state = ValidationState::new( extra,tests/test_validators.pyindex 0a5bc5f04..7e9f47137 100644@@ -3177,3 +3177,80 @@ def test_model_validate_json_default_value_validator_with_validation_info() -> N f2 = Foo.model_validate_json('{"field1": 1}', context='context') assert f1.field == f2.field == 2+++def test_wrap_validator_forwards_by_alias_by_name() -> None:+ """https://github.com/pydantic/pydantic/issues/13661"""++ class Inner(BaseModel):+ model_config = ConfigDict(validate_by_name=True)++ build_depends: list[str] = Field(default=[], alias='build-depends')++ @model_validator(mode='wrap')+ @classmethod+ def _wrap(cls, data: Any, handler: ValidatorFunctionWrapHandler) -> Any:+ return handler(data)++ class Outer(BaseModel):+ inner: Inner++ @field_validator('inner', mode='wrap')+ @classmethod+ def _wrap(cls, v: Any, handler: ValidatorFunctionWrapHandler) -> Any:+ return handler(v)++ by_name = {'build_depends': ['x']}+ by_alias = {'build-depends': ['x']}++ assert Inner.model_validate(by_name, by_alias=True, by_name=False).build_depends == []+ assert Inner.model_validate(by_alias, by_alias=True, by_name=False).build_depends == ['x']+ assert Inner.model_validate(by_name, by_alias=False, by_name=True).build_depends == ['x']+ assert Inner.model_validate(by_alias, by_alias=False, by_name=True).build_depends == []++ assert Outer.model_validate({'inner': by_name}, by_alias=True, by_name=False).inner.build_depends == []+ assert Outer.model_validate({'inner': by_alias}, by_alias=False, by_name=True).inner.build_depends == []+++def test_wrap_validator_forwards_runtime_settings() -> None:+ class Inner(BaseModel):+ a: int++ @model_validator(mode='wrap')+ @classmethod+ def _wrap(cls, data: Any, handler: ValidatorFunctionWrapHandler, info: ValidationInfo) -> Any:+ assert info.context == 'ctx'+ return handler(data)++ @field_validator('a', mode='wrap')+ @classmethod+ def _wrap_a(cls, v: Any, handler: ValidatorFunctionWrapHandler, info: ValidationInfo) -> Any:+ assert info.context == 'ctx'+ return handler(v)++ class Outer(BaseModel):+ inner: Inner++ @field_validator('inner', mode='wrap')+ @classmethod+ def _wrap(cls, v: Any, handler: ValidatorFunctionWrapHandler) -> Any:+ return handler(v)++ # strict:+ assert Outer.model_validate({'inner': {'a': '1'}}, context='ctx').inner.a == 1+ with pytest.raises(ValidationError, match='Input should be a valid integer'):+ Outer.model_validate({'inner': {'a': '1'}}, strict=True, context='ctx')++ # extra:+ m = Outer.model_validate({'inner': {'a': 1, 'b': 2}}, extra='allow', context='ctx')+ assert m.inner.model_extra == {'b': 2}+ with pytest.raises(ValidationError, match='Extra inputs are not permitted'):+ Outer.model_validate({'inner': {'a': 1, 'b': 2}}, extra='forbid', context='ctx')++ # from_attributes:+ class InnerObj:+ a = 1++ with pytest.raises(ValidationError, match='Input should be a valid dictionary'):+ Outer.model_validate({'inner': InnerObj()}, context='ctx')+ assert Outer.model_validate({'inner': InnerObj()}, from_attributes=True, context='ctx').inner.a == 1