Backtestspydanticrun-20261003-150343#13802
Three error-reference examples no longer raise the error they document, and the docs test suite cannot detect it
Our patch was judged better than the merged fix.
In this judgment, Patch B = our agent, Patch A = the merged fix.
Both patches make the same three documentation fixes. Each swaps `False` for `'not a complex number'` in the `complex_type` example. Each deletes the `string_sub_type` section. Each replaces `ImportString` with `Callable` in the `invalid-for-json-schema` example, as `Callable[..., object]` in A and as bare `Callable` in B, which works equally well. Neither of those differences matters. The patches differ in what else they change. Patch A also removes the `StringSubType` variant from pydantic-core's Rust error types, from the `ErrorType` Literal, and from core tests. That is a breaking public-API change: users can reference `'string_sub_type'` in `PydanticCustomError` or in error-type handling. The issue explicitly left this as a maintainer decision, so the extra risk counts against A. A also edits `docs/concepts/experimental.md` by changing the partial-JSON input. That change is unrelated to the issue, unexplained, and may alter the documented output. Finally, A adds no test for the blind spot the issue highlights, so a future regression like the `complex` one would again pass CI silently. Patch B keeps the core error variant and excludes it from `test_validation_error_codes` with an explanatory comment, which is a conservative and consistent choice. More importantly, B adds `test_error_docs_examples_raise`. This test rewrites every `try`/`except` in the error-page examples to raise in an `else` branch when no exception occurred, then executes the example. It would fail on all three broken examples before the fix and pass after it, and it directly closes the detection gap the issue asks about. B also extracts `skip_if_python_too_old` cleanly and respects `test="skip"` and `requires` settings. One risk is that some legitimate example contains a `try` that intentionally doesn't raise. The issue's exhaustive audit, in which every other example entered its except branch, makes that unlikely. B wins on tests and scope while matching A on correctness.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
7m 52s
Wall-clock time in the container
Full test suite
No new failures
12,878 passed · 527 skipped · 13,405 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
104vs 39 merged
Changed lines, ours vs merged
The issue
View on GitHubInitial Checks
- I confirm that I'm using Pydantic V2
Description
Three examples on the error-reference pages no longer raise the error they document, and the documentation test suite cannot detect it.
Every example on those pages has the same shape: do something that should fail, catch it, then print or assert the error code. The only assertion lives inside the except branch. When the operation stops failing, that branch never runs, so nothing is printed and no assert is evaluated. run_print_check compares printed output against the #> comments, and an example whose print never ran produces no output to disagree with, so the example exits 0 and CI stays green while the page documents behaviour that no longer exists.
I checked this exhaustively rather than by sampling. I injected a sentinel as the first statement of every except block on both error pages and ran each example. Of the 152 examples containing a try/except at v2.13.5, all 152 run, and exactly 3 never enter their except branch. On main the count is 3 of 157. None of the three is marked test="skip", so all three are executed by CI today.
1. complex_type, docs/errors/validation_errors.md
Model(num=False) now validates successfully to 0j, so the #> 'complex_type' line never prints. This changed in 2.13.0b1 with #12498, which made complex validation call the complex() constructor unconditionally in Python mode, and complex(False) is 0j.
2. string_sub_type, docs/errors/validation_errors.md
The section says a strict str field rejects an instance of a str subclass. It does not: the example returns a plain str with the value 'foo', and #> 'string_sub_type' never prints. pydantic_core 2.49.0 still declares the error ("Input should be a string, not an instance of a subclass of str"), but I could not find any str schema that raises it. Building core_schema.str_schema() directly with strict=True, without strict, and with strict=True plus a pattern all accept a str subclass and return a plain str.
This looks intentional rather than accidental. #6261 reported exactly this behaviour as a bug in June 2023, was labelled bug V2, and was closed with the conversation moved to pydantic-core#786. So the check appears to have been removed on purpose and this documentation section was left behind describing it.
3. invalid-for-json-schema, docs/errors/usage_errors.md
ImportString has had a JSON schema since 2.8.0 via #9344, so Model.model_json_schema() succeeds and returns a plain string schema. The assert exc_info.code == 'invalid-for-json-schema' inside the except block has not executed since that release.
Output of the example code below
Identical on 2.13.5 and on main at 2.14.0b2:
1. no exception; num = 0j
2. no exception; accepted 'foo'
3. no exception; {'properties': {'a': {'title': 'A', 'type': 'string'}}, 'required': ['a'], 'title': 'ImportStringModel', 'type': 'object'}
Suggested fixes
complex_typeis a one-word fix.Model(num='not a complex number')still raisescomplex_type, and so do[],{}and a bareobject(). ReplacingFalsewith any of those restores the example.string_sub_typeneeds a decision rather than a fix, which is the main reason I am opening an issue instead of sending a patch. Given the trail through #6261, the section probably wants deleting rather than repairing, and possibly the error variant too, but that is your call.invalid-for-json-schemaneeds a type that genuinely has no JSON schema, in place ofImportString.
Separately, the blind spot itself is fixable. If an example on these pages had to demonstrate that the error occurred, for instance by printing inside the except and also failing loudly when nothing was raised, then a future change like #12498 would turn the docs red instead of silently making a section untrue. I am happy to send a PR for any or all of this, including that check as a test, if you tell me which direction you prefer.
I used AI assistance to run this audit, in line with your AI policy. I have reproduced and understood each of the three cases myself and can explain any of them.
Example Code
from enum import Enum
from pydantic import (
BaseModel,
Field,
ImportString,
PydanticUserError,
ValidationError,
)
# 1. validation_errors.md, `complex_type`: documented to print 'complex_type'
class ComplexModel(BaseModel):
num: complex
try:
ComplexModel(num=False)
print('1. no exception; num =', ComplexModel(num=False).num)
except ValidationError as exc:
print('1.', repr(exc.errors()[0]['type']))
# 2. validation_errors.md, `string_sub_type`: documented to print 'string_sub_type'
class MyEnum(str, Enum):
foo = 'foo'
class StrictStrModel(BaseModel):
x: str = Field(strict=True)
try:
print('2. no exception; accepted', repr(StrictStrModel(x=MyEnum.foo).x))
except ValidationError as exc:
print('2.', repr(exc.errors()[0]['type']))
# 3. usage_errors.md, `invalid-for-json-schema`: the assert is never reached
class ImportStringModel(BaseModel):
a: ImportString
try:
print('3. no exception;', ImportStringModel.model_json_schema())
except PydanticUserError as exc:
print('3.', exc.code)
Python, Pydantic & OS Version
pydantic version: 2.13.5
pydantic-core version: 2.46.5
python version: 3.12.10 (CPython)
platform: Windows 11
also reproduced against main at pydantic 2.14.0b2 / pydantic-core 2.49.0The two patches
docs/errors/usage_errors.mdindex 7e28e9f8..48403726 100644@@ -620,11 +620,13 @@ type C = B This error is raised when Pydantic fails to generate a JSON schema for some `CoreSchema`. ```python-from pydantic import BaseModel, ImportString, PydanticUserError+from collections.abc import Callable++from pydantic import BaseModel, PydanticUserError class Model(BaseModel):- a: ImportString+ a: Callable try:docs/errors/validation_errors.mdindex 71d3a929..95e240e7 100644@@ -233,7 +233,7 @@ class Model(BaseModel): try:- Model(num=False)+ Model(num='not a complex number') except ValidationError as exc: print(repr(exc.errors()[0]['type'])) #> 'complex_type'@@ -1845,31 +1845,6 @@ except ValidationError as exc: #> 'string_pattern_mismatch' ``` -## `string_sub_type`--This error is raised when the value is an instance of a strict subtype of `str` when the field is strict:--```python-from enum import Enum--from pydantic import BaseModel, Field, ValidationError---class MyEnum(str, Enum):- foo = 'foo'---class Model(BaseModel):- x: str = Field(strict=True)---try:- Model(x=MyEnum.foo)-except ValidationError as exc:- print(repr(exc.errors()[0]['type']))- #> 'string_sub_type'-```- ## `string_too_long` This error is raised when the input value is a string whose length is greater than the field's `max_length` constraint:tests/test_docs.pyindex 7c185657..929be19b 100644@@ -1,8 +1,12 @@ from __future__ import annotations as _annotations +import ast+import contextlib+import io import os import platform import re+import runpy import subprocess import sys from datetime import datetime@@ -83,6 +87,14 @@ def print_callback(print_statement: str) -> str: return re.sub(r'(https://errors.pydantic.dev)/.+?/', r'\1/2/', print_statement) +def skip_if_python_too_old(prefix_settings: dict[str, str]) -> None:+ requires_settings = prefix_settings.get('requires')+ if requires_settings:+ major, minor = map(int, requires_settings.split('.'))+ if sys.version_info < (major, minor):+ pytest.skip(f'requires python {requires_settings}')++ def run_example(example: CodeExample, eval_example: EvalExample, mocker: Any) -> None: # noqa C901 eval_example.print_callback = print_callback @@ -92,11 +104,7 @@ def run_example(example: CodeExample, eval_example: EvalExample, mocker: Any) -> if test_settings.startswith('skip') and lint_settings.startswith('skip'): pytest.skip('both running code and lint skipped') - requires_settings = prefix_settings.get('requires')- if requires_settings:- major, minor = map(int, requires_settings.split('.'))- if sys.version_info < (major, minor):- pytest.skip(f'requires python {requires_settings}')+ skip_if_python_too_old(prefix_settings) group_name = prefix_settings.get('group') @@ -265,6 +273,7 @@ def test_validation_error_codes(): expected_validation_error_codes = set(core_schema.ErrorType.__args__) # Remove codes that are not currently accessible from pydantic: expected_validation_error_codes.remove('timezone_offset') # not currently exposed for configuration in pydantic+ expected_validation_error_codes.remove('string_sub_type') # not raised by any `str` validator, see #6261 test_failures = [] @@ -291,3 +300,55 @@ def test_validation_error_codes(): code_validation_error_codes = sorted(expected_validation_error_codes) assert code_validation_error_codes == documented_validation_error_codes, 'Error codes in code and docs do not match'+++class _RequireExceptionTransformer(ast.NodeTransformer):+ """Add an `else` branch to every `try`/`except` that fails if no exception was raised."""++ def visit_Try(self, node: ast.Try) -> ast.Try:+ self.generic_visit(node)+ if node.handlers and not node.orelse:+ node.orelse = [+ ast.Raise(+ exc=ast.Call(+ func=ast.Name(id='AssertionError', ctx=ast.Load()),+ args=[ast.Constant(value=f'try block on line {node.lineno} did not raise')],+ keywords=[],+ ),+ cause=None,+ )+ ]+ return node+++ERROR_DOCS_EXAMPLES = [+ example+ for example in find_examples(+ str(DOCS_ROOT / 'errors/errors.md'),+ str(DOCS_ROOT / 'errors/usage_errors.md'),+ str(DOCS_ROOT / 'errors/validation_errors.md'),+ skip=sys.platform == 'win32',+ )+ if 'try:' in example.source+]+++@pytest.mark.thread_unsafe+@pytest.mark.skipif(bool(skip_reason), reason=skip_reason or 'not skipping')+@pytest.mark.parametrize('example', ERROR_DOCS_EXAMPLES, ids=str)+def test_error_docs_examples_raise(example: CodeExample, tmp_path: Path):+ """Error examples only print or assert inside their `except` branch, so they must actually raise.++ Otherwise `test_docs_examples` passes silently when an example stops demonstrating its error.+ """+ prefix_settings = example.prefix_settings()+ if prefix_settings.get('test', '').startswith('skip'):+ pytest.skip('running code skipped')+ skip_if_python_too_old(prefix_settings)++ tree = _RequireExceptionTransformer().visit(ast.parse(example.source))+ module_path = tmp_path / 'error_example.py'+ module_path.write_text(ast.unparse(ast.fix_missing_locations(tree)))++ with contextlib.redirect_stdout(io.StringIO()):+ runpy.run_path(str(module_path))
docs/concepts/experimental.mdindex cc349f3a0..ab1665260 100644@@ -342,7 +342,7 @@ class MyModel(BaseModel): ta = TypeAdapter(MyModel) try: v = ta.validate_json(- '{"a": 1, "b": ["12345", "12', experimental_allow_partial=True+ '{"a": 1, "b": ["12345", "12"', experimental_allow_partial=True ) except ValidationError as e: print(e)docs/errors/usage_errors.mdindex 7e28e9f82..3e6a67412 100644@@ -620,11 +620,13 @@ type C = B This error is raised when Pydantic fails to generate a JSON schema for some `CoreSchema`. ```python-from pydantic import BaseModel, ImportString, PydanticUserError+from collections.abc import Callable++from pydantic import BaseModel, PydanticUserError class Model(BaseModel):- a: ImportString+ a: Callable[..., object] try:docs/errors/validation_errors.mdindex 71d3a9292..95e240e70 100644@@ -233,7 +233,7 @@ class Model(BaseModel): try:- Model(num=False)+ Model(num='not a complex number') except ValidationError as exc: print(repr(exc.errors()[0]['type'])) #> 'complex_type'@@ -1845,31 +1845,6 @@ except ValidationError as exc: #> 'string_pattern_mismatch' ``` -## `string_sub_type`--This error is raised when the value is an instance of a strict subtype of `str` when the field is strict:--```python-from enum import Enum--from pydantic import BaseModel, Field, ValidationError---class MyEnum(str, Enum):- foo = 'foo'---class Model(BaseModel):- x: str = Field(strict=True)---try:- Model(x=MyEnum.foo)-except ValidationError as exc:- print(repr(exc.errors()[0]['type']))- #> 'string_sub_type'-```- ## `string_too_long` This error is raised when the input value is a string whose length is greater than the field's `max_length` constraint:pydantic-core/python/pydantic_core/core_schema.pyindex b6fce060b..fda0e35ee 100644@@ -4776,7 +4776,6 @@ ErrorType: TypeAlias = Literal[ 'iterable_type', 'iteration_error', 'string_type',- 'string_sub_type', 'string_unicode', 'string_too_short', 'string_too_long',pydantic-core/src/errors/types.rsindex 4bdb92135..f49f48509 100644@@ -247,7 +247,6 @@ error_types! { // --------------------- // string errors StringType {},- StringSubType {}, StringUnicode {}, StringTooShort { min_length: {ctx_type: usize, ctx_fn: field_from_context},@@ -533,7 +532,6 @@ impl ErrorType { Self::IterableType { .. } => "Input should be iterable", Self::IterationError { .. } => "Error iterating over object, error: {error}", Self::StringType { .. } => "Input should be a valid string",- Self::StringSubType { .. } => "Input should be a string, not an instance of a subclass of str", Self::StringUnicode { .. } => { "Input should be a valid string, unable to parse raw data as a unicode string" }pydantic-core/tests/test_errors.pyindex 66f15d81a..b024e618b 100644@@ -303,7 +303,6 @@ all_errors = [ {'field_type': 'Foobar', 'max_length': 42, 'actual_length': 50}, ), ('string_type', 'Input should be a valid string', None),- ('string_sub_type', 'Input should be a string, not an instance of a subclass of str', None), ('string_unicode', 'Input should be a valid string, unable to parse raw data as a unicode string', None), ('string_pattern_mismatch', "String should match pattern 'foo'", {'pattern': 'foo'}), ('string_not_ascii', 'String should contain only ASCII characters', None),