Backtestspydanticrun-20261005-183002#12978
mypy [arg-type]-error when passing in type that can be converted to RootModel
Our patch was judged better than the merged fix.
In this judgment, Patch A = our agent, Patch B = the merged fix.
Both patches make essentially the same core change in `pydantic/mypy.py`. They register `_RootModelMetaclass` with the metaclass hook so the dataclass_transform spec is reset. They also let the plugin generate `__init__` for `RootModel` itself instead of keeping its explicit typed `__init__`. This fixes the root cause: with the plugin and `init_typed` unset, `RootModel[float]('1.0')` is accepted, just as `BaseModel` fields are. The only code difference is `self._cls.info.fullname` (A) versus `self._cls.fullname` (B). Both resolve to the same value, so correctness is equal. A also updates the metaclass-callback docstring to mention the RootModel metaclass, a small craft point.
The real difference is test coverage. B tests only the type-alias and subclass forms, and only in `root_models.py` with and without the plugin. A tests three forms: the alias, direct `RootModel[float]('1.0')` (the issue's form), and a subclass. It adds a `BaseModel` comparison case to show parity. It also adds cases to `plugin_fail.py` that run under the `init_typed=True` (strict) configs. There the expected errors appear for both `BaseModel` and `RootModel`, confirming that RootModel now follows the plugin's `init_typed` setting rather than always being typed. That covers the other half of the behavior change, which B leaves untested. A's 5 'removed' test lines are just the updated import lines. A is the stronger patch because of its broader and more meaningful tests.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
31m 52s
Wall-clock time in the container
Full test suite
No new failures
12,253 passed · 501 skipped · 12,754 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
179vs 63 merged
Changed lines, ours vs merged
The issue
View on GitHubInitial Checks
- I confirm that I'm using Pydantic V2
Description
The below example code (named foo.py) passes when running python foo.py as the input "1.0"-string gets converted to float. However, running mypy foo.py (with or without --strict) gives the following error:
foo.py:11: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float" [arg-type]
Found 1 error in 1 file (checked 1 source file)
I would expect the BaseModel-fields and the RootModel-field to behave the same in this case. That is, if the value can be converted – either via a custom made validator or through the conversion table – then mypy should not raise an error.
Example Code
import pydantic
class Foo(pydantic.BaseModel):
f: float
RFoo = pydantic.RootModel[float]
f = Foo(f="1.0")
rf = RFoo("1.0")
assert isinstance(f.f, float)
assert isinstance(rf.root, float)
assert f.f == rf.root
Python, Pydantic & OS Version
pydantic version: 2.12.5
pydantic-core version: 2.41.5
pydantic-core build: profile=release pgo=false
python version: 3.11.14 (main, Feb 3 2026, 22:51:56) [Clang 21.1.4 ]
platform: Linux-5.15.0-173-generic-x86_64-with-glibc2.35
related packages: typing_extensions-4.15.0 mypy-1.19.1
commit: unknownThe two patches
pydantic/mypy.pyindex cd28e700..d8b85610 100644@@ -88,6 +88,7 @@ CREATE_MODEL_FULLNAME = 'pydantic.main.create_model' BASESETTINGS_FULLNAME = 'pydantic_settings.main.BaseSettings' ROOT_MODEL_FULLNAME = 'pydantic.root_model.RootModel' MODEL_METACLASS_FULLNAME = 'pydantic._internal._model_construction.ModelMetaclass'+ROOT_MODEL_METACLASS_FULLNAME = 'pydantic.root_model._RootModelMetaclass' FIELD_FULLNAME = 'pydantic.fields.Field' DATACLASS_FULLNAME = 'pydantic.dataclasses.dataclass' MODEL_VALIDATOR_FULLNAME = 'pydantic.functional_validators.model_validator'@@ -143,7 +144,7 @@ class PydanticPlugin(Plugin): def get_metaclass_hook(self, fullname: str) -> Callable[[ClassDefContext], None] | None: """Update Pydantic `ModelMetaclass` definition."""- if fullname == MODEL_METACLASS_FULLNAME:+ if fullname in (MODEL_METACLASS_FULLNAME, ROOT_MODEL_METACLASS_FULLNAME): return self._pydantic_model_metaclass_marker_callback return None @@ -171,7 +172,7 @@ class PydanticPlugin(Plugin): transformer.transform() def _pydantic_model_metaclass_marker_callback(self, ctx: ClassDefContext) -> None:- """Reset dataclass_transform_spec attribute of ModelMetaclass.+ """Reset dataclass_transform_spec attribute of ModelMetaclass (and of the `RootModel` metaclass). Let the plugin handle it. This behavior can be disabled if 'debug_dataclass_transform' is set to True', for testing purposes.@@ -916,7 +917,13 @@ class PydanticModelTransformer: The added `__init__` will be annotated with types vs. all `Any` depending on the plugin settings. """- if '__init__' in self._cls.info.names and not self._cls.info.names['__init__'].plugin_generated:+ if (+ '__init__' in self._cls.info.names+ and not self._cls.info.names['__init__'].plugin_generated+ # `RootModel.__init__` is defined explicitly for runtime purposes, but its signature should+ # follow the plugin settings (e.g. `init_typed`), similarly to its subclasses:+ and self._cls.info.fullname != ROOT_MODEL_FULLNAME+ ): return # Don't generate an __init__ if one already exists typed = self.plugin_config.init_typedtests/mypy/modules/plugin_fail.pyindex 40ffb1dd..49e377e7 100644@@ -1,6 +1,6 @@ from typing import Generic, Optional, Set, TypeVar, Union -from pydantic import BaseModel, ConfigDict, Extra, Field, field_validator+from pydantic import BaseModel, ConfigDict, Extra, Field, RootModel, field_validator from pydantic.dataclasses import dataclass @@ -263,3 +263,17 @@ class ModelWithAnnotatedValidator(BaseModel): def instance_method(self) -> None: ...+++# With `init_typed`, `RootModel` (used directly or subclassed) should be typed like a `BaseModel` field:+class FloatModel(BaseModel):+ f: float+++class FloatRootModelSub(RootModel[float]):+ pass+++FloatModel(f='1.0')+RootModel[float]('1.0')+FloatRootModelSub('1.0')tests/mypy/modules/root_models.pyindex 804d1d43..a36520cc 100644@@ -46,3 +46,21 @@ m = Model[str](m1=Maybe(None), m2=Maybe('dog'), m3=Maybe([])) Model(m1=None, m2={}, m3=[]) assert_type(m.m1, Maybe[int])+++# `RootModel` (used directly or subclassed) should accept the same (non-strict) input as a `BaseModel` field:+class FloatModel(BaseModel):+ f: float+++FloatRootModel = RootModel[float]+++class FloatRootModelSub(RootModel[float]):+ pass+++float_model = FloatModel(f='1.0')+float_root_model = FloatRootModel('1.0')+float_root_model_direct = RootModel[float]('1.0')+float_root_model_sub = FloatRootModelSub('1.0')tests/mypy/outputs/mypy-default_ini/root_models.pyindex 01cf5bbb..3a4a97df 100644@@ -54,3 +54,25 @@ Model(m1=None, m2={}, m3=[]) # MYPY: error: Argument "m3" to "Model" has incompatible type "list[Never]"; expected "Maybe[Any]" [arg-type] assert_type(m.m1, Maybe[int])+++# `RootModel` (used directly or subclassed) should accept the same (non-strict) input as a `BaseModel` field:+class FloatModel(BaseModel):+ f: float+++FloatRootModel = RootModel[float]+++class FloatRootModelSub(RootModel[float]):+ pass+++float_model = FloatModel(f='1.0')+# MYPY: error: Argument "f" to "FloatModel" has incompatible type "str"; expected "float" [arg-type]+float_root_model = FloatRootModel('1.0')+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float" [arg-type]+float_root_model_direct = RootModel[float]('1.0')+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float" [arg-type]+float_root_model_sub = FloatRootModelSub('1.0')+# MYPY: error: Argument 1 to "FloatRootModelSub" has incompatible type "str"; expected "float" [arg-type]tests/mypy/outputs/mypy-plugin-strict_ini/plugin_fail.pyindex f0311cb2..c160e292 100644@@ -1,6 +1,6 @@ from typing import Generic, Optional, Set, TypeVar, Union -from pydantic import BaseModel, ConfigDict, Extra, Field, field_validator+from pydantic import BaseModel, ConfigDict, Extra, Field, RootModel, field_validator from pydantic.dataclasses import dataclass @@ -316,3 +316,20 @@ class ModelWithAnnotatedValidator(BaseModel): def instance_method(self) -> None: ...+++# With `init_typed`, `RootModel` (used directly or subclassed) should be typed like a `BaseModel` field:+class FloatModel(BaseModel):+ f: float+++class FloatRootModelSub(RootModel[float]):+ pass+++FloatModel(f='1.0')+# MYPY: error: Argument "f" to "FloatModel" has incompatible type "str"; expected "float" [arg-type]+RootModel[float]('1.0')+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float" [arg-type]+FloatRootModelSub('1.0')+# MYPY: error: Argument 1 to "FloatRootModelSub" has incompatible type "str"; expected "float" [arg-type]tests/mypy/outputs/mypy-plugin_ini/plugin_fail.pyindex 4bcd940b..61507b71 100644@@ -1,6 +1,6 @@ from typing import Generic, Optional, Set, TypeVar, Union -from pydantic import BaseModel, ConfigDict, Extra, Field, field_validator+from pydantic import BaseModel, ConfigDict, Extra, Field, RootModel, field_validator from pydantic.dataclasses import dataclass @@ -300,3 +300,17 @@ class ModelWithAnnotatedValidator(BaseModel): def instance_method(self) -> None: ...+++# With `init_typed`, `RootModel` (used directly or subclassed) should be typed like a `BaseModel` field:+class FloatModel(BaseModel):+ f: float+++class FloatRootModelSub(RootModel[float]):+ pass+++FloatModel(f='1.0')+RootModel[float]('1.0')+FloatRootModelSub('1.0')tests/mypy/outputs/mypy-plugin_ini/root_models.pyindex 5bb30a04..41a11e6c 100644@@ -49,3 +49,21 @@ m = Model[str](m1=Maybe(None), m2=Maybe('dog'), m3=Maybe([])) Model(m1=None, m2={}, m3=[]) assert_type(m.m1, Maybe[int])+++# `RootModel` (used directly or subclassed) should accept the same (non-strict) input as a `BaseModel` field:+class FloatModel(BaseModel):+ f: float+++FloatRootModel = RootModel[float]+++class FloatRootModelSub(RootModel[float]):+ pass+++float_model = FloatModel(f='1.0')+float_root_model = FloatRootModel('1.0')+float_root_model_direct = RootModel[float]('1.0')+float_root_model_sub = FloatRootModelSub('1.0')tests/mypy/outputs/pyproject-default_toml/root_models.pyindex 01cf5bbb..3a4a97df 100644@@ -54,3 +54,25 @@ Model(m1=None, m2={}, m3=[]) # MYPY: error: Argument "m3" to "Model" has incompatible type "list[Never]"; expected "Maybe[Any]" [arg-type] assert_type(m.m1, Maybe[int])+++# `RootModel` (used directly or subclassed) should accept the same (non-strict) input as a `BaseModel` field:+class FloatModel(BaseModel):+ f: float+++FloatRootModel = RootModel[float]+++class FloatRootModelSub(RootModel[float]):+ pass+++float_model = FloatModel(f='1.0')+# MYPY: error: Argument "f" to "FloatModel" has incompatible type "str"; expected "float" [arg-type]+float_root_model = FloatRootModel('1.0')+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float" [arg-type]+float_root_model_direct = RootModel[float]('1.0')+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float" [arg-type]+float_root_model_sub = FloatRootModelSub('1.0')+# MYPY: error: Argument 1 to "FloatRootModelSub" has incompatible type "str"; expected "float" [arg-type]tests/mypy/outputs/pyproject-plugin-strict_toml/plugin_fail.pyindex f0311cb2..c160e292 100644@@ -1,6 +1,6 @@ from typing import Generic, Optional, Set, TypeVar, Union -from pydantic import BaseModel, ConfigDict, Extra, Field, field_validator+from pydantic import BaseModel, ConfigDict, Extra, Field, RootModel, field_validator from pydantic.dataclasses import dataclass @@ -316,3 +316,20 @@ class ModelWithAnnotatedValidator(BaseModel): def instance_method(self) -> None: ...+++# With `init_typed`, `RootModel` (used directly or subclassed) should be typed like a `BaseModel` field:+class FloatModel(BaseModel):+ f: float+++class FloatRootModelSub(RootModel[float]):+ pass+++FloatModel(f='1.0')+# MYPY: error: Argument "f" to "FloatModel" has incompatible type "str"; expected "float" [arg-type]+RootModel[float]('1.0')+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float" [arg-type]+FloatRootModelSub('1.0')+# MYPY: error: Argument 1 to "FloatRootModelSub" has incompatible type "str"; expected "float" [arg-type]tests/mypy/outputs/pyproject-plugin_toml/plugin_fail.pyindex 4bcd940b..61507b71 100644@@ -1,6 +1,6 @@ from typing import Generic, Optional, Set, TypeVar, Union -from pydantic import BaseModel, ConfigDict, Extra, Field, field_validator+from pydantic import BaseModel, ConfigDict, Extra, Field, RootModel, field_validator from pydantic.dataclasses import dataclass @@ -300,3 +300,17 @@ class ModelWithAnnotatedValidator(BaseModel): def instance_method(self) -> None: ...+++# With `init_typed`, `RootModel` (used directly or subclassed) should be typed like a `BaseModel` field:+class FloatModel(BaseModel):+ f: float+++class FloatRootModelSub(RootModel[float]):+ pass+++FloatModel(f='1.0')+RootModel[float]('1.0')+FloatRootModelSub('1.0')
pydantic/mypy.pyindex cd28e7004..40aee0627 100644@@ -88,6 +88,7 @@ CREATE_MODEL_FULLNAME = 'pydantic.main.create_model' BASESETTINGS_FULLNAME = 'pydantic_settings.main.BaseSettings' ROOT_MODEL_FULLNAME = 'pydantic.root_model.RootModel' MODEL_METACLASS_FULLNAME = 'pydantic._internal._model_construction.ModelMetaclass'+ROOT_MODEL_METACLASS_FULLNAME = 'pydantic.root_model._RootModelMetaclass' FIELD_FULLNAME = 'pydantic.fields.Field' DATACLASS_FULLNAME = 'pydantic.dataclasses.dataclass' MODEL_VALIDATOR_FULLNAME = 'pydantic.functional_validators.model_validator'@@ -143,7 +144,7 @@ class PydanticPlugin(Plugin): def get_metaclass_hook(self, fullname: str) -> Callable[[ClassDefContext], None] | None: """Update Pydantic `ModelMetaclass` definition."""- if fullname == MODEL_METACLASS_FULLNAME:+ if fullname in (MODEL_METACLASS_FULLNAME, ROOT_MODEL_METACLASS_FULLNAME): return self._pydantic_model_metaclass_marker_callback return None @@ -916,7 +917,13 @@ class PydanticModelTransformer: The added `__init__` will be annotated with types vs. all `Any` depending on the plugin settings. """- if '__init__' in self._cls.info.names and not self._cls.info.names['__init__'].plugin_generated:+ if (+ '__init__' in self._cls.info.names+ and not self._cls.info.names['__init__'].plugin_generated+ # `RootModel` declares a typed `__init__` for the benefit of type checkers when the plugin+ # isn't used, but the plugin-generated one should take priority over it:+ and self._cls.fullname != ROOT_MODEL_FULLNAME+ ): return # Don't generate an __init__ if one already exists typed = self.plugin_config.init_typedtests/mypy/modules/root_models.pyindex 804d1d43e..f95bd7fe1 100644@@ -22,6 +22,18 @@ pets1 = Pets1(['dog', 'cat']) pets2 = Pets2(['dog', 'cat']) pets3 = Pets3(['dog', 'cat']) +RFloat = RootModel[float]+++class RFloatSub(RootModel[float]):+ pass+++# When the plugin is used with `init_typed` unset, arbitrary input+# should be accepted as it may be coerced to the `root` type:+rfloat = RFloat('1.0')+rfloat_sub = RFloatSub('1.0')+ class Pets4(RootModel[list[str]]): pets: list[str]tests/mypy/outputs/mypy-default_ini/root_models.pyindex 01cf5bbb3..df3354187 100644@@ -23,6 +23,20 @@ pets1 = Pets1(['dog', 'cat']) pets2 = Pets2(['dog', 'cat']) pets3 = Pets3(['dog', 'cat']) +RFloat = RootModel[float]+++class RFloatSub(RootModel[float]):+ pass+++# When the plugin is used with `init_typed` unset, arbitrary input+# should be accepted as it may be coerced to the `root` type:+rfloat = RFloat('1.0')+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float" [arg-type]+rfloat_sub = RFloatSub('1.0')+# MYPY: error: Argument 1 to "RFloatSub" has incompatible type "str"; expected "float" [arg-type]+ class Pets4(RootModel[list[str]]): pets: list[str]tests/mypy/outputs/mypy-plugin_ini/root_models.pyindex 5bb30a044..12b4c84bd 100644@@ -23,6 +23,18 @@ pets1 = Pets1(['dog', 'cat']) pets2 = Pets2(['dog', 'cat']) pets3 = Pets3(['dog', 'cat']) +RFloat = RootModel[float]+++class RFloatSub(RootModel[float]):+ pass+++# When the plugin is used with `init_typed` unset, arbitrary input+# should be accepted as it may be coerced to the `root` type:+rfloat = RFloat('1.0')+rfloat_sub = RFloatSub('1.0')+ class Pets4(RootModel[list[str]]): pets: list[str]tests/mypy/outputs/pyproject-default_toml/root_models.pyindex 01cf5bbb3..df3354187 100644@@ -23,6 +23,20 @@ pets1 = Pets1(['dog', 'cat']) pets2 = Pets2(['dog', 'cat']) pets3 = Pets3(['dog', 'cat']) +RFloat = RootModel[float]+++class RFloatSub(RootModel[float]):+ pass+++# When the plugin is used with `init_typed` unset, arbitrary input+# should be accepted as it may be coerced to the `root` type:+rfloat = RFloat('1.0')+# MYPY: error: Argument 1 to "RootModel" has incompatible type "str"; expected "float" [arg-type]+rfloat_sub = RFloatSub('1.0')+# MYPY: error: Argument 1 to "RFloatSub" has incompatible type "str"; expected "float" [arg-type]+ class Pets4(RootModel[list[str]]): pets: list[str]