Backtestspydanticrun-20261005-183002#13664
JSON Schema ignores ser_json_temporal, so serialization schemas contradict model_dump_json() output
Our patch was judged better than the merged fix.
In this judgment, Patch A = our agent, Patch B = the merged fix.
Both patches fix the main bug the same way. date/time/datetime emit {'type': 'number'} under 'seconds'/'milliseconds', and timedelta lets an explicitly set `ser_json_temporal` override `ser_json_timedelta`. Patch A handles the edges better.
(1) Explicit `None`. Patch B tests `'ser_json_temporal' in config_dict` and then calls `_common_temporal_schema`, which treats anything other than 'iso8601' as numeric. A config of `ser_json_temporal=None` would therefore make every temporal field `number`, even though `None` should behave as unset (falling back to `ser_json_timedelta`, and ISO strings elsewhere). Patch A checks `config_dict.get(...) is not None` for timedelta and `in ('seconds', 'milliseconds')` for the other types, so it degrades safely. A also tests this case against actual `model_dump_json()` output.
(2) Defaults. Patch A also updates `encode_default` so encoded defaults follow the same temporal/timedelta precedence. Without that, a schema could say `type: number` while carrying a string default, or the reverse. A tests this through a stdlib-dataclass default.
On tests, A's parametrized test checks the full properties, including defaults, and cross-checks every field's type and value against `model_dump_json()` for the default, iso8601, seconds, milliseconds and precedence configs. B's tests are solid but narrower: type only, no defaults, no `None` case.
Both patches are clean. B's `_common_temporal_schema` helper is tidy but encodes the fragile `!= 'iso8601'` check. Overall A is more correct and better tested.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
14m 12s
Wall-clock time in the container
Full test suite
No new failures
12,359 passed · 500 skipped · 12,859 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
135vs 88 merged
Changed lines, ours vs merged
The issue
View on GitHubInitial Checks
- I confirm that I'm using Pydantic V2
Description
ser_json_temporal landed in v2.12 and controls how datetime, date, time and timedelta are serialized to JSON. GenerateJsonSchema was never told about it, so a mode='serialization' schema still says these fields are strings even when model_dump_json() writes numbers.
With ser_json_temporal='seconds' (same with 'milliseconds'), every temporal field is affected:
schema: {'dt': {'type': 'string', 'format': 'date-time'}, 'td': {'type': 'string', 'format': 'duration'}}
dump: {'dt': 1577836800.0, 'td': 86400.0}
Running that payload through a JSON Schema validator fails with 1577836800.0 is not of type 'string', so the schema pydantic publishes rejects the output pydantic itself just produced. date_schema, time_schema and datetime_schema read no config at all right now.
There is a second mismatch that goes the other way, on timedelta. timedelta_schema only looks at the older ser_json_timedelta setting. The docs for ser_json_temporal say it takes precedence over ser_json_timedelta, and pydantic-core implements exactly that: SerializationConfig::from_config and TimeDeltaSerializer::build both check whether ser_json_temporal is present in the config before falling back to ser_json_timedelta. The JSON schema layer does not, so setting ser_json_temporal='iso8601' together with ser_json_timedelta='float' gives you the reverse problem:
schema: {'td': {'type': 'number'}}
dump: {'td': 'P1D'}
For anyone generating an OpenAPI document from a model this is a silent wrong answer rather than a crash, which is probably why it has gone unnoticed since the setting was added.
I have a patch that mirrors the pydantic-core resolution in the four temporal schema methods, plus tests. Happy to open a PR if you want to assign this to me.
Example Code
import json
from datetime import date, datetime, time, timedelta
from pydantic import BaseModel, ConfigDict
class Numeric(BaseModel):
model_config = ConfigDict(ser_json_temporal='seconds')
dt: datetime
d: date
t: time
td: timedelta
model = Numeric(dt=datetime(2020, 1, 1), d=date(2020, 1, 1), t=time(12, 0), td=timedelta(days=1))
print(Numeric.model_json_schema(mode='serialization')['properties'])
#> {'dt': {'format': 'date-time', 'title': 'Dt', 'type': 'string'},
#> 'd': {'format': 'date', 'title': 'D', 'type': 'string'},
#> 't': {'format': 'time', 'title': 'T', 'type': 'string'},
#> 'td': {'format': 'duration', 'title': 'Td', 'type': 'string'}}
print(json.loads(model.model_dump_json()))
#> {'dt': 1577836800.0, 'd': 1577836800.0, 't': 43200.0, 'td': 86400.0}
# The timedelta precedence case, wrong in the opposite direction:
class Precedence(BaseModel):
model_config = ConfigDict(ser_json_temporal='iso8601', ser_json_timedelta='float')
td: timedelta
print(Precedence.model_json_schema(mode='serialization')['properties'])
#> {'td': {'title': 'Td', 'type': 'number'}}
print(json.loads(Precedence(td=timedelta(days=1)).model_dump_json()))
#> {'td': 'P1D'}
Python, Pydantic & OS Version
pydantic version: 2.13.4
pydantic-core version: 2.46.4
pydantic-core build: profile=release pgo=false
python version: 3.12.13 (main, May 10 2026, 19:20:41) [Clang 22.1.3 ]
platform: macOS-15.7.4-arm64-arm-64bit
related packages: typing_extensions-4.16.0
commit: unknown
Also reproduces on main (2.14.0b1 / pydantic-core 2.48.0).
The two patches
pydantic/json_schema.pyindex c2183e19..a4772f57 100644@@ -827,6 +827,8 @@ class GenerateJsonSchema: Returns: The generated JSON schema. """+ if self._config.ser_json_temporal in ('seconds', 'milliseconds'):+ return {'type': 'number'} return {'type': 'string', 'format': 'date'} def time_schema(self, schema: core_schema.TimeSchema) -> JsonSchemaValue:@@ -838,6 +840,8 @@ class GenerateJsonSchema: Returns: The generated JSON schema. """+ if self._config.ser_json_temporal in ('seconds', 'milliseconds'):+ return {'type': 'number'} return {'type': 'string', 'format': 'time'} def datetime_schema(self, schema: core_schema.DatetimeSchema) -> JsonSchemaValue:@@ -849,6 +853,8 @@ class GenerateJsonSchema: Returns: The generated JSON schema. """+ if self._config.ser_json_temporal in ('seconds', 'milliseconds'):+ return {'type': 'number'} return {'type': 'string', 'format': 'date-time'} def timedelta_schema(self, schema: core_schema.TimedeltaSchema) -> JsonSchemaValue:@@ -860,10 +866,19 @@ class GenerateJsonSchema: Returns: The generated JSON schema. """- if self._config.ser_json_timedelta == 'float':+ if self._timedelta_json_mode() != 'iso8601': return {'type': 'number'} return {'type': 'string', 'format': 'duration'} + def _timedelta_json_mode(self) -> Literal['iso8601', 'seconds', 'milliseconds']:+ """Resolve how timedelta values are serialized to JSON, mirroring pydantic-core.++ `ser_json_temporal` takes precedence over `ser_json_timedelta` when it is explicitly set in the config.+ """+ if self._config.config_dict.get('ser_json_temporal') is not None:+ return self._config.ser_json_temporal+ return 'seconds' if self._config.ser_json_timedelta == 'float' else 'iso8601'+ def literal_schema(self, schema: core_schema.LiteralSchema) -> JsonSchemaValue: """Generates a JSON schema that matches a literal value. @@ -2451,8 +2466,14 @@ class GenerateJsonSchema: except PydanticSchemaGenerationError: raise pydantic_core.PydanticSerializationError(f'Unable to encode default value {dft}') + # `ser_json_temporal` takes precedence over `ser_json_timedelta` when explicitly set (mirroring pydantic-core):+ temporal_set = config.config_dict.get('ser_json_temporal') is not None return pydantic_core.to_jsonable_python(- default, timedelta_mode=config.ser_json_timedelta, bytes_mode=config.ser_json_bytes, by_alias=self.by_alias+ default,+ timedelta_mode='iso8601' if temporal_set else config.ser_json_timedelta,+ temporal_mode=config.ser_json_temporal if temporal_set else 'iso8601',+ bytes_mode=config.ser_json_bytes,+ by_alias=self.by_alias, ) def update_with_validations(tests/test_json_schema.pyindex 9cca3292..8ac16328 100644@@ -1878,6 +1878,116 @@ def test_model_default_timedelta(ser_json_timedelta: Literal['float', 'iso8601'] } +_TEMPORAL_ISO_PROPERTIES = {+ 'dt': {'default': '2020-01-01T00:00:00', 'format': 'date-time', 'title': 'Dt', 'type': 'string'},+ 'd': {'default': '2020-01-01', 'format': 'date', 'title': 'D', 'type': 'string'},+ 't': {'default': '12:00:00', 'format': 'time', 'title': 'T', 'type': 'string'},+ 'td': {'default': 'P1D', 'format': 'duration', 'title': 'Td', 'type': 'string'},+}+++@pytest.mark.parametrize(+ 'config,properties',+ [+ pytest.param({}, _TEMPORAL_ISO_PROPERTIES, id='default'),+ pytest.param({'ser_json_temporal': 'iso8601'}, _TEMPORAL_ISO_PROPERTIES, id='iso8601'),+ pytest.param(+ {'ser_json_temporal': 'seconds'},+ {+ 'dt': {'default': 1577836800.0, 'title': 'Dt', 'type': 'number'},+ 'd': {'default': 1577836800.0, 'title': 'D', 'type': 'number'},+ 't': {'default': 43200.0, 'title': 'T', 'type': 'number'},+ 'td': {'default': 86400.0, 'title': 'Td', 'type': 'number'},+ },+ id='seconds',+ ),+ pytest.param(+ {'ser_json_temporal': 'milliseconds'},+ {+ 'dt': {'default': 1577836800000.0, 'title': 'Dt', 'type': 'number'},+ 'd': {'default': 1577836800000.0, 'title': 'D', 'type': 'number'},+ 't': {'default': 43200000.0, 'title': 'T', 'type': 'number'},+ 'td': {'default': 86400000.0, 'title': 'Td', 'type': 'number'},+ },+ id='milliseconds',+ ),+ pytest.param(+ {'ser_json_timedelta': 'float'},+ {**_TEMPORAL_ISO_PROPERTIES, 'td': {'default': 86400.0, 'title': 'Td', 'type': 'number'}},+ id='timedelta_float',+ ),+ pytest.param(+ {'ser_json_temporal': 'iso8601', 'ser_json_timedelta': 'float'},+ _TEMPORAL_ISO_PROPERTIES,+ id='temporal_iso8601_overrides_timedelta_float',+ ),+ pytest.param(+ {'ser_json_temporal': 'milliseconds', 'ser_json_timedelta': 'float'},+ {+ 'dt': {'default': 1577836800000.0, 'title': 'Dt', 'type': 'number'},+ 'd': {'default': 1577836800000.0, 'title': 'D', 'type': 'number'},+ 't': {'default': 43200000.0, 'title': 'T', 'type': 'number'},+ 'td': {'default': 86400000.0, 'title': 'Td', 'type': 'number'},+ },+ id='temporal_milliseconds_overrides_timedelta_float',+ ),+ pytest.param(+ {'ser_json_temporal': None, 'ser_json_timedelta': 'float'},+ {**_TEMPORAL_ISO_PROPERTIES, 'td': {'default': 86400.0, 'title': 'Td', 'type': 'number'}},+ id='temporal_none_is_unset',+ ),+ ],+)+def test_model_temporal_ser_json_temporal(config: ConfigDict, properties: dict[str, Any]):+ class Model(BaseModel):+ model_config = config++ dt: datetime = datetime(2020, 1, 1)+ d: date = date(2020, 1, 1)+ t: time = time(12, 0)+ td: timedelta = timedelta(days=1)++ json_schema = Model.model_json_schema(mode='serialization')+ assert json_schema['properties'] == properties++ # The serialization schema must describe what `model_dump_json()` actually produces:+ dumped = json.loads(Model().model_dump_json())+ for name, prop in json_schema['properties'].items():+ assert dumped[name] == prop['default']+ assert isinstance(dumped[name], float if prop['type'] == 'number' else str)+++@pytest.mark.parametrize(+ 'config,expected_default',+ [+ pytest.param({}, 'P1D', id='default'),+ pytest.param({'ser_json_temporal': 'seconds'}, 86400.0, id='seconds'),+ pytest.param({'ser_json_timedelta': 'float'}, 86400.0, id='timedelta_float'),+ pytest.param(+ {'ser_json_temporal': 'iso8601', 'ser_json_timedelta': 'float'},+ 'P1D',+ id='temporal_iso8601_overrides_timedelta_float',+ ),+ pytest.param({'ser_json_temporal': None, 'ser_json_timedelta': 'float'}, 86400.0, id='temporal_none_is_unset'),+ ],+)+def test_model_default_stdlib_dataclass_ser_json_temporal(config: ConfigDict, expected_default: Any):+ """Defaults encoded through inference (e.g. stdlib dataclasses) follow the same precedence as pydantic-core."""++ @dataclasses.dataclass+ class TimeWindow:+ td: timedelta++ class Model(BaseModel):+ model_config = config++ value: TimeWindow = TimeWindow(td=timedelta(days=1))++ json_schema = Model.model_json_schema(mode='serialization')+ assert json_schema['properties']['value']['default'] == {'td': expected_default}+ assert json.loads(Model().model_dump_json())['value'] == {'td': expected_default}++ @pytest.mark.parametrize( 'ser_json_bytes,properties', [
pydantic/json_schema.pyindex c2183e193..aa330bc66 100644@@ -827,7 +827,7 @@ class GenerateJsonSchema: Returns: The generated JSON schema. """- return {'type': 'string', 'format': 'date'}+ return self._common_temporal_schema('date', self._config.ser_json_temporal) def time_schema(self, schema: core_schema.TimeSchema) -> JsonSchemaValue: """Generates a JSON schema that matches a time value.@@ -838,7 +838,7 @@ class GenerateJsonSchema: Returns: The generated JSON schema. """- return {'type': 'string', 'format': 'time'}+ return self._common_temporal_schema('time', self._config.ser_json_temporal) def datetime_schema(self, schema: core_schema.DatetimeSchema) -> JsonSchemaValue: """Generates a JSON schema that matches a datetime value.@@ -849,7 +849,7 @@ class GenerateJsonSchema: Returns: The generated JSON schema. """- return {'type': 'string', 'format': 'date-time'}+ return self._common_temporal_schema('date-time', self._config.ser_json_temporal) def timedelta_schema(self, schema: core_schema.TimedeltaSchema) -> JsonSchemaValue: """Generates a JSON schema that matches a timedelta value.@@ -860,9 +860,21 @@ class GenerateJsonSchema: Returns: The generated JSON schema. """- if self._config.ser_json_timedelta == 'float':+ if 'ser_json_temporal' in self._config.config_dict:+ temporal_format = self._config.ser_json_temporal+ else:+ # `ser_json_temporal` supersedes `ser_json_timedelta`, which only applies when the former isn't+ # explicitly set.+ temporal_format = 'seconds' if self._config.ser_json_timedelta == 'float' else 'iso8601'+ return self._common_temporal_schema('duration', temporal_format)++ def _common_temporal_schema(+ self, format: str, temporal_format: Literal['iso8601', 'seconds', 'milliseconds']+ ) -> JsonSchemaValue:+ if temporal_format != 'iso8601':+ # Both `'seconds'` and `'milliseconds'` serialize to a number: return {'type': 'number'}- return {'type': 'string', 'format': 'duration'}+ return {'type': 'string', 'format': format} def literal_schema(self, schema: core_schema.LiteralSchema) -> JsonSchemaValue: """Generates a JSON schema that matches a literal value.tests/test_json_schema.pyindex 9cca32928..5157bdb80 100644@@ -830,6 +830,72 @@ def test_date_types(field_type, expected_schema): assert Model.model_json_schema() == base_schema +@pytest.mark.parametrize('ser_json_temporal', ['iso8601', 'seconds', 'milliseconds'])+@pytest.mark.parametrize(+ 'field_type,iso8601_format',+ [+ (datetime, 'date-time'),+ (date, 'date'),+ (time, 'time'),+ (timedelta, 'duration'),+ ],+)+def test_date_types_ser_json_temporal(field_type, iso8601_format, ser_json_temporal):+ """https://github.com/pydantic/pydantic/issues/13664"""++ class Model(BaseModel):+ model_config = ConfigDict(ser_json_temporal=ser_json_temporal)++ a: field_type++ if ser_json_temporal == 'iso8601':+ expected_schema = {'title': 'A', 'type': 'string', 'format': iso8601_format}+ else:+ expected_schema = {'title': 'A', 'type': 'number'}++ assert Model.model_json_schema(mode='serialization')['properties']['a'] == expected_schema+++@pytest.mark.parametrize('ser_json_temporal', ['iso8601', 'seconds', 'milliseconds'])+def test_date_types_ser_json_temporal_matches_serialized_output(ser_json_temporal):+ class Model(BaseModel):+ model_config = ConfigDict(ser_json_temporal=ser_json_temporal)++ dt: datetime+ d: date+ t: time+ td: timedelta++ model = Model(dt=datetime(2020, 1, 1), d=date(2020, 1, 1), t=time(12, 0), td=timedelta(days=1))+ properties = Model.model_json_schema(mode='serialization')['properties']+ expected_type = 'string' if ser_json_temporal == 'iso8601' else 'number'++ for field_name, value in json.loads(model.model_dump_json()).items():+ assert properties[field_name]['type'] == expected_type+ if ser_json_temporal == 'iso8601':+ assert isinstance(value, str)+ else:+ assert isinstance(value, float)+++@pytest.mark.parametrize(+ 'config,expected_schema',+ [+ ({'ser_json_timedelta': 'float'}, {'type': 'number'}),+ ({'ser_json_timedelta': 'iso8601'}, {'type': 'string', 'format': 'duration'}),+ ({'ser_json_temporal': 'seconds', 'ser_json_timedelta': 'iso8601'}, {'type': 'number'}),+ ({'ser_json_temporal': 'iso8601', 'ser_json_timedelta': 'float'}, {'type': 'string', 'format': 'duration'}),+ ],+)+def test_timedelta_ser_json_temporal_takes_precedence(config, expected_schema):+ class Model(BaseModel):+ model_config = config++ a: timedelta++ assert Model.model_json_schema(mode='serialization')['properties']['a'] == {'title': 'A', **expected_schema}++ @pytest.mark.parametrize( 'interval', [