Backtestspydanticrun-20261022-024030#13802
Three error-reference examples no longer raise the error they document, and the docs test suite cannot detect it
Our patch was judged better than the merged fix.
In this judgment, Patch B = our agent, Patch A = the merged fix.
Both patches fix the three stale examples identically in substance: a non-numeric input for `complex_type` (both inputs are confirmed in the issue to raise it and pass the independent tests), a `Callable` annotation for `invalid-for-json-schema`, and removal of the `string_sub_type` section. The independent tests pass on both, so correctness on the three reported examples is a wash. The differences lie in tests and scope. Patch B adds `test_error_docs_examples_raise`, an AST-instrumented check that every `try`/`except` on the error pages actually enters its `except` branch. This is precisely the blind spot the issue describes and the test the reporter offered to write; it would have failed on base for all three examples and will catch the next #12498-style regression. B also keeps `test_validation_error_codes` consistent with a single explicit exclusion, mirroring the existing `timezone_offset` convention right above it. Patch A adds no test for the blind spot at all, so the docs can go silently stale again. Patch A instead expands scope into pydantic-core, deleting the `StringSubType` variant from the Rust enum, the `ErrorType` Literal, and the core test table. The issue explicitly left that to the maintainers' judgement; removing a public error code from `ErrorType` is a user-facing API change (anyone matching on `'string_sub_type'` or using the Literal in typing now breaks) and belongs in a separate, deliberately reviewed change, not bundled with a docs fix. A also includes an unrelated edit to `docs/concepts/experimental.md` that has nothing to do with the issue. Neither of these earns credit, and the core removal adds real risk. B resolves the issue, adds the regression test the issue asked for, and stays in scope. A fixes the same three examples but without a guard and with risky unrelated churn.
Four judges ruled on this ticket in parallel, and the verdict comes from counting their votes. Each saw the issue and the two patches, labelled A and B in random order (two of them saw ours as A), with issue links and version numbers removed. Where tests could check the fix, they also saw the results of tests a separate agent wrote for the issue, run on both patches. None was told which patch was ours. The reasoning above is one judge's, shown verbatim.
Solve
8m 26s
Wall-clock time in the container
Full test suite
No new failures
3,320 passed · 268 skipped · 3,588 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
101vs 39 merged
Changed lines, ours vs merged
The issue
View on GitHubInitial Checks
- I confirm that I'm using Pydantic V2
Description
Three examples on the error-reference pages no longer raise the error they document, and the documentation test suite cannot detect it.
Every example on those pages has the same shape: do something that should fail, catch it, then print or assert the error code. The only assertion lives inside the except branch. When the operation stops failing, that branch never runs, so nothing is printed and no assert is evaluated. run_print_check compares printed output against the #> comments, and an example whose print never ran produces no output to disagree with, so the example exits 0 and CI stays green while the page documents behaviour that no longer exists.
I checked this exhaustively rather than by sampling. I injected a sentinel as the first statement of every except block on both error pages and ran each example. Of the 152 examples containing a try/except at v2.13.5, all 152 run, and exactly 3 never enter their except branch. On main the count is 3 of 157. None of the three is marked test="skip", so all three are executed by CI today.
1. complex_type, docs/errors/validation_errors.md
Model(num=False) now validates successfully to 0j, so the #> 'complex_type' line never prints. This changed in 2.13.0b1 with #12498, which made complex validation call the complex() constructor unconditionally in Python mode, and complex(False) is 0j.
2. string_sub_type, docs/errors/validation_errors.md
The section says a strict str field rejects an instance of a str subclass. It does not: the example returns a plain str with the value 'foo', and #> 'string_sub_type' never prints. pydantic_core 2.49.0 still declares the error ("Input should be a string, not an instance of a subclass of str"), but I could not find any str schema that raises it. Building core_schema.str_schema() directly with strict=True, without strict, and with strict=True plus a pattern all accept a str subclass and return a plain str.
This looks intentional rather than accidental. #6261 reported exactly this behaviour as a bug in June 2023, was labelled bug V2, and was closed with the conversation moved to pydantic-core#786. So the check appears to have been removed on purpose and this documentation section was left behind describing it.
3. invalid-for-json-schema, docs/errors/usage_errors.md
ImportString has had a JSON schema since 2.8.0 via #9344, so Model.model_json_schema() succeeds and returns a plain string schema. The assert exc_info.code == 'invalid-for-json-schema' inside the except block has not executed since that release.
Output of the example code below
Identical on 2.13.5 and on main at 2.14.0b2:
1. no exception; num = 0j
2. no exception; accepted 'foo'
3. no exception; {'properties': {'a': {'title': 'A', 'type': 'string'}}, 'required': ['a'], 'title': 'ImportStringModel', 'type': 'object'}
Suggested fixes
complex_typeis a one-word fix.Model(num='not a complex number')still raisescomplex_type, and so do[],{}and a bareobject(). ReplacingFalsewith any of those restores the example.string_sub_typeneeds a decision rather than a fix, which is the main reason I am opening an issue instead of sending a patch. Given the trail through #6261, the section probably wants deleting rather than repairing, and possibly the error variant too, but that is your call.invalid-for-json-schemaneeds a type that genuinely has no JSON schema, in place ofImportString.
Separately, the blind spot itself is fixable. If an example on these pages had to demonstrate that the error occurred, for instance by printing inside the except and also failing loudly when nothing was raised, then a future change like #12498 would turn the docs red instead of silently making a section untrue. I am happy to send a PR for any or all of this, including that check as a test, if you tell me which direction you prefer.
I used AI assistance to run this audit, in line with your AI policy. I have reproduced and understood each of the three cases myself and can explain any of them.
Example Code
from enum import Enum
from pydantic import (
BaseModel,
Field,
ImportString,
PydanticUserError,
ValidationError,
)
# 1. validation_errors.md, `complex_type`: documented to print 'complex_type'
class ComplexModel(BaseModel):
num: complex
try:
ComplexModel(num=False)
print('1. no exception; num =', ComplexModel(num=False).num)
except ValidationError as exc:
print('1.', repr(exc.errors()[0]['type']))
# 2. validation_errors.md, `string_sub_type`: documented to print 'string_sub_type'
class MyEnum(str, Enum):
foo = 'foo'
class StrictStrModel(BaseModel):
x: str = Field(strict=True)
try:
print('2. no exception; accepted', repr(StrictStrModel(x=MyEnum.foo).x))
except ValidationError as exc:
print('2.', repr(exc.errors()[0]['type']))
# 3. usage_errors.md, `invalid-for-json-schema`: the assert is never reached
class ImportStringModel(BaseModel):
a: ImportString
try:
print('3. no exception;', ImportStringModel.model_json_schema())
except PydanticUserError as exc:
print('3.', exc.code)
Python, Pydantic & OS Version
pydantic version: 2.13.5
pydantic-core version: 2.46.5
python version: 3.12.10 (CPython)
platform: Windows 11
also reproduced against main at pydantic 2.14.0b2 / pydantic-core 2.49.0The two patches
docs/errors/usage_errors.mdindex 7e28e9f8..c1b8d767 100644@@ -620,11 +620,13 @@ type C = B This error is raised when Pydantic fails to generate a JSON schema for some `CoreSchema`. ```python-from pydantic import BaseModel, ImportString, PydanticUserError+from collections.abc import Callable++from pydantic import BaseModel, PydanticUserError class Model(BaseModel):- a: ImportString+ a: Callable[[int], int] try:docs/errors/validation_errors.mdindex 71d3a929..defd987d 100644@@ -233,7 +233,7 @@ class Model(BaseModel): try:- Model(num=False)+ Model(num=[]) except ValidationError as exc: print(repr(exc.errors()[0]['type'])) #> 'complex_type'@@ -1845,31 +1845,6 @@ except ValidationError as exc: #> 'string_pattern_mismatch' ``` -## `string_sub_type`--This error is raised when the value is an instance of a strict subtype of `str` when the field is strict:--```python-from enum import Enum--from pydantic import BaseModel, Field, ValidationError---class MyEnum(str, Enum):- foo = 'foo'---class Model(BaseModel):- x: str = Field(strict=True)---try:- Model(x=MyEnum.foo)-except ValidationError as exc:- print(repr(exc.errors()[0]['type']))- #> 'string_sub_type'-```- ## `string_too_long` This error is raised when the input value is a string whose length is greater than the field's `max_length` constraint:tests/test_docs.pyindex 7c185657..41ebabf3 100644@@ -1,10 +1,14 @@ from __future__ import annotations as _annotations +import ast+import contextlib+import io import os import platform import re import subprocess import sys+import types from datetime import datetime from pathlib import Path from tempfile import NamedTemporaryFile@@ -207,6 +211,69 @@ def test_docs_examples(example: CodeExample, eval_example: EvalExample, tmp_path run_example(example, eval_example, mocker) +class _MarkExceptHandlers(ast.NodeTransformer):+ """Insert a call recording which `try` statement was handled as the first statement of every `except` handler."""++ def __init__(self, sentinel_name: str) -> None:+ self.sentinel_name = sentinel_name+ self.try_lines: list[int] = []++ def _visit_try(self, node: ast.Try | ast.TryStar) -> ast.AST:+ self.generic_visit(node)+ if node.handlers:+ self.try_lines.append(node.lineno)+ for handler in node.handlers:+ call = ast.parse(f'{self.sentinel_name}({node.lineno})').body[0]+ handler.body.insert(0, ast.copy_location(call, handler.body[0]))+ return node++ visit_Try = _visit_try+ visit_TryStar = _visit_try+++@pytest.mark.thread_unsafe+@pytest.mark.filterwarnings('ignore::DeprecationWarning')+@pytest.mark.skipif(bool(skip_reason), reason=skip_reason or 'not skipping')+@pytest.mark.parametrize(+ 'example', list(find_examples(str(DOCS_ROOT / 'errors'), skip=sys.platform == 'win32')), ids=str+)+def test_error_docs_examples_raise(example: CodeExample):+ """Every `try`/`except` in the error reference pages must actually enter its `except` branch.++ `run_print_check` only compares the output of `print` calls that run, so an example whose+ operation stopped raising would otherwise pass silently while documenting stale behavior.+ """+ prefix_settings = example.prefix_settings()+ if prefix_settings.get('test', '').startswith('skip'):+ pytest.skip('running code skipped')+ requires_settings = prefix_settings.get('requires')+ if requires_settings:+ major, minor = map(int, requires_settings.split('.'))+ if sys.version_info < (major, minor):+ pytest.skip(f'requires python {requires_settings}')++ sentinel_name = '__pydantic_docs_except_reached__'+ transformer = _MarkExceptHandlers(sentinel_name)+ tree = ast.fix_missing_locations(transformer.visit(ast.parse(example.source)))+ if not transformer.try_lines:+ pytest.skip('no try/except in example')++ reached: set[int] = set()+ module_name = f'docs_error_example_{example.start_line}'+ module = types.ModuleType(module_name)+ module.__dict__[sentinel_name] = reached.add+ sys.modules[module_name] = module+ try:+ with contextlib.redirect_stdout(io.StringIO()):+ exec(compile(tree, str(example.path), 'exec'), module.__dict__)+ finally:+ del sys.modules[module_name]++ example_line = example.start_line+ not_raised = [example_line + line for line in transformer.try_lines if line not in reached]+ assert not_raised == [], f'`except` branch never entered for the `try` at line(s) {not_raised} of {example.path}'++ @pytest.mark.thread_unsafe @pytest.mark.skipif(bool(skip_reason), reason=skip_reason or 'not skipping') @pytest.mark.skipif(sys.version_info >= (3, 13), reason='python-devtools does not yet support python 3.13')@@ -265,6 +332,7 @@ def test_validation_error_codes(): expected_validation_error_codes = set(core_schema.ErrorType.__args__) # Remove codes that are not currently accessible from pydantic: expected_validation_error_codes.remove('timezone_offset') # not currently exposed for configuration in pydantic+ expected_validation_error_codes.remove('string_sub_type') # no longer raised by any `str` validator test_failures = []
docs/concepts/experimental.mdindex cc349f3a0..ab1665260 100644@@ -342,7 +342,7 @@ class MyModel(BaseModel): ta = TypeAdapter(MyModel) try: v = ta.validate_json(- '{"a": 1, "b": ["12345", "12', experimental_allow_partial=True+ '{"a": 1, "b": ["12345", "12"', experimental_allow_partial=True ) except ValidationError as e: print(e)docs/errors/usage_errors.mdindex 7e28e9f82..3e6a67412 100644@@ -620,11 +620,13 @@ type C = B This error is raised when Pydantic fails to generate a JSON schema for some `CoreSchema`. ```python-from pydantic import BaseModel, ImportString, PydanticUserError+from collections.abc import Callable++from pydantic import BaseModel, PydanticUserError class Model(BaseModel):- a: ImportString+ a: Callable[..., object] try:docs/errors/validation_errors.mdindex 71d3a9292..95e240e70 100644@@ -233,7 +233,7 @@ class Model(BaseModel): try:- Model(num=False)+ Model(num='not a complex number') except ValidationError as exc: print(repr(exc.errors()[0]['type'])) #> 'complex_type'@@ -1845,31 +1845,6 @@ except ValidationError as exc: #> 'string_pattern_mismatch' ``` -## `string_sub_type`--This error is raised when the value is an instance of a strict subtype of `str` when the field is strict:--```python-from enum import Enum--from pydantic import BaseModel, Field, ValidationError---class MyEnum(str, Enum):- foo = 'foo'---class Model(BaseModel):- x: str = Field(strict=True)---try:- Model(x=MyEnum.foo)-except ValidationError as exc:- print(repr(exc.errors()[0]['type']))- #> 'string_sub_type'-```- ## `string_too_long` This error is raised when the input value is a string whose length is greater than the field's `max_length` constraint:pydantic-core/python/pydantic_core/core_schema.pyindex b6fce060b..fda0e35ee 100644@@ -4776,7 +4776,6 @@ ErrorType: TypeAlias = Literal[ 'iterable_type', 'iteration_error', 'string_type',- 'string_sub_type', 'string_unicode', 'string_too_short', 'string_too_long',pydantic-core/src/errors/types.rsindex 4bdb92135..f49f48509 100644@@ -247,7 +247,6 @@ error_types! { // --------------------- // string errors StringType {},- StringSubType {}, StringUnicode {}, StringTooShort { min_length: {ctx_type: usize, ctx_fn: field_from_context},@@ -533,7 +532,6 @@ impl ErrorType { Self::IterableType { .. } => "Input should be iterable", Self::IterationError { .. } => "Error iterating over object, error: {error}", Self::StringType { .. } => "Input should be a valid string",- Self::StringSubType { .. } => "Input should be a string, not an instance of a subclass of str", Self::StringUnicode { .. } => { "Input should be a valid string, unable to parse raw data as a unicode string" }pydantic-core/tests/test_errors.pyindex 66f15d81a..b024e618b 100644@@ -303,7 +303,6 @@ all_errors = [ {'field_type': 'Foobar', 'max_length': 42, 'actual_length': 50}, ), ('string_type', 'Input should be a valid string', None),- ('string_sub_type', 'Input should be a string, not an instance of a subclass of str', None), ('string_unicode', 'Input should be a valid string, unable to parse raw data as a unicode string', None), ('string_pattern_mismatch', "String should match pattern 'foo'", {'pattern': 'foo'}), ('string_not_ascii', 'String should contain only ASCII characters', None),