Backtestspydanticrun-20261027-165153#13661

Issue #13661 Merged fix PR #13668 Run 27 Oct 2026 · run-20261027-165153 pydantic/pydantic

Runtime by_name/by_alias arguments dropped by model_validator(mode="wrap")

Better

Our patch was judged better than the merged fix.

In this judgment, Patch A = our agent, Patch B = the merged fix.

The Rust change is identical in both patches: InternalValidator now captures extra.by_alias/by_name at construction and forwards them in both validate() and validate_assignment() instead of hardcoding None. This is the root cause (the wrap-validator handler and generator paths rebuilt Extra with the runtime flags discarded), and independent tests confirm both patches fix every scenario including JSON and nested models. The only difference is field placement (cosmetic) and tests. Patch A's tests exercise the issue's axis more completely: python/json/strings entry points for the wrap model validator, a wrap field validator around a nested model, validate_assignment (the second code path touched by the fix), and the Iterable/generator path that shares InternalValidator. Each of these would fail on base and pass after the fix. Patch B covers the model-wrap and field-wrap cases, but its second test checks context/strict/extra/from_attributes forwarding, which already worked before the change and so does not exercise the fix. B's test is adequate; A's is more targeted to the paths the diff actually modifies, including validate_assignment which B never tests. Narrow win for A on test coverage; correctness and scope are equal.

The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.

Solve

5m 21s

Wall-clock time in the container

Full test suite

No new failures

491 passed · 92 skipped · 583 total

Contamination audit

Clean

No sign the agent saw the real fix

Patch size

109vs 89 merged

Changed lines, ours vs merged

Initial Checks

  • I confirm that I'm using Pydantic V2

Description

The handler passed to a wrap-mode model validator appears to silently drop the passed-in by_name/by_alias arguments from the top-level validate_python methods.

Example Code

from typing import Self
from pydantic import BaseModel, TypeAdapter, ValidatorFunctionWrapHandler, model_validator

CFG = {"alias_generator": lambda s: s.replace("_", "-"), "validate_by_name": True}

class Plain(BaseModel):
    model_config = CFG
    build_depends: list[str] = []

class Wrapped(BaseModel):
    model_config = CFG
    build_depends: list[str] = []

    @model_validator(mode="wrap")
    @classmethod
    def _noop(cls, data, handler: ValidatorFunctionWrapHandler) -> Self:
        return handler(data)

data = {"build_depends": ["x"]}  # field name, not the alias
print(TypeAdapter(Plain).validate_python(data, by_alias=True, by_name=False))    # build_depends=[]    correct
print(TypeAdapter(Wrapped).validate_python(data, by_alias=True, by_name=False))  # build_depends=['x'] wrong

Python, Pydantic & OS Version

pydantic version: 2.13.4
        pydantic-core version: 2.46.4
          pydantic-core build: profile=release pgo=false
               python version: 3.14.6 (main, Jun 23 2026, 15:18:23) [Clang 22.1.3 ]
                     platform: Linux-6.18.33.2-microsoft-standard-WSL2-x86_64-with-glibc2.39
             related packages: typing_extensions-4.16.0
                       commit: unknown

The two patches

Our patch+104 −5
pydantic-core/src/validators/generator.rsindex 7529248d..702825c4 100644@@ -234,6 +234,8 @@ pub struct InternalValidator {     hide_input_in_errors: bool,     validation_error_cause: bool,     cache_str: jiter::StringCacheMode,+    by_alias: Option<bool>,+    by_name: Option<bool>, }  impl fmt::Debug for InternalValidator {@@ -268,6 +270,8 @@ impl InternalValidator {             hide_input_in_errors,             validation_error_cause,             cache_str: extra.cache_str,+            by_alias: extra.by_alias,+            by_name: extra.by_name,         }     } @@ -286,8 +290,8 @@ impl InternalValidator {             from_attributes: self.from_attributes,             context: self.context.as_ref().map(|data| data.bind(py)),             cache_str: self.cache_str,-            by_alias: None,-            by_name: None,+            by_alias: self.by_alias,+            by_name: self.by_name,         };         let mut state = ValidationState::new(             extra,@@ -329,8 +333,8 @@ impl InternalValidator {             from_attributes: self.from_attributes,             context: self.context.as_ref().map(|data| data.bind(py)),             cache_str: self.cache_str,-            by_alias: None,-            by_name: None,+            by_alias: self.by_alias,+            by_name: self.by_name,         };         let mut state = ValidationState::new(             extra,tests/test_validators.pyindex 0a5bc5f0..c01ec389 100644@@ -1,7 +1,8 @@ import contextlib+import json import re from collections import deque-from collections.abc import Callable+from collections.abc import Callable, Iterable from dataclasses import dataclass from datetime import date, datetime from enum import Enum@@ -3177,3 +3178,97 @@ def test_model_validate_json_default_value_validator_with_validation_info() -> N     f2 = Foo.model_validate_json('{"field1": 1}', context='context')      assert f1.field == f2.field == 2+++_BY_ALIAS_BY_NAME_CONFIG = ConfigDict(alias_generator=lambda s: s.replace('_', '-'), validate_by_name=True)+++class _WrappedModel(BaseModel):+    model_config = _BY_ALIAS_BY_NAME_CONFIG++    build_depends: list[str] = []++    @model_validator(mode='wrap')+    @classmethod+    def _noop(cls, data: Any, handler: ValidatorFunctionWrapHandler) -> Any:+        return handler(data)+++@pytest.mark.parametrize('mode', ['python', 'json', 'strings'])+def test_wrap_model_validator_respects_runtime_by_alias_by_name(mode: str) -> None:+    """https://github.com/pydantic/pydantic/issues/13661"""+    ta = TypeAdapter(_WrappedModel)+    if mode == 'python':+        validate = ta.validate_python+    elif mode == 'json':++        def validate(data: Any, **kwargs: Any) -> Any:+            return ta.validate_json(json.dumps(data), **kwargs)++    else:+        validate = ta.validate_strings++    by_name_data = {'build_depends': ['x']}+    by_alias_data = {'build-depends': ['x']}++    assert validate(by_name_data, by_alias=True, by_name=False).build_depends == []+    assert validate(by_alias_data, by_alias=True, by_name=False).build_depends == ['x']+    assert validate(by_name_data, by_alias=False, by_name=True).build_depends == ['x']+    assert validate(by_alias_data, by_alias=False, by_name=True).build_depends == []+++def test_wrap_field_validator_respects_runtime_by_alias_by_name() -> None:+    class Inner(BaseModel):+        model_config = _BY_ALIAS_BY_NAME_CONFIG++        some_value: int = 0++    class Outer(BaseModel):+        inner: Annotated[Inner, WrapValidator(lambda v, handler: handler(v))]++    assert Outer.model_validate({'inner': {'some_value': 1}}, by_alias=True, by_name=False).inner.some_value == 0+    assert Outer.model_validate({'inner': {'some-value': 1}}, by_alias=True, by_name=False).inner.some_value == 1+    assert Outer.model_validate({'inner': {'some_value': 1}}, by_alias=False, by_name=True).inner.some_value == 1+    assert Outer.model_validate({'inner': {'some-value': 1}}, by_alias=False, by_name=True).inner.some_value == 0+++def test_wrap_model_validator_assignment_respects_runtime_by_alias_by_name() -> None:+    class Inner(BaseModel):+        model_config = _BY_ALIAS_BY_NAME_CONFIG++        some_value: int = 0++    class Outer(BaseModel):+        inner: Inner = Inner()++        @model_validator(mode='wrap')+        @classmethod+        def _noop(cls, data: Any, handler: ValidatorFunctionWrapHandler) -> Any:+            return handler(data)++    validator = Outer.__pydantic_validator__++    m = Outer()+    validator.validate_assignment(m, 'inner', {'some_value': 1}, by_alias=True, by_name=False)+    assert m.inner.some_value == 0+    validator.validate_assignment(m, 'inner', {'some-value': 1}, by_alias=True, by_name=False)+    assert m.inner.some_value == 1+    validator.validate_assignment(m, 'inner', {'some-value': 2}, by_alias=False, by_name=True)+    assert m.inner.some_value == 0+    validator.validate_assignment(m, 'inner', {'some_value': 3}, by_alias=False, by_name=True)+    assert m.inner.some_value == 3+++def test_generator_respects_runtime_by_alias_by_name() -> None:+    class Inner(BaseModel):+        model_config = _BY_ALIAS_BY_NAME_CONFIG++        some_value: int = 0++    ta = TypeAdapter(Iterable[Inner])++    items = ta.validate_python([{'some_value': 1}, {'some-value': 2}], by_alias=True, by_name=False)+    assert [i.some_value for i in items] == [0, 2]++    items = ta.validate_python([{'some_value': 1}, {'some-value': 2}], by_alias=False, by_name=True)+    assert [i.some_value for i in items] == [1, 0] 
Merged fix · PR #13668+85 −4
pydantic-core/src/validators/generator.rsindex 7529248d3..a83527dfe 100644@@ -225,6 +225,8 @@ pub struct InternalValidator {     extra_behavior: Option<ExtraBehavior>,     from_attributes: Option<bool>,     context: Option<Py<PyAny>>,+    by_alias: Option<bool>,+    by_name: Option<bool>,     field_name: Option<Py<PyString>>,     self_instance: Option<Py<PyAny>>,     recursion_guard: RecursionState,@@ -259,6 +261,8 @@ impl InternalValidator {             extra_behavior: extra.extra_behavior,             from_attributes: extra.from_attributes,             context: extra.context.map(|d| d.clone().unbind()),+            by_alias: extra.by_alias,+            by_name: extra.by_name,             field_name: state.field_name().map(|d| d.clone().unbind()),             self_instance: state.self_instance.map(|d| d.clone().unbind()),             recursion_guard: state.recursion_guard.clone(),@@ -286,8 +290,8 @@ impl InternalValidator {             from_attributes: self.from_attributes,             context: self.context.as_ref().map(|data| data.bind(py)),             cache_str: self.cache_str,-            by_alias: None,-            by_name: None,+            by_alias: self.by_alias,+            by_name: self.by_name,         };         let mut state = ValidationState::new(             extra,@@ -329,8 +333,8 @@ impl InternalValidator {             from_attributes: self.from_attributes,             context: self.context.as_ref().map(|data| data.bind(py)),             cache_str: self.cache_str,-            by_alias: None,-            by_name: None,+            by_alias: self.by_alias,+            by_name: self.by_name,         };         let mut state = ValidationState::new(             extra,tests/test_validators.pyindex 0a5bc5f04..7e9f47137 100644@@ -3177,3 +3177,80 @@ def test_model_validate_json_default_value_validator_with_validation_info() -> N     f2 = Foo.model_validate_json('{"field1": 1}', context='context')      assert f1.field == f2.field == 2+++def test_wrap_validator_forwards_by_alias_by_name() -> None:+    """https://github.com/pydantic/pydantic/issues/13661"""++    class Inner(BaseModel):+        model_config = ConfigDict(validate_by_name=True)++        build_depends: list[str] = Field(default=[], alias='build-depends')++        @model_validator(mode='wrap')+        @classmethod+        def _wrap(cls, data: Any, handler: ValidatorFunctionWrapHandler) -> Any:+            return handler(data)++    class Outer(BaseModel):+        inner: Inner++        @field_validator('inner', mode='wrap')+        @classmethod+        def _wrap(cls, v: Any, handler: ValidatorFunctionWrapHandler) -> Any:+            return handler(v)++    by_name = {'build_depends': ['x']}+    by_alias = {'build-depends': ['x']}++    assert Inner.model_validate(by_name, by_alias=True, by_name=False).build_depends == []+    assert Inner.model_validate(by_alias, by_alias=True, by_name=False).build_depends == ['x']+    assert Inner.model_validate(by_name, by_alias=False, by_name=True).build_depends == ['x']+    assert Inner.model_validate(by_alias, by_alias=False, by_name=True).build_depends == []++    assert Outer.model_validate({'inner': by_name}, by_alias=True, by_name=False).inner.build_depends == []+    assert Outer.model_validate({'inner': by_alias}, by_alias=False, by_name=True).inner.build_depends == []+++def test_wrap_validator_forwards_runtime_settings() -> None:+    class Inner(BaseModel):+        a: int++        @model_validator(mode='wrap')+        @classmethod+        def _wrap(cls, data: Any, handler: ValidatorFunctionWrapHandler, info: ValidationInfo) -> Any:+            assert info.context == 'ctx'+            return handler(data)++        @field_validator('a', mode='wrap')+        @classmethod+        def _wrap_a(cls, v: Any, handler: ValidatorFunctionWrapHandler, info: ValidationInfo) -> Any:+            assert info.context == 'ctx'+            return handler(v)++    class Outer(BaseModel):+        inner: Inner++        @field_validator('inner', mode='wrap')+        @classmethod+        def _wrap(cls, v: Any, handler: ValidatorFunctionWrapHandler) -> Any:+            return handler(v)++    # strict:+    assert Outer.model_validate({'inner': {'a': '1'}}, context='ctx').inner.a == 1+    with pytest.raises(ValidationError, match='Input should be a valid integer'):+        Outer.model_validate({'inner': {'a': '1'}}, strict=True, context='ctx')++    # extra:+    m = Outer.model_validate({'inner': {'a': 1, 'b': 2}}, extra='allow', context='ctx')+    assert m.inner.model_extra == {'b': 2}+    with pytest.raises(ValidationError, match='Extra inputs are not permitted'):+        Outer.model_validate({'inner': {'a': 1, 'b': 2}}, extra='forbid', context='ctx')++    # from_attributes:+    class InnerObj:+        a = 1++    with pytest.raises(ValidationError, match='Input should be a valid dictionary'):+        Outer.model_validate({'inner': InnerObj()}, context='ctx')+    assert Outer.model_validate({'inner': InnerObj()}, from_attributes=True, context='ctx').inner.a == 1