Backtestsvuerun-20261002-115633#10505

Issue #10505 Merged fix PR #15298 Run 2 Oct 2026 · run-20261002-115633 vuejs/core

Clearing select's value in change handler behaviour changed since 3.4.15 via webdriver

Worse

The merged fix was judged better than our patch.

In this judgment, Patch B = our agent, Patch A = the merged fix.

Both patches fix the root cause the same way. They replace the blanket `_assigning` flag, which skipped `setSelected` for the whole tick, with a snapshot of the value just assigned from the DOM. `updated` then re-syncs the DOM whenever the model differs from that snapshot. So a `@change` handler that sets the model to null now clears the select in both patches, and both add tests that fail before the change and pass after it.

The difference is in the edge cases, where Patch A holds up better:

1. **Snapshot timing.** Patch B snapshots `selectedVal.slice()` after calling the assigner. For Array models the user's `onUpdate:modelValue` receives `selectedVal` itself and may mutate it synchronously. Patch B's snapshot then records the mutated array, matches the (same) mutated model, and skips the re-sync, leaving the DOM stale. Patch A computes and snapshots before calling the assigner, and has a test for exactly this case.
2. **Multiple flag changes.** Patch A records `el.multiple` at assign time and re-syncs if it changed before `updated`. Patch B compares using the current `el.multiple` against a snapshot taken under the old mode.
3. **Throwing assigner.** Patch A wraps the assigner in try/finally so the pending marker is still cleared if the assigner throws.
4. **Repeated updates.** Patch A consumes the pending value in `updated`, so a second update in the same tick always re-syncs. Patch B keeps reusing the stale snapshot until nextTick.

On tests, Patch B's are more directly focused on the issue's variants: null reset, setting another value, Array reset and mutation, and Set reset. Patch A includes the core issue test plus many edge-case tests; a few (counting writes to `selected`) are more about performance and are somewhat tangential.

The code footprint is similar in both. Patch A is the more robust fix overall.

The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.

Solve

7m 20s

Wall-clock time in the container

Full test suite

No new failures

3,684 passed · 6 skipped · 3,690 total

Contamination audit

Clean

No sign the agent saw the real fix

Patch size

241vs 345 merged

Changed lines, ours vs merged

Vue version

3.4.21

Link to minimal reproduction

https://play.vuejs.org/#eNp9Uk1P4zAQ/SuzvtBKkO5q91SllXYRh+VAEXACc4iSSWtwbMsfoVLIf2ds00IRkEMSz3sz8+Z5BvbXmKIPyOas9NgZWXlccgVQOpRYe+hPOt2gXHCWA0IrziJh9/QnWs3rTaXWSCT6NhJX6jQFOEu1qJo2MRP6SoZI+0nILVpdzjLwBe0X0VYKD1jlLAvJB0P9W22jPBAKMoQN5Q0DOBjHcmaIWc7eDUdHV1thPEgSSanecUapPkSq6Iy2Hgaw2MIIrdUdHJFDRzGx1sr51y5R6CKySuetUGt4BhWkXE7ie3rIxeaAene/nNzdE4erNqhc6tA5mEzn0GvRwBDnFC1M9l2LZA/8WCxSw2mmwL5VxgsT3OZjErUEGOPrY7VciysCyeFkz5IdkzU0RivWxYPTipYkteKs1p0REu0q3QvZN9+J4KySUj+dp5i3AY938XqD9eMn8Qe3jTHOLi06tD1tzR7zlV2jz/DZ9QVu6X8P0mIGSexvwCt0Woa8tJH2L0ST7TteUvs/3TldzI0723pUbjdUFJosS3zOaA9Ovxn9Te7v4s+r1SMbXwCvMCS3

Steps to reproduce

👋 sorry I can only reproduce this myself when acting on chrome with webdriver, but I have narrowed it down a lot

the basic premise is we have a strange select that clears its value on change, exampled in the repo link

The bug occurs when _webdriver_ clicks the select and clicks one of the options within the value does not get cleared afterwards. If I click in the page myself it clears properly.

What is expected?

The value of the select afterwards should be null

What is actually happening?

it is whatever was selected last, ie 0 or 1

System Info

System:
    OS: Linux 5.15 Ubuntu 20.04.6 LTS (Focal Fossa)
    CPU: (32) x64 AMD Ryzen 9 5950X 16-Core Processor
    Memory: 55.80 GB / 88.39 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 18.16.1 - ~/.nvm/versions/node/v18.16.1/bin/node
    npm: 9.5.1 - ~/.nvm/versions/node/v18.16.1/bin/npm
  Browsers:
    Chrome: 122.0.6261.94

Any additional comments?

I have bisected the releases and found that this first happens from 3.4.15. I suspect the change is related to the select performance improvement https://github.com/vuejs/core/commit/2ffb956efe692da059f4895669084c5278871351

further i notice the commit introduces and _assigning field which changes the behaviour until the next tick. and wrapping the clearing call in nextTick works as a workaround in my instance.

  nextTick(() => { selection.value = null })

I suspect the issue relates to the fact that webdriver submits selection events in a slightly unusual manner. However I think that shouldn't mean this broke but it has

The two patches

Our patch+237 −4
packages/runtime-dom/__tests__/directives/vModel.spec.tsindex 590c0d7df..8fbbb3c89 100644@@ -1009,6 +1009,212 @@ describe('vModel', () => {     expect(bar.selected).toEqual(true)   }) +  it('single select should sync DOM when change handler resets model', async () => {+    const component = defineComponent({+      data() {+        return { value: null as string | null }+      },+      render() {+        return [+          withVModel(+            h(+              'select',+              {+                'onUpdate:modelValue': setValue.bind(this),+                onChange: () => {+                  this.value = null+                },+              },+              [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+            ),+            this.value,+          ),+        ]+      },+    })+    render(h(component), root)++    const input = root.querySelector('select')+    const foo = root.querySelector('option[value=foo]')+    const bar = root.querySelector('option[value=bar]')+    const data = root._vnode.component.data++    foo.selected = true+    triggerEvent('change', input)+    await nextTick()+    expect(data.value).toBe(null)+    expect(input.selectedIndex).toBe(-1)+    expect(foo.selected).toBe(false)+    expect(bar.selected).toBe(false)++    bar.selected = true+    triggerEvent('change', input)+    await nextTick()+    expect(data.value).toBe(null)+    expect(input.selectedIndex).toBe(-1)+    expect(foo.selected).toBe(false)+    expect(bar.selected).toBe(false)+  })++  it('single select should sync DOM when change handler sets another value', async () => {+    const component = defineComponent({+      data() {+        return { value: null as string | null }+      },+      render() {+        return [+          withVModel(+            h(+              'select',+              {+                'onUpdate:modelValue': setValue.bind(this),+                onChange: () => {+                  this.value = 'bar'+                },+              },+              [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+            ),+            this.value,+          ),+        ]+      },+    })+    render(h(component), root)++    const input = root.querySelector('select')+    const foo = root.querySelector('option[value=foo]')+    const bar = root.querySelector('option[value=bar]')+    const data = root._vnode.component.data++    foo.selected = true+    triggerEvent('change', input)+    await nextTick()+    expect(data.value).toBe('bar')+    expect(input.value).toBe('bar')+    expect(foo.selected).toBe(false)+    expect(bar.selected).toBe(true)+  })++  it('multiple select (model is Array) should sync DOM when change handler resets model', async () => {+    const component = defineComponent({+      data() {+        return { value: [] as string[] }+      },+      render() {+        return [+          withVModel(+            h(+              'select',+              {+                multiple: true,+                'onUpdate:modelValue': setValue.bind(this),+                onChange: () => {+                  this.value = []+                },+              },+              [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+            ),+            this.value,+          ),+        ]+      },+    })+    render(h(component), root)++    const input = root.querySelector('select')+    const foo = root.querySelector('option[value=foo]')+    const bar = root.querySelector('option[value=bar]')+    const data = root._vnode.component.data++    foo.selected = true+    bar.selected = true+    triggerEvent('change', input)+    await nextTick()+    expect(data.value).toMatchObject([])+    expect(foo.selected).toBe(false)+    expect(bar.selected).toBe(false)+  })++  it('multiple select (model is Array) should sync DOM when change handler mutates model', async () => {+    const component = defineComponent({+      data() {+        return { value: [] as string[] }+      },+      render() {+        return [+          withVModel(+            h(+              'select',+              {+                multiple: true,+                'onUpdate:modelValue': setValue.bind(this),+                onChange: () => {+                  this.value.splice(0)+                },+              },+              [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+            ),+            this.value,+          ),+        ]+      },+    })+    render(h(component), root)++    const input = root.querySelector('select')+    const foo = root.querySelector('option[value=foo]')+    const bar = root.querySelector('option[value=bar]')+    const data = root._vnode.component.data++    foo.selected = true+    bar.selected = true+    triggerEvent('change', input)+    await nextTick()+    expect(data.value).toMatchObject([])+    expect(foo.selected).toBe(false)+    expect(bar.selected).toBe(false)+  })++  it('multiple select (model is Set) should sync DOM when change handler resets model', async () => {+    const component = defineComponent({+      data() {+        return { value: new Set<string>() }+      },+      render() {+        return [+          withVModel(+            h(+              'select',+              {+                multiple: true,+                'onUpdate:modelValue': setValue.bind(this),+                onChange: () => {+                  this.value = new Set()+                },+              },+              [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+            ),+            this.value,+          ),+        ]+      },+    })+    render(h(component), root)++    const input = root.querySelector('select')+    const foo = root.querySelector('option[value=foo]')+    const bar = root.querySelector('option[value=bar]')+    const data = root._vnode.component.data++    foo.selected = true+    triggerEvent('change', input)+    await nextTick()+    expect(data.value).toBeInstanceOf(Set)+    expect(data.value.size).toBe(0)+    expect(foo.selected).toBe(false)+    expect(bar.selected).toBe(false)+  })+   it('multiple select (model is Array)', async () => {     const component = defineComponent({       data() {packages/runtime-dom/src/directives/vModel.tsindex eeb248f28..203e5d83d 100644@@ -44,7 +44,7 @@ type ModelDirective<T, Modifiers extends string = string> = ObjectDirective<   T & {     [assignKey]: AssignerFn     [initialValueKey]?: string-    _assigning?: boolean+    _assignedValues?: any[]   },   any,   Modifiers@@ -247,9 +247,12 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = {             : selectedVal           : selectedVal[0],       )-      el._assigning = true+      // snapshot the selection the DOM already reflects so the next update can+      // skip re-syncing it, while model changes made later in the same tick+      // (e.g. by a user @change handler) are still applied to the DOM+      el._assignedValues = selectedVal.slice()       nextTick(() => {-        el._assigning = false+        el._assignedValues = undefined       })     })     el[assignKey] = getModelAssigner(vnode)@@ -264,12 +267,36 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = {     el[assignKey] = getModelAssigner(vnode)   },   updated(el, { value }) {-    if (!el._assigning) {+    const assignedValues = el._assignedValues+    if (+      !assignedValues ||+      !isSelectedState(value, assignedValues, el.multiple)+    ) {       setSelected(el, value)     }   }, } +// check whether a model value matches the selected option values the DOM+// already reflects, in which case the DOM does not need to be re-synced+function isSelectedState(+  value: any,+  selectedVal: any[],+  isMultiple: boolean,+): boolean {+  if (!isMultiple) {+    return looseEqual(value, selectedVal[0])+  }+  if (isSet(value)) {+    if (value.size !== selectedVal.length) return false+    for (let i = 0; i < selectedVal.length; i++) {+      if (!value.has(selectedVal[i])) return false+    }+    return true+  }+  return isArray(value) && looseEqual(value, selectedVal)+}+ function setSelected(el: HTMLSelectElement, value: any) {   const isMultiple = el.multiple   const isArrayValue = isArray(value) 
Merged fix · PR #15298+333 −12
packages/runtime-dom/__tests__/directives/vModel.spec.tsindex 590c0d7df..429163126 100644@@ -1317,6 +1317,290 @@ describe('vModel', () => {     expect(bar.selected).toEqual(true)   }) +  function mountSelectModel(+    initialValue: any,+    update: (value: any) => any,+    multiple = false,+    optionValues: any[] = ['foo', 'bar'],+  ) {+    const component = defineComponent({+      data: () => ({ value: initialValue }),+      render() {+        return withVModel(+          h(+            'select',+            {+              multiple,+              'onUpdate:modelValue': (value: any) => {+                this.value = update(value)+              },+            },+            optionValues.map(value => h('option', { value })),+          ),+          this.value,+        )+      },+    })+    render(h(component), root)+    const input = root.querySelector('select') as HTMLSelectElement+    return { input, options: input.options, data: root._vnode.component.data }+  }++  function trackSelectedWrites(input: HTMLSelectElement) {+    const selected = Object.getOwnPropertyDescriptor(+      HTMLOptionElement.prototype,+      'selected',+    )!+    let writes = 0+    for (const option of input.options) {+      Object.defineProperty(option, 'selected', {+        configurable: true,+        get: selected.get,+        set(value) {+          writes+++          selected.set!.call(this, value)+        },+      })+    }+    return () => writes+  }++  it('should sync a multiple select when the Set model is overridden', async () => {+    const { input, options, data } = mountSelectModel(+      new Set<string>(),+      () => new Set(['foo']),+      true,+    )+    const foo = options[0]+    const bar = options[1]++    bar.selected = true+    triggerEvent('change', input)+    await nextTick()++    expect(Array.from(data.value)).toEqual(['foo'])+    expect(foo.selected).toBe(true)+    expect(bar.selected).toBe(false)+  })++  it('should clear a single select when a native change handler clears the model', async () => {+    const component = defineComponent({+      data() {+        return { value: null as string | null }+      },+      render() {+        return withVModel(+          h(+            'select',+            {+              'onUpdate:modelValue': setValue.bind(this),+              onChange: () => {+                this.value = null+              },+            },+            [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+          ),+          this.value,+        )+      },+    })+    render(h(component), root)+    const input = root.querySelector('select') as HTMLSelectElement+    const data = root._vnode.component.data++    input.options[1].selected = true+    triggerEvent('change', input)+    await nextTick()++    expect(data.value).toBe(null)+    expect(input.selectedIndex).toBe(-1)+  })++  it('should preserve the selected option when duplicate values exist', async () => {+    const { input, options, data } = mountSelectModel(+      null,+      value => value,+      false,+      ['foo', 'foo'],+    )++    options[1].selected = true+    triggerEvent('change', input)+    await nextTick()++    expect(data.value).toBe('foo')+    expect(input.selectedIndex).toBe(1)+  })++  it('should resync when a multiple select becomes single during the pending update', async () => {+    const component = defineComponent({+      data() {+        return { value: [] as string[], multiple: true }+      },+      render() {+        return withVModel(+          h(+            'select',+            {+              multiple: this.multiple,+              'onUpdate:modelValue': (value: string[]) => {+                this.value = value+                this.multiple = false+              },+            },+            [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+          ),+          this.value,+        )+      },+    })+    render(h(component), root)+    const input = root.querySelector('select') as HTMLSelectElement+    const data = root._vnode.component.data++    input.options[1].selected = true+    triggerEvent('change', input)+    await nextTick()++    expect(data.value).toEqual(['bar'])+    expect(input.multiple).toBe(false)+    expect(input.selectedIndex).toBe(-1)+  })++  it('should snapshot an emitted Array before the change handler mutates it', async () => {+    const { input, options, data } = mountSelectModel(+      ['foo'],+      (value: string[]) => {+        value.pop()+        return value+      },+      true,+    )+    const foo = options[0]+    const bar = options[1]++    foo.selected = true+    bar.selected = true+    triggerEvent('change', input)+    await nextTick()++    expect(data.value).toEqual(['foo'])+    expect(foo.selected).toBe(true)+    expect(bar.selected).toBe(false)+  })++  it('should resync after the emitted Set is mutated in the change handler', async () => {+    const { input, options, data } = mountSelectModel(+      new Set(['foo']),+      (value: Set<string>) => {+        value.delete('bar')+        return value+      },+      true,+    )+    const foo = options[0]+    const bar = options[1]++    foo.selected = true+    bar.selected = true+    triggerEvent('change', input)+    await nextTick()++    expect(Array.from(data.value)).toEqual(['foo'])+    expect(foo.selected).toBe(true)+    expect(bar.selected).toBe(false)+  })++  it('should not rewrite options after assigning a Set of objects', async () => {+    const fooValue = { id: 'foo' }+    const barValue = { id: 'bar' }+    const { input, options } = mountSelectModel(+      new Set([fooValue]),+      value => value,+      true,+      [fooValue, barValue],+    )++    options[0].selected = false+    options[1].selected = true+    const getWrites = trackSelectedWrites(input)+    triggerEvent('change', input)+    await nextTick()++    expect(getWrites()).toBe(0)+  })++  it('should not rewrite options after assigning an Array of objects', async () => {+    const fooValue = { id: 'foo' }+    const barValue = { id: 'bar' }+    const { input, options } = mountSelectModel([], value => value, true, [+      fooValue,+      barValue,+    ])++    options[1].selected = true+    const getWrites = trackSelectedWrites(input)+    triggerEvent('change', input)+    await nextTick()++    expect(getWrites()).toBe(0)+  })++  it('should not rewrite options for a primitive Array model', async () => {+    const optionValues = Array.from({ length: 10 }, (_, i) => i)+    const { input, options, data } = mountSelectModel(+      [],+      value => value,+      true,+      optionValues,+    )++    for (let i = 0; i < 5; i++) options[i].selected = true+    const getWrites = trackSelectedWrites(input)+    triggerEvent('change', input)+    await nextTick()++    expect(data.value).toHaveLength(5)+    expect(getWrites()).toBe(0)+  })++  it('should clear the pending assignment when the assigner throws', async () => {+    const error = new Error('assign failed')+    const component = defineComponent({+      data: () => ({ value: [] }),+      render() {+        return withVModel(+          h(+            'select',+            {+              multiple: true,+              'onUpdate:modelValue': () => {+                throw error+              },+            },+            [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+          ),+          this.value,+        )+      },+    })+    render(h(component), root)+    const input = root.querySelector('select') as HTMLSelectElement+    const onError = vi.fn((event: ErrorEvent) => event.preventDefault())+    window.addEventListener('error', onError)++    try {+      input.options[1].selected = true+      triggerEvent('change', input)+      await nextTick()++      expect(onError).toHaveBeenCalled()+      expect((input as any)._pendingValue).toBeUndefined()+    } finally {+      window.removeEventListener('error', onError)+    }+  })+   it('multiple select uses current Array/Set model type', async () => {     const component = defineComponent({       data() {packages/runtime-dom/src/directives/vModel.tsindex eeb248f28..041f17c5a 100644@@ -44,7 +44,7 @@ type ModelDirective<T, Modifiers extends string = string> = ObjectDirective<   T & {     [assignKey]: AssignerFn     [initialValueKey]?: string-    _assigning?: boolean+    _pendingValue?: [multiple: boolean, value: any]   },   any,   Modifiers@@ -240,17 +240,31 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = {         .map((o: HTMLOptionElement) =>           number ? looseToNumber(getValue(o)) : getValue(o),         )-      el[assignKey](-        el.multiple-          ? isSet((el as any)._modelValue)-            ? new Set(selectedVal)+      const multiple = el.multiple+      const assignedValue = multiple+        ? isSet((el as any)._modelValue)+          ? new Set(selectedVal)+          : selectedVal+        : selectedVal[0]+      // Array models receive selectedVal directly, so snapshot it before user+      // code can mutate it. Set models already receive a fresh Set.+      const pending = (el._pendingValue = [+        multiple,+        multiple+          ? isArray(assignedValue)+            ? selectedVal.slice()             : selectedVal-          : selectedVal[0],-      )-      el._assigning = true-      nextTick(() => {-        el._assigning = false-      })+          : assignedValue,+      ])+      try {+        el[assignKey](assignedValue)+      } finally {+        nextTick(() => {+          if (el._pendingValue === pending) {+            el._pendingValue = undefined+          }+        })+      }     })     el[assignKey] = getModelAssigner(vnode)   },@@ -264,12 +278,35 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = {     el[assignKey] = getModelAssigner(vnode)   },   updated(el, { value }) {-    if (!el._assigning) {+    const pending = el._pendingValue+    el._pendingValue = undefined+    if (+      !pending ||+      pending[0] !== el.multiple ||+      !isSameSelectValue(value, pending[1], pending[0])+    ) {       setSelected(el, value)     }   }, } +function isSameSelectValue(+  value: any,+  assignedValue: any,+  multiple: boolean,+): boolean {+  if (!multiple) return looseEqual(value, assignedValue)+  if (isArray(value)) return looseEqual(value, assignedValue)+  if (isSet(value)) {+    if (value.size !== assignedValue.length) return false+    for (const item of assignedValue) {+      if (!value.has(item)) return false+    }+    return true+  }+  return false+}+ function setSelected(el: HTMLSelectElement, value: any) {   const isMultiple = el.multiple   const isArrayValue = isArray(value)