Backtestsvuerun-20261002-115633#15009
v-model on <select multiple> uses stale collection type after switching between Array and Set
Our patch was judged better than the merged fix.
In this judgment, Patch B = our agent, Patch A = the merged fix.
The production code changes are functionally identical. Both remove the `isSetModel` value captured at `created` time and store the current binding value on `el._modelValue`. They set it in `created` and refresh it in `beforeUpdate`, so the change listener checks `isSet(...)` against the current model. Both fix the root cause described in the issue. The only source difference is that B adds a short explanatory comment, a minor craft plus. The difference is in the tests. Patch A uses a single test that starts with an Array, switches to a Set, then switches back to an Array. Only the first switch exercises the bug. The originally captured type was Array, so the Set→Array leg would pass even without the fix, and the reverse direction is never really tested. Patch B adds two separate tests: one starting with an Array that switches to a Set, and one starting with a Set that switches to an Array. Each would fail before the fix, so both directions the issue reports are genuinely covered. B also asserts that option selection syncs correctly after the switch, and that the type is right on an interaction before the switch. B's tests are therefore stronger regression coverage for the reported scenarios.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
6m 27s
Wall-clock time in the container
Full test suite
No new failures
3,609 passed · 6 skipped · 3,615 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
101vs 55 merged
Changed lines, ours vs merged
The issue
View on GitHubVue version
3.5.39
Link to minimal reproduction
Steps to reproduce
- Bind a
<select multiple v-model>to an Array. - Switch the bound value to a Set at runtime.
- Interact with the select again.
- The emitted model becomes an Array again.
- Switching back from Set -> Array shows the same stale-type behavior in reverse.
What is expected?
The current collection type should be respected after the model switches at runtime.
What is actually happening?
The change handler keeps using the collection type captured when the directive was created, so the first user interaction after a runtime Array/Set switch emits the old type.
System Info
Any additional comments?
_No response_
The two patches
packages/runtime-dom/__tests__/directives/vModel.spec.tsindex 2b78b0c61..017230dbc 100644@@ -1317,6 +1317,98 @@ describe('vModel', () => { expect(bar.selected).toEqual(true) }) + it('multiple select (model switches from Array to Set)', async () => {+ const component = defineComponent({+ data() {+ return { value: [] as any }+ },+ render() {+ return [+ withVModel(+ h(+ 'select',+ {+ value: null,+ multiple: true,+ 'onUpdate:modelValue': setValue.bind(this),+ },+ [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+ ),+ this.value,+ ),+ ]+ },+ })+ render(h(component), root)++ const input = root.querySelector('select')+ const foo = root.querySelector('option[value=foo]')+ const bar = root.querySelector('option[value=bar]')+ const data = root._vnode.component.data++ foo.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(data.value).toBeInstanceOf(Array)++ data.value = new Set(['bar'])+ await nextTick()+ expect(foo.selected).toEqual(false)+ expect(bar.selected).toEqual(true)++ foo.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(data.value).toBeInstanceOf(Set)+ expect(data.value).toMatchObject(new Set(['foo', 'bar']))+ })++ it('multiple select (model switches from Set to Array)', async () => {+ const component = defineComponent({+ data() {+ return { value: new Set() as any }+ },+ render() {+ return [+ withVModel(+ h(+ 'select',+ {+ value: null,+ multiple: true,+ 'onUpdate:modelValue': setValue.bind(this),+ },+ [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+ ),+ this.value,+ ),+ ]+ },+ })+ render(h(component), root)++ const input = root.querySelector('select')+ const foo = root.querySelector('option[value=foo]')+ const bar = root.querySelector('option[value=bar]')+ const data = root._vnode.component.data++ foo.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(data.value).toBeInstanceOf(Set)++ data.value = ['bar']+ await nextTick()+ expect(foo.selected).toEqual(false)+ expect(bar.selected).toEqual(true)++ foo.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(data.value).toBeInstanceOf(Array)+ expect(data.value).toMatchObject(['foo', 'bar'])+ })+ it('multiple select (model is Set, option value is object)', async () => { const fooValue = { foo: 1 } const barValue = { bar: 1 }packages/runtime-dom/src/directives/vModel.tsindex b49bf809e..269f0043b 100644@@ -207,7 +207,9 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { // <select multiple> value need to be deep traversed deep: true, created(el, { value, modifiers: { number } }, vnode) {- const isSetModel = isSet(value)+ // store the v-model value on the element so the change listener emits+ // the collection type (Array / Set) of the current binding.+ ;(el as any)._modelValue = value addEventListener(el, 'change', () => { const selectedVal = Array.prototype.filter .call(el.options, (o: HTMLOptionElement) => o.selected)@@ -216,7 +218,7 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { ) el[assignKey]( el.multiple- ? isSetModel+ ? isSet((el as any)._modelValue) ? new Set(selectedVal) : selectedVal : selectedVal[0],@@ -233,7 +235,8 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { mounted(el, { value }) { setSelected(el, value) },- beforeUpdate(el, _binding, vnode) {+ beforeUpdate(el, { value }, vnode) {+ ;(el as any)._modelValue = value el[assignKey] = getModelAssigner(vnode) }, updated(el, { value }) {
packages/runtime-dom/__tests__/directives/vModel.spec.tsindex 2b78b0c61..590c0d7df 100644@@ -1317,6 +1317,54 @@ describe('vModel', () => { expect(bar.selected).toEqual(true) }) + it('multiple select uses current Array/Set model type', async () => {+ const component = defineComponent({+ data() {+ return { value: [] }+ },+ render() {+ return [+ withVModel(+ h(+ 'select',+ {+ value: null,+ multiple: true,+ 'onUpdate:modelValue': setValue.bind(this),+ },+ [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+ ),+ this.value,+ ),+ ]+ },+ })+ render(h(component), root)++ const input = root.querySelector('select')+ const foo = root.querySelector('option[value=foo]')+ const bar = root.querySelector('option[value=bar]')+ const data = root._vnode.component.data++ data.value = new Set(['foo'])+ await nextTick()+ foo.selected = true+ bar.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(data.value).toBeInstanceOf(Set)+ expect(data.value).toMatchObject(new Set(['foo', 'bar']))++ data.value = ['foo']+ await nextTick()+ foo.selected = false+ bar.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(Array.isArray(data.value)).toBe(true)+ expect(data.value).toMatchObject(['bar'])+ })+ it('multiple select (model is Set, option value is object)', async () => { const fooValue = { foo: 1 } const barValue = { bar: 1 }packages/runtime-dom/src/directives/vModel.tsindex b49bf809e..766db6bfe 100644@@ -207,7 +207,7 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { // <select multiple> value need to be deep traversed deep: true, created(el, { value, modifiers: { number } }, vnode) {- const isSetModel = isSet(value)+ ;(el as any)._modelValue = value addEventListener(el, 'change', () => { const selectedVal = Array.prototype.filter .call(el.options, (o: HTMLOptionElement) => o.selected)@@ -216,7 +216,7 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { ) el[assignKey]( el.multiple- ? isSetModel+ ? isSet((el as any)._modelValue) ? new Set(selectedVal) : selectedVal : selectedVal[0],@@ -233,7 +233,8 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { mounted(el, { value }) { setSelected(el, value) },- beforeUpdate(el, _binding, vnode) {+ beforeUpdate(el, { value }, vnode) {+ ;(el as any)._modelValue = value el[assignKey] = getModelAssigner(vnode) }, updated(el, { value }) {