Backtestsvuerun-20261003-231210#15009
v-model on <select multiple> uses stale collection type after switching between Array and Set
Our patch was judged better than the merged fix.
In this judgment, Patch B = our agent, Patch A = the merged fix.
The source changes are functionally identical. Both remove the `isSetModel` value captured once in `created`. Both store the current binding value on the element in `created` and refresh it in `beforeUpdate`, so the change handler checks `isSet` against the latest model and the root cause is fixed either way. The difference is in the tests. Patch A has one test that starts from an Array, switches to a Set, then back to an Array. It would fail before the fix and does cover both directions. Patch B has two separate tests, one starting from an Array and one starting from a Set. Each first confirms the initial type is emitted correctly. Each then switches type and checks that the DOM selection follows the new model (`foo.selected` false, `bar.selected` true) before checking the emitted type. Starting from a Set exercises the reverse stale case from the creation-time type, which is exactly what the issue describes. Patch B also adds a short comment explaining why the value is stored on the element. Both patches are tightly scoped. B wins narrowly on test coverage and clarity.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
3m 20s
Wall-clock time in the container
Full test suite
No new failures
3,609 passed · 6 skipped · 3,615 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
103vs 55 merged
Changed lines, ours vs merged
The issue
View on GitHubVue version
3.5.39
Link to minimal reproduction
Steps to reproduce
- Bind a
<select multiple v-model>to an Array. - Switch the bound value to a Set at runtime.
- Interact with the select again.
- The emitted model becomes an Array again.
- Switching back from Set -> Array shows the same stale-type behavior in reverse.
What is expected?
The current collection type should be respected after the model switches at runtime.
What is actually happening?
The change handler keeps using the collection type captured when the directive was created, so the first user interaction after a runtime Array/Set switch emits the old type.
System Info
Any additional comments?
_No response_
The two patches
packages/runtime-dom/__tests__/directives/vModel.spec.tsindex 2b78b0c61..262ea581c 100644@@ -1317,6 +1317,100 @@ describe('vModel', () => { expect(bar.selected).toEqual(true) }) + it('multiple select (model switches from Array to Set)', async () => {+ const component = defineComponent({+ data() {+ return { value: [] as any }+ },+ render() {+ return [+ withVModel(+ h(+ 'select',+ {+ value: null,+ multiple: true,+ 'onUpdate:modelValue': setValue.bind(this),+ },+ [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+ ),+ this.value,+ ),+ ]+ },+ })+ render(h(component), root)++ const input = root.querySelector('select')+ const foo = root.querySelector('option[value=foo]')+ const bar = root.querySelector('option[value=bar]')+ const data = root._vnode.component.data++ foo.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(data.value).toBeInstanceOf(Array)+ expect(data.value).toMatchObject(['foo'])++ data.value = new Set(['bar'])+ await nextTick()+ expect(foo.selected).toEqual(false)+ expect(bar.selected).toEqual(true)++ foo.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(data.value).toBeInstanceOf(Set)+ expect(data.value).toMatchObject(new Set(['foo', 'bar']))+ })++ it('multiple select (model switches from Set to Array)', async () => {+ const component = defineComponent({+ data() {+ return { value: new Set() as any }+ },+ render() {+ return [+ withVModel(+ h(+ 'select',+ {+ value: null,+ multiple: true,+ 'onUpdate:modelValue': setValue.bind(this),+ },+ [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+ ),+ this.value,+ ),+ ]+ },+ })+ render(h(component), root)++ const input = root.querySelector('select')+ const foo = root.querySelector('option[value=foo]')+ const bar = root.querySelector('option[value=bar]')+ const data = root._vnode.component.data++ foo.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(data.value).toBeInstanceOf(Set)+ expect(data.value).toMatchObject(new Set(['foo']))++ data.value = ['bar']+ await nextTick()+ expect(foo.selected).toEqual(false)+ expect(bar.selected).toEqual(true)++ foo.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(data.value).toBeInstanceOf(Array)+ expect(data.value).toMatchObject(['foo', 'bar'])+ })+ it('multiple select (model is Set, option value is object)', async () => { const fooValue = { foo: 1 } const barValue = { bar: 1 }packages/runtime-dom/src/directives/vModel.tsindex b49bf809e..e2844f7a2 100644@@ -207,7 +207,9 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { // <select multiple> value need to be deep traversed deep: true, created(el, { value, modifiers: { number } }, vnode) {- const isSetModel = isSet(value)+ // store the v-model value on the element so the change listener emits+ // the current collection type (Array or Set), even if it changes later.+ ;(el as any)._modelValue = value addEventListener(el, 'change', () => { const selectedVal = Array.prototype.filter .call(el.options, (o: HTMLOptionElement) => o.selected)@@ -216,7 +218,7 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { ) el[assignKey]( el.multiple- ? isSetModel+ ? isSet((el as any)._modelValue) ? new Set(selectedVal) : selectedVal : selectedVal[0],@@ -233,8 +235,9 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { mounted(el, { value }) { setSelected(el, value) },- beforeUpdate(el, _binding, vnode) {+ beforeUpdate(el, { value }, vnode) { el[assignKey] = getModelAssigner(vnode)+ ;(el as any)._modelValue = value }, updated(el, { value }) { if (!el._assigning) {
packages/runtime-dom/__tests__/directives/vModel.spec.tsindex 2b78b0c61..590c0d7df 100644@@ -1317,6 +1317,54 @@ describe('vModel', () => { expect(bar.selected).toEqual(true) }) + it('multiple select uses current Array/Set model type', async () => {+ const component = defineComponent({+ data() {+ return { value: [] }+ },+ render() {+ return [+ withVModel(+ h(+ 'select',+ {+ value: null,+ multiple: true,+ 'onUpdate:modelValue': setValue.bind(this),+ },+ [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+ ),+ this.value,+ ),+ ]+ },+ })+ render(h(component), root)++ const input = root.querySelector('select')+ const foo = root.querySelector('option[value=foo]')+ const bar = root.querySelector('option[value=bar]')+ const data = root._vnode.component.data++ data.value = new Set(['foo'])+ await nextTick()+ foo.selected = true+ bar.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(data.value).toBeInstanceOf(Set)+ expect(data.value).toMatchObject(new Set(['foo', 'bar']))++ data.value = ['foo']+ await nextTick()+ foo.selected = false+ bar.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(Array.isArray(data.value)).toBe(true)+ expect(data.value).toMatchObject(['bar'])+ })+ it('multiple select (model is Set, option value is object)', async () => { const fooValue = { foo: 1 } const barValue = { bar: 1 }packages/runtime-dom/src/directives/vModel.tsindex b49bf809e..766db6bfe 100644@@ -207,7 +207,7 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { // <select multiple> value need to be deep traversed deep: true, created(el, { value, modifiers: { number } }, vnode) {- const isSetModel = isSet(value)+ ;(el as any)._modelValue = value addEventListener(el, 'change', () => { const selectedVal = Array.prototype.filter .call(el.options, (o: HTMLOptionElement) => o.selected)@@ -216,7 +216,7 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { ) el[assignKey]( el.multiple- ? isSetModel+ ? isSet((el as any)._modelValue) ? new Set(selectedVal) : selectedVal : selectedVal[0],@@ -233,7 +233,8 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { mounted(el, { value }) { setSelected(el, value) },- beforeUpdate(el, _binding, vnode) {+ beforeUpdate(el, { value }, vnode) {+ ;(el as any)._modelValue = value el[assignKey] = getModelAssigner(vnode) }, updated(el, { value }) {