Backtestsvuerun-20261003-231210#15496
looseEqual: comparing Map/Set values with circular references throws RangeError (regression in 3.5.42)
Our patch was judged better than the merged fix.
In this judgment, Patch B = our agent, Patch A = the merged fix.
Both patches fix the root cause the same way. Each tracks the (a, b) pairs currently on the comparison stack, threads that state through the array, collection and object recursion, and removes entries on unwind. Both handle every repro in the issue: mutually-referencing Set elements, Map values, and self-containing Sets. Both also fix the cyclic plain-object/array case. Correctness differences: - Patch A enforces a bijection: a re-encountered `a` must map back to the same `b`, and vice versa. So `looseEqual(self, first)`, where self->self and first->second->first, returns false. Those structures are structurally indistinguishable, and the issue asks for structurally identical cyclic data to compare equal. A's stricter rule is defensible but can give false negatives. Patch B returns true there. - Patch A changes the exported `looseEqual` signature by adding an optional third `seen` parameter. This leaks internal state into the public API and risks misuse if `looseEqual` is ever passed as an array callback, where the third argument would be the array. Patch B keeps `looseEqual(a, b)` unchanged and uses a private `looseEqualImpl`. - Patch B allocates tracking state only when both sides are objects. Its one minor wart is that empty inner Sets are not removed from the map; this is harmless and bounded per call. Tests: - Patch B adds unit tests for cyclic Sets, Maps (including a map containing itself), and objects/arrays. It includes negative cases (`makeGraph(3)`, `s3`) proving it does not simply return true on cycles. - Patch B also adds two runtime-dom `<select v-model>` render tests that mirror the issue's actual reproduction path. - Patch A's tests cover the unit cases plus a shared-reference case, but have fewer meaningful negative cases. Its 'symmetric' test locks in the debatable false result. Scope and craft: both are focused. Patch B follows the issue's suggested design closely and has a clear explanatory comment. Patch A's `looseCompareObjects` extraction is extra churn. Overall, B is cleaner, keeps the API stable, and is better tested.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
5m 28s
Wall-clock time in the container
Full test suite
No new failures
3,746 passed · 6 skipped · 3,752 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
180vs 138 merged
Changed lines, ours vs merged
The issue
View on GitHubVue version
3.5.42 (also reproduced on current main, commit 5409708)
Link to minimal reproduction
Steps to reproduce
Open the reproduction above: a <select v-model> whose option :values are Sets containing mutually-referencing objects. The component throws during mount, before any interaction.
<script setup>
import { ref } from 'vue'
const makeGraph = () => {
const n1 = { id: 1 }
const n2 = { id: 2 }
n1.peer = n2
n2.peer = n1 // circular reference
return new Set([n1, n2])
}
const optA = makeGraph()
const optB = makeGraph()
const selected = ref(optB)
</script>
<template>
<select v-model="selected">
<option :value="optA">A</option>
<option :value="optB">B</option>
</select>
</template>
What is expected?
Mounting the select should not throw. looseEqual should safely terminate on cyclic structures (e.g. by tracking already-visited pairs) and return true for two structurally identical cyclic Sets/Maps.
What is actually happening?
Mounting throws RangeError: Maximum call stack size exceeded:
RangeError: Maximum call stack size exceeded
at looseCompareCollections (packages/shared/src/looseEqual.ts:16)
at looseEqual (packages/shared/src/looseEqual.ts:64)
at looseCompareCollections (packages/shared/src/looseEqual.ts:22)
at looseEqual (packages/shared/src/looseEqual.ts:64)
...
[Vue warn]: Unhandled error during execution of directive hook
System Info
Reproduced locally with vuejs/core@main (5409708) via vitest: both the unit-level looseEqual calls and the component-level render path (same shape as the test added in #15328) throw RangeError.
Any additional comments?
This is a regression introduced by #15328 ("fix(shared): correctly compare Map and Set values", released in v3.5.42), which added looseCompareCollections in packages/shared/src/looseEqual.ts:
function looseCompareCollections(
a: Map<any, any> | Set<any>,
b: Map<any, any> | Set<any>,
) {
if (a.size !== b.size) return false
const candidates = Array.from(b)
const matched = new Uint8Array(candidates.length)
for (const item of a) {
let index = -1
for (let i = 0; i < candidates.length; i++) {
if (!matched[i] && looseEqual(item, candidates[i])) {
index = i
break
}
}
if (index < 0) return false
matched[index] = 1
}
return true
}
looseEqual(item, candidates[i]) recurses into each [key, value] pair (Map) or element (Set), so a Map/Set whose entries point back to the collection itself or to each other causes unbounded recursion. Before 3.5.42, Maps/Sets never recursed into their entries (they fell through to String() comparison), so this exact code path — a <select v-model> with Map/Set values, which is precisely the scenario #15320/#15328 added support for — did not throw on 3.5.41; it silently compared wrong, which #15328 fixed.
Note: #5318 covers the same root cause for cyclic plain objects (pre-existing, still open). The Map/Set case is new in 3.5.42: cyclic Maps/Sets did not throw before.
Suggested fix: make looseEqual cycle-safe by tracking visited (a, b) pairs (e.g. with a WeakMap<object, Set<object>> and returning true on re-encounter), which also fixes #5318.
Additional local repro cases that all throw RangeError on current main:
looseEqual(new Set([a1, a2]), new Set([b1, b2]))wherea1.peer = a2; a2.peer = a1andb1.peer = b2; b2.peer = b1looseEqual(mapA, mapB)where both maps hold mutually-referencing valueslooseEqual(s1, s2)wheres1.add(s1)ands2.add(s2)
The two patches
packages/runtime-dom/__tests__/directives/vModel.spec.tsindex a94cb8e0d..5906b86f6 100644@@ -1902,4 +1902,76 @@ describe('vModel', () => { expect(root.querySelector('select').selectedIndex).toBe(1) })++ it('selects the matching option when values are sets with circular references', () => {+ const makeGraph = (id: number) => {+ const n1: any = { id: 1 }+ const n2: any = { id }+ n1.peer = n2+ n2.peer = n1+ return new Set([n1, n2])+ }+ const setA = makeGraph(2)+ const setB = makeGraph(3)+ const value = ref(makeGraph(3))+ const component = defineComponent(+ () => () =>+ withVModel(+ h(+ 'select',+ {+ 'onUpdate:modelValue': (val: Set<any>) => (value.value = val),+ },+ [+ h('option', { value: setA }, 'A'),+ h('option', { value: setB }, 'B'),+ ],+ ),+ value.value,+ ),+ )++ render(h(component), root)++ expect(root.querySelector('select').selectedIndex).toBe(1)+ })++ it('selects the matching option when values are maps with circular references', () => {+ const makeMap = (id: number) => {+ const v1: any = { id: 1 }+ const v2: any = { id }+ v1.peer = v2+ v2.peer = v1+ const map = new Map<string, any>([+ ['a', v1],+ ['b', v2],+ ])+ map.set('self', map)+ return map+ }+ const mapA = makeMap(2)+ const mapB = makeMap(3)+ const value = ref(makeMap(3))+ const component = defineComponent(+ () => () =>+ withVModel(+ h(+ 'select',+ {+ 'onUpdate:modelValue': (val: Map<string, any>) =>+ (value.value = val),+ },+ [+ h('option', { value: mapA }, 'A'),+ h('option', { value: mapB }, 'B'),+ ],+ ),+ value.value,+ ),+ )++ render(h(component), root)++ expect(root.querySelector('select').selectedIndex).toBe(1)+ }) })packages/shared/__tests__/looseEqual.spec.tsindex 777f3cfad..4cab097b2 100644@@ -288,4 +288,64 @@ describe('utils/looseEqual', () => { expect(looseEqual(new Set<any>([1, '1']), new Set<any>([1, 2]))).toBe(false) expect(looseEqual(new Set(), new Map())).toBe(false) })++ test('handles sets with circular references', () => {+ const makeGraph = (id = 2) => {+ const n1: any = { id: 1 }+ const n2: any = { id }+ n1.peer = n2+ n2.peer = n1+ return new Set([n1, n2])+ }++ expect(looseEqual(makeGraph(), makeGraph())).toBe(true)+ expect(looseEqual(makeGraph(), makeGraph(3))).toBe(false)++ const s1 = new Set<any>([1])+ const s2 = new Set<any>([1])+ s1.add(s1)+ s2.add(s2)+ expect(looseEqual(s1, s2)).toBe(true)++ const s3 = new Set<any>([2])+ s3.add(s3)+ expect(looseEqual(s1, s3)).toBe(false)+ })++ test('handles maps with circular references', () => {+ const makeMap = (id = 2) => {+ const v1: any = { id: 1 }+ const v2: any = { id }+ v1.peer = v2+ v2.peer = v1+ const map = new Map<any, any>([+ ['a', v1],+ ['b', v2],+ ])+ map.set('self', map)+ return map+ }++ expect(looseEqual(makeMap(), makeMap())).toBe(true)+ expect(looseEqual(makeMap(), makeMap(3))).toBe(false)+ })++ // #5318+ test('handles objects and arrays with circular references', () => {+ const makeObject = (id = 1) => {+ const obj: any = { id }+ obj.self = obj+ obj.list = [obj]+ return obj+ }++ expect(looseEqual(makeObject(), makeObject())).toBe(true)+ expect(looseEqual(makeObject(), makeObject(2))).toBe(false)++ const arr1: any[] = [1]+ const arr2: any[] = [1]+ arr1.push(arr1)+ arr2.push(arr2)+ expect(looseEqual(arr1, arr2)).toBe(true)+ }) })packages/shared/src/looseEqual.tsindex d037b0a57..114c3d683 100644@@ -1,10 +1,14 @@ import { isArray, isDate, isMap, isObject, isSet, isSymbol } from './general' -function looseCompareArrays(a: any[], b: any[]) {+// pairs of objects currently being compared further up the call stack, used to+// terminate on cyclic structures (a pair that is re-encountered is assumed equal)+type ComparingPairs = Map<object, Set<object>>++function looseCompareArrays(a: any[], b: any[], comparing?: ComparingPairs) { if (a.length !== b.length) return false let equal = true for (let i = 0; equal && i < a.length; i++) {- equal = looseEqual(a[i], b[i])+ equal = looseEqualImpl(a[i], b[i], comparing) } return equal }@@ -12,6 +16,7 @@ function looseCompareArrays(a: any[], b: any[]) { function looseCompareCollections( a: Map<any, any> | Set<any>, b: Map<any, any> | Set<any>,+ comparing?: ComparingPairs, ) { if (a.size !== b.size) return false const candidates = Array.from(b)@@ -19,7 +24,7 @@ function looseCompareCollections( for (const item of a) { let index = -1 for (let i = 0; i < candidates.length; i++) {- if (!matched[i] && looseEqual(item, candidates[i])) {+ if (!matched[i] && looseEqualImpl(item, candidates[i], comparing)) { index = i break }@@ -31,7 +36,30 @@ function looseCompareCollections( } export function looseEqual(a: any, b: any): boolean {+ return looseEqualImpl(a, b)+}++function looseEqualImpl(a: any, b: any, comparing?: ComparingPairs): boolean { if (a === b) return true+ if (isObject(a) && isObject(b)) {+ // only allocate tracking state once we actually recurse into objects+ if (!comparing) comparing = new Map()+ let bs = comparing.get(a)+ if (bs && bs.has(b)) return true+ if (!bs) comparing.set(a, (bs = new Set()))+ bs.add(b)+ const result = looseCompareValues(a, b, comparing)+ bs.delete(b)+ return result+ }+ return looseCompareValues(a, b)+}++function looseCompareValues(+ a: any,+ b: any,+ comparing?: ComparingPairs,+): boolean { let aValidType = isDate(a) let bValidType = isDate(b) if (aValidType || bValidType) {@@ -45,7 +73,9 @@ export function looseEqual(a: any, b: any): boolean { aValidType = isArray(a) bValidType = isArray(b) if (aValidType || bValidType) {- return aValidType && bValidType ? looseCompareArrays(a, b) : false+ return aValidType && bValidType+ ? looseCompareArrays(a, b, comparing)+ : false } aValidType = isObject(a) bValidType = isObject(b)@@ -56,12 +86,16 @@ export function looseEqual(a: any, b: any): boolean { aValidType = isMap(a) bValidType = isMap(b) if (aValidType || bValidType) {- return aValidType && bValidType ? looseCompareCollections(a, b) : false+ return aValidType && bValidType+ ? looseCompareCollections(a, b, comparing)+ : false } aValidType = isSet(a) bValidType = isSet(b) if (aValidType || bValidType) {- return aValidType && bValidType ? looseCompareCollections(a, b) : false+ return aValidType && bValidType+ ? looseCompareCollections(a, b, comparing)+ : false } const aKeysCount = Object.keys(a).length const bKeysCount = Object.keys(b).length@@ -74,7 +108,7 @@ export function looseEqual(a: any, b: any): boolean { if ( (aHasKey && !bHasKey) || (!aHasKey && bHasKey) ||- !looseEqual(a[key], b[key])+ !looseEqualImpl(a[key], b[key], comparing) ) { return false }
packages/shared/__tests__/looseEqual.spec.tsindex 777f3cfad..bc1bc3acd 100644@@ -288,4 +288,45 @@ describe('utils/looseEqual', () => { expect(looseEqual(new Set<any>([1, '1']), new Set<any>([1, 2]))).toBe(false) expect(looseEqual(new Set(), new Map())).toBe(false) })++ test('compares circular references correctly', () => {+ const makeGraph = () => {+ const n1: any = { id: 1 }+ const n2: any = { id: 2 }+ n1.peer = n2+ n2.peer = n1+ return [n1, n2]+ }++ expect(looseEqual(new Set(makeGraph()), new Set(makeGraph()))).toBe(true)+ expect(+ looseEqual(new Map([['a', makeGraph()]]), new Map([['a', makeGraph()]])),+ ).toBe(true)+ expect(looseEqual(makeGraph(), makeGraph())).toBe(true)+ expect(looseEqual({ n: makeGraph() }, { n: makeGraph() })).toBe(true)++ const selfSet = new Set<any>()+ selfSet.add(selfSet)+ const otherSelfSet = new Set<any>()+ otherSelfSet.add(otherSelfSet)+ expect(looseEqual(selfSet, otherSelfSet)).toBe(true)+ expect(looseEqual(selfSet, new Set([new Set()]))).toBe(false)++ const shared = { id: 1 }+ expect(+ looseEqual({ a: shared, b: shared }, { a: { id: 1 }, b: { id: 1 } }),+ ).toBe(true)+ })++ test('compares circular references symmetrically', () => {+ const self: any = {}+ self.next = self+ const first: any = {}+ const second: any = {}+ first.next = second+ second.next = first++ expect(looseEqual(self, first)).toBe(false)+ expect(looseEqual(first, self)).toBe(false)+ }) })packages/shared/src/looseEqual.tsindex d037b0a57..7e3e7f44e 100644@@ -1,10 +1,12 @@ import { isArray, isDate, isMap, isObject, isSet, isSymbol } from './general' -function looseCompareArrays(a: any[], b: any[]) {+type ComparisonState = [Map<any, any>, Map<any, any>]++function looseCompareArrays(a: any[], b: any[], seen: ComparisonState) { if (a.length !== b.length) return false let equal = true for (let i = 0; equal && i < a.length; i++) {- equal = looseEqual(a[i], b[i])+ equal = looseEqual(a[i], b[i], seen) } return equal }@@ -12,6 +14,7 @@ function looseCompareArrays(a: any[], b: any[]) { function looseCompareCollections( a: Map<any, any> | Set<any>, b: Map<any, any> | Set<any>,+ seen: ComparisonState, ) { if (a.size !== b.size) return false const candidates = Array.from(b)@@ -19,7 +22,7 @@ function looseCompareCollections( for (const item of a) { let index = -1 for (let i = 0; i < candidates.length; i++) {- if (!matched[i] && looseEqual(item, candidates[i])) {+ if (!matched[i] && looseEqual(item, candidates[i], seen)) { index = i break }@@ -30,7 +33,62 @@ function looseCompareCollections( return true } -export function looseEqual(a: any, b: any): boolean {+function looseCompareObjects(a: any, b: any, seen: ComparisonState) {+ let aValidType = isMap(a)+ let bValidType = isMap(b)+ if (aValidType || bValidType) {+ return aValidType && bValidType+ ? looseCompareCollections(a, b, seen)+ : false+ }+ aValidType = isSet(a)+ bValidType = isSet(b)+ if (aValidType || bValidType) {+ return aValidType && bValidType+ ? looseCompareCollections(a, b, seen)+ : false+ }+ const aKeysCount = Object.keys(a).length+ const bKeysCount = Object.keys(b).length+ if (aKeysCount !== bKeysCount) {+ return false+ }+ for (const key in a) {+ const aHasKey = a.hasOwnProperty(key)+ const bHasKey = b.hasOwnProperty(key)+ if (+ (aHasKey && !bHasKey) ||+ (!aHasKey && bHasKey) ||+ !looseEqual(a[key], b[key], seen)+ ) {+ return false+ }+ }+ return String(a) === String(b)+}++function looseCompareNested(+ a: any,+ b: any,+ seen: ComparisonState | undefined,+ compare: (a: any, b: any, seen: ComparisonState) => boolean,+) {+ if (!seen) {+ seen = [new Map(), new Map()]+ }+ const [seenA, seenB] = seen+ if (seenA.has(a) || seenB.has(b)) {+ return seenA.get(a) === b && seenB.get(b) === a+ }+ seenA.set(a, b)+ seenB.set(b, a)+ const equal = compare(a, b, seen)+ seenA.delete(a)+ seenB.delete(b)+ return equal+}++export function looseEqual(a: any, b: any, seen?: ComparisonState): boolean { if (a === b) return true let aValidType = isDate(a) let bValidType = isDate(b)@@ -45,7 +103,9 @@ export function looseEqual(a: any, b: any): boolean { aValidType = isArray(a) bValidType = isArray(b) if (aValidType || bValidType) {- return aValidType && bValidType ? looseCompareArrays(a, b) : false+ return aValidType && bValidType+ ? looseCompareNested(a, b, seen, looseCompareArrays)+ : false } aValidType = isObject(a) bValidType = isObject(b)@@ -53,32 +113,7 @@ export function looseEqual(a: any, b: any): boolean { if (!aValidType || !bValidType) { return false }- aValidType = isMap(a)- bValidType = isMap(b)- if (aValidType || bValidType) {- return aValidType && bValidType ? looseCompareCollections(a, b) : false- }- aValidType = isSet(a)- bValidType = isSet(b)- if (aValidType || bValidType) {- return aValidType && bValidType ? looseCompareCollections(a, b) : false- }- const aKeysCount = Object.keys(a).length- const bKeysCount = Object.keys(b).length- if (aKeysCount !== bKeysCount) {- return false- }- for (const key in a) {- const aHasKey = a.hasOwnProperty(key)- const bHasKey = b.hasOwnProperty(key)- if (- (aHasKey && !bHasKey) ||- (!aHasKey && bHasKey) ||- !looseEqual(a[key], b[key])- ) {- return false- }- }+ return looseCompareNested(a, b, seen, looseCompareObjects) } return String(a) === String(b) }