Backtestsvuerun-20261005-124535#11910

Issue #11910 Merged fix PR #11959 Run 5 Oct 2026 · run-20261005-124535 vuejs/core

Transition should sniff for teleport in custom components

Better

Our patch was judged better than the merged fix.

In this judgment, Patch A = our agent, Patch B = the merged fix.

Both patches fix the root cause the same way. When a component inside <Transition> renders a <Teleport> root, each forwards the transition hooks to the teleport's single non-comment child instead of the teleport vnode, so the teleported element gets enter and leave hooks and the bogus warning goes away.

Patch A puts the logic inside `setTransitionHooks` as a dedicated Teleport branch. This covers every path through one place: `renderComponentRoot` calling it with the root, and the component branch recursing into `subTree`. It also deliberately avoids setting hooks on the teleport vnode itself and explains why in a comment (`afterLeave` would fire before the child finishes leaving). Its warning check, `isTransitionableRoot`, handles the edge cases sensibly: a comment-only teleport, as with a hidden v-if, is allowed, and multiple element children still warn.

Patch B special-cases teleport in two places, `renderComponentRoot` and the component branch of `setTransitionHooks`, by exporting and reusing `getInnerChild`. This works but duplicates the check. For an empty or comment-only teleport it falls back to setting hooks on the teleport vnode, which A avoids.

On tests, A's unit tests are more thorough about the behaviour that matters:
- enter and leave hook calls on the teleported element;
- the element staying in the target until leave completes;
- a comment plus component child;
- out-in mode sequencing;
- still warning for multiple children.

B adds a valuable e2e test that mirrors the issue, plus a hook-update test. Its KeepAlive-root test is unrelated and likely passes without the change.

Overall A is the cleaner, more centralized design with stronger targeted unit coverage. B is functionally comparable but slightly more scattered.

The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.

Solve

10m 44s

Wall-clock time in the container

Full test suite

No new failures

3,639 passed · 6 skipped · 3,645 total

Contamination audit

Clean

No sign the agent saw the real fix

Patch size

147vs 160 merged

Changed lines, ours vs merged

Vue version

3.5.4

Link to minimal reproduction

https://play.vuejs.org/#eNqNVE1v2zAM/SuadugGNHaG7pS5xT5QYNthG9YcfVFsOlEjS4JEOwmC/PdRUpw6RVrsZIt87+mRErXnX6zN+g74jBe+ctIi84CdvSu1bK1xyPbMQcMOrHGmZVcEvTqlvpnWHuNZHhZB6epTqUtdGe1JamU27DYIvGuE8vC+1EWetqENaIHQWiUQaMVYsegQjWafKyWr9W3Jj/Q34Vvyuwf65N9lDUWekIk1d0J7iZKYWrRAvEbUQPiQpXx02U9kc1QsOcsTM3+iRjv/ITYHBbF2NJRbmHpHcmfiRyRha9kzWQcJYyhe5BQYdPJB6JKTIh/1hZYedyr8ZsHLBDSCm4S2Xw8hBaKHCRq2D2rGikribsamdBSHoDAmonlGiwd4TvxwiSgqlD08I6dgouOphhkTSrFpduMZCA+D2ltqRIIuRLVeOtPpesYWqgsIxjayxhVtPp3abQysQC5XOI4sjKvBUcRumTdK1sQmqbQBXa3YKH7N0dMFbOQye/RG092Om5a8oqsgFbjfNrj0JZ8lOyFHjs3mZ4yh60KdKV6toFpfiD/6bYiV/I8DD66nS3LKoXBLwJS+f/gFW/o/JVtTd4rQryT/AhXXBY8J9pUaRbZHuOj2RxxDqZdzf79FoOYfiwpGA/IQ8SWnsQxT8FLpT3Zvso+RR/2kLg4jfeFxGD0Pp5EYvxHxEXht1i8N0jAcLw7O2dicTQk//AP1sJ3y

Steps to reproduce

Click the button

What is expected?

Both should transition in

What is actually happening?

One transitions correctly, the other throws a warning and blinks into existance

System Info

System:
    OS: Linux 5.15 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
    CPU: (16) x64 AMD Ryzen 7 PRO 6850HS with Radeon Graphics
    Memory: 11.86 GB / 15.28 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 22.2.0 - ~/.nvm/versions/node/v22.2.0/bin/node
    Yarn: 3.2.2 - ~/.nvm/versions/node/v22.2.0/bin/yarn
    npm: 10.7.0 - ~/.nvm/versions/node/v22.2.0/bin/npm
    pnpm: 7.25.0 - ~/.nvm/versions/node/v22.2.0/bin/pnpm
    bun: 1.1.8 - ~/.bun/bin/bun
  Browsers:
    Chrome: 126.0.6478.55

Any additional comments?

This is a follow up from

  • #5836

My Intention in #5836 was, that a user should be able to do this:

<Transition>
  <CustomComp />
</Transition>

<!-- Custom Comp -->
<Teleport>
  <div></div>
</Teleport>

However, the fix for #5836 only allows:

<Transition>
  <Teleport>
    <div></div>
  </Teleport>
</Transition>

For me as a user those 2 should feel equivalent.
The way it is now is not really useful. If you are not gonna use a custom component inside transition, you could just easily swap teleport and transition around (which already worked before the fix):

<teleport>
  <transition>
    <div></div>
  </transition>
</teleport>

But the whole point of #5836 was to allow to transition any component that teleports internally.
And since nesting a custom component into a transition works already, teleport should just be transparent in this case

Usecase:

  • modals <transition><Modal /></transition>
  • popovers
  • ...

The two patches

Our patch+146 −1
packages/runtime-core/__tests__/components/BaseTransition.spec.tsindex c541d5fc4..372698bc2 100644@@ -2,8 +2,10 @@ import {   BaseTransition,   type BaseTransitionProps,   KeepAlive,+  Teleport,   type TestElement,   type VNodeProps,+  createCommentVNode,   h,   nextTick,   nodeOps,@@ -1242,6 +1244,121 @@ describe('BaseTransition', () => {     })   }) +  // Teleport as the root of a component nested in Transition+  describe('w/ component that renders a Teleport root', () => {+    test('toggle on-off', async () => {+      const target = nodeOps.createElement('div')+      const Modal = () => h(Teleport, { to: target }, [h('div', 'modal')])+      const toggle = ref(false)+      const { props, cbs } = mockProps()+      const { root } = mount(props, () => (toggle.value ? h(Modal) : null))+      expect(serializeInner(target)).toBe(``)++      // enter+      toggle.value = true+      await nextTick()+      expect(serializeInner(target)).toBe(`<div>modal</div>`)+      expect(serializeInner(root)).toBe(+        `<!--teleport start--><!--teleport end-->`,+      )+      expect(props.onBeforeEnter).toHaveBeenCalledTimes(1)+      assertCalledWithEl(props.onBeforeEnter, `<div>modal</div>`)+      expect(props.onEnter).toHaveBeenCalledTimes(1)+      assertCalledWithEl(props.onEnter, `<div>modal</div>`)+      expect(props.onAfterEnter).not.toHaveBeenCalled()+      cbs.doneEnter[`<div>modal</div>`]()+      expect(props.onAfterEnter).toHaveBeenCalledTimes(1)++      // leave: element must stay in the target until the leave finishes+      toggle.value = false+      await nextTick()+      expect(props.onBeforeLeave).toHaveBeenCalledTimes(1)+      expect(props.onLeave).toHaveBeenCalledTimes(1)+      assertCalledWithEl(props.onLeave, `<div>modal</div>`)+      expect(serializeInner(target)).toBe(`<div>modal</div>`)+      expect(props.onAfterLeave).not.toHaveBeenCalled()+      cbs.doneLeave[`<div>modal</div>`]()+      expect(props.onAfterLeave).toHaveBeenCalledTimes(1)+      expect(serializeInner(target)).toBe(``)+      expect(serializeInner(root)).toBe(`<!---->`)++      expect(+        `renders non-element root node that cannot be animated`,+      ).not.toHaveBeenWarned()+    })++    test('teleport w/ comment and component child', async () => {+      const target = nodeOps.createElement('div')+      const Inner = () => h('span', 'inner')+      const Modal = () =>+        h(Teleport, { to: target }, [createCommentVNode('comment'), h(Inner)])+      const toggle = ref(false)+      const { props, cbs } = mockProps()+      mount(props, () => (toggle.value ? h(Modal) : null))++      toggle.value = true+      await nextTick()+      expect(serializeInner(target)).toBe(`<!--comment--><span>inner</span>`)+      expect(props.onEnter).toHaveBeenCalledTimes(1)+      assertCalledWithEl(props.onEnter, `<span>inner</span>`)+      cbs.doneEnter[`<span>inner</span>`]()++      toggle.value = false+      await nextTick()+      expect(props.onLeave).toHaveBeenCalledTimes(1)+      assertCalledWithEl(props.onLeave, `<span>inner</span>`)+      // the leaving element is kept until the leave transition finishes+      expect(serializeInner(target)).toBe(`<span>inner</span>`)+      cbs.doneLeave[`<span>inner</span>`]()+      expect(serializeInner(target)).toBe(``)+      expect(+        `renders non-element root node that cannot be animated`,+      ).not.toHaveBeenWarned()+    })++    test('mode: "out-in"', async () => {+      const target = nodeOps.createElement('div')+      const Modal = () => h(Teleport, { to: target }, [h('div', 'modal')])+      const toggle = ref(true)+      const { props, cbs } = mockProps({ mode: 'out-in' })+      const { root } = mount(props, () =>+        toggle.value ? h(Modal) : h('div', 'other'),+      )+      expect(serializeInner(target)).toBe(`<div>modal</div>`)++      toggle.value = false+      await nextTick()+      expect(props.onLeave).toHaveBeenCalledTimes(1)+      assertCalledWithEl(props.onLeave, `<div>modal</div>`)+      // the next element must wait until the teleported element has left+      expect(serializeInner(target)).toBe(`<div>modal</div>`)+      expect(serializeInner(root)).toBe(`<!---->`)+      expect(props.onEnter).not.toHaveBeenCalled()++      cbs.doneLeave[`<div>modal</div>`]()+      expect(props.onAfterLeave).toHaveBeenCalledTimes(1)+      expect(serializeInner(target)).toBe(``)+      await nextTick()+      expect(serializeInner(root)).toBe(`<div>other</div>`)+      expect(props.onEnter).toHaveBeenCalledTimes(1)+      assertCalledWithEl(props.onEnter, `<div>other</div>`)+    })++    test('should still warn when teleport has multiple element children', async () => {+      const target = nodeOps.createElement('div')+      const Modal = () =>+        h(Teleport, { to: target }, [h('div', 'a'), h('div', 'b')])+      const { props } = mockProps()+      mount(props, () => h(Modal))+      expect(+        `renders non-element root node that cannot be animated`,+      ).toHaveBeenWarned()+      expect(+        `<transition> can only be used on a single element or component`,+      ).toHaveBeenWarned()+    })+  })+   // #10719   test('should not error on KeepAlive w/ function children', () => {     expect(() => mount({}, () => () => h('div'), true)).not.toThrow()packages/runtime-core/src/componentRenderUtils.tsindex 0b46130c0..efce172a3 100644@@ -18,6 +18,7 @@ import { ErrorCodes, handleError } from './errorHandling' import {   PatchFlags,   ShapeFlags,+  isArray,   isModelListener,   isObject,   isOn,@@ -35,6 +36,7 @@ import { } from './compat/compatConfig' import { shallowReadonly } from '@vue/reactivity' import { setTransitionHooks } from './components/BaseTransition'+import { isTeleport } from './components/Teleport'  /**  * dev only flag to track whether $attrs was used during render.@@ -255,7 +257,7 @@ export function renderComponentRoot(   }   // inherit transition data   if (vnode.transition) {-    if (__DEV__ && !isElementRoot(root)) {+    if (__DEV__ && !isTransitionableRoot(root)) {       warn(         `Component inside <Transition> renders non-element root node ` +           `that cannot be animated.`,@@ -368,6 +370,19 @@ const isElementRoot = (vnode: VNode) => {   ) } +// a <Teleport> root forwards transition hooks to its inner child+const isTransitionableRoot = (vnode: VNode): boolean => {+  if (isTeleport(vnode.type)) {+    const children = vnode.children+    if (!isArray(children)) return false+    const nonComment = (children as VNode[]).filter(c => c.type !== Comment)+    // only comments, e.g. a v-if branch that is currently hidden+    if (!nonComment.length) return children.length > 0+    return nonComment.length === 1 && !!isElementRoot(nonComment[0])+  }+  return !!isElementRoot(vnode)+}+ export function shouldUpdateComponent(   prevVNode: VNode,   nextVNode: VNode,packages/runtime-core/src/components/BaseTransition.tsindex 4a9d5098e..d9dece222 100644@@ -539,6 +539,19 @@ export function setTransitionHooks(vnode: VNode, hooks: TransitionHooks): void {   if (vnode.shapeFlag & ShapeFlags.COMPONENT && vnode.component) {     vnode.transition = hooks     setTransitionHooks(vnode.component.subTree, hooks)+  } else if (+    isTeleport(vnode.type) &&+    vnode.shapeFlag & ShapeFlags.ARRAY_CHILDREN+  ) {+    // e.g. a component inside <Transition> whose root is a <Teleport>:+    // the teleport itself cannot be animated, so pass the hooks down to its+    // inner child, mirroring how directly nested Teleports are handled.+    // the hooks are not set on the teleport vnode itself, otherwise removing+    // its placeholder would call `afterLeave` before the child finishes leaving.+    const child = findNonCommentChild(vnode.children as VNode[])+    if (child) {+      setTransitionHooks(child, hooks)+    }   } else if (__FEATURE_SUSPENSE__ && vnode.shapeFlag & ShapeFlags.SUSPENSE) {     vnode.ssContent!.transition = hooks.clone(vnode.ssContent!)     vnode.ssFallback!.transition = hooks.clone(vnode.ssFallback!) 
Merged fix · PR #11959+155 −5
packages/runtime-core/__tests__/components/BaseTransition.spec.tsindex c541d5fc4..65abcc6ff 100644@@ -2,6 +2,7 @@ import {   BaseTransition,   type BaseTransitionProps,   KeepAlive,+  Teleport,   type TestElement,   type VNodeProps,   h,@@ -1293,4 +1294,66 @@ describe('BaseTransition', () => {     await runTestWithKeepAlive(testOutIn)     __DEV__ = true   })++  test('should preserve transition for component with KeepAlive root', async () => {+    const root = nodeOps.createElement('div')+    const show = ref(false)+    const onBeforeEnter = vi.fn()+    const Child = { render: () => h('div', 'content') }+    const Comp = {+      render: () => h(KeepAlive, null, { default: () => h(Child) }),+    }+    const App = () =>+      h(BaseTransition, { onBeforeEnter }, () => (show.value ? h(Comp) : null))++    render(h(App), root)++    show.value = true+    await nextTick()+    expect(serializeInner(root)).toBe('<div>content</div>')+    expect(onBeforeEnter).toHaveBeenCalledTimes(1)+  })++  test('should not error on component with empty Teleport root', () => {+    const root = nodeOps.createElement('div')+    const target = nodeOps.createElement('div')+    const Comp = () => h(Teleport, { to: target }, [])++    expect(() =>+      render(+        h(BaseTransition, null, () => h(Comp)),+        root,+      ),+    ).not.toThrow()+    expect(serializeInner(root)).toBe(+      '<!--teleport start--><!--teleport end-->',+    )+    expect(serializeInner(target)).toBe('')+    expect(+      'Component inside <Transition> renders non-element root node',+    ).toHaveBeenWarned()+  })++  test('should update transition hooks for component with Teleport root', async () => {+    const root = nodeOps.createElement('div')+    const target = nodeOps.createElement('div')+    const show = ref(true)+    const firstBeforeLeave = vi.fn()+    const nextBeforeLeave = vi.fn()+    const beforeLeave = ref(firstBeforeLeave)+    const Comp = () => h(Teleport, { to: target }, h('div', 'content'))+    const App = () =>+      h(BaseTransition, { onBeforeLeave: beforeLeave.value }, () =>+        show.value ? h(Comp) : null,+      )++    render(h(App), root)++    beforeLeave.value = nextBeforeLeave+    show.value = false+    await nextTick()++    expect(firstBeforeLeave).not.toHaveBeenCalled()+    expect(nextBeforeLeave).toHaveBeenCalledTimes(1)+  }) })packages/runtime-core/src/componentRenderUtils.tsindex 0b46130c0..be58e5b0a 100644@@ -34,7 +34,8 @@ import {   warnDeprecation, } from './compat/compatConfig' import { shallowReadonly } from '@vue/reactivity'-import { setTransitionHooks } from './components/BaseTransition'+import { getInnerChild, setTransitionHooks } from './components/BaseTransition'+import { isTeleport } from './components/Teleport'  /**  * dev only flag to track whether $attrs was used during render.@@ -255,13 +256,14 @@ export function renderComponentRoot(   }   // inherit transition data   if (vnode.transition) {-    if (__DEV__ && !isElementRoot(root)) {+    const child = isTeleport(root.type) ? getInnerChild(root) || root : root+    if (__DEV__ && !isElementRoot(child)) {       warn(         `Component inside <Transition> renders non-element root node ` +           `that cannot be animated.`,       )     }-    setTransitionHooks(root, vnode.transition)+    setTransitionHooks(child, vnode.transition)   }    if (__DEV__ && setRoot) {packages/runtime-core/src/components/BaseTransition.tsindex 4a9d5098e..a8cfe8b71 100644@@ -506,7 +506,7 @@ function emptyPlaceholder(vnode: VNode): VNode | undefined {   } } -function getInnerChild(vnode: VNode): VNode | undefined {+export function getInnerChild(vnode: VNode): VNode | undefined {   if (!isKeepAlive(vnode)) {     if (isTeleport(vnode.type) && vnode.children) {       return findNonCommentChild(vnode.children as VNode[])@@ -538,7 +538,11 @@ function getInnerChild(vnode: VNode): VNode | undefined { export function setTransitionHooks(vnode: VNode, hooks: TransitionHooks): void {   if (vnode.shapeFlag & ShapeFlags.COMPONENT && vnode.component) {     vnode.transition = hooks-    setTransitionHooks(vnode.component.subTree, hooks)+    const subTree = vnode.component.subTree+    setTransitionHooks(+      isTeleport(subTree.type) ? getInnerChild(subTree) || subTree : subTree,+      hooks,+    )   } else if (__FEATURE_SUSPENSE__ && vnode.shapeFlag & ShapeFlags.SUSPENSE) {     vnode.ssContent!.transition = hooks.clone(vnode.ssContent!)     vnode.ssFallback!.transition = hooks.clone(vnode.ssFallback!)packages/vue/__tests__/e2e/Transition.spec.tsindex 17519e832..025cc7c00 100644@@ -2782,6 +2782,87 @@ describe('e2e: Transition', () => {       },       E2E_TIMEOUT,     )++    // #11910+    test(+      'apply transition to teleport component child',+      async () => {+        await page().evaluate(() => {+          const { createApp, ref } = (window as any).Vue+          createApp({+            template: `+            <div id="target"></div>+            <div id="container">+              <transition>+                  <Comp v-if="toggle"></Comp>+              </transition>+            </div>+            <button id="toggleBtn" @click="click">button</button>+          `,+            components: {+              Comp: {+                template: `+                    <Teleport to="#target">+                      <div class="test">content</div>+                    </Teleport>+                  `,+              },+            },+            setup: () => {+              const toggle = ref(false)+              const click = () => (toggle.value = !toggle.value)+              return { toggle, click }+            },+          }).mount('#app')+        })++        expect(await html('#target')).toBe('')+        expect(await html('#container')).toBe('<!--v-if-->')++        const classWhenTransitionStart = () =>+          page().evaluate(() => {+            ;(document.querySelector('#toggleBtn') as any)!.click()+            return Promise.resolve().then(() => {+              // find the class of teleported node+              return document+                .querySelector('#target div')!+                .className.split(/\s+/g)+            })+          })++        // enter+        expect(await classWhenTransitionStart()).toStrictEqual([+          'test',+          'v-enter-from',+          'v-enter-active',+        ])+        await nextFrame()+        expect(await classList('.test')).toStrictEqual([+          'test',+          'v-enter-active',+          'v-enter-to',+        ])+        await transitionFinish()+        expect(await html('#target')).toBe('<div class="test">content</div>')++        // leave+        expect(await classWhenTransitionStart()).toStrictEqual([+          'test',+          'v-leave-from',+          'v-leave-active',+        ])+        await nextFrame()+        expect(await classList('.test')).toStrictEqual([+          'test',+          'v-leave-active',+          'v-leave-to',+        ])+        await transitionFinish()+        expect(await html('#target')).toBe('')+        expect(await html('#container')).toBe('<!--v-if-->')+      },+      E2E_TIMEOUT,+    )   })    describe('transition with v-show', () => {