Backtestsvuerun-20261005-124535#15009

Issue #15009 Merged fix PR #15010 Run 5 Oct 2026 · run-20261005-124535 vuejs/core

v-model on <select multiple> uses stale collection type after switching between Array and Set

Better

Our patch was judged better than the merged fix.

In this judgment, Patch A = our agent, Patch B = the merged fix.

Both patches fix the bug the same way. Each replaces the `isSetModel` flag captured once in `created` with per-element state that `beforeUpdate` refreshes from the current binding value. So the change listener sees the current Array/Set type after a runtime switch. Correctness is equivalent for the scenarios in the issue.

Tests: both add a regression test that would fail before the fix and covers both Array -> Set and Set -> Array. A's test is a bit more thorough. It first interacts while the model is still an Array, then checks that the DOM selection syncs after each switch, then interacts again. B's test switches to a Set before any interaction, which still exercises the stale closure, but it checks less along the way.

Craft: A stores a boolean `_isSetModel`, typed through the directive's element generic (`HTMLSelectElement & { _isSetModel?: boolean }`). It adds an explanatory comment and calls `isSet` once per update. B uses repeated `(el as any)` casts with leading-semicolon statements, and keeps a reference to the whole model value on the element just to check its type later. That is less type-safe and less idiomatic than A's typed flag. A therefore wins on craft and slightly on test thoroughness.

The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.

Solve

7m 29s

Wall-clock time in the container

Full test suite

No new failures

3,608 passed · 6 skipped · 3,614 total

Contamination audit

Clean

No sign the agent saw the real fix

Patch size

74vs 55 merged

Changed lines, ours vs merged

Vue version

3.5.39

Link to minimal reproduction

https://play.vuejs.org/#__PROD__eNp9Uk1P4zAQ/SuWLwWJTQ/dPSwK1X6Iw+4BEHDDCAV3UgyObdnjtFKU/86MQwtIwMWK57158+bFg/wdQtVnkMeyTjqagCIB5rBUznTBRxSDiNCKUbTRd2JG1JlyymnvElMtaISVOGHSwc3tIWNtdhqNdyJtDOqHa38FeHAoBuXEvqPqG5uB+hxsBOM3s9b7GQuMytXzyQu5oAtCF2yDQDch6vuMSNq/tDX66UTJN0OUXE43gZ5F6/lELjLUOg0X/bfOr8By74sbJUWXLZpgpyHE9aGsUGwSk8yROp31fEI+4d03kXh0vuPRPmXSzkiIsByG3fRxrOdc4b33u8ojiYlSbs26ekze0Q8qASqpfReMhXhe9JOSx1O0jDXW+s3/UsOY4WhX1w+gnz6oP6Yt15S8iJAg9qDkHsMmrjlThk+vzmBL33uQEsyW2F+Al5C8zexxov3JbkW23/CK23/lmRm3vk6nWwSXdkuxUWaOha8kPb2/X6z+andRfS999JQoxbseImtSgIvqR7X4Kcdnt8MAPA==

Steps to reproduce

  1. Bind a <select multiple v-model> to an Array.
  2. Switch the bound value to a Set at runtime.
  3. Interact with the select again.
  4. The emitted model becomes an Array again.
  5. Switching back from Set -> Array shows the same stale-type behavior in reverse.

What is expected?

The current collection type should be respected after the model switches at runtime.

What is actually happening?

The change handler keeps using the collection type captured when the directive was created, so the first user interaction after a runtime Array/Set switch emits the old type.

System Info

Any additional comments?

_No response_

The two patches

Our patch+70 −4
packages/runtime-dom/__tests__/directives/vModel.spec.tsindex 2b78b0c61..0c5e29343 100644@@ -1317,6 +1317,66 @@ describe('vModel', () => {     expect(bar.selected).toEqual(true)   }) +  it('multiple select should respect model type switched at runtime', async () => {+    const component = defineComponent({+      data() {+        return { value: [] as any }+      },+      render() {+        return [+          withVModel(+            h(+              'select',+              {+                value: null,+                multiple: true,+                'onUpdate:modelValue': setValue.bind(this),+              },+              [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+            ),+            this.value,+          ),+        ]+      },+    })+    render(h(component), root)++    const input = root.querySelector('select')+    const foo = root.querySelector('option[value=foo]')+    const bar = root.querySelector('option[value=bar]')+    const data = root._vnode.component.data++    foo.selected = true+    triggerEvent('change', input)+    await nextTick()+    expect(data.value).toBeInstanceOf(Array)+    expect(data.value).toMatchObject(['foo'])++    // Array -> Set+    data.value = new Set(['bar'])+    await nextTick()+    expect(foo.selected).toEqual(false)+    expect(bar.selected).toEqual(true)++    foo.selected = true+    triggerEvent('change', input)+    await nextTick()+    expect(data.value).toBeInstanceOf(Set)+    expect(data.value).toMatchObject(new Set(['foo', 'bar']))++    // Set -> Array+    data.value = ['foo']+    await nextTick()+    expect(foo.selected).toEqual(true)+    expect(bar.selected).toEqual(false)++    bar.selected = true+    triggerEvent('change', input)+    await nextTick()+    expect(data.value).toBeInstanceOf(Array)+    expect(data.value).toMatchObject(['foo', 'bar'])+  })+   it('multiple select (model is Set, option value is object)', async () => {     const fooValue = { foo: 1 }     const barValue = { bar: 1 }packages/runtime-dom/src/directives/vModel.tsindex b49bf809e..bfe2e95fe 100644@@ -203,11 +203,16 @@ export const vModelRadio: ModelDirective<HTMLInputElement> = {   }, } -export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = {+export const vModelSelect: ModelDirective<+  HTMLSelectElement & { _isSetModel?: boolean },+  'number'+> = {   // <select multiple> value need to be deep traversed   deep: true,   created(el, { value, modifiers: { number } }, vnode) {-    const isSetModel = isSet(value)+    // track the current model collection type on the element so that the+    // change listener respects runtime switches between Array and Set+    el._isSetModel = isSet(value)     addEventListener(el, 'change', () => {       const selectedVal = Array.prototype.filter         .call(el.options, (o: HTMLOptionElement) => o.selected)@@ -216,7 +221,7 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = {         )       el[assignKey](         el.multiple-          ? isSetModel+          ? el._isSetModel             ? new Set(selectedVal)             : selectedVal           : selectedVal[0],@@ -233,7 +238,8 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = {   mounted(el, { value }) {     setSelected(el, value)   },-  beforeUpdate(el, _binding, vnode) {+  beforeUpdate(el, { value }, vnode) {+    el._isSetModel = isSet(value)     el[assignKey] = getModelAssigner(vnode)   },   updated(el, { value }) { 
Merged fix · PR #15010+52 −3
packages/runtime-dom/__tests__/directives/vModel.spec.tsindex 2b78b0c61..590c0d7df 100644@@ -1317,6 +1317,54 @@ describe('vModel', () => {     expect(bar.selected).toEqual(true)   }) +  it('multiple select uses current Array/Set model type', async () => {+    const component = defineComponent({+      data() {+        return { value: [] }+      },+      render() {+        return [+          withVModel(+            h(+              'select',+              {+                value: null,+                multiple: true,+                'onUpdate:modelValue': setValue.bind(this),+              },+              [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+            ),+            this.value,+          ),+        ]+      },+    })+    render(h(component), root)++    const input = root.querySelector('select')+    const foo = root.querySelector('option[value=foo]')+    const bar = root.querySelector('option[value=bar]')+    const data = root._vnode.component.data++    data.value = new Set(['foo'])+    await nextTick()+    foo.selected = true+    bar.selected = true+    triggerEvent('change', input)+    await nextTick()+    expect(data.value).toBeInstanceOf(Set)+    expect(data.value).toMatchObject(new Set(['foo', 'bar']))++    data.value = ['foo']+    await nextTick()+    foo.selected = false+    bar.selected = true+    triggerEvent('change', input)+    await nextTick()+    expect(Array.isArray(data.value)).toBe(true)+    expect(data.value).toMatchObject(['bar'])+  })+   it('multiple select (model is Set, option value is object)', async () => {     const fooValue = { foo: 1 }     const barValue = { bar: 1 }packages/runtime-dom/src/directives/vModel.tsindex b49bf809e..766db6bfe 100644@@ -207,7 +207,7 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = {   // <select multiple> value need to be deep traversed   deep: true,   created(el, { value, modifiers: { number } }, vnode) {-    const isSetModel = isSet(value)+    ;(el as any)._modelValue = value     addEventListener(el, 'change', () => {       const selectedVal = Array.prototype.filter         .call(el.options, (o: HTMLOptionElement) => o.selected)@@ -216,7 +216,7 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = {         )       el[assignKey](         el.multiple-          ? isSetModel+          ? isSet((el as any)._modelValue)             ? new Set(selectedVal)             : selectedVal           : selectedVal[0],@@ -233,7 +233,8 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = {   mounted(el, { value }) {     setSelected(el, value)   },-  beforeUpdate(el, _binding, vnode) {+  beforeUpdate(el, { value }, vnode) {+    ;(el as any)._modelValue = value     el[assignKey] = getModelAssigner(vnode)   },   updated(el, { value }) {