Backtestsvuerun-20261005-124535#15288

Issue #15288 Merged fix PR #15291 Run 5 Oct 2026 · run-20261005-124535 vuejs/core

KeepAlive caches a never-mounted vnode when a switch lands while an ancestor Suspense is pending

Better

Our patch was judged better than the merged fix.

In this judgment, Patch A = our agent, Patch B = the merged fix.

The production fixes are functionally identical. Both wrap the Suspense-path `cache.set` in KeepAlive's `cacheSubtree` with an `innerChild.component` / `vnode.component` guard. That is exactly the guard the issue suggests, and it addresses the root cause: a never-mounted vnode cached after an ancestor Suspense's early return skipped patching the new branch. Correctness is therefore a wash.

The tests differ.

- **Patch A's test** is simple and deterministic. It uses sync pages under a pending root Suspense driven by the shared `deps` helper. It switches to PageB while pending, resolves, then switches back to A and again to B. That second switch hits the poisoned cache entry for key 1, which would throw (`suspenseId` of null) before the fix. It then switches to A once more and explicitly unmounts the tree. The unmount covers the `unmountComponent(null)` teardown error the issue reports. It also includes an honest comment that the post-resolve 'pageA' assertion pins current behavior.
- **Patch B's test** exercises the same switch sequence with async pages and a manually resolved root dependency. It is closer to the Nuxt shape, but relies on `setTimeout` and extra awaits for timing. It does not check unmount.

On craft, Patch A adds a short comment explaining why the guard exists, so the third pending-ancestor path is documented next to the existing 'avoid caching vnode that not been mounted' note. Patch B adds the guard without explanation.

The differences are small, but A's test is more deterministic and covers both reported errors, and its code is better documented.

The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.

Solve

9m 23s

Wall-clock time in the container

Full test suite

No new failures

3,679 passed · 6 skipped · 3,685 total

Contamination audit

Clean

No sign the agent saw the real fix

Patch size

82vs 76 merged

Changed lines, ours vs merged

Vue version

3.5.41 (also reproduces on 3.5.40 and 3.6.0-rc.3)

Link to minimal reproduction

https://play.vuejs.org/#eNqNVs1u4zYQfpWBL6RQ2c42uz0YtoFsemhRtLtIc1vtgZHGFhtqSJCUEiMQ0IfoE/ZJCpKyJTsbbC8SNDOc75tf6mV2Y8yia3G2mq1daaXx4NC3ZluQbIy2Hl6gwp0kvNWN0YTkc6hzcLVQSj/d4S4HGx6aftcteaxy2KO/ba1F8r+S84JKzOHP1hkkhzn8hmhulOwQethZ3QDrWmQFFVRqch4qVOIAG+CNy2CzBcIn+Gx1Ix1ybqPIob+XDerWc5tD47JsPK70HjaBEv/yNTsK0Vpt3Wu5qKqIFL0qvV90QrW4MK2reROdLpeRsANfI9x9+nQP62MoWzBIlaQ97LSF66urxsG/f/8DkuCP9tmDr6UD6UAYM1fYoYrehDtQmXIMy+jVeanU3LZEwVd9qKzwUhPoXVRLkl4KBUbscXEkfqe1/xkNbC6Lw18KAiDR4ArYYMXyIJsA8wyiGYB4EnJIOb++usqS1KJvLQGPaak5q2THcmBW62BrwKKoDiwa93lB/ST9jXjEz2KPIa2BRXAR7L5JMxHNByrf4nfO8N2R4NsUkSq0WMVsrYDBDxFiONZHqCndQPUGNifanEUJy6YGH18ZfGQTHyaFO04Ejz5OLh7xcK5mgh176z7W37alby2mtkkhuFXUw7TdeChABltYn2ZoG74mFgZt5BOsIq/ymPFT57REaL/XONEo9c1FRaaJPxaj5uN4U6tUPpYvVl60yq/Oj6RjQ9m+TKVBPjRull8qToHn8AKNeF7BB+jP4L4H+ibjizNQ8zhxcSME9SMeVuGRJNBn0F/yuxB8HT/7i2F5vSJ5thDG3Gry+OwXpaad3C/i3vpFUKViyTjatADTPptuK7R20aBzofZja5LoYDNMFlfiAVUeOyKHx+gn5m0MEzZRG4RjoBt4jOtjMoc/pTkUVZWcZgX1AfR0B/ABcgQ5XzTZKCLRcfZuEd5yLzyCgPkWHuCplgrjAoxrZ9Lk0qWVeVy/LE9TmgN7YNkl2PurkSz7cfHKm0WnVYdVXN3j3VSKssYq4hN2aOdNigw60hWyywCuJwE8hADEwOomhzTuZ+bvX8cb4Gvp00VjtHSasEo0AMnbw1thRocf/g9+yEClKbIPbbhepht/G2q39tgYJTzGaVkPa2KZvmqb3sbi9uUl3pR/aUmcFQWxDPp+vQyqow10c7nbFLOhTRXS3tfFDJw/KNwUs1IrbVdQWtk4TcUs+Dyzhb4f9mCSc5etChqt3gaHbo7KYcIPPCWVqq3QnUKfbUmfOXfrZfjdWS8nGZj1/wEDZfRV

Steps to reproduce

The reproduction drives itself from onMounted — just open it and read the log. The tree is the one Nuxt renders for a page with <NuxtPage keepalive>:

<Suspense>            <!-- root boundary, still pending -->
  <RootDep />         <!-- async setup, resolves after 300ms -->
  <KeepAlive>
    <Suspense>        <!-- per-page boundary -->
      <component :is="page" :key="key" />
    </Suspense>
  </KeepAlive>
</Suspense>
  1. While RootDep is still pending (so parentSuspense.deps > 0), switch the inner page from PageA to PageB.
  2. Let the root boundary resolve.
  3. Switch back to PageA, then to PageB again.

What is expected?

The inner page follows the switches, and no errors are raised.

What is actually happening?

The rendered page is stuck on PageA forever — every later switch is a no-op — and the renderer throws:

Cannot read properties of null (reading 'suspenseId')   // patchSuspense
Cannot read properties of null (reading 'm')            // unmountComponent

In a production build the second one is the more familiar
Uncaught (in promise) TypeError: Cannot destructure property 'bum' of 'instance' as it is null.

Removing the <KeepAlive> and changing nothing else makes both errors go away and navigation work.

System Info

  System:
    OS: Linux 7.0 Ubuntu 26.04 LTS
    CPU: (4) x64 Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
    Memory: 5.86 GB / 11.67 GB
  Binaries:
    Node: 24.19.0
    npm: 11.19.0
  npmPackages:
    vue: 3.5.41
  Browsers:
    Chromium (Playwright 1.5x, headless)

Any additional comments?

The chain, as far as I could trace it:

  1. The route change re-renders KeepAlive, so the inner <Suspense> is patched with n1 != null. Because an ancestor boundary is still pending, SuspenseImpl.process takes its early return:
   if (parentSuspense && parentSuspense.deps > 0 && !n1.suspense.isInFallback) {
     n2.suspense = n1.suspense
     n2.suspense.vnode = n2
     n2.el = n1.el
     return
   }

The incoming page vnode is therefore never patched: vnode.component === null, vnode.el === null.

  1. KeepAlive's onUpdated → cacheSubtree still caches it, unconditionally:
   if (isSuspense(instance.subTree.type)) {
     queuePostRenderEffect(() => {
       cache.set(pendingCacheKey, getInnerChild(instance.subTree))
     }, instance.subTree.suspense)
   }
  1. The next render for that key hits the poisoned entry: KeepAlive copies cachedVNode.component (null) onto the new vnode and sets COMPONENT_KEPT_ALIVE, so patchSuspense reads newBranch.component.suspenseId on null, and the teardown that follows calls unmountComponent(null).

Suggested fix — the same shape as the two guards already at that site, i.e. do not cache a vnode that never finished mounting:

const innerChild = getInnerChild(instance.subTree)
if (innerChild.component) {
  cache.set(pendingCacheKey, innerChild)
}

With that guard the page is simply not cached that one time, and the reproduction runs clean.

This looks like a third path into the defect class fixed by #10912 (avoid caching vnode that not been mounted, for #10899) and #11479 (for #6028) — both guard KeepAlive's own subtree, while here it is an ancestor Suspense that is pending.

Real-world context: this is how it surfaced for us — a Nuxt 4 app rendering <NuxtPage :keepalive="{ max: 5 }" />, where a link clicked before hydration finished intermittently left the user on a blank page with Cannot destructure property 'bum' of 'e' as it is null in the console. The window widens with slower hydration, so it shows up under load / on slow clients.

<sub>Investigation and reproduction prepared with Claude Code, on behalf of drunomics.</sub>

The two patches

Our patch+81 −1
packages/runtime-core/__tests__/components/Suspense.spec.tsindex d40f85b86..9029746a2 100644@@ -2111,6 +2111,81 @@ describe('Suspense', () => {     expect(serializeInner(root)).toBe(`<div>async2</div>`)   }) +  // switching the KeepAlive child while an ancestor Suspense is pending+  test('KeepAlive + Suspense switch while ancestor Suspense is pending', async () => {+    const RootDep = defineAsyncComponent({+      render() {+        return h('div', 'root')+      },+    })+    const PageA = {+      name: 'PageA',+      render: () => h('div', 'pageA'),+    }+    const PageB = {+      name: 'PageB',+      render: () => h('div', 'pageB'),+    }+    const pages = [PageA, PageB]+    const viewRef = ref(0)+    const Inner = {+      render() {+        return h(KeepAlive, null, {+          default: () =>+            h(Suspense, null, {+              default: h(pages[viewRef.value], { key: viewRef.value }),+            }),+        })+      },+    }+    const root = nodeOps.createElement('div')+    const App = {+      render() {+        return h(Suspense, null, {+          default: h('div', [h(RootDep), h(Inner)]),+          fallback: h('div', 'loading'),+        })+      },+    }+    render(h(App), root)+    expect(serializeInner(root)).toBe(`<div>loading</div>`)++    // switch to PageB while the root Suspense is still pending+    viewRef.value = 1+    await nextTick()+    expect(serializeInner(root)).toBe(`<div>loading</div>`)++    await Promise.all(deps)+    await nextTick()+    // the switch made while pending is skipped by the inner Suspense (#8678),+    // so pageA is still rendered here; this pins current behavior, not intent+    expect(serializeInner(root)).toBe(+      `<div><div>root</div><div>pageA</div></div>`,+    )++    viewRef.value = 0+    await nextTick()+    expect(serializeInner(root)).toBe(+      `<div><div>root</div><div>pageA</div></div>`,+    )++    viewRef.value = 1+    await nextTick()+    expect(serializeInner(root)).toBe(+      `<div><div>root</div><div>pageB</div></div>`,+    )++    viewRef.value = 0+    await nextTick()+    expect(serializeInner(root)).toBe(+      `<div><div>root</div><div>pageA</div></div>`,+    )++    // unmount should not throw+    render(null, root)+    expect(serializeInner(root)).toBe(``)+  })+   test('KeepAlive + Suspense + comment slot', async () => {     const toggle = ref(false)     const Async = defineAsyncComponent({packages/runtime-core/src/components/KeepAlive.tsindex 55eaf8624..4d20bf558 100644@@ -248,7 +248,12 @@ const KeepAliveImpl: ComponentOptions = {         // avoid caching vnode that not been mounted         if (isSuspense(instance.subTree.type)) {           queuePostRenderEffect(() => {-            cache.set(pendingCacheKey!, getInnerChild(instance.subTree))+            const innerChild = getInnerChild(instance.subTree)+            // the inner Suspense may skip patching its new branch while an+            // ancestor Suspense is pending, leaving the vnode unmounted+            if (innerChild.component) {+              cache.set(pendingCacheKey!, innerChild)+            }           }, instance.subTree.suspense)         } else {           cache.set(pendingCacheKey, getInnerChild(instance.subTree)) 
Merged fix · PR #15291+75 −1
packages/runtime-core/__tests__/components/Suspense.spec.tsindex d40f85b86..6b6373fab 100644@@ -2111,6 +2111,77 @@ describe('Suspense', () => {     expect(serializeInner(root)).toBe(`<div>async2</div>`)   }) +  // #15288+  test('KeepAlive + Suspense switch while ancestor is pending', async () => {+    let resolveRootDep!: (comp: ComponentOptions) => void+    const rootDep = new Promise<ComponentOptions>(resolve => {+      resolveRootDep = resolve+    })+    const RootDep = defineAsyncComp(() => rootDep)+    const makePage = (name: string) =>+      defineAsyncComponent({+        render: () => h('div', `page ${name}`),+      })+    const PageA = makePage('A')+    const PageB = makePage('B')+    const page = shallowRef(PageA)+    const key = ref('a')+    const root = nodeOps.createElement('div')+    const App = {+      render() {+        return h(Suspense, null, {+          default: h('div', [+            h(RootDep),+            h(KeepAlive, null, {+              default: () =>+                h(Suspense, null, {+                  default: h(page.value, { key: key.value }),+                }),+            }),+          ]),+          fallback: h('div', 'loading'),+        })+      },+    }++    render(h(App), root)+    expect(serializeInner(root)).toBe('<div>loading</div>')++    await Promise.all(deps)+    await nextTick()++    page.value = PageB+    key.value = 'b'+    await nextTick()+    expect(serializeInner(root)).toBe('<div>loading</div>')++    resolveRootDep({+      render: () => h('div', 'root'),+    })+    await rootDep+    await new Promise(r => setTimeout(r))+    await nextTick()+    expect(serializeInner(root)).toBe(+      '<div><div>root</div><div>page A</div></div>',+    )++    page.value = PageA+    key.value = 'a'+    await nextTick()+    expect(serializeInner(root)).toBe(+      '<div><div>root</div><div>page A</div></div>',+    )++    page.value = PageB+    key.value = 'b'+    await nextTick()+    await Promise.all(deps)+    await nextTick()+    expect(serializeInner(root)).toBe(+      '<div><div>root</div><div>page B</div></div>',+    )+  })+   test('KeepAlive + Suspense + comment slot', async () => {     const toggle = ref(false)     const Async = defineAsyncComponent({packages/runtime-core/src/components/KeepAlive.tsindex 55eaf8624..b09152f72 100644@@ -248,7 +248,10 @@ const KeepAliveImpl: ComponentOptions = {         // avoid caching vnode that not been mounted         if (isSuspense(instance.subTree.type)) {           queuePostRenderEffect(() => {-            cache.set(pendingCacheKey!, getInnerChild(instance.subTree))+            const vnode = getInnerChild(instance.subTree)+            if (vnode.component) {+              cache.set(pendingCacheKey!, vnode)+            }           }, instance.subTree.suspense)         } else {           cache.set(pendingCacheKey, getInnerChild(instance.subTree))