Backtestsvuerun-20261005-124535#15495
[compiler-sfc] Top-level await inside switch case generates invalid code (missing semicolon before rewrite)
Our patch was judged better than the merged fix.
In this judgment, Patch A = our agent, Patch B = the merged fix.
Both patches make the same source change in compileScript.ts: they push `SwitchCase.consequent` onto the scope stack on enter and pop it on leave. This fixes the root cause the issue identifies, so the two are equally correct. The only differences are in the tests. Patch A tests the reported repro (an await after `qux()` inside a switch nested in an `if`). It also tests the 'consecutive awaits in one case' variant the issue explicitly lists: the second await gets `;(` and the first statement of a case gets no semicolon. Its third scenario is a `default` case following a `break`. Its negative assertions (`not.toMatch(/qux\(\)\s*\(/)` and the back-to-back `)(` check) directly catch the buggy output. Patch B tests only the 'await after an expression statement' case, both top-level and nested in a block. It does not cover consecutive awaits or verify that the first statement of a case is left alone. Both test sets would fail before the fix, but A's covers more of the issue's described variants. Patch B's braced `leave` body is marginally tidier stylistically, but that is negligible.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
7m 28s
Wall-clock time in the container
Full test suite
No new failures
3,741 passed · 6 skipped · 3,747 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
97vs 76 merged
Changed lines, ours vs merged
The issue
View on GitHub[compiler-sfc] Top-level await inside switch case generates invalid code (missing semicolon before rewrite)
Vue version
3.5.42 — also reproduced on main (5409708)
Link to minimal reproduction
Steps to reproduce
- Open the playground link above (or compile the SFC below with
@vue/compiler-sfc). - The component
setup()throwsTypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)).
SFC:
<script setup>
const a = true
const b = 1
function qux() {}
async function bar() { return 42 }
if (a) {
switch (b) {
case 1:
qux()
await bar()
}
}
</script>
What is expected?
The compiled setup() should run fine: qux() and await bar() should be two independent statements.
What is actually happening?
The top-level await rewrite in compileScript emits the withAsyncContext wrapper expression without a leading semicolon when the await is inside a switch case that is not the first statement:
async setup(__props, { expose: __expose }) {
...
if (a) {
switch (b) {
case 1:
qux()
(
([__temp,__restore] = _withAsyncContext(() => bar())),
await __temp,
__restore()
)
}
}
}
Because the next line starts with (, ASI does not insert a semicolon, so the two lines are parsed as a single call expression qux()(...). bar() is never awaited in the intended way and the runtime throws TypeError: object is not iterable.
The same code inside a plain block (not a switch) is compiled correctly with a leading ;:
if (a) {
qux()
;(
([__temp,__restore] = _withAsyncContext(() => bar())),
await __temp,
__restore()
)
}
Additional comments
Root cause: in packages/compiler-sfc/src/compileScript.ts, the scope stack used to decide whether the rewrite needs a semicolon only pushes/pops on BlockStatement. A switch statement's SwitchCase.consequent statement list is not tracked, so needsSemi is misjudged as false for await expressions inside case branches (unless the await happens to be the very first statement of the case).
Related variants also affected:
- Two consecutive top-level awaits inside one case produce
(...)(...)back-to-back (second one also parsed as a call of the first result). - Any
awaitthat follows an expression statement inside a case branch.
No prior issue found for this.
The two patches
packages/compiler-sfc/__tests__/__snapshots__/compileScript.spec.ts.snapindex 795f0ae88..ca1087de1 100644@@ -206,6 +206,41 @@ return { n, get x() { return x } } })" `; +exports[`SFC compile <script setup> > async/await detection > consecutive awaits in switch case 1`] = `+"import { withAsyncContext as _withAsyncContext } from 'vue'++export default {+ async setup(__props, { expose: __expose }) {+ __expose();++let __temp, __restore+switch (b) {+ case 1:+ (+ ([__temp,__restore] = _withAsyncContext(() => foo())),+ await __temp,+ __restore()+)+ ;(+ ([__temp,__restore] = _withAsyncContext(() => bar())),+ await __temp,+ __restore()+)+ break+ default:+ baz()+ ;(+ ([__temp,__restore] = _withAsyncContext(() => qux())),+ await __temp,+ __restore()+)+ }+return { }+}++}"+`;+ exports[`SFC compile <script setup> > async/await detection > expression statement 1`] = ` "import { withAsyncContext as _withAsyncContext } from 'vue' @@ -605,6 +640,31 @@ return { } }" `; +exports[`SFC compile <script setup> > async/await detection > switch case statements 1`] = `+"import { withAsyncContext as _withAsyncContext } from 'vue'++export default {+ async setup(__props, { expose: __expose }) {+ __expose();++let __temp, __restore+if (a) {+ switch (b) {+ case 1:+ qux()+ ;(+ ([__temp,__restore] = _withAsyncContext(() => bar())),+ await __temp,+ __restore()+)+ }+ }+return { }+}++}"+`;+ exports[`SFC compile <script setup> > async/await detection > variable 1`] = ` "import { withAsyncContext as _withAsyncContext } from 'vue' packages/compiler-sfc/__tests__/compileScript.spec.tsindex a1cc885cd..eff8845c6 100644@@ -960,6 +960,38 @@ describe('SFC compile <script setup>', () => { assertAwaitDetection(`if (ok) { await foo } else { await bar }`) }) + // should prepend semicolon inside switch case+ test('switch case statements', () => {+ const code = assertAwaitDetection(`if (a) {+ switch (b) {+ case 1:+ qux()+ await bar()+ }+ }`)+ expect(code).toMatch(/qux\(\)\n\s*;\(/)+ expect(code).not.toMatch(/qux\(\)\s*\(/)+ })++ test('consecutive awaits in switch case', () => {+ const code = assertAwaitDetection(`switch (b) {+ case 1:+ await foo()+ await bar()+ break+ default:+ baz()+ await qux()+ }`)+ // first statement of a case does not need a semicolon+ expect(code).toMatch(/case 1:\n\s*\(/)+ expect(code).toMatch(+ /\)\n\s*;\(\n {2}\(\[__temp,__restore\] = _withAsyncContext\(\(\) => bar\(\)\)\)/,+ )+ expect(code).toMatch(/baz\(\)\n\s*;\(/)+ expect(code).not.toMatch(/\)\s*\(\s*\(\[__temp/)+ })+ test('multiple `if` nested statements', () => { assertAwaitDetection(`if (ok) { let a = 'foo'packages/compiler-sfc/src/compileScript.tsindex 901196235..9337d5cd1 100644@@ -646,6 +646,8 @@ export function compileScript( } if (child.type === 'BlockStatement') { scope.push(child.body)+ } else if (child.type === 'SwitchCase') {+ scope.push(child.consequent) } if (child.type === 'AwaitExpression') { hasAwait = true@@ -670,7 +672,8 @@ export function compileScript( } }, leave(node: Node) {- if (node.type === 'BlockStatement') scope.pop()+ if (node.type === 'BlockStatement' || node.type === 'SwitchCase')+ scope.pop() }, }) }
packages/compiler-sfc/__tests__/__snapshots__/compileScript.spec.ts.snapindex 795f0ae88..c718e7690 100644@@ -206,6 +206,54 @@ return { n, get x() { return x } } })" `; +exports[`SFC compile <script setup> > async/await detection > await in switch case 1`] = `+"import { withAsyncContext as _withAsyncContext } from 'vue'++export default {+ async setup(__props, { expose: __expose }) {+ __expose();++let __temp, __restore+switch (a) {+ case 1:+ foo()+ ;(+ ([__temp,__restore] = _withAsyncContext(() => bar())),+ await __temp,+ __restore()+)+ }+return { }+}++}"+`;++exports[`SFC compile <script setup> > async/await detection > await in switch case nested in a block 1`] = `+"import { withAsyncContext as _withAsyncContext } from 'vue'++export default {+ async setup(__props, { expose: __expose }) {+ __expose();++let __temp, __restore+if (a) {+ switch (b) {+ case 1:+ qux()+ ;(+ ([__temp,__restore] = _withAsyncContext(() => bar())),+ await __temp,+ __restore()+)+ }+ }+return { }+}++}"+`;+ exports[`SFC compile <script setup> > async/await detection > expression statement 1`] = ` "import { withAsyncContext as _withAsyncContext } from 'vue' packages/compiler-sfc/__tests__/compileScript.spec.tsindex a1cc885cd..caaae92b4 100644@@ -960,6 +960,28 @@ describe('SFC compile <script setup>', () => { assertAwaitDetection(`if (ok) { await foo } else { await bar }`) }) + // #15495+ test('await in switch case', () => {+ const code = assertAwaitDetection(`switch (a) {+ case 1:+ foo()+ await bar()+ }`)+ expect(code).toMatch(/foo\(\)\s*;\(/)+ })++ // #15495+ test('await in switch case nested in a block', () => {+ const code = assertAwaitDetection(`if (a) {+ switch (b) {+ case 1:+ qux()+ await bar()+ }+ }`)+ expect(code).toMatch(/qux\(\)\s*;\(/)+ })+ test('multiple `if` nested statements', () => { assertAwaitDetection(`if (ok) { let a = 'foo'packages/compiler-sfc/src/compileScript.tsindex 901196235..3c070a0e0 100644@@ -646,6 +646,8 @@ export function compileScript( } if (child.type === 'BlockStatement') { scope.push(child.body)+ } else if (child.type === 'SwitchCase') {+ scope.push(child.consequent) } if (child.type === 'AwaitExpression') { hasAwait = true@@ -670,7 +672,9 @@ export function compileScript( } }, leave(node: Node) {- if (node.type === 'BlockStatement') scope.pop()+ if (node.type === 'BlockStatement' || node.type === 'SwitchCase') {+ scope.pop()+ } }, }) }