Backtestsvuerun-20261005-155915#15009
v-model on <select multiple> uses stale collection type after switching between Array and Set
Our patch was judged better than the merged fix.
In this judgment, Patch A = our agent, Patch B = the merged fix.
The production changes are functionally identical. Both drop the `isSetModel` value captured in `created`. Both store the current binding value on the element as `_modelValue` in `created` and refresh it in `beforeUpdate`. Both check `isSet(el._modelValue)` at change time. That fixes the root cause the issue describes, and Patch A's only source difference is an explanatory comment. The difference is in the tests. Patch B has one test that starts with an Array, switches to a Set, then back to an Array. It would fail before the fix, so it is valid. Patch A covers the same Array -> Set -> Array sequence and adds two things. First, it checks that `setSelected` reflects the new model type after each switch (`foo.selected`/`bar.selected` assertions). Second, it adds a separate test where the directive is created with a Set model and switched to an Array. That second test exercises the reverse stale-capture case the issue explicitly mentions, where the old code would wrongly emit a Set, from a different initial state. Patch A therefore covers both directions of the captured-type bug, while Patch B only covers the case where the directive was created with an Array. Scope and craft are otherwise equal. Patch A wins on test coverage.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
5m 15s
Wall-clock time in the container
Full test suite
No new failures
3,609 passed · 6 skipped · 3,615 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
104vs 55 merged
Changed lines, ours vs merged
The issue
View on GitHubVue version
3.5.39
Link to minimal reproduction
Steps to reproduce
- Bind a
<select multiple v-model>to an Array. - Switch the bound value to a Set at runtime.
- Interact with the select again.
- The emitted model becomes an Array again.
- Switching back from Set -> Array shows the same stale-type behavior in reverse.
What is expected?
The current collection type should be respected after the model switches at runtime.
What is actually happening?
The change handler keeps using the collection type captured when the directive was created, so the first user interaction after a runtime Array/Set switch emits the old type.
System Info
Any additional comments?
_No response_
The two patches
packages/runtime-dom/__tests__/directives/vModel.spec.tsindex 2b78b0c61..eea48a72f 100644@@ -1317,6 +1317,101 @@ describe('vModel', () => { expect(bar.selected).toEqual(true) }) + it('multiple select should respect model type switched at runtime (Array <-> Set)', async () => {+ const component = defineComponent({+ data() {+ return { value: [] as any }+ },+ render() {+ return [+ withVModel(+ h(+ 'select',+ {+ value: null,+ multiple: true,+ 'onUpdate:modelValue': setValue.bind(this),+ },+ [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+ ),+ this.value,+ ),+ ]+ },+ })+ render(h(component), root)++ const input = root.querySelector('select')+ const foo = root.querySelector('option[value=foo]')+ const bar = root.querySelector('option[value=bar]')+ const data = root._vnode.component.data++ foo.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(Array.isArray(data.value)).toBe(true)+ expect(data.value).toEqual(['foo'])++ // Array -> Set+ data.value = new Set(['foo'])+ await nextTick()+ bar.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(data.value).toBeInstanceOf(Set)+ expect(data.value).toMatchObject(new Set(['foo', 'bar']))++ // Set -> Array+ data.value = ['bar']+ await nextTick()+ expect(foo.selected).toBe(false)+ expect(bar.selected).toBe(true)+ foo.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(Array.isArray(data.value)).toBe(true)+ expect(data.value).toEqual(['foo', 'bar'])+ })++ it('multiple select should respect model type switched at runtime (Set -> Array)', async () => {+ const component = defineComponent({+ data() {+ return { value: new Set() as any }+ },+ render() {+ return [+ withVModel(+ h(+ 'select',+ {+ value: null,+ multiple: true,+ 'onUpdate:modelValue': setValue.bind(this),+ },+ [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+ ),+ this.value,+ ),+ ]+ },+ })+ render(h(component), root)++ const input = root.querySelector('select')+ const foo = root.querySelector('option[value=foo]')+ const bar = root.querySelector('option[value=bar]')+ const data = root._vnode.component.data++ data.value = ['foo']+ await nextTick()+ expect(foo.selected).toBe(true)+ bar.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(Array.isArray(data.value)).toBe(true)+ expect(data.value).toEqual(['foo', 'bar'])+ })+ it('multiple select (model is Set, option value is object)', async () => { const fooValue = { foo: 1 } const barValue = { bar: 1 }packages/runtime-dom/src/directives/vModel.tsindex b49bf809e..eb12014a7 100644@@ -207,7 +207,9 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { // <select multiple> value need to be deep traversed deep: true, created(el, { value, modifiers: { number } }, vnode) {- const isSetModel = isSet(value)+ // store the v-model value on the element so the change listener respects+ // the current collection type (Array / Set) even if it changes at runtime.+ ;(el as any)._modelValue = value addEventListener(el, 'change', () => { const selectedVal = Array.prototype.filter .call(el.options, (o: HTMLOptionElement) => o.selected)@@ -216,7 +218,7 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { ) el[assignKey]( el.multiple- ? isSetModel+ ? isSet((el as any)._modelValue) ? new Set(selectedVal) : selectedVal : selectedVal[0],@@ -233,7 +235,8 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { mounted(el, { value }) { setSelected(el, value) },- beforeUpdate(el, _binding, vnode) {+ beforeUpdate(el, { value }, vnode) {+ ;(el as any)._modelValue = value el[assignKey] = getModelAssigner(vnode) }, updated(el, { value }) {
packages/runtime-dom/__tests__/directives/vModel.spec.tsindex 2b78b0c61..590c0d7df 100644@@ -1317,6 +1317,54 @@ describe('vModel', () => { expect(bar.selected).toEqual(true) }) + it('multiple select uses current Array/Set model type', async () => {+ const component = defineComponent({+ data() {+ return { value: [] }+ },+ render() {+ return [+ withVModel(+ h(+ 'select',+ {+ value: null,+ multiple: true,+ 'onUpdate:modelValue': setValue.bind(this),+ },+ [h('option', { value: 'foo' }), h('option', { value: 'bar' })],+ ),+ this.value,+ ),+ ]+ },+ })+ render(h(component), root)++ const input = root.querySelector('select')+ const foo = root.querySelector('option[value=foo]')+ const bar = root.querySelector('option[value=bar]')+ const data = root._vnode.component.data++ data.value = new Set(['foo'])+ await nextTick()+ foo.selected = true+ bar.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(data.value).toBeInstanceOf(Set)+ expect(data.value).toMatchObject(new Set(['foo', 'bar']))++ data.value = ['foo']+ await nextTick()+ foo.selected = false+ bar.selected = true+ triggerEvent('change', input)+ await nextTick()+ expect(Array.isArray(data.value)).toBe(true)+ expect(data.value).toMatchObject(['bar'])+ })+ it('multiple select (model is Set, option value is object)', async () => { const fooValue = { foo: 1 } const barValue = { bar: 1 }packages/runtime-dom/src/directives/vModel.tsindex b49bf809e..766db6bfe 100644@@ -207,7 +207,7 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { // <select multiple> value need to be deep traversed deep: true, created(el, { value, modifiers: { number } }, vnode) {- const isSetModel = isSet(value)+ ;(el as any)._modelValue = value addEventListener(el, 'change', () => { const selectedVal = Array.prototype.filter .call(el.options, (o: HTMLOptionElement) => o.selected)@@ -216,7 +216,7 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { ) el[assignKey]( el.multiple- ? isSetModel+ ? isSet((el as any)._modelValue) ? new Set(selectedVal) : selectedVal : selectedVal[0],@@ -233,7 +233,8 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { mounted(el, { value }) { setSelected(el, value) },- beforeUpdate(el, _binding, vnode) {+ beforeUpdate(el, { value }, vnode) {+ ;(el as any)._modelValue = value el[assignKey] = getModelAssigner(vnode) }, updated(el, { value }) {