Backtestsvuerun-20261005-155915#15153

Issue #15153 Merged fix PR #15154 Run 5 Oct 2026 · run-20261005-155915 vuejs/core

Custom elements: async components nested ≥3 levels crash with TypeError: Cannot read properties of null (reading 'provides') — chained child resolve races its parent's mount

Better

Our patch was judged better than the merged fix.

In this judgment, Patch B = our agent, Patch A = the merged fix.

Both patches fix the root cause the issue identifies. The chained promise now settles only after the async element's own loader has resolved and mounted, so descendants chained on it cannot mount before their parent.

**How each patch does it**
- **Patch A** makes `_resolveDef()` return the loader promise and has the chain callback return that value. It also adds an `isConnected` guard so a detached child does not resolve.
- **Patch B** gets the same effect by returning `this._pendingResolve` from the chain callback after calling `_resolveDef()`. It also restructures `connectedCallback` so an element that has already resolved (`_resolved` but no `_instance`) still waits for a pending async parent. That re-insertion case is the same null-`provides` crash class, reached through `_mount` rather than `_resolveDef`, so it is a related hardening of the same ancestor-first guarantee rather than unrelated churn.

**Tests**
- **Patch A** has a clean, deterministic test using manually resolved promises: 3 levels with provide/inject checks. This would fail before the fix. Its disconnect test exercises A's extra `isConnected` behavior, not the reported bug.
- **Patch B** tests:
  - the exact issue scenario (3 levels, middle slowest);
  - a 4-level case where several deeper levels settle before their ancestors, which exercises the "any depth" claim;
  - inject inheritance across all levels;
  - the resolved-element re-insertion case.

  B's tests rely on real timeouts, so they are slightly more timing-dependent. However, the margins are generous.

**Verdict**
On correctness both are sound for the reported scenario. B closes an additional path to the same crash and verifies deeper nesting. A's `isConnected` guard is a reasonable but tangential addition. Overall B is the somewhat more complete fix, with broader test coverage of the reported behavior.

The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.

Solve

9m 54s

Wall-clock time in the container

Full test suite

No new failures

3,633 passed · 6 skipped · 3,639 total

Contamination audit

Clean

No sign the agent saw the real fix

Patch size

166vs 119 merged

Changed lines, ours vs merged

Vue version

3.5.40 (latest at the time of writing — the inline repro pins it; also reproduced on 3.5.13, 3.5.17, 3.5.30 and 3.6.0-rc.2; 3.4.38 — before the nested-async chaining existed — crashes with the same null dereference in the older _setParent provides copy inside vnode.ce)

Link to minimal reproduction

https://play.vuejs.org/#eNptVNFu4zYQ/JWBi0IyKssOihaBznYQJC6uRS53OLhPcR4YcW2xoUiCpOQYhv+9ICk7OeBeDHG5Ozs7nuVxdGtM2Xc0qkZzV1thPBz5ziw3SrRGW48jOG2ForvOed2uJLWkfDEEb91B1Xe6NVrFaFNAqy+6U554AUtbnLC1ukXWd5Rt1EbVWjmPRjuPRUjIVSfleKOmU9yTZAeHutGOFJyGbwit4FwSJPUkAzUvyeH2r/XqO4QPyULyCrrzZLFlzhcRaqhyUu8LCKWGyxLrRjjUlrmGHLTC1Wz2K/QWUjPuyjM9npgscET2NongWYU/ZkU4Juyswu+zFIj4WYWrGU7vI7bslS7KYIFcsZbGWCyRHzcKCMcifLRJrnyMI0KpllRKvcuz4QIZfkMqPsUCS4qTjfmWfGcVmjzjos8KHOH8QVKFjAtnJDtUL1LXr58M41yoXfWnefv0oi0nW12ZNzgtBccv19fXGU4FniKngOak9tn4OXU8jX+c6kEzTjaM5NkuTRR+41C0xzerW+Eozy05Lfs0syO/Fi3pzucxGcNl/oNMEXBcDPo/ebZ7HsfmF1MN1VHBvVBc70vG+aon5R+E86TI5lmnGqa4JG7pP6q90CorkNOZJC4yk7Xa5tm/j59vH+8fVvf4vvpndbf+++tjFVXPqbTEnFY3ZUvOsR3h5gbn4DhwA6JzwzJEv/rGEsGznYNhlpSfbIV1vgyZW22RJx092wXbPV3s9dFaH1z1PE6zAvXH/XNl2r8gWPGzBc1/tp/5+7+XlE4DnIYpHskFu6VGoKFTASOZUOCixwv5PZFK2+hKfGPWkZ3UlliobJl97cyAljvPvKjxef3lYQxLxmre1eQgOCkvaiblARM4SroJJYOETqidpMlWSEo1UbjwXJQ9kx2VUZaAiUXSJZsPEi7nZwGXcy76cIzJy7T/UuwaD67b+fR8MZ/GvOl73fSMlSXbz6fpUVwGE849tUYyT9FFc7P8akhF8oOfKmxG56UdemxGUNSTBTOGmHWYQPjLA7QXvokAxupecHJYHwytgivL+dSkPkF4S9vFZhRk2IwG2oHcB0Kj0/8+/flr

Steps to reproduce

  1. Open the reproduction link and watch the console: mounted x-inner never appears — the element crashes with an unhandled TypeError: Cannot read properties of null (reading 'provides') and never mounts. (The playground variant inserts the nested markup dynamically after the define() calls; dynamic and parser-created markup crash identically.)
  2. Parser-created (static server-HTML-style) variant — self-contained single file, no build step (save as repro.html, serve statically, open in any browser; Chromium, Firefox and WebKit all reproduce):
<!doctype html>
<meta charset="utf-8" />
<title>nested async custom elements repro</title>
<x-outer>
  <x-middle>
    <div>
      <x-inner>inner light dom</x-inner>
    </div>
  </x-middle>
</x-outer>
<script type="module">
  import {
    defineCustomElement,
    defineAsyncComponent,
    h,
  } from "https://unpkg.com/vue@3.5.40/dist/vue.esm-browser.js";

  // Delays chosen so the middle level settles AFTER its child: outer fast,
  // middle slow, inner fast. This crashes on 100% of loads.
  const delays = { "x-outer": 50, "x-middle": 300, "x-inner": 10 };

  const makeComponent = (name) => ({
    name,
    mounted() {
      console.log(`mounted ${name}`);
    },
    render() {
      return h("div", { style: "display:block;padding:6px;border:1px solid #888" }, [name, h("slot")]);
    },
  });

  const makeLoader = (tag) => () =>
    new Promise((resolve) => setTimeout(() => resolve(makeComponent(tag)), delays[tag]));

  // Define the three tags parent-first.
  for (const tag of ["x-outer", "x-middle", "x-inner"]) {
    customElements.define(tag, defineCustomElement(defineAsyncComponent(makeLoader(tag))));
  }

  window.addEventListener("error", (e) => console.error("UNCAUGHT:", e.message));
  window.addEventListener("unhandledrejection", (e) =>
    console.error("UNHANDLED REJECTION:", e.reason?.message ?? e.reason),
  );
</script>

What is expected?

All three elements mount ancestor-first: mounted x-outer, mounted x-middle, mounted x-inner. The nested-async chaining added in 3.5.0 (37ccb9b, "delay mounting of custom elements with async parent", closing #9341 / #8127 / #9351) exists to guarantee exactly this.

What is actually happening?

mounted x-outer
UNHANDLED REJECTION: Cannot read properties of null (reading 'provides')
mounted x-middle

x-inner crashes in VueElement._mount → _inheritParentContext (runtime-dom — parent._instance.provides is dereferenced guarded only by parent && this._app), never mounts, and is left permanently half-resolved: _resolved: true, _instance: null, shadow root empty. Nothing ever retries it, no error surfaces through app.config.errorHandler, and any provide/inject inheritance it should have received is lost. Its own descendants (at deeper nesting) then crash against it in cascade.

Any additional comments?

Analysis (why depth ≥ 3 is the trigger)

connectedCallback of a child under a pending async parent chains:

this._pendingResolve = parent._pendingResolve.then(() => {
  this._pendingResolve = undefined;
  this._resolveDef();
});
  • For an unchained parent (depth 2), parent._pendingResolve is the parent's own _resolveDef() flow, which settles after the parent has mounted → 2-level nesting is safe. The variants table below confirms: 2 levels never crash.
  • For a chained parent (depth ≥ 3), parent._pendingResolve is itself a chain promise — and that promise settles when the parent's _resolveDef() returns (i.e. when the parent's async load starts), not when the parent mounts.

So once the first unchained ancestor mounts, the whole chain unwinds within a few microtasks: every deeper level's loader fires nearly simultaneously and mount order degenerates to network settlement order. Any child whose async definition settles before its parent has mounted hits _inheritParentContext while parent._instance === null and throws. With real-network chunk timings the victim set varies per load, so in an app this presents as a flaky, page-dependent breakage; with the fixed delays above it is 100% deterministic.

Variants checked (each re-run in a real browser):

VariantResult
3 levels, middle slowestcrashes every load
3 levels, inner slowestclean (race direction confirmed)
2 levelsclean (chained parent required)
plain <div> between levelsstill crashes (structure-independent)
markup inserted dynamically after all define() callsstill crashes
all loaders instantclean (microtask FIFO protects when nothing is pending)

_inheritParentContext (#13219, ~3.5.14) did not introduce the race — it converted a pre-existing silent misordering into a hard crash. 3.4.38 (no chaining) and 3.5.13 (chaining, pre-#13219) fail with the same null dereference in the older _setParent provides-copy path.

Suggested direction — either (or both):

  1. Chain the child to the parent's actual mount, not to _resolveDef() returning — e.g. resolve the parent's _pendingResolve only after _mount() has run, so the guarantee the chaining was built for ("ancestor mounts before descendant") holds at any depth.
  2. Guard _inheritParentContext against parent._instance === null and defer context inheritance until the parent instance exists, instead of throwing away the child permanently on an unhandled rejection.

The two patches

Our patch+157 −9
packages/runtime-dom/__tests__/customElement.spec.tsindex a5bea20b8..47d57734c 100644@@ -2210,6 +2210,147 @@ describe('defineCustomElement', () => {     expect(barVal).toBe('bar')   }) +  describe('multiple levels of nested async custom elements', () => {+    const defineAsyncLevels = (+      prefix: string,+      delays: number[],+      mounted: string[],+      injected: Record<string, unknown>,+    ) => {+      const tags = delays.map((_, i) => `${prefix}-${i}`)+      tags.forEach((tag, i) => {+        const comp = {+          name: tag,+          setup() {+            provide(`level-${i}`, tag)+            // inject everything provided by ancestor levels+            for (let j = 0; j < i; j++) {+              injected[`${tag}:level-${j}`] = inject(`level-${j}`)+            }+          },+          mounted() {+            mounted.push(tag)+          },+          render(this: any) {+            return h('div', null, [tag, renderSlot(this.$slots, 'default')])+          },+        }+        customElements.define(+          tag,+          defineCustomElement(+            defineAsyncComponent(+              () =>+                new Promise<typeof comp>(r =>+                  setTimeout(() => r(comp), delays[i]),+                ),+            ),+          ),+        )+      })+      return tags+    }++    const nest = (tags: string[]): string =>+      tags.length+        ? `<${tags[0]}><div>${nest(tags.slice(1))}</div></${tags[0]}>`+        : ''++    const waitFor = (ms: number) => new Promise(r => setTimeout(r, ms))++    test('3 levels, middle level settles after its child', async () => {+      const mounted: string[] = []+      const injected: Record<string, unknown> = {}+      const tags = defineAsyncLevels(+        'my-el-async-chain3',+        [5, 40, 0],+        mounted,+        injected,+      )+      container.innerHTML = nest(tags)++      await waitFor(80)+      expect(mounted).toEqual(tags)+      const inner = container.querySelector(tags[2]) as VueElement+      expect(inner._instance).toBeTruthy()+      expect(inner.shadowRoot!.innerHTML).toBe(+        `<div>${tags[2]}<slot></slot></div>`,+      )+      expect(injected[`${tags[2]}:level-0`]).toBe(tags[0])+      expect(injected[`${tags[2]}:level-1`]).toBe(tags[1])+      expect(injected[`${tags[1]}:level-0`]).toBe(tags[0])+    })++    test('4 levels, deeper levels settle before their ancestors', async () => {+      const mounted: string[] = []+      const injected: Record<string, unknown> = {}+      const tags = defineAsyncLevels(+        'my-el-async-chain4',+        [5, 40, 20, 0],+        mounted,+        injected,+      )+      container.innerHTML = nest(tags)++      await waitFor(120)+      expect(mounted).toEqual(tags)+      for (const tag of tags) {+        expect(+          (container.querySelector(tag) as VueElement)._instance,+        ).toBeTruthy()+      }+      for (let i = 1; i < tags.length; i++) {+        for (let j = 0; j < i; j++) {+          expect(injected[`${tags[i]}:level-${j}`]).toBe(tags[j])+        }+      }+    })++    test('resolved element re-inserted under a pending async parent', async () => {+      const mounted: string[] = []+      const injected: Record<string, unknown> = {}+      const [parentTag] = defineAsyncLevels(+        'my-el-async-reinsert',+        [10],+        mounted,+        injected,+      )+      const childTag = 'my-el-async-reinsert-child'+      customElements.define(+        childTag,+        defineCustomElement({+          setup() {+            injected.child = inject('level-0', 'default')+          },+          mounted() {+            mounted.push(childTag)+          },+          render() {+            return h('div', childTag)+          },+        }),+      )++      // mount the child standalone, then detach it so it unmounts+      const child = document.createElement(childTag) as VueElement+      container.appendChild(child)+      expect(injected.child).toBe('default')+      child.remove()+      await nextTick()+      expect(child._instance).toBeNull()+      mounted.length = 0++      // re-insert the already-resolved child under a still-loading parent+      container.innerHTML = `<${parentTag}></${parentTag}>`+      container.querySelector(parentTag)!.appendChild(child)++      await waitFor(40)+      expect(mounted).toEqual([parentTag, childTag])+      expect(child._instance).toBeTruthy()+      expect(child.shadowRoot!.innerHTML).toBe(`<div>${childTag}</div>`)+      expect(injected.child).toBe(parentTag)+    })+  })+   describe('configureApp', () => {     test('should work', () => {       const E = defineCustomElement(packages/runtime-dom/src/apiCustomElement.tsindex 9e1f3a720..5168d0e6f 100644@@ -307,17 +307,24 @@ export class VueElement     }      if (!this._instance) {-      if (this._resolved) {+      if (parent && parent._pendingResolve) {+        // the parent must mount first so its instance (and provides) exists+        this._pendingResolve = parent._pendingResolve.then(() => {+          this._pendingResolve = undefined+          if (this._resolved) {+            if (!this._instance) this._mount(this._def)+          } else {+            this._resolveDef()+          }+          // if this element is itself async, settle the chained promise only+          // after its own definition has resolved and it has mounted, so that+          // descendants chained on it never mount before it does+          return this._pendingResolve+        })+      } else if (this._resolved) {         this._mount(this._def)       } else {-        if (parent && parent._pendingResolve) {-          this._pendingResolve = parent._pendingResolve.then(() => {-            this._pendingResolve = undefined-            this._resolveDef()-          })-        } else {-          this._resolveDef()-        }+        this._resolveDef()       }     }   } 
Merged fix · PR #15154+117 −2
packages/runtime-dom/__tests__/customElement.spec.tsindex a5bea20b8..27c7121c2 100644@@ -2210,6 +2210,118 @@ describe('defineCustomElement', () => {     expect(barVal).toBe('bar')   }) +  test('nested async custom elements should mount ancestor-first', async () => {+    const mounted: string[] = []+    const OuterComp = defineComponent({+      setup() {+        provide('foo', 'foo')+      },+      mounted() {+        mounted.push('outer')+      },+      render() {+        return h('slot')+      },+    })+    const MiddleComp = defineComponent({+      setup() {+        provide('bar', 'bar')+      },+      mounted() {+        mounted.push('middle')+      },+      render() {+        return h('slot')+      },+    })+    const InnerComp = defineComponent({+      setup() {+        const foo = inject('foo')+        const bar = inject('bar')+        return () => h('div', `${foo}/${bar}`)+      },+      mounted() {+        mounted.push('inner')+      },+    })+    let resolveOuter!: (comp: typeof OuterComp) => void+    let resolveMiddle!: (comp: typeof MiddleComp) => void+    let resolveInner!: (comp: typeof InnerComp) => void+    const outerReady = new Promise<typeof OuterComp>(resolve => {+      resolveOuter = resolve+    })+    const middleReady = new Promise<typeof MiddleComp>(resolve => {+      resolveMiddle = resolve+    })+    const innerReady = new Promise<typeof InnerComp>(resolve => {+      resolveInner = resolve+    })++    const Outer = defineCustomElement(defineAsyncComponent(() => outerReady))+    const Middle = defineCustomElement(defineAsyncComponent(() => middleReady))+    const Inner = defineCustomElement(defineAsyncComponent(() => innerReady))++    customElements.define('async-chain-outer', Outer)+    customElements.define('async-chain-middle', Middle)+    customElements.define('async-chain-inner', Inner)+    container.innerHTML =+      `<async-chain-outer>` ++      `<async-chain-middle>` ++      `<async-chain-inner></async-chain-inner>` ++      `</async-chain-middle>` ++      `</async-chain-outer>`++    resolveInner(InnerComp)+    resolveOuter(OuterComp)+    await new Promise(resolve => setTimeout(resolve))+    resolveMiddle(MiddleComp)+    await new Promise(resolve => setTimeout(resolve))++    const inner = container.querySelector('async-chain-inner') as VueElement+    expect(mounted).toEqual(['outer', 'middle', 'inner'])+    expect(inner.shadowRoot!.innerHTML).toBe('<div>foo/bar</div>')+  })++  test('should not resolve nested custom element after disconnect', async () => {+    const mounted = vi.fn()+    const ParentComp = defineComponent({+      render() {+        return h('slot')+      },+    })+    let resolveParent!: (comp: typeof ParentComp) => void+    const parentReady = new Promise<typeof ParentComp>(resolve => {+      resolveParent = resolve+    })+    const Parent = defineCustomElement(defineAsyncComponent(() => parentReady))+    const Child = defineCustomElement({+      mounted,+      render() {+        return h('div', 'child')+      },+    })++    customElements.define('async-disconnect-parent', Parent)+    customElements.define('async-disconnect-child', Child)+    container.innerHTML =+      `<async-disconnect-parent>` ++      `<async-disconnect-child></async-disconnect-child>` ++      `</async-disconnect-parent>`++    const parent = container.firstChild as VueElement+    const child = parent.firstChild as VueElement+    child.remove()+    resolveParent(ParentComp)+    await new Promise(resolve => setTimeout(resolve))++    expect(mounted).not.toHaveBeenCalled()+    expect(child.shadowRoot!.innerHTML).toBe('')++    parent.appendChild(child)+    expect(mounted).toHaveBeenCalledOnce()+    expect(child.shadowRoot!.innerHTML).toBe('<div>child</div>')+  })+   describe('configureApp', () => {     test('should work', () => {       const E = defineCustomElement(packages/runtime-dom/src/apiCustomElement.tsindex 9e1f3a720..9422f58d6 100644@@ -313,7 +313,9 @@ export class VueElement         if (parent && parent._pendingResolve) {           this._pendingResolve = parent._pendingResolve.then(() => {             this._pendingResolve = undefined-            this._resolveDef()+            if (this.isConnected) {+              return this._resolveDef()+            }           })         } else {           this._resolveDef()@@ -371,7 +373,7 @@ export class VueElement    */   private _resolveDef() {     if (this._pendingResolve) {-      return+      return this._pendingResolve     }      // set initial attrs@@ -428,6 +430,7 @@ export class VueElement         def.configureApp = this._def.configureApp         resolve((this._def = def), true)       })+      return this._pendingResolve     } else {       resolve(this._def)     }