Backtestsvuerun-20261005-155915#15320
looseEqual() reports Map and Set instances with different contents as equal
Our patch was judged better than the merged fix.
In this judgment, Patch B = our agent, Patch A = the merged fix.
Both patches fix the root cause the same way. They add explicit isMap/isSet branches so Map and Set no longer fall through to the generic object path and the `String(a) === String(b)` fallback. Both compare contents order-insensitively, using looseEqual per element and requiring a distinct match per element (a matched-flags array), so duplicate-looking objects can't match the same counterpart twice. Map entries are compared as [key, value] pairs via looseEqual on arrays, giving loose key and value comparison in both. A puts its checks inside the isObject branch and B puts them just before it; the behavior is equivalent, and both reject Map-vs-Set and Map/Set-vs-other-type comparisons. So correctness is essentially a tie.
The difference is in the tests. Patch B covers more of what the issue raises:
- Key-order insensitivity for Maps and element-order insensitivity for Sets.
- Empty-vs-empty and size mismatches in both directions.
- Nested loose values.
- The distinct-match case `new Set([{a:1},{a:1}])` vs `new Set([{a:1},{a:2}])`.
- Cross-type comparisons against plain objects, arrays, and the literal strings '[object Map]' and '[object Set]'. These directly guard against the stringify fallback named in the issue.
- v-model `<select>` regression tests for both Map and Set, using the existing mountSelectModel helper, which matches surrounding conventions.
- SSR ssrRenderDynamicModel checks, which exercise another consumer of looseEqual.
Patch A's tests are reasonable but narrower. They have one Map-only v-model test built by hand with withVModel, and fewer edge cases.
On craft, B's helper has a clear explanatory comment and a name that describes its unordered semantics. The scope of both patches is appropriate. B wins on test thoroughness and on consistency with existing test helpers.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
6m 23s
Wall-clock time in the container
Full test suite
No new failures
3,693 passed · 6 skipped · 3,699 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
136vs 116 merged
Changed lines, ours vs merged
The issue
View on GitHubVue version
3.5.x / main (verified at a2b40db)
Link to minimal reproduction
Reproducible directly against the repo (see below) — looseEqual is not exported publicly, so the SFC Playground can only show the v-model symptom, not the root cause.
Steps to reproduce
looseEqual() in packages/shared/src/looseEqual.ts reports unrelated Map and Set instances as equal:
import { looseEqual } from '@vue/shared'
looseEqual(new Map([['a', 1]]), new Map([['b', 2]])) // true, expected false
looseEqual(new Set([1]), new Set([2])) // true, expected false
looseEqual(new Map([['a', 1]]), new Map()) // true, expected false
This surfaces to users through v-model on <select>. The following selects the wrong option:
const mapA = new Map([['id', 1]])
const mapB = new Map([['id', 2]])
const selected = ref(mapB)
<select v-model="selected">
<option :value="mapA">A</option>
<option :value="mapB">B</option>
</select>
el.selectedIndex is 0 (option A) when it should be 1, because looseEqual(mapA, mapB) returns true and the loop in setSelected stops at the first option.
What is expected?
Map/Set values with different contents compare as not equal, so v-model selects the option that actually matches.
What is actually happening?
Map and Set fall through to the generic object branch. Object.keys() on either is always [], so the key-count check passes and the for...in loop body never executes — entries are never compared. Execution then reaches the final line:
return String(a) === String(b)
Every Map stringifies to '[object Map]' and every Set to '[object Set]', so any two of the same type are reported equal.
Note this differs from Date and Symbol, which are given explicit branches above, and from arrays and plain objects, which compare correctly:
looseEqual([1], [2]) // false, correct
looseEqual({ a: 1 }, { a: 2 }) // false, correct
packages/shared/__tests__/looseEqual.spec.ts has 13 cases but none for Map/Set, which is why this hasn't been caught.
Possible fix
Add explicit branches before the generic object check, mirroring the existing Date/Symbol pattern. isMap and isSet already exist in packages/shared/src/general.ts. Set needs content comparison rather than reference lookup to stay consistent with looseEqual's semantics (e.g. new Set([{ a: 1 }]) vs new Set([{ a: 1 }])).
Worth confirming the intended semantics first: should Map comparison be key-order-insensitive, and should Set compare loosely (looseEqual per element) or strictly? Happy to open a PR with tests once the direction is confirmed.
System Info
Vue: 3.5.x / main @ a2b40db
Any additional comments?
Unrelated to #15298, which touches only vModel.ts.
The two patches
packages/runtime-dom/__tests__/directives/vModel.spec.tsindex 429163126..e715dfbb8 100644@@ -1416,6 +1416,28 @@ describe('vModel', () => { expect(input.selectedIndex).toBe(-1) }) + it('should select the matching option when values are Maps', async () => {+ const mapA = new Map([['id', 1]])+ const mapB = new Map([['id', 2]])+ const { input } = mountSelectModel(mapB, value => value, false, [+ mapA,+ mapB,+ ])++ expect(input.selectedIndex).toBe(1)+ })++ it('should select the matching option when values are Sets', async () => {+ const setA = new Set([1])+ const setB = new Set([2])+ const { input } = mountSelectModel(setB, value => value, false, [+ setA,+ setB,+ ])++ expect(input.selectedIndex).toBe(1)+ })+ it('should preserve the selected option when duplicate values exist', async () => { const { input, options, data } = mountSelectModel( null,packages/server-renderer/__tests__/ssrVModelHelpers.spec.tsindex 7d00b9cb7..34affdad6 100644@@ -19,6 +19,17 @@ describe('ssr: v-model helpers', () => { expect(ssrRenderDynamicModel('radio', 'foo', 'foo')).toBe(` checked`) expect(ssrRenderDynamicModel('radio', 1, '1')).toBe(` checked`) expect(ssrRenderDynamicModel('radio', 1, 0)).toBe(``)++ expect(+ ssrRenderDynamicModel('radio', new Map([['a', 1]]), new Map([['b', 2]])),+ ).toBe(``)+ expect(+ ssrRenderDynamicModel('radio', new Map([['a', 1]]), new Map([['a', 1]])),+ ).toBe(` checked`)+ expect(ssrRenderDynamicModel('radio', new Set([1]), new Set([2]))).toBe(``)+ expect(ssrRenderDynamicModel('radio', new Set([1]), new Set([1]))).toBe(+ ` checked`,+ ) }) test('ssrGetDynamicModelProps', () => {packages/shared/__tests__/looseEqual.spec.tsindex 2dea58ce5..fa93df661 100644@@ -233,4 +233,73 @@ describe('utils/looseEqual', () => { expect(looseEqual(arr1, arr5)).toBe(false) expect(looseEqual(arr5, arr1)).toBe(false) })++ test('compares Maps correctly', () => {+ const map1 = new Map<any, any>([['a', 1]])++ expect(looseEqual(map1, map1)).toBe(true)+ expect(looseEqual(map1, new Map([['a', 1]]))).toBe(true)+ // Different keys+ expect(looseEqual(map1, new Map([['b', 1]]))).toBe(false)+ // Different values+ expect(looseEqual(map1, new Map([['a', 2]]))).toBe(false)+ // Different sizes+ expect(looseEqual(map1, new Map())).toBe(false)+ expect(looseEqual(new Map(), map1)).toBe(false)+ expect(looseEqual(new Map(), new Map())).toBe(true)+ // Key order does not matter+ expect(+ looseEqual(+ new Map<any, any>([+ ['a', 1],+ ['b', 2],+ ]),+ new Map<any, any>([+ ['b', 2],+ ['a', 1],+ ]),+ ),+ ).toBe(true)+ // Nested values compare loosely+ expect(+ looseEqual(new Map([['a', { x: [1] }]]), new Map([['a', { x: [1] }]])),+ ).toBe(true)+ expect(+ looseEqual(new Map([['a', { x: [1] }]]), new Map([['a', { x: [2] }]])),+ ).toBe(false)+ // Map vs other types+ expect(looseEqual(map1, { a: 1 })).toBe(false)+ expect(looseEqual({ a: 1 }, map1)).toBe(false)+ expect(looseEqual(new Map(), {})).toBe(false)+ expect(looseEqual(new Map(), [])).toBe(false)+ expect(looseEqual(new Map(), new Set())).toBe(false)+ expect(looseEqual(map1, '[object Map]')).toBe(false)+ })++ test('compares Sets correctly', () => {+ const set1 = new Set([1, 2])++ expect(looseEqual(set1, set1)).toBe(true)+ expect(looseEqual(set1, new Set([1, 2]))).toBe(true)+ // Order does not matter+ expect(looseEqual(set1, new Set([2, 1]))).toBe(true)+ // Different contents+ expect(looseEqual(new Set([1]), new Set([2]))).toBe(false)+ // Different sizes+ expect(looseEqual(set1, new Set([1]))).toBe(false)+ expect(looseEqual(new Set([1]), new Set())).toBe(false)+ expect(looseEqual(new Set(), new Set())).toBe(true)+ // Elements compare loosely+ expect(looseEqual(new Set([{ a: 1 }]), new Set([{ a: 1 }]))).toBe(true)+ expect(looseEqual(new Set([{ a: 1 }]), new Set([{ a: 2 }]))).toBe(false)+ // Each element must match a distinct element+ expect(+ looseEqual(new Set([{ a: 1 }, { a: 1 }]), new Set([{ a: 1 }, { a: 2 }])),+ ).toBe(false)+ // Set vs other types+ expect(looseEqual(new Set([1]), [1])).toBe(false)+ expect(looseEqual([1], new Set([1]))).toBe(false)+ expect(looseEqual(new Set(), {})).toBe(false)+ expect(looseEqual(new Set(), '[object Set]')).toBe(false)+ }) })packages/shared/src/looseEqual.tsindex 9e7176721..3ae13693b 100644@@ -1,4 +1,4 @@-import { isArray, isDate, isObject, isSymbol } from './general'+import { isArray, isDate, isMap, isObject, isSet, isSymbol } from './general' function looseCompareArrays(a: any[], b: any[]) { if (a.length !== b.length) return false@@ -9,6 +9,24 @@ function looseCompareArrays(a: any[], b: any[]) { return equal } +// order-insensitive comparison where each item of `a` must be matched by a+// distinct, loosely-equal item of `b`+function looseCompareUnordered(a: any[], b: any[]) {+ if (a.length !== b.length) return false+ const matched: boolean[] = new Array(b.length).fill(false)+ for (let i = 0; i < a.length; i++) {+ let found = false+ for (let j = 0; j < b.length; j++) {+ if (!matched[j] && looseEqual(a[i], b[j])) {+ matched[j] = found = true+ break+ }+ }+ if (!found) return false+ }+ return true+}+ export function looseEqual(a: any, b: any): boolean { if (a === b) return true let aValidType = isDate(a)@@ -26,6 +44,20 @@ export function looseEqual(a: any, b: any): boolean { if (aValidType || bValidType) { return aValidType && bValidType ? looseCompareArrays(a, b) : false }+ aValidType = isMap(a)+ bValidType = isMap(b)+ if (aValidType || bValidType) {+ return aValidType && bValidType+ ? looseCompareUnordered(Array.from(a.entries()), Array.from(b.entries()))+ : false+ }+ aValidType = isSet(a)+ bValidType = isSet(b)+ if (aValidType || bValidType) {+ return aValidType && bValidType+ ? looseCompareUnordered(Array.from(a), Array.from(b))+ : false+ } aValidType = isObject(a) bValidType = isObject(b) if (aValidType || bValidType) {
packages/runtime-dom/__tests__/directives/vModel.spec.tsindex 429163126..a94cb8e0d 100644@@ -1874,4 +1874,32 @@ describe('vModel', () => { await nextTick() expect(foo.checked).toEqual(false) })++ // #15320+ it('selects the matching option when values are maps', () => {+ const mapA = new Map([['id', 1]])+ const mapB = new Map([['id', 2]])+ const value = ref(mapB)+ const component = defineComponent(+ () => () =>+ withVModel(+ h(+ 'select',+ {+ 'onUpdate:modelValue': (val: Map<string, number>) =>+ (value.value = val),+ },+ [+ h('option', { value: mapA }, 'A'),+ h('option', { value: mapB }, 'B'),+ ],+ ),+ value.value,+ ),+ )++ render(h(component), root)++ expect(root.querySelector('select').selectedIndex).toBe(1)+ }) })packages/shared/__tests__/looseEqual.spec.tsindex 2dea58ce5..777f3cfad 100644@@ -233,4 +233,59 @@ describe('utils/looseEqual', () => { expect(looseEqual(arr1, arr5)).toBe(false) expect(looseEqual(arr5, arr1)).toBe(false) })++ test('compares maps correctly', () => {+ const map = new Map<any, any>([+ [{ id: 1 }, { value: '1' }],+ ['foo', 'bar'],+ ])++ expect(looseEqual(map, map)).toBe(true)+ expect(+ looseEqual(+ map,+ new Map<any, any>([+ ['foo', 'bar'],+ [{ id: '1' }, { value: 1 }],+ ]),+ ),+ ).toBe(true)+ expect(looseEqual(map, new Map([['foo', 'bar']]))).toBe(false)+ expect(looseEqual(new Map([['a', 1]]), new Map([['b', 2]]))).toBe(false)+ expect(+ looseEqual(+ new Map<any, any>([+ ['a', 1],+ ['b', 2],+ ]),+ new Map<any, any>([+ ['a', 2],+ ['b', 1],+ ]),+ ),+ ).toBe(false)+ expect(+ looseEqual(+ new Map<any, any>([+ [1, 'value'],+ ['1', 'value'],+ ]),+ new Map<any, any>([+ [1, 'value'],+ [2, 'value'],+ ]),+ ),+ ).toBe(false)+ })++ test('compares sets correctly', () => {+ const set = new Set<any>([{ id: 1 }, 'foo'])++ expect(looseEqual(set, set)).toBe(true)+ expect(looseEqual(set, new Set(['foo', { id: '1' }]))).toBe(true)+ expect(looseEqual(set, new Set(['foo']))).toBe(false)+ expect(looseEqual(new Set([1]), new Set([2]))).toBe(false)+ expect(looseEqual(new Set<any>([1, '1']), new Set<any>([1, 2]))).toBe(false)+ expect(looseEqual(new Set(), new Map())).toBe(false)+ }) })packages/shared/src/looseEqual.tsindex 9e7176721..d037b0a57 100644@@ -1,4 +1,4 @@-import { isArray, isDate, isObject, isSymbol } from './general'+import { isArray, isDate, isMap, isObject, isSet, isSymbol } from './general' function looseCompareArrays(a: any[], b: any[]) { if (a.length !== b.length) return false@@ -9,6 +9,27 @@ function looseCompareArrays(a: any[], b: any[]) { return equal } +function looseCompareCollections(+ a: Map<any, any> | Set<any>,+ b: Map<any, any> | Set<any>,+) {+ if (a.size !== b.size) return false+ const candidates = Array.from(b)+ const matched = new Uint8Array(candidates.length)+ for (const item of a) {+ let index = -1+ for (let i = 0; i < candidates.length; i++) {+ if (!matched[i] && looseEqual(item, candidates[i])) {+ index = i+ break+ }+ }+ if (index < 0) return false+ matched[index] = 1+ }+ return true+}+ export function looseEqual(a: any, b: any): boolean { if (a === b) return true let aValidType = isDate(a)@@ -32,6 +53,16 @@ export function looseEqual(a: any, b: any): boolean { if (!aValidType || !bValidType) { return false }+ aValidType = isMap(a)+ bValidType = isMap(b)+ if (aValidType || bValidType) {+ return aValidType && bValidType ? looseCompareCollections(a, b) : false+ }+ aValidType = isSet(a)+ bValidType = isSet(b)+ if (aValidType || bValidType) {+ return aValidType && bValidType ? looseCompareCollections(a, b) : false+ } const aKeysCount = Object.keys(a).length const bKeysCount = Object.keys(b).length if (aKeysCount !== bKeysCount) {