Backtestsvuerun-20261005-155915#15465
[compiler-sfc] Typo 'exit' instead of 'leave' in estree-walker causes missing ASI guard and runtime error with consecutive awaits
Our patch was judged better than the merged fix.
In this judgment, Patch B = our agent, Patch A = the merged fix.
Both patches make the same source change: `exit` becomes `leave` in the walker options in compileScript.ts. This fixes the root cause, since `scope.pop()` now runs when a BlockStatement is left. Correctness is therefore identical, and the decision rests on the tests. Patch A adds one runtime test. It compiles an SFC with `genDefaultAs`, strips the import line with a regex, evaluates the output via `new Function` with a stubbed `_withAsyncContext`, and checks that `setup` resolves. That would fail before the fix (TypeError from `(...)(...)`), but it depends on the exact shape of the generated code: the single leading import line, what `setup` returns, and the `expose` stub. It is also stylistically unusual for this spec file. Patch B adds two output-assertion tests in the style the surrounding await tests already use (`;(\n ([__temp,__restore] = ...` matches). They cover two nesting scenarios: an `if` inside an `if`, and a `for...of` body inside a `while`. Each also has a negative regex asserting that no `)(` call-chaining appears between the blocks. Both tests would fail before the fix and pass after it. They are more targeted, cover more cases, and fit the conventions of the file better. Patch B wins on tests and craft, with the source fix being equal.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
8m 10s
Wall-clock time in the container
Full test suite
No new failures
3,721 passed · 6 skipped · 3,727 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
44vs 21 merged
Changed lines, ours vs merged
The issue
View on GitHubVue version
3.5.40
Link to minimal reproduction
Steps to reproduce
- Open the SFC Playground link.
- Click on the "JS" tab in the right panel to view the compiled output.
- Observe the compiled code for the two
awaitstatements. - Notice that there is no semicolon (
;) inserted between the two_withAsyncContextblocks.
What is expected?
- Open the SFC Playground link.
- Click on the "JS" tab in the right panel to view the compiled output.
- Observe the compiled code for the two
awaitstatements. - Notice that there is no semicolon (
;) inserted between the two_withAsyncContextblocks.
What is actually happening?
What is actually happening? *
The ASI guard (`;`) is missing.
Because of this, the JavaScript engine interprets the second statement as a function call invoked on the result of the first statement, causing a runtime error: `TypeError: (...) is not a function`.
([temp,restore] = _withAsyncContext(() => Promise.resolve(1))),
await __temp,
__restore()
)( // <--- RUNTIME ERROR
([temp,restore] = _withAsyncContext(() => Promise.resolve(2))),
await __temp,
__restore()
)
### System Info
System:
OS: Linux 5.10 Debian GNU/Linux 11 (bullseye) 11 (bullseye)
CPU: (4) x64 AMD EPYC 9575F 64-Core Processor
Memory: 6.69 GB / 11.65 GB
Container: Yes
Shell: 5.1.4 - /bin/bash
Binaries:
Node: 24.14.1 - /root/.nvm/versions/node/v24.14.1/bin/node
Yarn: 1.22.22 - /root/.yarn/bin/yarn
npm: 11.11.0 - /root/.nvm/versions/node/v24.14.1/bin/npm
pnpm: 10.33.0 - /root/.nvm/versions/node/v24.14.1/bin/pnpm
Browsers:
Chrome: 150.0.7871.181
npmPackages:
vue: ^3.5.40 => 3.5.40
### Any additional comments?
**Root Cause:**
The bug is caused by a typo in the AST walker configuration inside `compiler-sfc`. The compiler uses `estree-walker` which expects the hooks `{ enter, leave }`. However, the code currently passes `{ enter, exit }`.
Since `exit` is not a valid hook in `estree-walker`, it is never called. Consequently, `scope.pop()` is never executed when leaving a `BlockStatement` (like the `if` block in the reproduction). This corrupts the `scope` stack, causing the `needsSemi` calculation to fail for all subsequent `AwaitExpression` nodes.
**Proposed Fix:**
Simply change `exit` to `leave` in the walker options:
- exit(node2) {
- leave(node2) { if (node2.type === "BlockStatement") scope.pop(); }
The two patches
packages/compiler-sfc/__tests__/compileScript.spec.tsindex d54541019..f4a51c194 100644@@ -1013,6 +1013,48 @@ describe('SFC compile <script setup>', () => { }`) }) + // a nested block must be popped from the scope stack once left, so that+ // subsequent awaits in the outer block still get their ASI guard+ test('consecutive awaits after a nested block statement', () => {+ const { content } = compile(`<script setup>+ if (ok) {+ if (a) {+ foo()+ }+ await Promise.resolve(1)+ await Promise.resolve(2)+ }+ </script>`)+ expect(content).toMatch(`let __temp, __restore`)+ expect(content).toMatch(`async setup(`)+ expect(content).toMatch(+ `;(\n ([__temp,__restore] = _withAsyncContext(() => Promise.resolve(1)))`,+ )+ expect(content).toMatch(+ `;(\n ([__temp,__restore] = _withAsyncContext(() => Promise.resolve(2)))`,+ )+ expect(content).not.toMatch(/\)\s*\(\s*\(\[__temp,__restore\]/)+ })++ test('consecutive awaits after a nested loop body', () => {+ const { content } = compile(`<script setup>+ while (ok) {+ for (const x of list) {+ foo(x)+ }+ await bar+ await baz+ }+ </script>`)+ expect(content).toMatch(+ `;(\n ([__temp,__restore] = _withAsyncContext(() => bar))`,+ )+ expect(content).toMatch(+ `;(\n ([__temp,__restore] = _withAsyncContext(() => baz))`,+ )+ expect(content).not.toMatch(/\)\s*\(\s*\(\[__temp,__restore\]/)+ })+ test('should ignore await inside functions', () => { // function declaration assertAwaitDetection(`async function foo() { await bar }`, false)packages/compiler-sfc/src/compileScript.tsindex d2047c5b2..901196235 100644@@ -669,7 +669,7 @@ export function compileScript( ) } },- exit(node: Node) {+ leave(node: Node) { if (node.type === 'BlockStatement') scope.pop() }, })
packages/compiler-sfc/__tests__/compileScript.spec.tsindex d54541019..a1cc885cd 100644@@ -1026,6 +1026,25 @@ describe('SFC compile <script setup>', () => { false, ) })++ // #15465+ test('await statements after a nested block should be separated', async () => {+ const { content } = compile(+ `<script setup>+ if (true) {+ if (false) {}+ await Promise.resolve(1)+ await Promise.resolve(2)+ }+ </script>`,+ { genDefaultAs: '_sfc_' },+ )+ const component = new Function(+ '_withAsyncContext',+ `${content.replace(/^import .*\n/, '')};return _sfc_`,+ )((getAwaitable: () => unknown) => [getAwaitable(), () => {}])+ await expect(component.setup({}, { expose() {} })).resolves.toEqual({})+ }) }) describe('errors', () => {packages/compiler-sfc/src/compileScript.tsindex d2047c5b2..901196235 100644@@ -669,7 +669,7 @@ export function compileScript( ) } },- exit(node: Node) {+ leave(node: Node) { if (node.type === 'BlockStatement') scope.pop() }, })