Backtestsvuerun-20261007-145226#11910

Issue #11910 Merged fix PR #11959 Run 7 Oct 2026 · run-20261007-145226 vuejs/core

Transition should sniff for teleport in custom components

Better

Our patch was judged better than the merged fix.

In this judgment, Patch A = our agent, Patch B = the merged fix.

Both patches fix the root cause the same way. When a component inside <Transition> renders a <Teleport> root, the transition hooks are now attached to the teleport's inner element rather than to the teleport vnode, and the dev warning is adjusted to match.

Patch A puts the unwrapping inside `setTransitionHooks` itself, as a teleport branch that recurses into the first non-comment child. Every caller benefits automatically:
- `renderComponentRoot`
- the component-subTree recursion that runs when hooks are updated
- TransitionGroup children

Patch A also documents why hooks must not sit on the teleport vnode: placeholder removal would otherwise fire leave callbacks early. It falls back sensibly for empty children. Its `isTransitionRoot` warning check uses `filterSingleRoot`, consistent with how `isElementRoot` is used elsewhere.

Patch B reaches the same behavior but duplicates the `isTeleport(x) ? getInnerChild(x) || x : x` unwrapping at two call sites, `renderComponentRoot` and the component branch of `setTransitionHooks`. It also has to export `getInnerChild`. That is more scattered and easier to miss in future call paths.

On tests, Patch A's unit tests exercise the real transition lifecycle through a component-rooted teleport, and would fail before the fix:
- leave keeps the element in the target until done
- enter
- appear
- out-in sequencing
- warning for non-element content
- empty teleport

Patch B's e2e test closely mirrors the issue and is valuable, and its hook-update test is useful. However, its KeepAlive test is unrelated to the change, and it does not cover appear or out-in.

Correctness is roughly equal. A wins on the more centralized, robust design and the more thorough lifecycle test coverage.

The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.

Solve

9m 29s

Wall-clock time in the container

Full test suite

No new failures

3,639 passed · 6 skipped · 3,646 total

Contamination audit

Clean

No sign the agent saw the real fix

Patch size

141vs 160 merged

Changed lines, ours vs merged

Vue version

3.5.4

Link to minimal reproduction

https://play.vuejs.org/#eNqNVE1v2zAM/SuadugGNHaG7pS5xT5QYNthG9YcfVFsOlEjS4JEOwmC/PdRUpw6RVrsZIt87+mRErXnX6zN+g74jBe+ctIi84CdvSu1bK1xyPbMQcMOrHGmZVcEvTqlvpnWHuNZHhZB6epTqUtdGe1JamU27DYIvGuE8vC+1EWetqENaIHQWiUQaMVYsegQjWafKyWr9W3Jj/Q34Vvyuwf65N9lDUWekIk1d0J7iZKYWrRAvEbUQPiQpXx02U9kc1QsOcsTM3+iRjv/ITYHBbF2NJRbmHpHcmfiRyRha9kzWQcJYyhe5BQYdPJB6JKTIh/1hZYedyr8ZsHLBDSCm4S2Xw8hBaKHCRq2D2rGikribsamdBSHoDAmonlGiwd4TvxwiSgqlD08I6dgouOphhkTSrFpduMZCA+D2ltqRIIuRLVeOtPpesYWqgsIxjayxhVtPp3abQysQC5XOI4sjKvBUcRumTdK1sQmqbQBXa3YKH7N0dMFbOQye/RG092Om5a8oqsgFbjfNrj0JZ8lOyFHjs3mZ4yh60KdKV6toFpfiD/6bYiV/I8DD66nS3LKoXBLwJS+f/gFW/o/JVtTd4rQryT/AhXXBY8J9pUaRbZHuOj2RxxDqZdzf79FoOYfiwpGA/IQ8SWnsQxT8FLpT3Zvso+RR/2kLg4jfeFxGD0Pp5EYvxHxEXht1i8N0jAcLw7O2dicTQk//AP1sJ3y

Steps to reproduce

Click the button

What is expected?

Both should transition in

What is actually happening?

One transitions correctly, the other throws a warning and blinks into existance

System Info

System:
    OS: Linux 5.15 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
    CPU: (16) x64 AMD Ryzen 7 PRO 6850HS with Radeon Graphics
    Memory: 11.86 GB / 15.28 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 22.2.0 - ~/.nvm/versions/node/v22.2.0/bin/node
    Yarn: 3.2.2 - ~/.nvm/versions/node/v22.2.0/bin/yarn
    npm: 10.7.0 - ~/.nvm/versions/node/v22.2.0/bin/npm
    pnpm: 7.25.0 - ~/.nvm/versions/node/v22.2.0/bin/pnpm
    bun: 1.1.8 - ~/.bun/bin/bun
  Browsers:
    Chrome: 126.0.6478.55

Any additional comments?

This is a follow up from

  • #5836

My Intention in #5836 was, that a user should be able to do this:

<Transition>
  <CustomComp />
</Transition>

<!-- Custom Comp -->
<Teleport>
  <div></div>
</Teleport>

However, the fix for #5836 only allows:

<Transition>
  <Teleport>
    <div></div>
  </Teleport>
</Transition>

For me as a user those 2 should feel equivalent.
The way it is now is not really useful. If you are not gonna use a custom component inside transition, you could just easily swap teleport and transition around (which already worked before the fix):

<teleport>
  <transition>
    <div></div>
  </transition>
</teleport>

But the whole point of #5836 was to allow to transition any component that teleports internally.
And since nesting a custom component into a transition works already, teleport should just be transparent in this case

Usecase:

  • modals <transition><Modal /></transition>
  • popovers
  • ...

The two patches

Our patch+140 −1
packages/runtime-core/__tests__/components/BaseTransition.spec.tsindex c541d5fc4..7b3f6d13b 100644@@ -2,6 +2,7 @@ import {   BaseTransition,   type BaseTransitionProps,   KeepAlive,+  Teleport,   type TestElement,   type VNodeProps,   h,@@ -1293,4 +1294,111 @@ describe('BaseTransition', () => {     await runTestWithKeepAlive(testOutIn)     __DEV__ = true   })++  describe('w/ Teleport as component root', () => {+    test('toggle on-off', async () => {+      const target = nodeOps.createElement('div')+      const Comp = ({ msg }: { msg: string }) =>+        h(Teleport, { to: target }, [h('div', msg)])+      const toggle = ref(true)+      const { props, cbs } = mockProps()+      mount(props, () => (toggle.value ? h(Comp, { msg: 'hello' }) : null))+      expect(serializeInner(target)).toBe(`<div>hello</div>`)++      toggle.value = false+      await nextTick()+      expect(props.onBeforeLeave).toHaveBeenCalledTimes(1)+      assertCalledWithEl(props.onBeforeLeave, `<div>hello</div>`)+      expect(props.onLeave).toHaveBeenCalledTimes(1)+      assertCalledWithEl(props.onLeave, `<div>hello</div>`)+      // element stays in the teleport target until leave finishes+      expect(serializeInner(target)).toBe(`<div>hello</div>`)+      cbs.doneLeave[`<div>hello</div>`]()+      expect(serializeInner(target)).toBe(``)+      expect(props.onAfterLeave).toHaveBeenCalledTimes(1)++      toggle.value = true+      await nextTick()+      expect(serializeInner(target)).toBe(`<div>hello</div>`)+      // before enter spy asserts node has no parent when it's called+      expect(props.onBeforeEnter).toHaveBeenCalledTimes(1)+      assertCalledWithEl(props.onBeforeEnter, `<div>hello</div>`)+      expect(props.onEnter).toHaveBeenCalledTimes(1)+      assertCalledWithEl(props.onEnter, `<div>hello</div>`)+      cbs.doneEnter[`<div>hello</div>`]()+      expect(props.onAfterEnter).toHaveBeenCalledTimes(1)++      assertCalls(props, {+        onEnterCancelled: 0,+        onLeaveCancelled: 0,+      })+      expect(+        `renders non-element root node that cannot be animated`,+      ).not.toHaveBeenWarned()+    })++    test('appear', () => {+      const target = nodeOps.createElement('div')+      const Comp = () => h(Teleport, { to: target }, [h('div')])+      const { props, cbs } = mockProps({ appear: true })+      mount(props, () => h(Comp))+      expect(props.onBeforeAppear).toHaveBeenCalledTimes(1)+      expect(props.onAppear).toHaveBeenCalledTimes(1)+      assertCalledWithEl(props.onAppear, `<div></div>`)+      cbs.doneEnter[`<div></div>`]()+      expect(props.onAfterAppear).toHaveBeenCalledTimes(1)+    })++    test('mode: "out-in"', async () => {+      const target = nodeOps.createElement('div')+      const CompA = () => h(Teleport, { to: target }, [h('div', 'a')])+      const CompB = () => h(Teleport, { to: target }, [h('span', 'b')])+      const toggle = ref(true)+      const { props, cbs } = mockProps({ mode: 'out-in' })+      mount(props, () => (toggle.value ? h(CompA) : h(CompB)))+      expect(serializeInner(target)).toBe(`<div>a</div>`)++      toggle.value = false+      await nextTick()+      expect(props.onLeave).toHaveBeenCalledTimes(1)+      assertCalledWithEl(props.onLeave, `<div>a</div>`)+      // enter waits for leave to finish+      expect(props.onEnter).not.toHaveBeenCalled()+      expect(serializeInner(target)).toBe(`<div>a</div>`)++      cbs.doneLeave[`<div>a</div>`]()+      expect(props.onAfterLeave).toHaveBeenCalledTimes(1)+      await nextTick()+      expect(serializeInner(target)).toBe(`<span>b</span>`)+      expect(props.onEnter).toHaveBeenCalledTimes(1)+      assertCalledWithEl(props.onEnter, `<span>b</span>`)+      cbs.doneEnter[`<span>b</span>`]()+      expect(props.onAfterEnter).toHaveBeenCalledTimes(1)+    })++    test('should warn when teleport content is not a single element', () => {+      const target = nodeOps.createElement('div')+      const Comp = () => h(Teleport, { to: target }, 'text')+      const { props } = mockProps()+      mount(props, () => h(Comp))+      expect(+        `renders non-element root node that cannot be animated`,+      ).toHaveBeenWarned()+    })++    test('should not throw when teleport has no vnode children', async () => {+      const target = nodeOps.createElement('div')+      const Comp = () => h(Teleport, { to: target }, [])+      const toggle = ref(true)+      const { props } = mockProps()+      mount(props, () => (toggle.value ? h(Comp) : null))+      expect(serializeInner(target)).toBe(``)+      toggle.value = false+      await nextTick()+      expect(serializeInner(target)).toBe(``)+      expect(+        `renders non-element root node that cannot be animated`,+      ).toHaveBeenWarned()+    })+  }) })packages/runtime-core/src/componentRenderUtils.tsindex 0b46130c0..49ec491b5 100644@@ -35,6 +35,7 @@ import { } from './compat/compatConfig' import { shallowReadonly } from '@vue/reactivity' import { setTransitionHooks } from './components/BaseTransition'+import { isTeleport } from './components/Teleport'  /**  * dev only flag to track whether $attrs was used during render.@@ -255,7 +256,7 @@ export function renderComponentRoot(   }   // inherit transition data   if (vnode.transition) {-    if (__DEV__ && !isElementRoot(root)) {+    if (__DEV__ && !isTransitionRoot(root)) {       warn(         `Component inside <Transition> renders non-element root node ` +           `that cannot be animated.`,@@ -368,6 +369,19 @@ const isElementRoot = (vnode: VNode) => {   ) } +// a teleport is transparent to transitions, so check its content instead+const isTransitionRoot = (vnode: VNode): boolean => {+  if (+    isTeleport(vnode.type) &&+    vnode.shapeFlag & ShapeFlags.ARRAY_CHILDREN &&+    vnode.children+  ) {+    const children = filterSingleRoot(vnode.children as VNodeArrayChildren)+    return !!children && !!isElementRoot(children)+  }+  return !!isElementRoot(vnode)+}+ export function shouldUpdateComponent(   prevVNode: VNode,   nextVNode: VNode,packages/runtime-core/src/components/BaseTransition.tsindex 4a9d5098e..44a4f8a30 100644@@ -12,6 +12,7 @@ import {   cloneVNode,   createCommentVNode,   isSameVNodeType,+  isVNode, } from '../vnode' import { warn } from '../warning' import { isKeepAlive } from './KeepAlive'@@ -542,6 +543,22 @@ export function setTransitionHooks(vnode: VNode, hooks: TransitionHooks): void {   } else if (__FEATURE_SUSPENSE__ && vnode.shapeFlag & ShapeFlags.SUSPENSE) {     vnode.ssContent!.transition = hooks.clone(vnode.ssContent!)     vnode.ssFallback!.transition = hooks.clone(vnode.ssFallback!)+  } else if (+    isTeleport(vnode.type) &&+    vnode.shapeFlag & ShapeFlags.ARRAY_CHILDREN &&+    vnode.children+  ) {+    // a teleport is transparent to transitions, e.g. a component inside+    // <Transition> that renders a <Teleport> as its root. The hooks must not+    // be set on the teleport vnode itself, otherwise removing its placeholder+    // anchors would trigger leave callbacks (e.g. out-in afterLeave) early.+    const child = findNonCommentChild(vnode.children as VNode[])+    if (isVNode(child)) {+      setTransitionHooks(child, hooks)+    } else {+      // empty or not-yet-normalized children, nothing to animate+      vnode.transition = hooks+    }   } else {     vnode.transition = hooks   } 
Merged fix · PR #11959+155 −5
packages/runtime-core/__tests__/components/BaseTransition.spec.tsindex c541d5fc4..65abcc6ff 100644@@ -2,6 +2,7 @@ import {   BaseTransition,   type BaseTransitionProps,   KeepAlive,+  Teleport,   type TestElement,   type VNodeProps,   h,@@ -1293,4 +1294,66 @@ describe('BaseTransition', () => {     await runTestWithKeepAlive(testOutIn)     __DEV__ = true   })++  test('should preserve transition for component with KeepAlive root', async () => {+    const root = nodeOps.createElement('div')+    const show = ref(false)+    const onBeforeEnter = vi.fn()+    const Child = { render: () => h('div', 'content') }+    const Comp = {+      render: () => h(KeepAlive, null, { default: () => h(Child) }),+    }+    const App = () =>+      h(BaseTransition, { onBeforeEnter }, () => (show.value ? h(Comp) : null))++    render(h(App), root)++    show.value = true+    await nextTick()+    expect(serializeInner(root)).toBe('<div>content</div>')+    expect(onBeforeEnter).toHaveBeenCalledTimes(1)+  })++  test('should not error on component with empty Teleport root', () => {+    const root = nodeOps.createElement('div')+    const target = nodeOps.createElement('div')+    const Comp = () => h(Teleport, { to: target }, [])++    expect(() =>+      render(+        h(BaseTransition, null, () => h(Comp)),+        root,+      ),+    ).not.toThrow()+    expect(serializeInner(root)).toBe(+      '<!--teleport start--><!--teleport end-->',+    )+    expect(serializeInner(target)).toBe('')+    expect(+      'Component inside <Transition> renders non-element root node',+    ).toHaveBeenWarned()+  })++  test('should update transition hooks for component with Teleport root', async () => {+    const root = nodeOps.createElement('div')+    const target = nodeOps.createElement('div')+    const show = ref(true)+    const firstBeforeLeave = vi.fn()+    const nextBeforeLeave = vi.fn()+    const beforeLeave = ref(firstBeforeLeave)+    const Comp = () => h(Teleport, { to: target }, h('div', 'content'))+    const App = () =>+      h(BaseTransition, { onBeforeLeave: beforeLeave.value }, () =>+        show.value ? h(Comp) : null,+      )++    render(h(App), root)++    beforeLeave.value = nextBeforeLeave+    show.value = false+    await nextTick()++    expect(firstBeforeLeave).not.toHaveBeenCalled()+    expect(nextBeforeLeave).toHaveBeenCalledTimes(1)+  }) })packages/runtime-core/src/componentRenderUtils.tsindex 0b46130c0..be58e5b0a 100644@@ -34,7 +34,8 @@ import {   warnDeprecation, } from './compat/compatConfig' import { shallowReadonly } from '@vue/reactivity'-import { setTransitionHooks } from './components/BaseTransition'+import { getInnerChild, setTransitionHooks } from './components/BaseTransition'+import { isTeleport } from './components/Teleport'  /**  * dev only flag to track whether $attrs was used during render.@@ -255,13 +256,14 @@ export function renderComponentRoot(   }   // inherit transition data   if (vnode.transition) {-    if (__DEV__ && !isElementRoot(root)) {+    const child = isTeleport(root.type) ? getInnerChild(root) || root : root+    if (__DEV__ && !isElementRoot(child)) {       warn(         `Component inside <Transition> renders non-element root node ` +           `that cannot be animated.`,       )     }-    setTransitionHooks(root, vnode.transition)+    setTransitionHooks(child, vnode.transition)   }    if (__DEV__ && setRoot) {packages/runtime-core/src/components/BaseTransition.tsindex 4a9d5098e..a8cfe8b71 100644@@ -506,7 +506,7 @@ function emptyPlaceholder(vnode: VNode): VNode | undefined {   } } -function getInnerChild(vnode: VNode): VNode | undefined {+export function getInnerChild(vnode: VNode): VNode | undefined {   if (!isKeepAlive(vnode)) {     if (isTeleport(vnode.type) && vnode.children) {       return findNonCommentChild(vnode.children as VNode[])@@ -538,7 +538,11 @@ function getInnerChild(vnode: VNode): VNode | undefined { export function setTransitionHooks(vnode: VNode, hooks: TransitionHooks): void {   if (vnode.shapeFlag & ShapeFlags.COMPONENT && vnode.component) {     vnode.transition = hooks-    setTransitionHooks(vnode.component.subTree, hooks)+    const subTree = vnode.component.subTree+    setTransitionHooks(+      isTeleport(subTree.type) ? getInnerChild(subTree) || subTree : subTree,+      hooks,+    )   } else if (__FEATURE_SUSPENSE__ && vnode.shapeFlag & ShapeFlags.SUSPENSE) {     vnode.ssContent!.transition = hooks.clone(vnode.ssContent!)     vnode.ssFallback!.transition = hooks.clone(vnode.ssFallback!)packages/vue/__tests__/e2e/Transition.spec.tsindex 17519e832..025cc7c00 100644@@ -2782,6 +2782,87 @@ describe('e2e: Transition', () => {       },       E2E_TIMEOUT,     )++    // #11910+    test(+      'apply transition to teleport component child',+      async () => {+        await page().evaluate(() => {+          const { createApp, ref } = (window as any).Vue+          createApp({+            template: `+            <div id="target"></div>+            <div id="container">+              <transition>+                  <Comp v-if="toggle"></Comp>+              </transition>+            </div>+            <button id="toggleBtn" @click="click">button</button>+          `,+            components: {+              Comp: {+                template: `+                    <Teleport to="#target">+                      <div class="test">content</div>+                    </Teleport>+                  `,+              },+            },+            setup: () => {+              const toggle = ref(false)+              const click = () => (toggle.value = !toggle.value)+              return { toggle, click }+            },+          }).mount('#app')+        })++        expect(await html('#target')).toBe('')+        expect(await html('#container')).toBe('<!--v-if-->')++        const classWhenTransitionStart = () =>+          page().evaluate(() => {+            ;(document.querySelector('#toggleBtn') as any)!.click()+            return Promise.resolve().then(() => {+              // find the class of teleported node+              return document+                .querySelector('#target div')!+                .className.split(/\s+/g)+            })+          })++        // enter+        expect(await classWhenTransitionStart()).toStrictEqual([+          'test',+          'v-enter-from',+          'v-enter-active',+        ])+        await nextFrame()+        expect(await classList('.test')).toStrictEqual([+          'test',+          'v-enter-active',+          'v-enter-to',+        ])+        await transitionFinish()+        expect(await html('#target')).toBe('<div class="test">content</div>')++        // leave+        expect(await classWhenTransitionStart()).toStrictEqual([+          'test',+          'v-leave-from',+          'v-leave-active',+        ])+        await nextFrame()+        expect(await classList('.test')).toStrictEqual([+          'test',+          'v-leave-active',+          'v-leave-to',+        ])+        await transitionFinish()+        expect(await html('#target')).toBe('')+        expect(await html('#container')).toBe('<!--v-if-->')+      },+      E2E_TIMEOUT,+    )   })    describe('transition with v-show', () => {