Backtestsvuerun-20261007-145226#15142
Suspense: flushing buffered effects overflows the call stack when many effects accumulate while pending (RangeError: Maximum call stack size exceeded)
Our patch was judged better than the merged fix.
In this judgment, Patch B = our agent, Patch A = the merged fix.
Both patches fix the issue at its root cause. Each replaces the three spread pushes the issue names with plain loops: `queuePostFlushCb`, the nested `flushPostFlushCbs` merge into `activePostFlushCbs`, and the Suspense merge into the pending parent's `effects`. On correctness they are equivalent for the reported scenario. Patch B also converts the spread in `queueEffectWithSuspense` (`suspense.effects.push(...fn)`). In practice that array is a lifecycle hook array and stays small, so the extra hardening is mostly neutral, but it is low-risk and closes a site with the same pattern. Tests are where the patches differ. Both add scheduler tests with 1M-entry arrays covering the direct `queuePostFlushCb` path and the nested-flush merge path. Those tests would fail before the fix and pass after it. Patch A adds nothing that exercises its Suspense.ts change. Patch B adds a nested-Suspense integration test: the inner boundary resolves first, its 1M buffered effects merge into the still-pending outer boundary via the loop in Suspense.ts, and the test then checks that all effects run once the outer boundary resolves. This test covers the actual Suspense path from the issue, including the merge site, and also passes through `queueEffectWithSuspense`. B's nested-flush scheduler test also checks that the outer callback finishes normally. Scope and craft are comparable: both have clear comments and follow the surrounding loop conventions. Patch B wins on more complete test coverage of the changed code paths.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
6m 11s
Wall-clock time in the container
Full test suite
No new failures
3,635 passed · 6 skipped · 3,641 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
130vs 55 merged
Changed lines, ours vs merged
The issue
View on GitHubVue version
3.5.39 (also reproduces on 3.5.40 / @b5f8518 in the playground)
Link to minimal reproduction
Steps to reproduce
- Open the playground and show the Preview pane.
- The app renders a
<Suspense>whose default slot contains an async component (resolves after ~4s) plus a large tree (2000 rows, each with a fewflush: 'post'watchers). - While the suspense is pending, a timer keeps mutating a ref, so the still-mounted tree re-renders repeatedly. Each re-render buffers its post effects into
suspense.effects(viaqueueEffectWithSuspense). - When the async component resolves, the suspense flushes the buffered effects.
What is expected?
The buffered effects flush and the app keeps working.
What is actually happening?
Uncaught (in promise): RangeError: Maximum call stack size exceeded — thrown from queuePostFlushCb called by suspense.resolve():
RangeError: Maximum call stack size exceeded
at queuePostFlushCb (runtime-core.esm-bundler.js:331)
at Object.resolve (runtime-core.esm-bundler.js:7426)
The scheduler dies mid-flush, leaving the app permanently wedged (blank page).
Root cause
suspense.effects is unbounded — every post effect of every component under a pending suspense boundary is buffered into it. On resolve, the whole array is flushed with a spread call:
scheduler.ts:pendingPostFlushCbs.push(...cb)scheduler.ts(flushPostFlushCbsnested case):activePostFlushCbs.push(...deduped)Suspense.ts(merge into pending parent):parent.effects.push(...effects)
Spreading an array into a function call is limited by the engine's call stack (~100k–200k args in V8), so once enough effects accumulate the flush itself throws.
Real-world impact
We hit this in production in a Nuxt app: a kanban board page with ~1000 mounted cards that re-renders once per second (elapsed-time ticker). Navigating to another page keeps the board mounted under <NuxtPage>'s pending Suspense; its buffered effects exceed the spread limit and every SPA navigation away from the board crashes with a permanent white screen (hard reload of the target URL works fine, since there is no pending suspense in that case).
Suggested fix
Replace the unbounded spread pushes with plain loops. I have a PR ready with the fix and a regression test (queuePostFlushCb with a 1M-entry array).
The two patches
packages/runtime-core/__tests__/components/Suspense.spec.tsindex d40f85b86..0d527dbeb 100644@@ -43,7 +43,10 @@ import { provide, } from 'vue' import type { RawSlots } from '../../src/componentSlots'-import { resetSuspenseId } from '../../src/components/Suspense'+import {+ queueEffectWithSuspense,+ resetSuspenseId,+} from '../../src/components/Suspense' import { PatchFlags } from '@vue/shared' describe('Suspense', () => {@@ -747,6 +750,74 @@ describe('Suspense', () => { expect(calls).toEqual([`inner mounted`, `outer mounted`]) }) + // #15142+ test('should not overflow the call stack when flushing a large number of buffered effects', async () => {+ const N = 1_000_000+ let count = 0+ const effects: (() => void)[] = []+ for (let i = 0; i < N; i++) {+ effects.push(() => {+ count+++ })+ }++ const AsyncOuter = defineAsyncComponent(+ { render: () => h('div', 'async outer') },+ 10,+ )+ const AsyncInner = defineAsyncComponent(+ { render: () => h('div', 'async inner') },+ 1,+ )++ const Buffered = {+ setup() {+ // buffered into the pending inner suspense+ queueEffectWithSuspense(effects, getCurrentInstance()!.suspense)+ return () => h('div', 'buffered')+ },+ }++ const Inner = {+ setup() {+ return () =>+ h(Suspense, null, {+ default: h('div', [h(AsyncInner), h(Buffered)]),+ fallback: h('div', 'fallback inner'),+ })+ },+ }++ const Comp = {+ setup() {+ return () =>+ h(Suspense, null, {+ default: h('div', [h(AsyncOuter), h(Inner)]),+ fallback: h('div', 'fallback outer'),+ })+ },+ }++ const root = nodeOps.createElement('div')+ render(h(Comp), root)+ expect(serializeInner(root)).toBe(`<div>fallback outer</div>`)++ // inner resolves first: its buffered effects are merged into the+ // still-pending outer suspense+ await deps[1]+ await nextTick()+ expect(serializeInner(root)).toBe(`<div>fallback outer</div>`)+ expect(count).toBe(0)++ // outer resolves: all buffered effects are flushed+ await Promise.all(deps)+ await nextTick()+ expect(serializeInner(root)).toBe(+ `<div><div>async outer</div><div><div>async inner</div><div>buffered</div></div></div>`,+ )+ expect(count).toBe(N)+ })+ test('error handling', async () => { const Async = { async setup() {packages/runtime-core/__tests__/scheduler.spec.tsindex 3e454aec0..d9ce8008a 100644@@ -341,6 +341,42 @@ describe('scheduler', () => { await nextTick() expect(calls).toEqual(['cb1', 'cb2']) })++ // #15142+ it('should not overflow the call stack with a very large array', async () => {+ let count = 0+ const cbs: SchedulerJob[] = []+ for (let i = 0; i < 1_000_000; i++) {+ cbs.push(() => {+ count+++ })+ }+ expect(() => queuePostFlushCb(cbs)).not.toThrow()+ await nextTick()+ expect(count).toBe(1_000_000)+ })++ // #15142+ it('should not overflow the call stack when flushing a very large array in a nested flush', async () => {+ let count = 0+ const cbs: SchedulerJob[] = []+ for (let i = 0; i < 1_000_000; i++) {+ cbs.push(() => {+ count+++ })+ }+ const calls: string[] = []+ queuePostFlushCb(() => {+ calls.push('outer')+ queuePostFlushCb(cbs)+ // nested flush appends the pending cbs to the active queue+ flushPostFlushCbs()+ calls.push('outer done')+ })+ await nextTick()+ expect(calls).toEqual(['outer', 'outer done'])+ expect(count).toBe(1_000_000)+ }) }) describe('queueJob w/ queuePostFlushCb', () => {packages/runtime-core/src/components/Suspense.tsindex ba5e194ae..4c9827d67 100644@@ -617,7 +617,10 @@ function createSuspenseBoundary( if (parent.pendingBranch) { // found a pending parent suspense, merge buffered post jobs // into that parent- parent.effects.push(...effects)+ // avoid spread: effects can be arbitrarily large+ for (let i = 0; i < effects.length; i++) {+ parent.effects.push(effects[i])+ } hasUnresolvedAncestor = true break }@@ -906,7 +909,9 @@ export function queueEffectWithSuspense( ): void { if (suspense && suspense.pendingBranch) { if (isArray(fn)) {- suspense.effects.push(...fn)+ for (let i = 0; i < fn.length; i++) {+ suspense.effects.push(fn[i])+ } } else { suspense.effects.push(fn) }packages/runtime-core/src/scheduler.tsindex af6752078..ea0dcf215 100644@@ -133,8 +133,12 @@ export function queuePostFlushCb(cb: SchedulerJobs): void { } else { // if cb is an array, it is a component lifecycle hook which can only be // triggered by a job, which is already deduped in the main queue, so- // we can skip duplicate check here to improve perf- pendingPostFlushCbs.push(...cb)+ // we can skip duplicate check here to improve perf.+ // avoid spreading into push(): large arrays (e.g. buffered suspense+ // effects) would exceed the engine's argument limit (#15142)+ for (let i = 0; i < cb.length; i++) {+ pendingPostFlushCbs.push(cb[i])+ } } queueFlush() }@@ -179,7 +183,9 @@ export function flushPostFlushCbs(seen?: CountMap): void { // #1947 already has active queue, nested flushPostFlushCbs call if (activePostFlushCbs) {- activePostFlushCbs.push(...deduped)+ for (let i = 0; i < deduped.length; i++) {+ activePostFlushCbs.push(deduped[i])+ } return }
packages/runtime-core/__tests__/scheduler.spec.tsindex 3e454aec0..000a0d578 100644@@ -303,6 +303,44 @@ describe('scheduler', () => { expect(calls).toEqual(['cb1', 'cb2', 'cb3']) }) + it('should not overflow the call stack with a very large cb array', async () => {+ // a suspense boundary can buffer an unbounded number of post effects+ // while pending (e.g. a large tree re-rendering under it) and flush them+ // all at once on resolve - spreading such an array into push() throws+ // RangeError: Maximum call stack size exceeded+ let called = 0+ const cbs: SchedulerJob[] = []+ for (let i = 0; i < 1000000; i++) {+ cbs.push(() => {+ called+++ })+ }++ queuePostFlushCb(cbs)+ await nextTick()+ expect(called).toBe(1000000)+ })++ it('should not overflow the call stack when merging a very large cb array into an active flush', async () => {+ // same as above, but the large array is queued while a post flush is+ // already in progress, exercising the merge into activePostFlushCbs+ // inside a nested flushPostFlushCbs call+ let called = 0+ const cbs: SchedulerJob[] = []+ for (let i = 0; i < 1000000; i++) {+ cbs.push(() => {+ called+++ })+ }++ queuePostFlushCb(() => {+ queuePostFlushCb(cbs)+ flushPostFlushCbs()+ })+ await nextTick()+ expect(called).toBe(1000000)+ })+ it('should dedupe queued postFlushCb', async () => { const calls: string[] = [] const cb1 = () => {packages/runtime-core/src/components/Suspense.tsindex ba5e194ae..37e5067ff 100644@@ -617,7 +617,9 @@ function createSuspenseBoundary( if (parent.pendingBranch) { // found a pending parent suspense, merge buffered post jobs // into that parent- parent.effects.push(...effects)+ for (let i = 0; i < effects.length; i++) {+ parent.effects.push(effects[i])+ } hasUnresolvedAncestor = true break }packages/runtime-core/src/scheduler.tsindex af6752078..4355018a0 100644@@ -133,8 +133,13 @@ export function queuePostFlushCb(cb: SchedulerJobs): void { } else { // if cb is an array, it is a component lifecycle hook which can only be // triggered by a job, which is already deduped in the main queue, so- // we can skip duplicate check here to improve perf- pendingPostFlushCbs.push(...cb)+ // we can skip duplicate check here to improve perf.+ // use a loop instead of `push(...cb)`: the array can be arbitrarily large+ // (e.g. effects buffered by a suspense boundary) and spreading it would+ // overflow the call stack (#15142)+ for (let i = 0; i < cb.length; i++) {+ pendingPostFlushCbs.push(cb[i])+ } } queueFlush() }@@ -179,7 +184,9 @@ export function flushPostFlushCbs(seen?: CountMap): void { // #1947 already has active queue, nested flushPostFlushCbs call if (activePostFlushCbs) {- activePostFlushCbs.push(...deduped)+ for (let i = 0; i < deduped.length; i++) {+ activePostFlushCbs.push(deduped[i])+ } return }