Backtestsvuerun-20261009-161443#15113

Issue #15113 Merged fix PR #15114 Run 9 Oct 2026 · run-20261009-161443 vuejs/core

SSR memory leak - options API watchers are created and never stopped with async setup()

Better

Our patch was judged better than the merged fix.

In this judgment, Patch B = our agent, Patch A = the merged fix.

The production code change is identical in both patches. Each wraps `handleSetupResult` in the async-setup `.then()` callback with `setInSSRSetupState(true)`, then resets it to false in a `finally`. This fixes the root cause: after the setup promise resolves, `finishComponentSetup`/`applyOptions` runs with `isInSSRComponentSetup` set, so `watch` options and `this.$watch` calls in `created()` follow SSR semantics. Non-immediate watchers become no-ops, and sync watchers are registered for SSR cleanup. Correctness is equal.

The difference is in the tests. Both include the issue's reproduction test, which fails before the fix and passes after. Patch A adds a GC/WeakRef retention test. It targets the memory-leak symptom directly, but it sits in a suite marked `describe.skipIf(!global.gc)`, so it only runs when GC is exposed. Patch B adds two always-run tests covering other paths through the same fix. One checks `this.$watch` inside `created()`, confirming non-immediate watchers stay inert while immediate ones run exactly once. The other checks a `flush: 'sync'` options watcher, which goes through the SSR cleanup-handle path rather than the NOOP path. These exercise distinct branches of the SSR watcher logic that the fix enables, so Patch B's regression coverage is broader and more reliably executed. Patch B also adds a short comment explaining why the SSR setup state is restored, which makes the intent clearer.

With code parity, Patch B's broader always-running tests and clearer comment make it the slightly better patch.

The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.

Solve

5m 51s

Wall-clock time in the container

Full test suite

No new failures

1,739 passed · 1 skipped · 1,740 total

Contamination audit

Clean

No sign the agent saw the real fix

Patch size

85vs 76 merged

Changed lines, ours vs merged

Vue version

3.5.40

Steps to reproduce

originally reported in https://github.com/nuxt/nuxt/issues/30782

  1. create an options API component with an async setup(), a computed property that reads shared module-level state, and a watch on that
  2. render it on the server and then mutate the shared state after the render is done
  3. see that the watcher is still active on the server

Reproduction

test('options-api watchers should not be created for async setup components', async () => {
  const open = ref(true)
  const spy = vi.fn()

  const App = defineComponent({
    setup: () => Promise.resolve({}),
    computed: {
      isOpen() {
        return open.value
      },
    },
    watch: {
      isOpen: spy,
    },
    render() {
      return h('div', String(this.isOpen))
    },
  })

  const html = await renderToString(createSSRApp(App))
  expect(html).toBe('<div>true</div>')

  // mutating the state after the request is done should not trigger the watcher
  open.value = false
  await nextTick()
  expect(spy).not.toHaveBeenCalled()
})

What is expected?

the same behavior as with a synchronous setup: regular watchers declared via the watch option don't run during SSR and don't survive the render

mutating the shared state after renderToString resolves should not trigger anything

What is actually happening?

when setup() returns a Promise, the watch option creates a live watcher on the server that is never stopped

if this subscribes to state that outlives the request, it keeps the entire component instance (and app) reachable forever

System Info

Any additional comments?

_No response_

The two patches

Our patch+84 −1
packages/runtime-core/src/component.tsindex c46741bee..4156a9170 100644@@ -894,7 +894,14 @@ function setupStatefulComponent(         // return the promise so server-renderer can wait on it         return setupResult           .then((resolvedResult: unknown) => {-            handleSetupResult(instance, resolvedResult, isSSR)+            // restore SSR setup state so that options API (watch, computed,+            // lifecycle hooks) applied after async setup behave as in SSR+            setInSSRSetupState(true)+            try {+              handleSetupResult(instance, resolvedResult, isSSR)+            } finally {+              setInSSRSetupState(false)+            }           })           .catch(e => {             handleError(e, instance, ErrorCodes.SETUP_FUNCTION)packages/server-renderer/__tests__/ssrWatch.spec.tsindex 2b1ad98d2..04a667a3a 100644@@ -212,6 +212,82 @@ describe('ssr: watch', () => {     expect(beforeAwaitTriggered).toBe(false)     expect(afterAwaitTriggered).toBe(false)   })++  test('options-api watchers should not be created for async setup components', async () => {+    const open = ref(true)+    const spy = vi.fn()++    const App = defineComponent({+      setup: () => Promise.resolve({}),+      computed: {+        isOpen() {+          return open.value+        },+      },+      watch: {+        isOpen: spy,+      },+      render() {+        return h('div', String(this.isOpen))+      },+    })++    const html = await renderToString(createSSRApp(App))+    expect(html).toBe('<div>true</div>')++    // mutating the state after the request is done should not trigger the watcher+    open.value = false+    await nextTick()+    expect(spy).not.toHaveBeenCalled()+  })++  test('this.$watch in created() should not leak for async setup components', async () => {+    const open = ref(true)+    const spy = vi.fn()+    const immediateSpy = vi.fn()++    const App = defineComponent({+      setup: () => Promise.resolve({}),+      created() {+        this.$watch(() => open.value, spy)+        this.$watch(() => open.value, immediateSpy, { immediate: true })+      },+      render() {+        return h('div', String(open.value))+      },+    })++    const html = await renderToString(createSSRApp(App))+    expect(html).toBe('<div>true</div>')+    expect(immediateSpy).toHaveBeenCalledTimes(1)++    open.value = false+    await nextTick()+    expect(spy).not.toHaveBeenCalled()+    expect(immediateSpy).toHaveBeenCalledTimes(1)+  })++  test('options-api flush:sync watchers should be cleaned up for async setup components', async () => {+    const open = ref(true)+    const spy = vi.fn()++    const App = defineComponent({+      setup: () => Promise.resolve({}),+      watch: {+        open: { handler: spy, flush: 'sync' },+      },+      data: () => ({ open }),+      render() {+        return h('div', String(open.value))+      },+    })++    const html = await renderToString(createSSRApp(App))+    expect(html).toBe('<div>true</div>')++    open.value = false+    expect(spy).not.toHaveBeenCalled()+  }) })  describe('ssr: watchEffect', () => { 
Merged fix · PR #15114+75 −1
packages/runtime-core/src/component.tsindex c46741bee..162a6ad44 100644@@ -894,7 +894,12 @@ function setupStatefulComponent(         // return the promise so server-renderer can wait on it         return setupResult           .then((resolvedResult: unknown) => {-            handleSetupResult(instance, resolvedResult, isSSR)+            setInSSRSetupState(true)+            try {+              handleSetupResult(instance, resolvedResult, isSSR)+            } finally {+              setInSSRSetupState(false)+            }           })           .catch(e => {             handleError(e, instance, ErrorCodes.SETUP_FUNCTION)packages/server-renderer/__tests__/ssrWatch.spec.tsindex 2b1ad98d2..2dad83cd2 100644@@ -130,6 +130,35 @@ describe('ssr: watch', () => {     expect(msg).toBe('start')   }) +  // #15113+  test('options-api watchers should not be created for async setup components', async () => {+    const open = ref(true)+    const spy = vi.fn()++    const App = defineComponent({+      setup: () => Promise.resolve({}),+      computed: {+        isOpen() {+          return open.value+        },+      },+      watch: {+        isOpen: spy,+      },+      render() {+        return h('div', String(this.isOpen))+      },+    })++    const html = await renderToString(createSSRApp(App))+    expect(html).toBe('<div>true</div>')++    // mutating the state after the request is done should not trigger the watcher+    open.value = false+    await nextTick()+    expect(spy).not.toHaveBeenCalled()+  })+   test('should not run non-immediate watchers registered after async context restore', async () => {     const text = ref('start')     let beforeAwaitTriggered = false@@ -351,4 +380,44 @@ describe.skipIf(!global.gc)('ssr: watch gc', () => {      expect(weakRefs.filter(ref => ref.deref()).length).toBe(0)   })++  // #15113+  test('options-api should not retain apps with async setup + watcher on global state', async () => {+    const weakRefs: { deref(): unknown | undefined }[] = []++    const open = ref(true)++    const App = defineComponent({+      setup: () => Promise.resolve({}),+      computed: {+        isOpen() {+          return open.value+        },+      },+      watch: {+        isOpen() {},+      },+      render() {+        return h('div', String(this.isOpen))+      },+    })++    async function renderOnce() {+      const app = createSSRApp(App)+      // @ts-expect-error ES2021 API+      weakRefs.push(new WeakRef(app))+      const html = await renderToString(app)+      expect(html).toBe('<div>true</div>')+    }++    for (let i = 0; i < 10; i++) {+      await renderOnce()+    }++    for (let i = 0; i < 5; i++) {+      await gc()+    }++    expect(weakRefs.filter(ref => ref.deref()).length).toBe(0)+  }) })