Backtestsvuerun-20261009-161443#15153
Custom elements: async components nested ≥3 levels crash with TypeError: Cannot read properties of null (reading 'provides') — chained child resolve races its parent's mount
Our patch was judged better than the merged fix.
In this judgment, Patch A = our agent, Patch B = the merged fix.
Both patches make the same core fix. The chain callback now returns `this._resolveDef()`, and `_resolveDef()` returns the parent's own `_pendingResolve` (the asyncDef().then(resolve) promise). As a result, a chained parent's `_pendingResolve` settles only after that parent's async load finishes and it mounts. This restores ancestor-first mounting at any depth, which is the issue's first suggested direction and the root cause. The patches differ in the extra edge they cover. Patch A also handles an already-resolved element (`_resolved` true, `_instance` null) that is re-connected under a still-pending async parent. The original code calls `_mount` immediately in that case, so `_inheritParentContext` would hit the same `parent._instance === null` dereference. That is the same class of crash the issue describes, so A closes a second path to it. Its tests cover: - 3 levels with the slowest middle level (the issue's exact scenario). - 4 levels with descending load times (the cascade case). - The re-connect case. All three check mount order, shadow DOM content and the full provide/inject chain at each level. They would fail before the fix. Patch B adds an `isConnected` guard so a child detached while waiting does not resolve. That is reasonable but tangential, and does not address a crash path. B's main test is deterministic and well built, with explicit resolvers and inject checks, but it covers only depth 3. Its second test exercises B's own tangential guard. A's tests rely on real timeouts, which is slightly less deterministic, but the margins are generous. Overall, A fixes the root cause equally well, covers an additional crash path the issue implies, and tests deeper nesting, so A is the better fix.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
5m 47s
Wall-clock time in the container
Full test suite
No new failures
691 passed · 1 skipped · 692 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
130vs 119 merged
Changed lines, ours vs merged
The issue
View on GitHubVue version
3.5.40 (latest at the time of writing — the inline repro pins it; also reproduced on 3.5.13, 3.5.17, 3.5.30 and 3.6.0-rc.2; 3.4.38 — before the nested-async chaining existed — crashes with the same null dereference in the older _setParent provides copy inside vnode.ce)
Link to minimal reproduction
Steps to reproduce
- Open the reproduction link and watch the console:
mounted x-innernever appears — the element crashes with an unhandledTypeError: Cannot read properties of null (reading 'provides')and never mounts. (The playground variant inserts the nested markup dynamically after thedefine()calls; dynamic and parser-created markup crash identically.) - Parser-created (static server-HTML-style) variant — self-contained single file, no build step (save as
repro.html, serve statically, open in any browser; Chromium, Firefox and WebKit all reproduce):
<!doctype html>
<meta charset="utf-8" />
<title>nested async custom elements repro</title>
<x-outer>
<x-middle>
<div>
<x-inner>inner light dom</x-inner>
</div>
</x-middle>
</x-outer>
<script type="module">
import {
defineCustomElement,
defineAsyncComponent,
h,
} from "https://unpkg.com/vue@3.5.40/dist/vue.esm-browser.js";
// Delays chosen so the middle level settles AFTER its child: outer fast,
// middle slow, inner fast. This crashes on 100% of loads.
const delays = { "x-outer": 50, "x-middle": 300, "x-inner": 10 };
const makeComponent = (name) => ({
name,
mounted() {
console.log(`mounted ${name}`);
},
render() {
return h("div", { style: "display:block;padding:6px;border:1px solid #888" }, [name, h("slot")]);
},
});
const makeLoader = (tag) => () =>
new Promise((resolve) => setTimeout(() => resolve(makeComponent(tag)), delays[tag]));
// Define the three tags parent-first.
for (const tag of ["x-outer", "x-middle", "x-inner"]) {
customElements.define(tag, defineCustomElement(defineAsyncComponent(makeLoader(tag))));
}
window.addEventListener("error", (e) => console.error("UNCAUGHT:", e.message));
window.addEventListener("unhandledrejection", (e) =>
console.error("UNHANDLED REJECTION:", e.reason?.message ?? e.reason),
);
</script>
What is expected?
All three elements mount ancestor-first: mounted x-outer, mounted x-middle, mounted x-inner. The nested-async chaining added in 3.5.0 (37ccb9b, "delay mounting of custom elements with async parent", closing #9341 / #8127 / #9351) exists to guarantee exactly this.
What is actually happening?
mounted x-outer
UNHANDLED REJECTION: Cannot read properties of null (reading 'provides')
mounted x-middle
x-inner crashes in VueElement._mount → _inheritParentContext (runtime-dom — parent._instance.provides is dereferenced guarded only by parent && this._app), never mounts, and is left permanently half-resolved: _resolved: true, _instance: null, shadow root empty. Nothing ever retries it, no error surfaces through app.config.errorHandler, and any provide/inject inheritance it should have received is lost. Its own descendants (at deeper nesting) then crash against it in cascade.
Any additional comments?
Analysis (why depth ≥ 3 is the trigger)
connectedCallback of a child under a pending async parent chains:
this._pendingResolve = parent._pendingResolve.then(() => {
this._pendingResolve = undefined;
this._resolveDef();
});
- For an unchained parent (depth 2),
parent._pendingResolveis the parent's own_resolveDef()flow, which settles after the parent has mounted → 2-level nesting is safe. The variants table below confirms: 2 levels never crash. - For a chained parent (depth ≥ 3),
parent._pendingResolveis itself a chain promise — and that promise settles when the parent's_resolveDef()returns (i.e. when the parent's async load starts), not when the parent mounts.
So once the first unchained ancestor mounts, the whole chain unwinds within a few microtasks: every deeper level's loader fires nearly simultaneously and mount order degenerates to network settlement order. Any child whose async definition settles before its parent has mounted hits _inheritParentContext while parent._instance === null and throws. With real-network chunk timings the victim set varies per load, so in an app this presents as a flaky, page-dependent breakage; with the fixed delays above it is 100% deterministic.
Variants checked (each re-run in a real browser):
| Variant | Result |
|---|---|
| 3 levels, middle slowest | crashes every load |
| 3 levels, inner slowest | clean (race direction confirmed) |
| 2 levels | clean (chained parent required) |
plain <div> between levels | still crashes (structure-independent) |
markup inserted dynamically after all define() calls | still crashes |
| all loaders instant | clean (microtask FIFO protects when nothing is pending) |
_inheritParentContext (#13219, ~3.5.14) did not introduce the race — it converted a pre-existing silent misordering into a hard crash. 3.4.38 (no chaining) and 3.5.13 (chaining, pre-#13219) fail with the same null dereference in the older _setParent provides-copy path.
Suggested direction — either (or both):
- Chain the child to the parent's actual mount, not to
_resolveDef()returning — e.g. resolve the parent's_pendingResolveonly after_mount()has run, so the guarantee the chaining was built for ("ancestor mounts before descendant") holds at any depth. - Guard
_inheritParentContextagainstparent._instance === nulland defer context inheritance until the parent instance exists, instead of throwing away the child permanently on an unhandled rejection.
The two patches
packages/runtime-dom/__tests__/customElement.spec.tsindex a5bea20b8..994573cc9 100644@@ -2210,6 +2210,114 @@ describe('defineCustomElement', () => { expect(barVal).toBe('bar') }) + describe('async & deeply nested custom elements', () => {+ // a middle level that resolves after its own child must still mount+ // before that child (ancestor-first), at any depth+ const run = async (tags: string[], delays: number[]) => {+ const mounted: string[] = []+ const injected: Record<string, string[]> = {}+ tags.forEach((tag, i) => {+ const Comp = {+ name: tag,+ setup() {+ const ancestors = tags.slice(0, i)+ injected[tag] = ancestors.map(t => inject<string>(t, 'missing'))+ provide(tag, tag)+ },+ mounted() {+ mounted.push(tag)+ },+ render(this: any) {+ return h('div', null, [tag, renderSlot(this.$slots, 'default')])+ },+ }+ const load = () =>+ new Promise<typeof Comp>(r => setTimeout(() => r(Comp), delays[i]))+ customElements.define(+ tag,+ defineCustomElement(defineAsyncComponent(load)),+ )+ })+ container.innerHTML = tags.reduceRight(+ (inner, tag) => `<${tag}><div>${inner}</div></${tag}>`,+ 'light dom',+ )+ await new Promise(r => setTimeout(r, Math.max(...delays) * tags.length))+ expect(mounted).toEqual(tags)+ let el = container.firstElementChild as VueElement+ for (const tag of tags) {+ expect(el.shadowRoot!.innerHTML).toBe(`<div>${tag}<slot></slot></div>`)+ expect(injected[tag]).toEqual(tags.slice(0, tags.indexOf(tag)))+ el = el.firstElementChild!.firstElementChild as VueElement+ }+ }++ test('3 levels with slowest middle level', async () => {+ await run(+ ['my-el-deep-a-1', 'my-el-deep-a-2', 'my-el-deep-a-3'],+ [5, 30, 1],+ )+ })++ test('4 levels with descending load times', async () => {+ await run(+ [+ 'my-el-deep-b-1',+ 'my-el-deep-b-2',+ 'my-el-deep-b-3',+ 'my-el-deep-b-4',+ ],+ [1, 30, 15, 1],+ )+ })++ test('resolved element re-connected under pending parent', async () => {+ const Parent = {+ setup() {+ provide('foo', 'bar')+ },+ render(this: any) {+ return h('div', null, renderSlot(this.$slots, 'default'))+ },+ }+ customElements.define(+ 'my-el-deep-c-parent',+ defineCustomElement(+ defineAsyncComponent(+ () => new Promise(r => setTimeout(() => r(Parent), 10)),+ ),+ ),+ )+ let injected: string | undefined+ customElements.define(+ 'my-el-deep-c-child',+ defineCustomElement({+ setup() {+ injected = inject<string>('foo', 'none')+ return () => h('div', 'child')+ },+ }),+ )++ // mount the child once so it is resolved, then detach it+ const child = document.createElement('my-el-deep-c-child') as VueElement+ container.appendChild(child)+ expect(child._instance).toBeTruthy()+ child.remove()+ await nextTick()+ expect(child._instance).toBeNull()++ const parent = document.createElement('my-el-deep-c-parent')+ container.appendChild(parent)+ parent.appendChild(child)++ await new Promise(r => setTimeout(r, 30))+ expect(child._instance).toBeTruthy()+ expect(child.shadowRoot!.innerHTML).toBe(`<div>child</div>`)+ expect(injected).toBe('bar')+ })+ })+ describe('configureApp', () => { test('should work', () => { const E = defineCustomElement(packages/runtime-dom/src/apiCustomElement.tsindex 9e1f3a720..3dea9e97e 100644@@ -308,12 +308,25 @@ export class VueElement if (!this._instance) { if (this._resolved) {- this._mount(this._def)+ if (parent && parent._pendingResolve) {+ // already resolved (re-connected) but the new parent is still+ // pending: wait for it to mount so its context can be inherited+ this._pendingResolve = parent._pendingResolve.then(() => {+ this._pendingResolve = undefined+ this._mount(this._def)+ })+ } else {+ this._mount(this._def)+ } } else { if (parent && parent._pendingResolve) {+ // wait for the parent to actually mount before resolving. If the+ // parent is itself chained to an async ancestor, its own async load+ // only starts once the chain fires, so we must also wait for the+ // promise returned by its _resolveDef(), not just the chain itself. this._pendingResolve = parent._pendingResolve.then(() => { this._pendingResolve = undefined- this._resolveDef()+ return this._resolveDef() }) } else { this._resolveDef()@@ -369,9 +382,9 @@ export class VueElement /** * resolve inner component definition (handle possible async component) */- private _resolveDef() {+ private _resolveDef(): Promise<void> | undefined { if (this._pendingResolve) {- return+ return this._pendingResolve } // set initial attrs@@ -428,6 +441,7 @@ export class VueElement def.configureApp = this._def.configureApp resolve((this._def = def), true) })+ return this._pendingResolve } else { resolve(this._def) }
packages/runtime-dom/__tests__/customElement.spec.tsindex a5bea20b8..27c7121c2 100644@@ -2210,6 +2210,118 @@ describe('defineCustomElement', () => { expect(barVal).toBe('bar') }) + test('nested async custom elements should mount ancestor-first', async () => {+ const mounted: string[] = []+ const OuterComp = defineComponent({+ setup() {+ provide('foo', 'foo')+ },+ mounted() {+ mounted.push('outer')+ },+ render() {+ return h('slot')+ },+ })+ const MiddleComp = defineComponent({+ setup() {+ provide('bar', 'bar')+ },+ mounted() {+ mounted.push('middle')+ },+ render() {+ return h('slot')+ },+ })+ const InnerComp = defineComponent({+ setup() {+ const foo = inject('foo')+ const bar = inject('bar')+ return () => h('div', `${foo}/${bar}`)+ },+ mounted() {+ mounted.push('inner')+ },+ })+ let resolveOuter!: (comp: typeof OuterComp) => void+ let resolveMiddle!: (comp: typeof MiddleComp) => void+ let resolveInner!: (comp: typeof InnerComp) => void+ const outerReady = new Promise<typeof OuterComp>(resolve => {+ resolveOuter = resolve+ })+ const middleReady = new Promise<typeof MiddleComp>(resolve => {+ resolveMiddle = resolve+ })+ const innerReady = new Promise<typeof InnerComp>(resolve => {+ resolveInner = resolve+ })++ const Outer = defineCustomElement(defineAsyncComponent(() => outerReady))+ const Middle = defineCustomElement(defineAsyncComponent(() => middleReady))+ const Inner = defineCustomElement(defineAsyncComponent(() => innerReady))++ customElements.define('async-chain-outer', Outer)+ customElements.define('async-chain-middle', Middle)+ customElements.define('async-chain-inner', Inner)+ container.innerHTML =+ `<async-chain-outer>` ++ `<async-chain-middle>` ++ `<async-chain-inner></async-chain-inner>` ++ `</async-chain-middle>` ++ `</async-chain-outer>`++ resolveInner(InnerComp)+ resolveOuter(OuterComp)+ await new Promise(resolve => setTimeout(resolve))+ resolveMiddle(MiddleComp)+ await new Promise(resolve => setTimeout(resolve))++ const inner = container.querySelector('async-chain-inner') as VueElement+ expect(mounted).toEqual(['outer', 'middle', 'inner'])+ expect(inner.shadowRoot!.innerHTML).toBe('<div>foo/bar</div>')+ })++ test('should not resolve nested custom element after disconnect', async () => {+ const mounted = vi.fn()+ const ParentComp = defineComponent({+ render() {+ return h('slot')+ },+ })+ let resolveParent!: (comp: typeof ParentComp) => void+ const parentReady = new Promise<typeof ParentComp>(resolve => {+ resolveParent = resolve+ })+ const Parent = defineCustomElement(defineAsyncComponent(() => parentReady))+ const Child = defineCustomElement({+ mounted,+ render() {+ return h('div', 'child')+ },+ })++ customElements.define('async-disconnect-parent', Parent)+ customElements.define('async-disconnect-child', Child)+ container.innerHTML =+ `<async-disconnect-parent>` ++ `<async-disconnect-child></async-disconnect-child>` ++ `</async-disconnect-parent>`++ const parent = container.firstChild as VueElement+ const child = parent.firstChild as VueElement+ child.remove()+ resolveParent(ParentComp)+ await new Promise(resolve => setTimeout(resolve))++ expect(mounted).not.toHaveBeenCalled()+ expect(child.shadowRoot!.innerHTML).toBe('')++ parent.appendChild(child)+ expect(mounted).toHaveBeenCalledOnce()+ expect(child.shadowRoot!.innerHTML).toBe('<div>child</div>')+ })+ describe('configureApp', () => { test('should work', () => { const E = defineCustomElement(packages/runtime-dom/src/apiCustomElement.tsindex 9e1f3a720..9422f58d6 100644@@ -313,7 +313,9 @@ export class VueElement if (parent && parent._pendingResolve) { this._pendingResolve = parent._pendingResolve.then(() => { this._pendingResolve = undefined- this._resolveDef()+ if (this.isConnected) {+ return this._resolveDef()+ } }) } else { this._resolveDef()@@ -371,7 +373,7 @@ export class VueElement */ private _resolveDef() { if (this._pendingResolve) {- return+ return this._pendingResolve } // set initial attrs@@ -428,6 +430,7 @@ export class VueElement def.configureApp = this._def.configureApp resolve((this._def = def), true) })+ return this._pendingResolve } else { resolve(this._def) }