Backtestsvuerun-20261013-093701#15320

Issue #15320 Merged fix PR #15328 Run 13 Oct 2026 · run-20261013-093701 vuejs/core

looseEqual() reports Map and Set instances with different contents as equal

Better

Our patch was judged better than the merged fix.

In this judgment, Patch A = our agent, Patch B = the merged fix.

Both patches fix the root cause the same way. Each adds Map/Set branches to looseEqual before the generic Object.keys path, using isMap/isSet from general.ts. Each compares contents order-insensitively, with a greedy matching step where every element of `a` must loosely match a distinct, unmatched element of `b`. Map entries are compared as [key, value] pairs via looseEqual in both, so keys and values are compared loosely. The placement differs: A puts the checks before the isObject branch, and B puts them inside it after the both-objects check. Behavior is the same for every mixed-type case (Map vs {}, Map vs Set, Map vs primitive all return false). Correctness is therefore a wash, including the same greedy-matching limitation in both.

The difference is in the tests. A's looseEqual tests cover the cases the issue lists:
- Map with different keys, different values, and empty vs non-empty in both directions.
- Empty vs empty.
- Key-order insensitivity and loose comparison of values.
- Distinct-element matching for Sets.
- Cross-type checks (Map vs Set, Map vs {}, {} vs Map, Map vs [], Set vs {}, Set vs []).

B's looseEqual tests are also solid. They add loose key matching ({id:1} vs {id:'1'}) and swapped values, but have fewer edge and cross-type cases. A's vModel integration test is clearly stronger. It covers Maps and Sets, a reactive update to a Set, a distinct but loosely equal Map instance selecting index 0, and a non-matching Map giving -1. B's vModel test only checks the initial Map selection.

On craft, B is slightly tidier. It checks `size` before allocating an array, uses a typed array for the matched flags, and keeps the import on one line. A's multi-line import may not match prettier output. These are minor points. A's more thorough tests decide it.

The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.

Solve

4m 45s

Wall-clock time in the container

Full test suite

No new failures

3,692 passed · 6 skipped · 3,698 total

Contamination audit

Clean

No sign the agent saw the real fix

Patch size

138vs 116 merged

Changed lines, ours vs merged

Vue version

3.5.x / main (verified at a2b40db)

Link to minimal reproduction

Reproducible directly against the repo (see below) — looseEqual is not exported publicly, so the SFC Playground can only show the v-model symptom, not the root cause.

Steps to reproduce

looseEqual() in packages/shared/src/looseEqual.ts reports unrelated Map and Set instances as equal:

import { looseEqual } from '@vue/shared'

looseEqual(new Map([['a', 1]]), new Map([['b', 2]])) // true, expected false
looseEqual(new Set([1]), new Set([2]))               // true, expected false
looseEqual(new Map([['a', 1]]), new Map())           // true, expected false

This surfaces to users through v-model on <select>. The following selects the wrong option:

const mapA = new Map([['id', 1]])
const mapB = new Map([['id', 2]])
const selected = ref(mapB)
<select v-model="selected">
  <option :value="mapA">A</option>
  <option :value="mapB">B</option>
</select>

el.selectedIndex is 0 (option A) when it should be 1, because looseEqual(mapA, mapB) returns true and the loop in setSelected stops at the first option.

What is expected?

Map/Set values with different contents compare as not equal, so v-model selects the option that actually matches.

What is actually happening?

Map and Set fall through to the generic object branch. Object.keys() on either is always [], so the key-count check passes and the for...in loop body never executes — entries are never compared. Execution then reaches the final line:

return String(a) === String(b)

Every Map stringifies to '[object Map]' and every Set to '[object Set]', so any two of the same type are reported equal.

Note this differs from Date and Symbol, which are given explicit branches above, and from arrays and plain objects, which compare correctly:

looseEqual([1], [2])       // false, correct
looseEqual({ a: 1 }, { a: 2 }) // false, correct

packages/shared/__tests__/looseEqual.spec.ts has 13 cases but none for Map/Set, which is why this hasn't been caught.

Possible fix

Add explicit branches before the generic object check, mirroring the existing Date/Symbol pattern. isMap and isSet already exist in packages/shared/src/general.ts. Set needs content comparison rather than reference lookup to stay consistent with looseEqual's semantics (e.g. new Set([{ a: 1 }]) vs new Set([{ a: 1 }])).

Worth confirming the intended semantics first: should Map comparison be key-order-insensitive, and should Set compare loosely (looseEqual per element) or strictly? Happy to open a PR with tests once the direction is confirmed.

System Info

Vue: 3.5.x / main @ a2b40db

Any additional comments?

Unrelated to #15298, which touches only vModel.ts.

The two patches

Our patch+137 −1
packages/runtime-dom/__tests__/directives/vModel.spec.tsindex 429163126..5ba70a641 100644@@ -1416,6 +1416,49 @@ describe('vModel', () => {     expect(input.selectedIndex).toBe(-1)   }) +  it('should select the matching option when values are Maps or Sets', async () => {+    const mapA = new Map([['id', 1]])+    const mapB = new Map([['id', 2]])+    const setA = new Set([1])+    const setB = new Set([2])+    const selected = ref<any>(mapB)+    const component = defineComponent({+      render() {+        return withVModel(+          h(+            'select',+            {+              'onUpdate:modelValue': (v: any) => (selected.value = v),+            },+            [+              h('option', { value: mapA }),+              h('option', { value: mapB }),+              h('option', { value: setA }),+              h('option', { value: setB }),+            ],+          ),+          selected.value,+        )+      },+    })+    render(h(component), root)+    const input = root.querySelector('select') as HTMLSelectElement+    expect(input.selectedIndex).toBe(1)++    selected.value = setB+    await nextTick()+    expect(input.selectedIndex).toBe(3)++    // loosely equal but distinct instance still matches+    selected.value = new Map([['id', 1]])+    await nextTick()+    expect(input.selectedIndex).toBe(0)++    selected.value = new Map([['id', 3]])+    await nextTick()+    expect(input.selectedIndex).toBe(-1)+  })+   it('should preserve the selected option when duplicate values exist', async () => {     const { input, options, data } = mountSelectModel(       null,packages/shared/__tests__/looseEqual.spec.tsindex 2dea58ce5..e43c218e7 100644@@ -233,4 +233,58 @@ describe('utils/looseEqual', () => {     expect(looseEqual(arr1, arr5)).toBe(false)     expect(looseEqual(arr5, arr1)).toBe(false)   })++  test('compares maps correctly', () => {+    expect(looseEqual(new Map([['a', 1]]), new Map([['a', 1]]))).toBe(true)+    expect(looseEqual(new Map([['a', 1]]), new Map([['b', 2]]))).toBe(false)+    expect(looseEqual(new Map([['a', 1]]), new Map([['a', 2]]))).toBe(false)+    expect(looseEqual(new Map([['a', 1]]), new Map())).toBe(false)+    expect(looseEqual(new Map(), new Map([['a', 1]]))).toBe(false)+    expect(looseEqual(new Map(), new Map())).toBe(true)+    // key order does not matter+    expect(+      looseEqual(+        new Map<string, number>([+          ['a', 1],+          ['b', 2],+        ]),+        new Map<string, number>([+          ['b', 2],+          ['a', 1],+        ]),+      ),+    ).toBe(true)+    // values are compared loosely+    expect(+      looseEqual(new Map([['a', { x: 1 }]]), new Map([['a', { x: 1 }]])),+    ).toBe(true)+    expect(+      looseEqual(new Map([['a', { x: 1 }]]), new Map([['a', { x: 2 }]])),+    ).toBe(false)+    // not equal to other types+    expect(looseEqual(new Map(), new Set())).toBe(false)+    expect(looseEqual(new Map(), {})).toBe(false)+    expect(looseEqual({}, new Map())).toBe(false)+    expect(looseEqual(new Map(), [])).toBe(false)+  })++  test('compares sets correctly', () => {+    expect(looseEqual(new Set([1]), new Set([1]))).toBe(true)+    expect(looseEqual(new Set([1]), new Set([2]))).toBe(false)+    expect(looseEqual(new Set([1]), new Set())).toBe(false)+    expect(looseEqual(new Set(), new Set([1]))).toBe(false)+    expect(looseEqual(new Set(), new Set())).toBe(true)+    // order does not matter+    expect(looseEqual(new Set([1, 2]), new Set([2, 1]))).toBe(true)+    // elements are compared loosely+    expect(looseEqual(new Set([{ a: 1 }]), new Set([{ a: 1 }]))).toBe(true)+    expect(looseEqual(new Set([{ a: 1 }]), new Set([{ a: 2 }]))).toBe(false)+    // each element must match a distinct element+    expect(+      looseEqual(new Set([{ a: 1 }, { a: 1 }]), new Set([{ a: 1 }, { b: 2 }])),+    ).toBe(false)+    // not equal to other types+    expect(looseEqual(new Set(), {})).toBe(false)+    expect(looseEqual(new Set(), [])).toBe(false)+  }) })packages/shared/src/looseEqual.tsindex 9e7176721..a183f3a16 100644@@ -1,4 +1,11 @@-import { isArray, isDate, isObject, isSymbol } from './general'+import {+  isArray,+  isDate,+  isMap,+  isObject,+  isSet,+  isSymbol,+} from './general'  function looseCompareArrays(a: any[], b: any[]) {   if (a.length !== b.length) return false@@ -9,6 +16,24 @@ function looseCompareArrays(a: any[], b: any[]) {   return equal } +// Order-insensitive loose comparison of Map entries / Set values. Each entry+// of `a` must be matched by a distinct, loosely equal entry of `b`.+function looseCompareCollections(a: any[], b: any[]) {+  if (a.length !== b.length) return false+  const matched: boolean[] = new Array(b.length).fill(false)+  for (let i = 0; i < a.length; i++) {+    let found = false+    for (let j = 0; j < b.length; j++) {+      if (!matched[j] && looseEqual(a[i], b[j])) {+        matched[j] = found = true+        break+      }+    }+    if (!found) return false+  }+  return true+}+ export function looseEqual(a: any, b: any): boolean {   if (a === b) return true   let aValidType = isDate(a)@@ -26,6 +51,20 @@ export function looseEqual(a: any, b: any): boolean {   if (aValidType || bValidType) {     return aValidType && bValidType ? looseCompareArrays(a, b) : false   }+  aValidType = isMap(a)+  bValidType = isMap(b)+  if (aValidType || bValidType) {+    return aValidType && bValidType+      ? looseCompareCollections(Array.from(a), Array.from(b))+      : false+  }+  aValidType = isSet(a)+  bValidType = isSet(b)+  if (aValidType || bValidType) {+    return aValidType && bValidType+      ? looseCompareCollections(Array.from(a), Array.from(b))+      : false+  }   aValidType = isObject(a)   bValidType = isObject(b)   if (aValidType || bValidType) { 
Merged fix · PR #15328+115 −1
packages/runtime-dom/__tests__/directives/vModel.spec.tsindex 429163126..a94cb8e0d 100644@@ -1874,4 +1874,32 @@ describe('vModel', () => {     await nextTick()     expect(foo.checked).toEqual(false)   })++  // #15320+  it('selects the matching option when values are maps', () => {+    const mapA = new Map([['id', 1]])+    const mapB = new Map([['id', 2]])+    const value = ref(mapB)+    const component = defineComponent(+      () => () =>+        withVModel(+          h(+            'select',+            {+              'onUpdate:modelValue': (val: Map<string, number>) =>+                (value.value = val),+            },+            [+              h('option', { value: mapA }, 'A'),+              h('option', { value: mapB }, 'B'),+            ],+          ),+          value.value,+        ),+    )++    render(h(component), root)++    expect(root.querySelector('select').selectedIndex).toBe(1)+  }) })packages/shared/__tests__/looseEqual.spec.tsindex 2dea58ce5..777f3cfad 100644@@ -233,4 +233,59 @@ describe('utils/looseEqual', () => {     expect(looseEqual(arr1, arr5)).toBe(false)     expect(looseEqual(arr5, arr1)).toBe(false)   })++  test('compares maps correctly', () => {+    const map = new Map<any, any>([+      [{ id: 1 }, { value: '1' }],+      ['foo', 'bar'],+    ])++    expect(looseEqual(map, map)).toBe(true)+    expect(+      looseEqual(+        map,+        new Map<any, any>([+          ['foo', 'bar'],+          [{ id: '1' }, { value: 1 }],+        ]),+      ),+    ).toBe(true)+    expect(looseEqual(map, new Map([['foo', 'bar']]))).toBe(false)+    expect(looseEqual(new Map([['a', 1]]), new Map([['b', 2]]))).toBe(false)+    expect(+      looseEqual(+        new Map<any, any>([+          ['a', 1],+          ['b', 2],+        ]),+        new Map<any, any>([+          ['a', 2],+          ['b', 1],+        ]),+      ),+    ).toBe(false)+    expect(+      looseEqual(+        new Map<any, any>([+          [1, 'value'],+          ['1', 'value'],+        ]),+        new Map<any, any>([+          [1, 'value'],+          [2, 'value'],+        ]),+      ),+    ).toBe(false)+  })++  test('compares sets correctly', () => {+    const set = new Set<any>([{ id: 1 }, 'foo'])++    expect(looseEqual(set, set)).toBe(true)+    expect(looseEqual(set, new Set(['foo', { id: '1' }]))).toBe(true)+    expect(looseEqual(set, new Set(['foo']))).toBe(false)+    expect(looseEqual(new Set([1]), new Set([2]))).toBe(false)+    expect(looseEqual(new Set<any>([1, '1']), new Set<any>([1, 2]))).toBe(false)+    expect(looseEqual(new Set(), new Map())).toBe(false)+  }) })packages/shared/src/looseEqual.tsindex 9e7176721..d037b0a57 100644@@ -1,4 +1,4 @@-import { isArray, isDate, isObject, isSymbol } from './general'+import { isArray, isDate, isMap, isObject, isSet, isSymbol } from './general'  function looseCompareArrays(a: any[], b: any[]) {   if (a.length !== b.length) return false@@ -9,6 +9,27 @@ function looseCompareArrays(a: any[], b: any[]) {   return equal } +function looseCompareCollections(+  a: Map<any, any> | Set<any>,+  b: Map<any, any> | Set<any>,+) {+  if (a.size !== b.size) return false+  const candidates = Array.from(b)+  const matched = new Uint8Array(candidates.length)+  for (const item of a) {+    let index = -1+    for (let i = 0; i < candidates.length; i++) {+      if (!matched[i] && looseEqual(item, candidates[i])) {+        index = i+        break+      }+    }+    if (index < 0) return false+    matched[index] = 1+  }+  return true+}+ export function looseEqual(a: any, b: any): boolean {   if (a === b) return true   let aValidType = isDate(a)@@ -32,6 +53,16 @@ export function looseEqual(a: any, b: any): boolean {     if (!aValidType || !bValidType) {       return false     }+    aValidType = isMap(a)+    bValidType = isMap(b)+    if (aValidType || bValidType) {+      return aValidType && bValidType ? looseCompareCollections(a, b) : false+    }+    aValidType = isSet(a)+    bValidType = isSet(b)+    if (aValidType || bValidType) {+      return aValidType && bValidType ? looseCompareCollections(a, b) : false+    }     const aKeysCount = Object.keys(a).length     const bKeysCount = Object.keys(b).length     if (aKeysCount !== bKeysCount) {