Backtestsvuerun-20261021-133314#15142
Suspense: flushing buffered effects overflows the call stack when many effects accumulate while pending (RangeError: Maximum call stack size exceeded)
Our patch was judged better than the merged fix.
In this judgment, Patch A = our agent, Patch B = the merged fix.
Both patches replace the three spread pushes the issue names (queuePostFlushCb, the nested flushPostFlushCbs merge, and the Suspense merge into a pending parent) with index loops, and both pass the independent tests that reproduce the issue's scenarios. The difference is in completeness and test coverage. Patch A also converts the fourth spread site, `suspense.effects.push(...fn)` in queueEffectWithSuspense, which is the exact path the issue says buffers effects into the suspense; a component with a large hook array would overflow there even with Patch B applied. Patch A's Suspense.spec tests exercise the actual boundary (500k hooks under a pending Suspense, and the nested-parent merge), so they fail on base and would also fail on Patch B at the queueEffectWithSuspense spread, proving the extra site matters. Patch B's tests only cover the scheduler functions directly and never go through Suspense, so they do not guard the merge-into-parent change it makes. Scope and craft are otherwise equivalent: same loop idiom, explanatory comments in both. Patch A is the more complete fix with stronger regression tests.
Four judges ruled on this ticket in parallel, and the verdict comes from counting their votes. Each saw the issue and the two patches, labelled A and B in random order (two of them saw ours as A), with issue links and version numbers removed. Where tests could check the fix, they also saw the results of tests a separate agent wrote for the issue, run on both patches. None was told which patch was ours. The reasoning above is one judge's, shown verbatim.
Solve
5m 2s
Wall-clock time in the container
Full test suite
No new failures
1,746 passed · 1 skipped · 1,747 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
165vs 55 merged
Changed lines, ours vs merged
The issue
View on GitHubVue version
3.5.39 (also reproduces on 3.5.40 / @b5f8518 in the playground)
Link to minimal reproduction
Steps to reproduce
- Open the playground and show the Preview pane.
- The app renders a
<Suspense>whose default slot contains an async component (resolves after ~4s) plus a large tree (2000 rows, each with a fewflush: 'post'watchers). - While the suspense is pending, a timer keeps mutating a ref, so the still-mounted tree re-renders repeatedly. Each re-render buffers its post effects into
suspense.effects(viaqueueEffectWithSuspense). - When the async component resolves, the suspense flushes the buffered effects.
What is expected?
The buffered effects flush and the app keeps working.
What is actually happening?
Uncaught (in promise): RangeError: Maximum call stack size exceeded — thrown from queuePostFlushCb called by suspense.resolve():
RangeError: Maximum call stack size exceeded
at queuePostFlushCb (runtime-core.esm-bundler.js:331)
at Object.resolve (runtime-core.esm-bundler.js:7426)
The scheduler dies mid-flush, leaving the app permanently wedged (blank page).
Root cause
suspense.effects is unbounded — every post effect of every component under a pending suspense boundary is buffered into it. On resolve, the whole array is flushed with a spread call:
scheduler.ts:pendingPostFlushCbs.push(...cb)scheduler.ts(flushPostFlushCbsnested case):activePostFlushCbs.push(...deduped)Suspense.ts(merge into pending parent):parent.effects.push(...effects)
Spreading an array into a function call is limited by the engine's call stack (~100k–200k args in V8), so once enough effects accumulate the flush itself throws.
Real-world impact
We hit this in production in a Nuxt app: a kanban board page with ~1000 mounted cards that re-renders once per second (elapsed-time ticker). Navigating to another page keeps the board mounted under <NuxtPage>'s pending Suspense; its buffered effects exceed the spread limit and every SPA navigation away from the board crashes with a permanent white screen (hard reload of the target URL works fine, since there is no pending suspense in that case).
Suggested fix
Replace the unbounded spread pushes with plain loops. I have a PR ready with the fix and a regression test (queuePostFlushCb with a 1M-entry array).
The two patches
packages/runtime-core/__tests__/components/Suspense.spec.tsindex d40f85b86..d3b630745 100644@@ -683,6 +683,112 @@ describe('Suspense', () => { expect(calls).toEqual([`outer mounted`, `inner mounted`]) }) + // a component that registers a large number of mounted hooks, so that a+ // pending suspense buffers more effects than can be spread as arguments+ function createManyHooksComp(count: number, onCall: () => void) {+ return {+ setup() {+ for (let i = 0; i < count; i++) {+ onMounted(onCall)+ }+ return () => h('div', 'many hooks')+ },+ }+ }++ test('should not overflow the call stack when flushing many buffered effects', async () => {+ const count = 500_000+ let calls = 0+ const ManyHooks = createManyHooksComp(count, () => calls++)+ const Async = defineAsyncComponent({+ render() {+ return h('div', 'async')+ },+ })++ const Comp = {+ setup() {+ return () =>+ h(Suspense, null, {+ default: h('div', [h(Async), h(ManyHooks)]),+ fallback: h('div', 'fallback'),+ })+ },+ }++ const root = nodeOps.createElement('div')+ render(h(Comp), root)+ expect(serializeInner(root)).toBe(`<div>fallback</div>`)+ expect(calls).toBe(0)++ await Promise.all(deps)+ await nextTick()+ expect(serializeInner(root)).toBe(+ `<div><div>async</div><div>many hooks</div></div>`,+ )+ expect(calls).toBe(count)+ })++ test('should not overflow the call stack when merging many buffered effects into a pending parent suspense', async () => {+ const count = 500_000+ let calls = 0+ const ManyHooks = createManyHooksComp(count, () => calls++)+ const AsyncOuter = defineAsyncComponent(+ {+ render() {+ return h('div', 'async outer')+ },+ },+ 10,+ )+ const AsyncInner = defineAsyncComponent(+ {+ render() {+ return h('div', 'async inner')+ },+ },+ 1,+ )++ const Inner = {+ setup() {+ return () =>+ h(Suspense, null, {+ default: h('div', [h(AsyncInner), h(ManyHooks)]),+ fallback: h('div', 'fallback inner'),+ })+ },+ }++ const Comp = {+ setup() {+ return () =>+ h(Suspense, null, {+ default: h('div', [h(AsyncOuter), h(Inner)]),+ fallback: h('div', 'fallback outer'),+ })+ },+ }++ const root = nodeOps.createElement('div')+ render(h(Comp), root)+ expect(serializeInner(root)).toBe(`<div>fallback outer</div>`)++ // inner resolves first: its buffered effects are merged into the+ // still-pending outer suspense+ await deps[1]+ await nextTick()+ expect(serializeInner(root)).toBe(`<div>fallback outer</div>`)+ expect(calls).toBe(0)++ await Promise.all(deps)+ await nextTick()+ expect(serializeInner(root)).toBe(+ `<div><div>async outer</div><div><div>async inner</div><div>many hooks</div></div></div>`,+ )+ expect(calls).toBe(count)+ })+ test('nested suspense (child resolves first)', async () => { const calls: string[] = [] packages/runtime-core/__tests__/scheduler.spec.tsindex 3e454aec0..30d88b124 100644@@ -341,6 +341,46 @@ describe('scheduler', () => { await nextTick() expect(calls).toEqual(['cb1', 'cb2']) })++ it('should not overflow the call stack when queueing a large array', async () => {+ const count = 500_000+ let calls = 0+ const cbs: SchedulerJob[] = []+ for (let i = 0; i < count; i++) {+ cbs.push(() => {+ calls+++ })+ }++ expect(() => queuePostFlushCb(cbs)).not.toThrow()+ await nextTick()+ expect(calls).toBe(count)+ })++ it('should not overflow the call stack on nested flush of a large queue', async () => {+ const count = 500_000+ let calls = 0+ const cbs: SchedulerJob[] = []+ for (let i = 0; i < count; i++) {+ cbs.push(() => {+ calls+++ })+ }+ const calledLast: string[] = []+ const cb1 = () => {+ queuePostFlushCb(cbs)+ // nested flush while the active post flush queue is being flushed+ flushPostFlushCbs()+ }+ const cb2 = () => {+ calledLast.push('cb2')+ }+ queuePostFlushCb([cb1, cb2])++ await nextTick()+ expect(calls).toBe(count)+ expect(calledLast).toEqual(['cb2'])+ }) }) describe('queueJob w/ queuePostFlushCb', () => {packages/runtime-core/src/components/Suspense.tsindex ba5e194ae..83f2d3154 100644@@ -617,7 +617,10 @@ function createSuspenseBoundary( if (parent.pendingBranch) { // found a pending parent suspense, merge buffered post jobs // into that parent- parent.effects.push(...effects)+ // avoid spread push: effects may be too large to spread as arguments+ for (let i = 0; i < effects.length; i++) {+ parent.effects.push(effects[i])+ } hasUnresolvedAncestor = true break }@@ -906,7 +909,9 @@ export function queueEffectWithSuspense( ): void { if (suspense && suspense.pendingBranch) { if (isArray(fn)) {- suspense.effects.push(...fn)+ for (let i = 0; i < fn.length; i++) {+ suspense.effects.push(fn[i])+ } } else { suspense.effects.push(fn) }packages/runtime-core/src/scheduler.tsindex af6752078..e1194f12b 100644@@ -134,7 +134,11 @@ export function queuePostFlushCb(cb: SchedulerJobs): void { // if cb is an array, it is a component lifecycle hook which can only be // triggered by a job, which is already deduped in the main queue, so // we can skip duplicate check here to improve perf- pendingPostFlushCbs.push(...cb)+ // use a loop instead of spread push: cb may be a large array (e.g. effects+ // buffered by a pending suspense) and spreading it can overflow the stack+ for (let i = 0; i < cb.length; i++) {+ pendingPostFlushCbs.push(cb[i])+ } } queueFlush() }@@ -179,7 +183,9 @@ export function flushPostFlushCbs(seen?: CountMap): void { // #1947 already has active queue, nested flushPostFlushCbs call if (activePostFlushCbs) {- activePostFlushCbs.push(...deduped)+ for (let i = 0; i < deduped.length; i++) {+ activePostFlushCbs.push(deduped[i])+ } return }
packages/runtime-core/__tests__/scheduler.spec.tsindex 3e454aec0..000a0d578 100644@@ -303,6 +303,44 @@ describe('scheduler', () => { expect(calls).toEqual(['cb1', 'cb2', 'cb3']) }) + it('should not overflow the call stack with a very large cb array', async () => {+ // a suspense boundary can buffer an unbounded number of post effects+ // while pending (e.g. a large tree re-rendering under it) and flush them+ // all at once on resolve - spreading such an array into push() throws+ // RangeError: Maximum call stack size exceeded+ let called = 0+ const cbs: SchedulerJob[] = []+ for (let i = 0; i < 1000000; i++) {+ cbs.push(() => {+ called+++ })+ }++ queuePostFlushCb(cbs)+ await nextTick()+ expect(called).toBe(1000000)+ })++ it('should not overflow the call stack when merging a very large cb array into an active flush', async () => {+ // same as above, but the large array is queued while a post flush is+ // already in progress, exercising the merge into activePostFlushCbs+ // inside a nested flushPostFlushCbs call+ let called = 0+ const cbs: SchedulerJob[] = []+ for (let i = 0; i < 1000000; i++) {+ cbs.push(() => {+ called+++ })+ }++ queuePostFlushCb(() => {+ queuePostFlushCb(cbs)+ flushPostFlushCbs()+ })+ await nextTick()+ expect(called).toBe(1000000)+ })+ it('should dedupe queued postFlushCb', async () => { const calls: string[] = [] const cb1 = () => {packages/runtime-core/src/components/Suspense.tsindex ba5e194ae..37e5067ff 100644@@ -617,7 +617,9 @@ function createSuspenseBoundary( if (parent.pendingBranch) { // found a pending parent suspense, merge buffered post jobs // into that parent- parent.effects.push(...effects)+ for (let i = 0; i < effects.length; i++) {+ parent.effects.push(effects[i])+ } hasUnresolvedAncestor = true break }packages/runtime-core/src/scheduler.tsindex af6752078..4355018a0 100644@@ -133,8 +133,13 @@ export function queuePostFlushCb(cb: SchedulerJobs): void { } else { // if cb is an array, it is a component lifecycle hook which can only be // triggered by a job, which is already deduped in the main queue, so- // we can skip duplicate check here to improve perf- pendingPostFlushCbs.push(...cb)+ // we can skip duplicate check here to improve perf.+ // use a loop instead of `push(...cb)`: the array can be arbitrarily large+ // (e.g. effects buffered by a suspense boundary) and spreading it would+ // overflow the call stack (#15142)+ for (let i = 0; i < cb.length; i++) {+ pendingPostFlushCbs.push(cb[i])+ } } queueFlush() }@@ -179,7 +184,9 @@ export function flushPostFlushCbs(seen?: CountMap): void { // #1947 already has active queue, nested flushPostFlushCbs call if (activePostFlushCbs) {- activePostFlushCbs.push(...deduped)+ for (let i = 0; i < deduped.length; i++) {+ activePostFlushCbs.push(deduped[i])+ } return }