Backtestsvuerun-20261021-133314#15465
[compiler-sfc] Typo 'exit' instead of 'leave' in estree-walker causes missing ASI guard and runtime error with consecutive awaits
Our patch was judged better than the merged fix.
In this judgment, Patch B = our agent, Patch A = the merged fix.
Both patches apply the identical one-line source fix (rename the walker hook from `exit` to `leave` in compileScript.ts), so correctness is equal and the independent tests confirm both resolve the issue. The differences are in tests and supporting cleanup. Patch A adds one test that compiles the exact nested-block scenario from the issue and executes the output via `new Function`, verifying no TypeError at runtime; it would fail before and pass after. Patch B adds two tests covering both the top-level-block and nested-block cases and asserts on the presence of the `;(` ASI guards in the compiled output; both would also fail on base (an unpopped block scope makes `needsSemi` false even for later top-level awaits) and the string-matching style matches the surrounding tests in that file. Patch B additionally removes the bogus `exit?: (node: T) => any` entry from the local `estree-walker` type augmentation in global.d.ts. That declaration is what allowed the typo to typecheck in the first place; deleting it makes the regression impossible to reintroduce silently and carries no risk since `exit` is not a real estree-walker hook. That is a direct, low-risk improvement at the root of how the bug slipped in, plus slightly broader test coverage, which tips the comparison to B. Patch A's runtime-execution test is arguably a more faithful reproduction of the reported symptom, but not enough to outweigh B's type cleanup and extra coverage.
Four judges ruled on this ticket in parallel, and the verdict comes from counting their votes. Each saw the issue and the two patches, labelled A and B in random order (two of them saw ours as A), with issue links and version numbers removed. Where tests could check the fix, they also saw the results of tests a separate agent wrote for the issue, run on both patches. None was told which patch was ours. The reasoning above is one judge's, shown verbatim.
Solve
8m 7s
Wall-clock time in the container
Full test suite
No new failures
3,721 passed · 6 skipped · 3,727 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
21vs 21 merged
Changed lines, ours vs merged
The issue
View on GitHubVue version
3.5.40
Link to minimal reproduction
Steps to reproduce
- Open the SFC Playground link.
- Click on the "JS" tab in the right panel to view the compiled output.
- Observe the compiled code for the two
awaitstatements. - Notice that there is no semicolon (
;) inserted between the two_withAsyncContextblocks.
What is expected?
- Open the SFC Playground link.
- Click on the "JS" tab in the right panel to view the compiled output.
- Observe the compiled code for the two
awaitstatements. - Notice that there is no semicolon (
;) inserted between the two_withAsyncContextblocks.
What is actually happening?
What is actually happening? *
The ASI guard (`;`) is missing.
Because of this, the JavaScript engine interprets the second statement as a function call invoked on the result of the first statement, causing a runtime error: `TypeError: (...) is not a function`.
([temp,restore] = _withAsyncContext(() => Promise.resolve(1))),
await __temp,
__restore()
)( // <--- RUNTIME ERROR
([temp,restore] = _withAsyncContext(() => Promise.resolve(2))),
await __temp,
__restore()
)
### System Info
System:
OS: Linux 5.10 Debian GNU/Linux 11 (bullseye) 11 (bullseye)
CPU: (4) x64 AMD EPYC 9575F 64-Core Processor
Memory: 6.69 GB / 11.65 GB
Container: Yes
Shell: 5.1.4 - /bin/bash
Binaries:
Node: 24.14.1 - /root/.nvm/versions/node/v24.14.1/bin/node
Yarn: 1.22.22 - /root/.yarn/bin/yarn
npm: 11.11.0 - /root/.nvm/versions/node/v24.14.1/bin/npm
pnpm: 10.33.0 - /root/.nvm/versions/node/v24.14.1/bin/pnpm
Browsers:
Chrome: 150.0.7871.181
npmPackages:
vue: ^3.5.40 => 3.5.40
### Any additional comments?
**Root Cause:**
The bug is caused by a typo in the AST walker configuration inside `compiler-sfc`. The compiler uses `estree-walker` which expects the hooks `{ enter, leave }`. However, the code currently passes `{ enter, exit }`.
Since `exit` is not a valid hook in `estree-walker`, it is never called. Consequently, `scope.pop()` is never executed when leaving a `BlockStatement` (like the `if` block in the reproduction). This corrupts the `scope` stack, causing the `needsSemi` calculation to fail for all subsequent `AwaitExpression` nodes.
**Proposed Fix:**
Simply change `exit` to `leave` in the walker options:
- exit(node2) {
- leave(node2) { if (node2.type === "BlockStatement") scope.pop(); }
The two patches
packages/compiler-sfc/__tests__/compileScript.spec.tsindex d54541019..c272d072e 100644@@ -1013,6 +1013,24 @@ describe('SFC compile <script setup>', () => { }`) }) + test('consecutive awaits after a top-level block statement', () => {+ const { content } = compile(+ `<script setup>if (ok) {\n foo()\n}\nawait bar\nawait baz</script>`,+ )+ expect(content).toMatch(`async setup(`)+ // each await must be guarded so it is not parsed as a call on the+ // previous expression+ expect(content.match(/\n;\(/g)).toHaveLength(2)+ })++ test('consecutive awaits after a nested block statement', () => {+ const { content } = compile(+ `<script setup>if (ok) {\n if (a) {\n foo()\n }\n await bar\n await baz\n}</script>`,+ )+ expect(content).toMatch(`async setup(`)+ expect(content.match(/\n\s*;\(/g)).toHaveLength(2)+ })+ test('should ignore await inside functions', () => { // function declaration assertAwaitDetection(`async function foo() { await bar }`, false)packages/compiler-sfc/src/compileScript.tsindex d2047c5b2..901196235 100644@@ -669,7 +669,7 @@ export function compileScript( ) } },- exit(node: Node) {+ leave(node: Node) { if (node.type === 'BlockStatement') scope.pop() }, })packages/global.d.tsindex 8b627d2e5..43a204763 100644@@ -24,7 +24,6 @@ declare module 'estree-walker' { options: { enter?: (node: T, parent: T | null) => any leave?: (node: T, parent: T | null) => any- exit?: (node: T) => any } & ThisType<{ skip: () => void }>, ) }
packages/compiler-sfc/__tests__/compileScript.spec.tsindex d54541019..a1cc885cd 100644@@ -1026,6 +1026,25 @@ describe('SFC compile <script setup>', () => { false, ) })++ // #15465+ test('await statements after a nested block should be separated', async () => {+ const { content } = compile(+ `<script setup>+ if (true) {+ if (false) {}+ await Promise.resolve(1)+ await Promise.resolve(2)+ }+ </script>`,+ { genDefaultAs: '_sfc_' },+ )+ const component = new Function(+ '_withAsyncContext',+ `${content.replace(/^import .*\n/, '')};return _sfc_`,+ )((getAwaitable: () => unknown) => [getAwaitable(), () => {}])+ await expect(component.setup({}, { expose() {} })).resolves.toEqual({})+ }) }) describe('errors', () => {packages/compiler-sfc/src/compileScript.tsindex d2047c5b2..901196235 100644@@ -669,7 +669,7 @@ export function compileScript( ) } },- exit(node: Node) {+ leave(node: Node) { if (node.type === 'BlockStatement') scope.pop() }, })