Backtestsvuerun-20261005-124535#15142
Suspense: flushing buffered effects overflows the call stack when many effects accumulate while pending (RangeError: Maximum call stack size exceeded)
Our patch was judged better than the merged fix.
In this judgment, Patch B = our agent, Patch A = the merged fix.
Both patches replace the unbounded spread pushes the issue names: `pendingPostFlushCbs.push(...cb)` and `activePostFlushCbs.push(...deduped)` in `scheduler.ts`, and `parent.effects.push(...effects)` in `Suspense.ts`. Each uses an equivalent index loop, so on the issue's core scenario both are correct. Patch B also converts `suspense.effects.push(...fn)` in `queueEffectWithSuspense`. That is the very function the issue says buffers the effects, and it has the same failure mode: a component with a very large hook array overflows at buffer time, before resolve ever runs. Patch A leaves that spread in place, so its fix of this bug class in the suspense buffering path is incomplete. B's extra change is low-risk and directly relevant, not churn. Tests: both add a scheduler test for a 1M-entry `queuePostFlushCb` array and a nested `flushPostFlushCbs` merge test, and each of these would fail before the change. B adds two Suspense integration tests: - one flushes 1M buffered `onMounted` effects on resolve; - one merges 1M effects from a resolved inner suspense into a still-pending parent. These exercise the real Suspense paths, including the parent-merge site in `Suspense.ts` and the `queueEffectWithSuspense` array path, end to end. Patch A has no test that covers the `Suspense.ts` parent-merge change at all. Craft is comparable: both add clear comments and use idiomatic loops. B wins on completeness of the fix and on test coverage of the reported Suspense scenario.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
9m 24s
Wall-clock time in the container
Full test suite
No new failures
3,636 passed · 6 skipped · 3,642 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
172vs 55 merged
Changed lines, ours vs merged
The issue
View on GitHubVue version
3.5.39 (also reproduces on 3.5.40 / @b5f8518 in the playground)
Link to minimal reproduction
Steps to reproduce
- Open the playground and show the Preview pane.
- The app renders a
<Suspense>whose default slot contains an async component (resolves after ~4s) plus a large tree (2000 rows, each with a fewflush: 'post'watchers). - While the suspense is pending, a timer keeps mutating a ref, so the still-mounted tree re-renders repeatedly. Each re-render buffers its post effects into
suspense.effects(viaqueueEffectWithSuspense). - When the async component resolves, the suspense flushes the buffered effects.
What is expected?
The buffered effects flush and the app keeps working.
What is actually happening?
Uncaught (in promise): RangeError: Maximum call stack size exceeded — thrown from queuePostFlushCb called by suspense.resolve():
RangeError: Maximum call stack size exceeded
at queuePostFlushCb (runtime-core.esm-bundler.js:331)
at Object.resolve (runtime-core.esm-bundler.js:7426)
The scheduler dies mid-flush, leaving the app permanently wedged (blank page).
Root cause
suspense.effects is unbounded — every post effect of every component under a pending suspense boundary is buffered into it. On resolve, the whole array is flushed with a spread call:
scheduler.ts:pendingPostFlushCbs.push(...cb)scheduler.ts(flushPostFlushCbsnested case):activePostFlushCbs.push(...deduped)Suspense.ts(merge into pending parent):parent.effects.push(...effects)
Spreading an array into a function call is limited by the engine's call stack (~100k–200k args in V8), so once enough effects accumulate the flush itself throws.
Real-world impact
We hit this in production in a Nuxt app: a kanban board page with ~1000 mounted cards that re-renders once per second (elapsed-time ticker). Navigating to another page keeps the board mounted under <NuxtPage>'s pending Suspense; its buffered effects exceed the spread limit and every SPA navigation away from the board crashes with a permanent white screen (hard reload of the target URL works fine, since there is no pending suspense in that case).
Suggested fix
Replace the unbounded spread pushes with plain loops. I have a PR ready with the fix and a regression test (queuePostFlushCb with a 1M-entry array).
The two patches
packages/runtime-core/__tests__/components/Suspense.spec.tsindex d40f85b86..d140a185e 100644@@ -747,6 +747,121 @@ describe('Suspense', () => { expect(calls).toEqual([`inner mounted`, `outer mounted`]) }) + // spreading this many buffered effects into a call exceeds the engine's+ // argument limit (RangeError: Maximum call stack size exceeded)+ const MANY_EFFECTS = 1_000_000++ test('flush a very large number of buffered effects on resolve', async () => {+ let mountedCalls = 0+ const ManyHooks = {+ setup() {+ for (let i = 0; i < MANY_EFFECTS; i++) {+ onMounted(() => {+ mountedCalls+++ })+ }+ return () => h('div', 'many hooks')+ },+ }++ const Async = defineAsyncComponent({+ render() {+ return h('div', 'async')+ },+ })++ const Comp = {+ setup() {+ return () =>+ h(Suspense, null, {+ default: h('div', [h(Async), h(ManyHooks)]),+ fallback: h('div', 'fallback'),+ })+ },+ }++ const root = nodeOps.createElement('div')+ render(h(Comp), root)+ expect(serializeInner(root)).toBe(`<div>fallback</div>`)+ expect(mountedCalls).toBe(0)++ await Promise.all(deps)+ await nextTick()+ expect(serializeInner(root)).toBe(+ `<div><div>async</div><div>many hooks</div></div>`,+ )+ expect(mountedCalls).toBe(MANY_EFFECTS)+ })++ test('merge a very large number of buffered effects into pending parent suspense', async () => {+ let mountedCalls = 0+ let outerMounted = false++ const AsyncOuter = defineAsyncComponent(+ {+ setup: () => {+ onMounted(() => {+ outerMounted = true+ })+ return () => h('div', 'async outer')+ },+ },+ 10,+ )++ const AsyncInner = defineAsyncComponent(+ {+ setup: () => {+ for (let i = 0; i < MANY_EFFECTS; i++) {+ onMounted(() => {+ mountedCalls+++ })+ }+ return () => h('div', 'async inner')+ },+ },+ 1,+ )++ const Inner = {+ setup() {+ return () =>+ h(Suspense, null, {+ default: h(AsyncInner),+ fallback: h('div', 'fallback inner'),+ })+ },+ }++ const Comp = {+ setup() {+ return () =>+ h(Suspense, null, {+ default: h('div', [h(AsyncOuter), h(Inner)]),+ fallback: h('div', 'fallback outer'),+ })+ },+ }++ const root = nodeOps.createElement('div')+ render(h(Comp), root)+ expect(serializeInner(root)).toBe(`<div>fallback outer</div>`)++ // inner resolves first; its effects are merged into the pending parent+ await deps[1]+ await nextTick()+ expect(serializeInner(root)).toBe(`<div>fallback outer</div>`)+ expect(mountedCalls).toBe(0)++ await Promise.all(deps)+ await nextTick()+ expect(serializeInner(root)).toBe(+ `<div><div>async outer</div><div>async inner</div></div>`,+ )+ expect(mountedCalls).toBe(MANY_EFFECTS)+ expect(outerMounted).toBe(true)+ })+ test('error handling', async () => { const Async = { async setup() {packages/runtime-core/__tests__/scheduler.spec.tsindex 3e454aec0..fa193c6b9 100644@@ -341,6 +341,22 @@ describe('scheduler', () => { await nextTick() expect(calls).toEqual(['cb1', 'cb2']) })++ it('should handle a very large array of postFlushCbs', async () => {+ // spreading an array this large into a call exceeds the engine's+ // argument limit (RangeError: Maximum call stack size exceeded)+ const count = 1_000_000+ let calls = 0+ const cbs: (() => void)[] = []+ for (let i = 0; i < count; i++) {+ cbs.push(() => {+ calls+++ })+ }+ expect(() => queuePostFlushCb(cbs)).not.toThrow()+ await nextTick()+ expect(calls).toBe(count)+ }) }) describe('queueJob w/ queuePostFlushCb', () => {@@ -844,4 +860,22 @@ describe('scheduler', () => { await nextTick() expect(calls).toEqual(['cb2', 'cb1']) })++ test('nested flushPostFlushCbs with a very large array of postFlushCbs', async () => {+ const count = 1_000_000+ let calls = 0++ queuePostFlushCb(() => {+ for (let i = 0; i < count; i++) {+ queuePostFlushCb(() => {+ calls+++ })+ }+ // nested flush merges pending cbs into the active queue+ flushPostFlushCbs()+ })++ await nextTick()+ expect(calls).toBe(count)+ }) })packages/runtime-core/src/components/Suspense.tsindex ba5e194ae..32a2aec0a 100644@@ -617,7 +617,11 @@ function createSuspenseBoundary( if (parent.pendingBranch) { // found a pending parent suspense, merge buffered post jobs // into that parent- parent.effects.push(...effects)+ // use a loop instead of spread to avoid exceeding the engine's+ // argument limit when many effects have been buffered+ for (let i = 0; i < effects.length; i++) {+ parent.effects.push(effects[i])+ } hasUnresolvedAncestor = true break }@@ -906,7 +910,9 @@ export function queueEffectWithSuspense( ): void { if (suspense && suspense.pendingBranch) { if (isArray(fn)) {- suspense.effects.push(...fn)+ for (let i = 0; i < fn.length; i++) {+ suspense.effects.push(fn[i])+ } } else { suspense.effects.push(fn) }packages/runtime-core/src/scheduler.tsindex af6752078..e21e3a880 100644@@ -133,8 +133,13 @@ export function queuePostFlushCb(cb: SchedulerJobs): void { } else { // if cb is an array, it is a component lifecycle hook which can only be // triggered by a job, which is already deduped in the main queue, so- // we can skip duplicate check here to improve perf- pendingPostFlushCbs.push(...cb)+ // we can skip duplicate check here to improve perf.+ // use a loop instead of spread: cb may be very large (e.g. effects+ // buffered by a pending suspense) and spreading it into a call can exceed+ // the engine's argument limit+ for (let i = 0; i < cb.length; i++) {+ pendingPostFlushCbs.push(cb[i])+ } } queueFlush() }@@ -179,7 +184,9 @@ export function flushPostFlushCbs(seen?: CountMap): void { // #1947 already has active queue, nested flushPostFlushCbs call if (activePostFlushCbs) {- activePostFlushCbs.push(...deduped)+ for (let i = 0; i < deduped.length; i++) {+ activePostFlushCbs.push(deduped[i])+ } return }
packages/runtime-core/__tests__/scheduler.spec.tsindex 3e454aec0..000a0d578 100644@@ -303,6 +303,44 @@ describe('scheduler', () => { expect(calls).toEqual(['cb1', 'cb2', 'cb3']) }) + it('should not overflow the call stack with a very large cb array', async () => {+ // a suspense boundary can buffer an unbounded number of post effects+ // while pending (e.g. a large tree re-rendering under it) and flush them+ // all at once on resolve - spreading such an array into push() throws+ // RangeError: Maximum call stack size exceeded+ let called = 0+ const cbs: SchedulerJob[] = []+ for (let i = 0; i < 1000000; i++) {+ cbs.push(() => {+ called+++ })+ }++ queuePostFlushCb(cbs)+ await nextTick()+ expect(called).toBe(1000000)+ })++ it('should not overflow the call stack when merging a very large cb array into an active flush', async () => {+ // same as above, but the large array is queued while a post flush is+ // already in progress, exercising the merge into activePostFlushCbs+ // inside a nested flushPostFlushCbs call+ let called = 0+ const cbs: SchedulerJob[] = []+ for (let i = 0; i < 1000000; i++) {+ cbs.push(() => {+ called+++ })+ }++ queuePostFlushCb(() => {+ queuePostFlushCb(cbs)+ flushPostFlushCbs()+ })+ await nextTick()+ expect(called).toBe(1000000)+ })+ it('should dedupe queued postFlushCb', async () => { const calls: string[] = [] const cb1 = () => {packages/runtime-core/src/components/Suspense.tsindex ba5e194ae..37e5067ff 100644@@ -617,7 +617,9 @@ function createSuspenseBoundary( if (parent.pendingBranch) { // found a pending parent suspense, merge buffered post jobs // into that parent- parent.effects.push(...effects)+ for (let i = 0; i < effects.length; i++) {+ parent.effects.push(effects[i])+ } hasUnresolvedAncestor = true break }packages/runtime-core/src/scheduler.tsindex af6752078..4355018a0 100644@@ -133,8 +133,13 @@ export function queuePostFlushCb(cb: SchedulerJobs): void { } else { // if cb is an array, it is a component lifecycle hook which can only be // triggered by a job, which is already deduped in the main queue, so- // we can skip duplicate check here to improve perf- pendingPostFlushCbs.push(...cb)+ // we can skip duplicate check here to improve perf.+ // use a loop instead of `push(...cb)`: the array can be arbitrarily large+ // (e.g. effects buffered by a suspense boundary) and spreading it would+ // overflow the call stack (#15142)+ for (let i = 0; i < cb.length; i++) {+ pendingPostFlushCbs.push(cb[i])+ } } queueFlush() }@@ -179,7 +184,9 @@ export function flushPostFlushCbs(seen?: CountMap): void { // #1947 already has active queue, nested flushPostFlushCbs call if (activePostFlushCbs) {- activePostFlushCbs.push(...deduped)+ for (let i = 0; i < deduped.length; i++) {+ activePostFlushCbs.push(deduped[i])+ } return }