Backtestsvuerun-20261005-124535#15153
Custom elements: async components nested ≥3 levels crash with TypeError: Cannot read properties of null (reading 'provides') — chained child resolve races its parent's mount
Our patch was judged better than the merged fix.
In this judgment, Patch A = our agent, Patch B = the merged fix.
Both patches fix the root cause the same way. The chained `.then` callback now returns the element's own async-load promise. This applies at any depth. A descendant chained onto a chained parent therefore waits until that parent has actually resolved and mounted, not merely until its `_resolveDef()` call returns. Patch A does this with a single line: `return this._pendingResolve` after `_resolveDef()`. When the definition is async, that value is the asyncDef promise, which settles only after `resolve()`/`_mount` runs. When the definition is sync, it is undefined because `resolve` clears it. Patch B gets the same effect by having `_resolveDef` return the pending promise. It also adds an `isConnected` guard that skips resolution for children disconnected before their parent resolves. That guard is a behavior change beyond the issue's ask, and it adds some risk around lifecycle edge cases, such as elements temporarily detached during DOM moves. It is neutral at best. On tests, Patch A is stronger. It covers the exact 3-level 'middle slowest' race from the issue, a 4-level case where inner levels resolve before their parents, and dynamic insertion of a grandchild under a still-pending chained parent. It checks ancestor-first mount order, non-null `_instance`, shadow DOM content, and provide/inject inheritance at every level. All of these would fail before the fix. Patch B's main test is deterministic and also checks order and inject values, but it covers only the 3-level case. Its second test exercises the unrelated disconnect behavior. Patch A is the more minimal and focused fix with broader regression coverage.
The judge saw only the two patches, labelled A and B in random order, with issue links and version numbers removed. The reasoning above is shown verbatim.
Solve
7m 9s
Wall-clock time in the container
Full test suite
No new failures
3,633 passed · 6 skipped · 3,639 total
Contamination audit
Clean
No sign the agent saw the real fix
Patch size
129vs 119 merged
Changed lines, ours vs merged
The issue
View on GitHubVue version
3.5.40 (latest at the time of writing — the inline repro pins it; also reproduced on 3.5.13, 3.5.17, 3.5.30 and 3.6.0-rc.2; 3.4.38 — before the nested-async chaining existed — crashes with the same null dereference in the older _setParent provides copy inside vnode.ce)
Link to minimal reproduction
Steps to reproduce
- Open the reproduction link and watch the console:
mounted x-innernever appears — the element crashes with an unhandledTypeError: Cannot read properties of null (reading 'provides')and never mounts. (The playground variant inserts the nested markup dynamically after thedefine()calls; dynamic and parser-created markup crash identically.) - Parser-created (static server-HTML-style) variant — self-contained single file, no build step (save as
repro.html, serve statically, open in any browser; Chromium, Firefox and WebKit all reproduce):
<!doctype html>
<meta charset="utf-8" />
<title>nested async custom elements repro</title>
<x-outer>
<x-middle>
<div>
<x-inner>inner light dom</x-inner>
</div>
</x-middle>
</x-outer>
<script type="module">
import {
defineCustomElement,
defineAsyncComponent,
h,
} from "https://unpkg.com/vue@3.5.40/dist/vue.esm-browser.js";
// Delays chosen so the middle level settles AFTER its child: outer fast,
// middle slow, inner fast. This crashes on 100% of loads.
const delays = { "x-outer": 50, "x-middle": 300, "x-inner": 10 };
const makeComponent = (name) => ({
name,
mounted() {
console.log(`mounted ${name}`);
},
render() {
return h("div", { style: "display:block;padding:6px;border:1px solid #888" }, [name, h("slot")]);
},
});
const makeLoader = (tag) => () =>
new Promise((resolve) => setTimeout(() => resolve(makeComponent(tag)), delays[tag]));
// Define the three tags parent-first.
for (const tag of ["x-outer", "x-middle", "x-inner"]) {
customElements.define(tag, defineCustomElement(defineAsyncComponent(makeLoader(tag))));
}
window.addEventListener("error", (e) => console.error("UNCAUGHT:", e.message));
window.addEventListener("unhandledrejection", (e) =>
console.error("UNHANDLED REJECTION:", e.reason?.message ?? e.reason),
);
</script>
What is expected?
All three elements mount ancestor-first: mounted x-outer, mounted x-middle, mounted x-inner. The nested-async chaining added in 3.5.0 (37ccb9b, "delay mounting of custom elements with async parent", closing #9341 / #8127 / #9351) exists to guarantee exactly this.
What is actually happening?
mounted x-outer
UNHANDLED REJECTION: Cannot read properties of null (reading 'provides')
mounted x-middle
x-inner crashes in VueElement._mount → _inheritParentContext (runtime-dom — parent._instance.provides is dereferenced guarded only by parent && this._app), never mounts, and is left permanently half-resolved: _resolved: true, _instance: null, shadow root empty. Nothing ever retries it, no error surfaces through app.config.errorHandler, and any provide/inject inheritance it should have received is lost. Its own descendants (at deeper nesting) then crash against it in cascade.
Any additional comments?
Analysis (why depth ≥ 3 is the trigger)
connectedCallback of a child under a pending async parent chains:
this._pendingResolve = parent._pendingResolve.then(() => {
this._pendingResolve = undefined;
this._resolveDef();
});
- For an unchained parent (depth 2),
parent._pendingResolveis the parent's own_resolveDef()flow, which settles after the parent has mounted → 2-level nesting is safe. The variants table below confirms: 2 levels never crash. - For a chained parent (depth ≥ 3),
parent._pendingResolveis itself a chain promise — and that promise settles when the parent's_resolveDef()returns (i.e. when the parent's async load starts), not when the parent mounts.
So once the first unchained ancestor mounts, the whole chain unwinds within a few microtasks: every deeper level's loader fires nearly simultaneously and mount order degenerates to network settlement order. Any child whose async definition settles before its parent has mounted hits _inheritParentContext while parent._instance === null and throws. With real-network chunk timings the victim set varies per load, so in an app this presents as a flaky, page-dependent breakage; with the fixed delays above it is 100% deterministic.
Variants checked (each re-run in a real browser):
| Variant | Result |
|---|---|
| 3 levels, middle slowest | crashes every load |
| 3 levels, inner slowest | clean (race direction confirmed) |
| 2 levels | clean (chained parent required) |
plain <div> between levels | still crashes (structure-independent) |
markup inserted dynamically after all define() calls | still crashes |
| all loaders instant | clean (microtask FIFO protects when nothing is pending) |
_inheritParentContext (#13219, ~3.5.14) did not introduce the race — it converted a pre-existing silent misordering into a hard crash. 3.4.38 (no chaining) and 3.5.13 (chaining, pre-#13219) fail with the same null dereference in the older _setParent provides-copy path.
Suggested direction — either (or both):
- Chain the child to the parent's actual mount, not to
_resolveDef()returning — e.g. resolve the parent's_pendingResolveonly after_mount()has run, so the guarantee the chaining was built for ("ancestor mounts before descendant") holds at any depth. - Guard
_inheritParentContextagainstparent._instance === nulland defer context inheritance until the parent instance exists, instead of throwing away the child permanently on an unhandled rejection.
The two patches
packages/runtime-dom/__tests__/customElement.spec.tsindex a5bea20b8..e863edb9c 100644@@ -2210,6 +2210,131 @@ describe('defineCustomElement', () => { expect(barVal).toBe('bar') }) + describe('async & deeply nested custom elements', () => {+ const createNested = (+ prefix: string,+ levels: number,+ delays: number[],+ mounted: string[],+ injected: Record<string, unknown>,+ ) => {+ const tags: string[] = []+ for (let i = 0; i < levels; i++) {+ const tag = `${prefix}-${i}`+ tags.push(tag)+ customElements.define(+ tag,+ defineCustomElement(+ defineAsyncComponent(+ () =>+ new Promise<any>(resolve =>+ setTimeout(+ () =>+ resolve({+ setup() {+ provide(`level-${i}`, tag)+ for (let j = 0; j < i; j++) {+ injected[`${tag}:level-${j}`] = inject(`level-${j}`)+ }+ onMounted(() => mounted.push(tag))+ },+ render(this: any) {+ return h('div', null, [+ tag,+ renderSlot(this.$slots, 'default'),+ ])+ },+ }),+ delays[i],+ ),+ ),+ ),+ ),+ )+ }+ let html = ''+ for (let i = levels - 1; i >= 0; i--) {+ html = `<${tags[i]}><div>${html}</div></${tags[i]}>`+ }+ container.innerHTML = html+ return tags+ }++ const assertAllMounted = (+ tags: string[],+ mounted: string[],+ injected: Record<string, unknown>,+ ) => {+ // ancestor-first mount order+ expect(mounted).toEqual(tags)+ let el: Element | null = container+ for (let i = 0; i < tags.length; i++) {+ el = el!.querySelector(tags[i])+ const ce = el as VueElement+ expect(ce._instance).not.toBeNull()+ expect(ce.shadowRoot!.innerHTML).toBe(+ `<div>${tags[i]}<slot></slot></div>`,+ )+ for (let j = 0; j < i; j++) {+ expect(injected[`${tags[i]}:level-${j}`]).toBe(tags[j])+ }+ }+ }++ test('3 levels where the middle level resolves last', async () => {+ const mounted: string[] = []+ const injected: Record<string, unknown> = {}+ const tags = createNested(+ 'my-el-async-deep-a',+ 3,+ [5, 40, 1],+ mounted,+ injected,+ )+ await new Promise(r => setTimeout(r, 100))+ assertAllMounted(tags, mounted, injected)+ })++ test('4 levels where inner levels resolve before their parents', async () => {+ const mounted: string[] = []+ const injected: Record<string, unknown> = {}+ const tags = createNested(+ 'my-el-async-deep-b',+ 4,+ [5, 40, 20, 1],+ mounted,+ injected,+ )+ await new Promise(r => setTimeout(r, 150))+ assertAllMounted(tags, mounted, injected)+ })++ test('nested markup inserted after a pending parent chain already exists', async () => {+ const mounted: string[] = []+ const injected: Record<string, unknown> = {}+ const tags = createNested(+ 'my-el-async-deep-c',+ 3,+ [5, 40, 1],+ mounted,+ injected,+ )+ // the middle element has started loading its own async definition;+ // a new grandchild connected now must still wait for it to mount+ await new Promise(r => setTimeout(r, 15))+ const middle = container.querySelector(tags[1])!+ expect(mounted).toEqual([tags[0]])+ const extra = document.createElement(tags[2])+ middle.appendChild(extra)+ await new Promise(r => setTimeout(r, 100))+ expect(mounted).toEqual([...tags, tags[2]])+ expect((extra as VueElement)._instance).not.toBeNull()+ expect(extra.shadowRoot!.innerHTML).toBe(+ `<div>${tags[2]}<slot></slot></div>`,+ )+ })+ })+ describe('configureApp', () => { test('should work', () => { const E = defineCustomElement(packages/runtime-dom/src/apiCustomElement.tsindex 9e1f3a720..0ed4af46e 100644@@ -314,6 +314,10 @@ export class VueElement this._pendingResolve = parent._pendingResolve.then(() => { this._pendingResolve = undefined this._resolveDef()+ // if this element's own definition is async, keep the chain pending+ // until it has actually resolved and mounted, so that descendants+ // chained onto this element never mount before it does.+ return this._pendingResolve }) } else { this._resolveDef()
packages/runtime-dom/__tests__/customElement.spec.tsindex a5bea20b8..27c7121c2 100644@@ -2210,6 +2210,118 @@ describe('defineCustomElement', () => { expect(barVal).toBe('bar') }) + test('nested async custom elements should mount ancestor-first', async () => {+ const mounted: string[] = []+ const OuterComp = defineComponent({+ setup() {+ provide('foo', 'foo')+ },+ mounted() {+ mounted.push('outer')+ },+ render() {+ return h('slot')+ },+ })+ const MiddleComp = defineComponent({+ setup() {+ provide('bar', 'bar')+ },+ mounted() {+ mounted.push('middle')+ },+ render() {+ return h('slot')+ },+ })+ const InnerComp = defineComponent({+ setup() {+ const foo = inject('foo')+ const bar = inject('bar')+ return () => h('div', `${foo}/${bar}`)+ },+ mounted() {+ mounted.push('inner')+ },+ })+ let resolveOuter!: (comp: typeof OuterComp) => void+ let resolveMiddle!: (comp: typeof MiddleComp) => void+ let resolveInner!: (comp: typeof InnerComp) => void+ const outerReady = new Promise<typeof OuterComp>(resolve => {+ resolveOuter = resolve+ })+ const middleReady = new Promise<typeof MiddleComp>(resolve => {+ resolveMiddle = resolve+ })+ const innerReady = new Promise<typeof InnerComp>(resolve => {+ resolveInner = resolve+ })++ const Outer = defineCustomElement(defineAsyncComponent(() => outerReady))+ const Middle = defineCustomElement(defineAsyncComponent(() => middleReady))+ const Inner = defineCustomElement(defineAsyncComponent(() => innerReady))++ customElements.define('async-chain-outer', Outer)+ customElements.define('async-chain-middle', Middle)+ customElements.define('async-chain-inner', Inner)+ container.innerHTML =+ `<async-chain-outer>` ++ `<async-chain-middle>` ++ `<async-chain-inner></async-chain-inner>` ++ `</async-chain-middle>` ++ `</async-chain-outer>`++ resolveInner(InnerComp)+ resolveOuter(OuterComp)+ await new Promise(resolve => setTimeout(resolve))+ resolveMiddle(MiddleComp)+ await new Promise(resolve => setTimeout(resolve))++ const inner = container.querySelector('async-chain-inner') as VueElement+ expect(mounted).toEqual(['outer', 'middle', 'inner'])+ expect(inner.shadowRoot!.innerHTML).toBe('<div>foo/bar</div>')+ })++ test('should not resolve nested custom element after disconnect', async () => {+ const mounted = vi.fn()+ const ParentComp = defineComponent({+ render() {+ return h('slot')+ },+ })+ let resolveParent!: (comp: typeof ParentComp) => void+ const parentReady = new Promise<typeof ParentComp>(resolve => {+ resolveParent = resolve+ })+ const Parent = defineCustomElement(defineAsyncComponent(() => parentReady))+ const Child = defineCustomElement({+ mounted,+ render() {+ return h('div', 'child')+ },+ })++ customElements.define('async-disconnect-parent', Parent)+ customElements.define('async-disconnect-child', Child)+ container.innerHTML =+ `<async-disconnect-parent>` ++ `<async-disconnect-child></async-disconnect-child>` ++ `</async-disconnect-parent>`++ const parent = container.firstChild as VueElement+ const child = parent.firstChild as VueElement+ child.remove()+ resolveParent(ParentComp)+ await new Promise(resolve => setTimeout(resolve))++ expect(mounted).not.toHaveBeenCalled()+ expect(child.shadowRoot!.innerHTML).toBe('')++ parent.appendChild(child)+ expect(mounted).toHaveBeenCalledOnce()+ expect(child.shadowRoot!.innerHTML).toBe('<div>child</div>')+ })+ describe('configureApp', () => { test('should work', () => { const E = defineCustomElement(packages/runtime-dom/src/apiCustomElement.tsindex 9e1f3a720..9422f58d6 100644@@ -313,7 +313,9 @@ export class VueElement if (parent && parent._pendingResolve) { this._pendingResolve = parent._pendingResolve.then(() => { this._pendingResolve = undefined- this._resolveDef()+ if (this.isConnected) {+ return this._resolveDef()+ } }) } else { this._resolveDef()@@ -371,7 +373,7 @@ export class VueElement */ private _resolveDef() { if (this._pendingResolve) {- return+ return this._pendingResolve } // set initial attrs@@ -428,6 +430,7 @@ export class VueElement def.configureApp = this._def.configureApp resolve((this._def = def), true) })+ return this._pendingResolve } else { resolve(this._def) }